From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57C0741232 for ; Mon, 11 Mar 2024 14:46:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710168376; cv=none; b=uAogPmKG/BLzSPp4CC4kidP22jZLdwNdykQUfvjbsqnU4p7Fk9nBU40NcIl0+aQutaQc4WLGprUTass91yFvFTgiv6XsoniNNhiK+Gqi4HmpIksCj98RuTa7+rekX1KZuNcFaSBYla+bQDH9HrF7qXcDG8zFb8P0i2pqKCkGgM8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710168376; c=relaxed/simple; bh=aTwrh90GUA0KuD1dJsmiDHSRUsUSaTCyVUrQIX6iNAo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Vb8YCQVU9G8br2d8K9cVoWR884zpukWH87WLV+NiiD2JEbtd59n8VkfuLfIgybLet3AsiVGRbsxE3EmsVVeSlEW1ocwSYw724K1ZGkAUCY7yAvaTqoxQDffX0aiP3MDCe42bywoHJyW7xETiEw5pXqufkR2LmBDScB1tu9O3xWk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=rHyJ3FtD; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rHyJ3FtD" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-6e66e8fcc2dso2905209b3a.3 for ; Mon, 11 Mar 2024 07:46:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710168372; x=1710773172; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=7WZeoUY9lDhr7yJPXp/YwXiCG8hTtAt9+Pvs1llVqw0=; b=rHyJ3FtDcw8P3wUOnNulEZuwPV4VP0ulj4JM28BomYQAawePdstskecFXjin3dHATR x4aqmmZMPM+ZUs8tKM2d4QnxSPCoOXKQnLrrV7t2e6d4tHcXzmK253JWCT592tlQR6mk uXo0+GIF3C45JyvikWWPq6dVH8ihWBmpYg/KvifT9ETHjIvWCdFgHXRMMME4GkY9Y5Eo eDjrkmsf8BUw0A+oY4NjDDbAv709DQ3L8IeZokl5MY8ZsWQe4doWKQ2aKUEunK7rbGMh 65pphfZ8I9Qz8hXH3hXRJ437HKXNAw0AyzJ7eXbGGKR0plvTtsUHzro/JLE79v+GlYyN ZclA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710168372; x=1710773172; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7WZeoUY9lDhr7yJPXp/YwXiCG8hTtAt9+Pvs1llVqw0=; b=Jd0zz+EMcSGRM8vzqA7R2qFojcn/tiXgxAwjIxk9Eahc21dghQKRd/+Xw7cbv4h3Ig kRGLO4/KgT/UyVWIBN4S+C2XBLakXENB0QCUCgc0ctCgUC2xMa1KaCPljdsgsVu5PdQ6 wY6GEKew8iCUpgQYBxkEBgYnzuAhhyVaL5wPdKn0XTGtWtvkI50M4sJ+cblg1RgfTlO9 GM4yygNnrUCWTBI4lYlUSiZtC2K2tpWapWcfgNbvzj6zgDSHfdQkJYaSyBdPTitTJHJn 7EEeg6ZHZ8LyItHWm8WbMIdVar7UkYm9q6rYArQ/6fip1ixm60xC0L9UlcfITB7S8fsK Zc8Q== X-Forwarded-Encrypted: i=1; AJvYcCU4GLQY9hWh6fbPR82J97tBbh/QyKF5y/d2jK0gL2lnbVzLhmM7hpQkU/U1Vch6fxMzSbutdOLQcAw9mV4Ri8uKyadgqdj6yCRDVOTvZg== X-Gm-Message-State: AOJu0Yz3d2Bnqaz5+6hgyHRW0R8lu4Fs4jt2+LML3W3iB12zf7rCOGHw NLrUJYh3MhDcj0oM4/rPG+lbYnVdf8eVsaLqzV5fChVw124axhOuScLcBc5h0g== X-Google-Smtp-Source: AGHT+IEkyoSv3cUPd2YD+Ord9GisLbDuQ3mTJgXZUAwKm1FrFZN401VY7NABhiAj7Fw9fR+qh9jZVw== X-Received: by 2002:a05:6a00:2d20:b0:6e5:5a24:818c with SMTP id fa32-20020a056a002d2000b006e55a24818cmr7159193pfb.7.1710168372299; Mon, 11 Mar 2024 07:46:12 -0700 (PDT) Received: from thinkpad ([117.217.184.48]) by smtp.gmail.com with ESMTPSA id o12-20020a62f90c000000b006e053e98e1csm4427472pfh.136.2024.03.11.07.46.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Mar 2024 07:46:11 -0700 (PDT) Date: Mon, 11 Mar 2024 20:15:59 +0530 From: Manivannan Sadhasivam To: Niklas Cassel Cc: Jingoo Han , Gustavo Pimentel , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Marek Vasut , Yoshihiro Shimoda , Thierry Reding , Jonathan Hunter , Kishon Vijay Abraham I , Vidya Sagar , Vignesh Raghavendra , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Minghuan Lian , Mingkai Hu , Roy Zang , Kunihiko Hayashi , Masami Hiramatsu , Kishon Vijay Abraham I , Jesper Nilsson , Srikanth Thokala , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@axis.com, Frank Li Subject: Re: [PATCH v9 07/10] PCI: dwc: ep: Remove "core_init_notifier" flag Message-ID: <20240311144559.GA2504@thinkpad> References: <20240304-pci-dbi-rework-v9-0-29d433d99cda@linaro.org> <20240304-pci-dbi-rework-v9-7-29d433d99cda@linaro.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Mar 08, 2024 at 02:24:35PM +0100, Niklas Cassel wrote: > On Mon, Mar 04, 2024 at 02:52:19PM +0530, Manivannan Sadhasivam wrote: > > "core_init_notifier" flag is set by the glue drivers requiring refclk from > > the host to complete the DWC core initialization. Also, those drivers will > > send a notification to the EPF drivers once the initialization is fully > > completed using the pci_epc_init_notify() API. Only then, the EPF drivers > > will start functioning. > > > > For the rest of the drivers generating refclk locally, EPF drivers will > > start functioning post binding with them. EPF drivers rely on the > > 'core_init_notifier' flag to differentiate between the drivers. > > Unfortunately, this creates two different flows for the EPF drivers. > > > > So to avoid that, let's get rid of the "core_init_notifier" flag and follow > > a single initialization flow for the EPF drivers. This is done by calling > > the dw_pcie_ep_init_notify() from all glue drivers after the completion of > > dw_pcie_ep_init_registers() API. This will allow all the glue drivers to > > send the notification to the EPF drivers once the initialization is fully > > completed. > > > > Only difference here is that, the drivers requiring refclk from host will > > send the notification once refclk is received, while others will send it > > during probe time itself. > > > > Reviewed-by: Frank Li > > Signed-off-by: Manivannan Sadhasivam > > --- > > diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c > > index 18c80002d3bd..fc0282b0d626 100644 > > --- a/drivers/pci/endpoint/functions/pci-epf-test.c > > +++ b/drivers/pci/endpoint/functions/pci-epf-test.c > > @@ -927,21 +928,12 @@ static int pci_epf_test_bind(struct pci_epf *epf) > > if (ret) > > return ret; > > > > Hello Mani, > > Since you asked for testing, I gave your series a spin > (with a driver without .core_init_notifier). > > > There seems to be a problem that pci_epc_write_header() is never called. > > Debugging this, it seems that .core_init in pci-epf-test is never called. > > If I add debug prints in pci_epc_init_notify(), I see that it does not > notify a single EPF driver. > > It appears that the patch in $subject will call pci_epc_init_notify() > at EPC driver .probe() time, and at that point in time, there are no > EPF drivers registered. > > They get registered later, when doing the configfs write. > > > I would say that it is the following change that breaks things: > > > - if (!core_init_notifier) { > > - ret = pci_epf_test_core_init(epf); > > - if (ret) > > - return ret; > > - } > > - > > Since without this code, pci_epf_test_core_init() will no longer be called, > as there is currently no one that calls epf->core_init() for a EPF driver > after it has been bound. (For drivers that call dw_pcie_ep_init_notify() in > .probe()) > Thanks a lot for testing, Niklas! > I guess one way to solve this would be for the EPC core to keep track of > the current EPC "core state" (up/down). If the core is "up" at EPF .bind() > time, notify the EPF driver directly after .bind()? > Yeah, that's a good solution. But I think it would be better if the EPC caches all events if the EPF drivers are not available and dispatch them once the bind happens for each EPF driver. Even though INIT_COMPLETE is the only event that is getting generated before bind() now, IMO it is better to add provision to catch other events also. Wdyt? - Mani -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3FEADC54E58 for ; Mon, 11 Mar 2024 14:47:03 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=zWWweWYI; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4TtfkF34FHz3cZK for ; Tue, 12 Mar 2024 01:47:01 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=zWWweWYI; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linaro.org (client-ip=2607:f8b0:4864:20::431; helo=mail-pf1-x431.google.com; envelope-from=manivannan.sadhasivam@linaro.org; receiver=lists.ozlabs.org) Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4TtfjR3Z4qz3btZ for ; Tue, 12 Mar 2024 01:46:17 +1100 (AEDT) Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-6e63e9abf6aso2383346b3a.2 for ; Mon, 11 Mar 2024 07:46:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710168372; x=1710773172; darn=lists.ozlabs.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=7WZeoUY9lDhr7yJPXp/YwXiCG8hTtAt9+Pvs1llVqw0=; b=zWWweWYI4s2wmdVwfKb/ALYwf2xjiDT4Y18w2cM57REuIay6cNUGtBTsf5aDDL6amb v64UlNK5nW5Nup+GY2+OdjYBzOj4aFkYKb2ZVgwJ1gsSkjS6iYn47h+s/hUJ66DPwgBG 7//KyihYqroehfAuPBCTDO9n5K1XAZ0bULo2lTg28mfHDnNsRXstOGQHp2sdAiZlbmiD ig5uDkbbbyEBNjfeGK8IyfNRa8743QBd3Lrpi7fqTuY+beMiR3nET6wwz64ozHY7mLBy BriwnO4LxlzEQE1ciW1MczABVQXMwrGzN4f13kmJR7LfjXljK1DmFe8Ah/gCuOiiV4CI WCDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710168372; x=1710773172; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7WZeoUY9lDhr7yJPXp/YwXiCG8hTtAt9+Pvs1llVqw0=; b=tIvoT0byji6R6S+LZ5BS5LKy4PTLjdXtfRKwUP7FqOJ6Lp81etEBNYsKnevKZzm/9D sf9E8A8Nf7nSWLes1klW3hJHad3hkifB7YVEy/d92TvY5RgQO5zza9w0NUesndH1YJik POIyeGP67ODe3xTImor8WbNB1EjCofSx93lDQcd/Z+0UlfFhxs8yZBVCMvW4vmOEc73q oaM6Y3ttmfCIqT5hgnGV7wU/2b0C+TlB+C+SqBrhh+epvdvDYKJSMJNvvzl3UvMq6t9K xBUiQ/GDFvDyBIYJ3h1182kxVNUlfUrQT+cNnW5/Tp1C2J3JlKYHW17DWGDMtiFPZ+eT SSzQ== X-Forwarded-Encrypted: i=1; AJvYcCXXnRlSHdZ75t6QynHJN8OVzucjS45tSM4y7mUc9k/qa8KwlxwZkaHlukcqGhqiHt03DKXY8J2jOR6ezS9wQ2KcTvX2vQAVsx5Hecgz4A== X-Gm-Message-State: AOJu0YzxG7zihblVHNNdF2Ovd6Ys2ngo3esyLIDQdpXjb+yGHpX40WUq BSGA4X1r++aAiiQEyDRSbgAHxLzTbM0vsOSllqmsGaw1mOfFsfNhvrDE5VhvrQ== X-Google-Smtp-Source: AGHT+IEkyoSv3cUPd2YD+Ord9GisLbDuQ3mTJgXZUAwKm1FrFZN401VY7NABhiAj7Fw9fR+qh9jZVw== X-Received: by 2002:a05:6a00:2d20:b0:6e5:5a24:818c with SMTP id fa32-20020a056a002d2000b006e55a24818cmr7159193pfb.7.1710168372299; Mon, 11 Mar 2024 07:46:12 -0700 (PDT) Received: from thinkpad ([117.217.184.48]) by smtp.gmail.com with ESMTPSA id o12-20020a62f90c000000b006e053e98e1csm4427472pfh.136.2024.03.11.07.46.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Mar 2024 07:46:11 -0700 (PDT) Date: Mon, 11 Mar 2024 20:15:59 +0530 From: Manivannan Sadhasivam To: Niklas Cassel Subject: Re: [PATCH v9 07/10] PCI: dwc: ep: Remove "core_init_notifier" flag Message-ID: <20240311144559.GA2504@thinkpad> References: <20240304-pci-dbi-rework-v9-0-29d433d99cda@linaro.org> <20240304-pci-dbi-rework-v9-7-29d433d99cda@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Vignesh Raghavendra , Kunihiko Hayashi , linux-pci@vger.kernel.org, Lorenzo Pieralisi , Frank Li , Minghuan Lian , Thierry Reding , Kishon Vijay Abraham I , Fabio Estevam , Marek Vasut , Kishon Vijay Abraham I , Rob Herring , Jesper Nilsson , linux-tegra@vger.kernel.org, linux-arm-kernel@axis.com, Jonathan Hunter , NXP Linux Team , Richard Zhu , Srikanth Thokala , linux-arm-msm@vger.kernel.org, Sascha Hauer , linuxppc-dev@lists.ozlabs.org, Bjorn Helgaas , linux-omap@vger.kernel.org, Mingkai Hu , linux-arm-kernel@ lists.infradead.org, Roy Zang , Jingoo Han , Yoshihiro Shimoda , linux-kernel@vger.kernel.org, Vidya Sagar , linux-renesas-soc@vger.kernel.org, Masami Hiramatsu , Pengutronix Kernel Team , Gustavo Pimentel , Shawn Guo , Lucas Stach Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Mar 08, 2024 at 02:24:35PM +0100, Niklas Cassel wrote: > On Mon, Mar 04, 2024 at 02:52:19PM +0530, Manivannan Sadhasivam wrote: > > "core_init_notifier" flag is set by the glue drivers requiring refclk from > > the host to complete the DWC core initialization. Also, those drivers will > > send a notification to the EPF drivers once the initialization is fully > > completed using the pci_epc_init_notify() API. Only then, the EPF drivers > > will start functioning. > > > > For the rest of the drivers generating refclk locally, EPF drivers will > > start functioning post binding with them. EPF drivers rely on the > > 'core_init_notifier' flag to differentiate between the drivers. > > Unfortunately, this creates two different flows for the EPF drivers. > > > > So to avoid that, let's get rid of the "core_init_notifier" flag and follow > > a single initialization flow for the EPF drivers. This is done by calling > > the dw_pcie_ep_init_notify() from all glue drivers after the completion of > > dw_pcie_ep_init_registers() API. This will allow all the glue drivers to > > send the notification to the EPF drivers once the initialization is fully > > completed. > > > > Only difference here is that, the drivers requiring refclk from host will > > send the notification once refclk is received, while others will send it > > during probe time itself. > > > > Reviewed-by: Frank Li > > Signed-off-by: Manivannan Sadhasivam > > --- > > diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c > > index 18c80002d3bd..fc0282b0d626 100644 > > --- a/drivers/pci/endpoint/functions/pci-epf-test.c > > +++ b/drivers/pci/endpoint/functions/pci-epf-test.c > > @@ -927,21 +928,12 @@ static int pci_epf_test_bind(struct pci_epf *epf) > > if (ret) > > return ret; > > > > Hello Mani, > > Since you asked for testing, I gave your series a spin > (with a driver without .core_init_notifier). > > > There seems to be a problem that pci_epc_write_header() is never called. > > Debugging this, it seems that .core_init in pci-epf-test is never called. > > If I add debug prints in pci_epc_init_notify(), I see that it does not > notify a single EPF driver. > > It appears that the patch in $subject will call pci_epc_init_notify() > at EPC driver .probe() time, and at that point in time, there are no > EPF drivers registered. > > They get registered later, when doing the configfs write. > > > I would say that it is the following change that breaks things: > > > - if (!core_init_notifier) { > > - ret = pci_epf_test_core_init(epf); > > - if (ret) > > - return ret; > > - } > > - > > Since without this code, pci_epf_test_core_init() will no longer be called, > as there is currently no one that calls epf->core_init() for a EPF driver > after it has been bound. (For drivers that call dw_pcie_ep_init_notify() in > .probe()) > Thanks a lot for testing, Niklas! > I guess one way to solve this would be for the EPC core to keep track of > the current EPC "core state" (up/down). If the core is "up" at EPF .bind() > time, notify the EPF driver directly after .bind()? > Yeah, that's a good solution. But I think it would be better if the EPC caches all events if the EPF drivers are not available and dispatch them once the bind happens for each EPF driver. Even though INIT_COMPLETE is the only event that is getting generated before bind() now, IMO it is better to add provision to catch other events also. Wdyt? - Mani -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 30343C54E58 for ; Mon, 11 Mar 2024 14:46:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YkDunVdvWpNGtlyeH8YMyVR6lOATzOVhe8cHDa4pPus=; b=gCFwVy0zAx9zz3 EWme0ZWVhuvgeWgeVCT56S/YotSWUuKlxMQDrIIZwo74YpQzqx9oA6hHXgpu2x0LWEVlP5YUh4GkT Y/n/h7vDrAX/RVKoaWjHiR47oQjLH/iYnoumOaunpU/oWh+wq/c06lWsp1DEsUFwKNpkeJOGlS82u Y0s76tSpeZoAVmGqJXRyKuGXjRNBL3MuoBvziVVGTr4TBUslMzZOImj19eRlOiYyPBfLylFV8uoMc 1E3/Y5FH05q6UMItbBwAVvMKj0whys2mD+d21JLOmTpkfHv2RuPVEB5WFxxoW7qQM2h2lIpNbEgP9 QDFXuUbYrGGEAIkJiiiw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rjgv0-00000001rEe-3305; Mon, 11 Mar 2024 14:46:22 +0000 Received: from mail-pf1-x433.google.com ([2607:f8b0:4864:20::433]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rjguw-00000001rC0-3j8d for linux-arm-kernel@lists.infradead.org; Mon, 11 Mar 2024 14:46:20 +0000 Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-6e66e8fcc2dso2905214b3a.3 for ; Mon, 11 Mar 2024 07:46:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710168372; x=1710773172; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=7WZeoUY9lDhr7yJPXp/YwXiCG8hTtAt9+Pvs1llVqw0=; b=ePcuCUzVXvZO2kn0daIpP9gupuoj689GWFzmBxeUjUiv2KcYDDzubHvy88Y88loEUU ocZieCtO5wJeoKH1LyFzjHLJk0pjp+IIDZ9noUjGacz7K0oGSl7uFcXZVK7pBpVVB7mt BBC5WSKEg1Up1avox14XmFFgtKeEa10EhAeBu6wDqEXIu4yvLKUty7npBg5+z5+/CdXs npftwY8nj1LO4g/lrFPtmoAYYOoBxezsIawm0yL0xsDDQ/hWzFpw7uEPDOMwjA0ReaXK MggbanoaTKI85zUSgBCMZg9JmmpgQOixfYtahs4D0moSDgK83Cnx70ZbIIgWALq4BCFE hJow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710168372; x=1710773172; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7WZeoUY9lDhr7yJPXp/YwXiCG8hTtAt9+Pvs1llVqw0=; b=IYtfkk+/InI+jk9cldtzu8jROU8Ffg/ITQMqaC239ju9uSGWlFCpcMrLME1YioywQY UJIifggjW+6M6hyFzXHfl5KF2dBvEPzT4goenGt1mKHl1ODKdVdiLsoCTgGCk0rFUSLx iFChiTWZJOR3qSl5GGPjYqRVa/DY+Hded/2rVzukmte8RfpeoKtDlh+2SMGysTk7oNJT aoVeKTereP+8vh6ZtGhxi7q6CRnkVr2BI/UMmz6PqOIwT/XISzSMIB4hqnrfHv1Hgf3M 1u2ZfIJSAfTYR5L79EbQrs11N0MB3PkrQmTTzlYAQhTPZ0jvHQT8QJ0qH1utjWyLIsch fysw== X-Forwarded-Encrypted: i=1; AJvYcCUcZNY5gNPr31Hn66MiMnSyCaoxHolMpaYCJb6HwSJl8ll2pOOE9bzb07Jyx93SX1dh+2E+UhdGbdajl48Pl2ddd0aDzqO03ySSATVzRIhPM6CQsDI= X-Gm-Message-State: AOJu0YwHm0hR+szLfPY7fUQuCLYxptrYMV+d2lZte0r4PHr7O/o/OUqo ZTZKRSCBKOSmWWQazCFzp/S4aKCjrgpe2dl6pFO2xZJh7d3gWkN6HTATW9ykLQ== X-Google-Smtp-Source: AGHT+IEkyoSv3cUPd2YD+Ord9GisLbDuQ3mTJgXZUAwKm1FrFZN401VY7NABhiAj7Fw9fR+qh9jZVw== X-Received: by 2002:a05:6a00:2d20:b0:6e5:5a24:818c with SMTP id fa32-20020a056a002d2000b006e55a24818cmr7159193pfb.7.1710168372299; Mon, 11 Mar 2024 07:46:12 -0700 (PDT) Received: from thinkpad ([117.217.184.48]) by smtp.gmail.com with ESMTPSA id o12-20020a62f90c000000b006e053e98e1csm4427472pfh.136.2024.03.11.07.46.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Mar 2024 07:46:11 -0700 (PDT) Date: Mon, 11 Mar 2024 20:15:59 +0530 From: Manivannan Sadhasivam To: Niklas Cassel Cc: Jingoo Han , Gustavo Pimentel , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Marek Vasut , Yoshihiro Shimoda , Thierry Reding , Jonathan Hunter , Kishon Vijay Abraham I , Vidya Sagar , Vignesh Raghavendra , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Minghuan Lian , Mingkai Hu , Roy Zang , Kunihiko Hayashi , Masami Hiramatsu , Kishon Vijay Abraham I , Jesper Nilsson , Srikanth Thokala , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@axis.com, Frank Li Subject: Re: [PATCH v9 07/10] PCI: dwc: ep: Remove "core_init_notifier" flag Message-ID: <20240311144559.GA2504@thinkpad> References: <20240304-pci-dbi-rework-v9-0-29d433d99cda@linaro.org> <20240304-pci-dbi-rework-v9-7-29d433d99cda@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240311_074619_276660_20026B62 X-CRM114-Status: GOOD ( 36.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBNYXIgMDgsIDIwMjQgYXQgMDI6MjQ6MzVQTSArMDEwMCwgTmlrbGFzIENhc3NlbCB3 cm90ZToKPiBPbiBNb24sIE1hciAwNCwgMjAyNCBhdCAwMjo1MjoxOVBNICswNTMwLCBNYW5pdmFu bmFuIFNhZGhhc2l2YW0gd3JvdGU6Cj4gPiAiY29yZV9pbml0X25vdGlmaWVyIiBmbGFnIGlzIHNl dCBieSB0aGUgZ2x1ZSBkcml2ZXJzIHJlcXVpcmluZyByZWZjbGsgZnJvbQo+ID4gdGhlIGhvc3Qg dG8gY29tcGxldGUgdGhlIERXQyBjb3JlIGluaXRpYWxpemF0aW9uLiBBbHNvLCB0aG9zZSBkcml2 ZXJzIHdpbGwKPiA+IHNlbmQgYSBub3RpZmljYXRpb24gdG8gdGhlIEVQRiBkcml2ZXJzIG9uY2Ug dGhlIGluaXRpYWxpemF0aW9uIGlzIGZ1bGx5Cj4gPiBjb21wbGV0ZWQgdXNpbmcgdGhlIHBjaV9l cGNfaW5pdF9ub3RpZnkoKSBBUEkuIE9ubHkgdGhlbiwgdGhlIEVQRiBkcml2ZXJzCj4gPiB3aWxs IHN0YXJ0IGZ1bmN0aW9uaW5nLgo+ID4gCj4gPiBGb3IgdGhlIHJlc3Qgb2YgdGhlIGRyaXZlcnMg Z2VuZXJhdGluZyByZWZjbGsgbG9jYWxseSwgRVBGIGRyaXZlcnMgd2lsbAo+ID4gc3RhcnQgZnVu Y3Rpb25pbmcgcG9zdCBiaW5kaW5nIHdpdGggdGhlbS4gRVBGIGRyaXZlcnMgcmVseSBvbiB0aGUK PiA+ICdjb3JlX2luaXRfbm90aWZpZXInIGZsYWcgdG8gZGlmZmVyZW50aWF0ZSBiZXR3ZWVuIHRo ZSBkcml2ZXJzLgo+ID4gVW5mb3J0dW5hdGVseSwgdGhpcyBjcmVhdGVzIHR3byBkaWZmZXJlbnQg Zmxvd3MgZm9yIHRoZSBFUEYgZHJpdmVycy4KPiA+IAo+ID4gU28gdG8gYXZvaWQgdGhhdCwgbGV0 J3MgZ2V0IHJpZCBvZiB0aGUgImNvcmVfaW5pdF9ub3RpZmllciIgZmxhZyBhbmQgZm9sbG93Cj4g PiBhIHNpbmdsZSBpbml0aWFsaXphdGlvbiBmbG93IGZvciB0aGUgRVBGIGRyaXZlcnMuIFRoaXMg aXMgZG9uZSBieSBjYWxsaW5nCj4gPiB0aGUgZHdfcGNpZV9lcF9pbml0X25vdGlmeSgpIGZyb20g YWxsIGdsdWUgZHJpdmVycyBhZnRlciB0aGUgY29tcGxldGlvbiBvZgo+ID4gZHdfcGNpZV9lcF9p bml0X3JlZ2lzdGVycygpIEFQSS4gVGhpcyB3aWxsIGFsbG93IGFsbCB0aGUgZ2x1ZSBkcml2ZXJz IHRvCj4gPiBzZW5kIHRoZSBub3RpZmljYXRpb24gdG8gdGhlIEVQRiBkcml2ZXJzIG9uY2UgdGhl IGluaXRpYWxpemF0aW9uIGlzIGZ1bGx5Cj4gPiBjb21wbGV0ZWQuCj4gPiAKPiA+IE9ubHkgZGlm ZmVyZW5jZSBoZXJlIGlzIHRoYXQsIHRoZSBkcml2ZXJzIHJlcXVpcmluZyByZWZjbGsgZnJvbSBo b3N0IHdpbGwKPiA+IHNlbmQgdGhlIG5vdGlmaWNhdGlvbiBvbmNlIHJlZmNsayBpcyByZWNlaXZl ZCwgd2hpbGUgb3RoZXJzIHdpbGwgc2VuZCBpdAo+ID4gZHVyaW5nIHByb2JlIHRpbWUgaXRzZWxm Lgo+ID4gCj4gPiBSZXZpZXdlZC1ieTogRnJhbmsgTGkgPEZyYW5rLkxpQG54cC5jb20+Cj4gPiBT aWduZWQtb2ZmLWJ5OiBNYW5pdmFubmFuIFNhZGhhc2l2YW0gPG1hbml2YW5uYW4uc2FkaGFzaXZh bUBsaW5hcm8ub3JnPgo+ID4gLS0tCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9wY2kvZW5kcG9p bnQvZnVuY3Rpb25zL3BjaS1lcGYtdGVzdC5jIGIvZHJpdmVycy9wY2kvZW5kcG9pbnQvZnVuY3Rp b25zL3BjaS1lcGYtdGVzdC5jCj4gPiBpbmRleCAxOGM4MDAwMmQzYmQuLmZjMDI4MmIwZDYyNiAx MDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvcGNpL2VuZHBvaW50L2Z1bmN0aW9ucy9wY2ktZXBmLXRl c3QuYwo+ID4gKysrIGIvZHJpdmVycy9wY2kvZW5kcG9pbnQvZnVuY3Rpb25zL3BjaS1lcGYtdGVz dC5jCj4gPiBAQCAtOTI3LDIxICs5MjgsMTIgQEAgc3RhdGljIGludCBwY2lfZXBmX3Rlc3RfYmlu ZChzdHJ1Y3QgcGNpX2VwZiAqZXBmKQo+ID4gIAlpZiAocmV0KQo+ID4gIAkJcmV0dXJuIHJldDsK PiA+Cj4gCj4gSGVsbG8gTWFuaSwKPiAKPiBTaW5jZSB5b3UgYXNrZWQgZm9yIHRlc3RpbmcsIEkg Z2F2ZSB5b3VyIHNlcmllcyBhIHNwaW4KPiAod2l0aCBhIGRyaXZlciB3aXRob3V0IC5jb3JlX2lu aXRfbm90aWZpZXIpLgo+IAo+IAo+IFRoZXJlIHNlZW1zIHRvIGJlIGEgcHJvYmxlbSB0aGF0IHBj aV9lcGNfd3JpdGVfaGVhZGVyKCkgaXMgbmV2ZXIgY2FsbGVkLgo+IAo+IERlYnVnZ2luZyB0aGlz LCBpdCBzZWVtcyB0aGF0IC5jb3JlX2luaXQgaW4gcGNpLWVwZi10ZXN0IGlzIG5ldmVyIGNhbGxl ZC4KPiAKPiBJZiBJIGFkZCBkZWJ1ZyBwcmludHMgaW4gcGNpX2VwY19pbml0X25vdGlmeSgpLCBJ IHNlZSB0aGF0IGl0IGRvZXMgbm90Cj4gbm90aWZ5IGEgc2luZ2xlIEVQRiBkcml2ZXIuCj4gCj4g SXQgYXBwZWFycyB0aGF0IHRoZSBwYXRjaCBpbiAkc3ViamVjdCB3aWxsIGNhbGwgcGNpX2VwY19p bml0X25vdGlmeSgpCj4gYXQgRVBDIGRyaXZlciAucHJvYmUoKSB0aW1lLCBhbmQgYXQgdGhhdCBw b2ludCBpbiB0aW1lLCB0aGVyZSBhcmUgbm8KPiBFUEYgZHJpdmVycyByZWdpc3RlcmVkLgo+IAo+ IFRoZXkgZ2V0IHJlZ2lzdGVyZWQgbGF0ZXIsIHdoZW4gZG9pbmcgdGhlIGNvbmZpZ2ZzIHdyaXRl Lgo+IAo+IAo+IEkgd291bGQgc2F5IHRoYXQgaXQgaXMgdGhlIGZvbGxvd2luZyBjaGFuZ2UgdGhh dCBicmVha3MgdGhpbmdzOgo+IAo+ID4gLQlpZiAoIWNvcmVfaW5pdF9ub3RpZmllcikgewo+ID4g LQkJcmV0ID0gcGNpX2VwZl90ZXN0X2NvcmVfaW5pdChlcGYpOwo+ID4gLQkJaWYgKHJldCkKPiA+ IC0JCQlyZXR1cm4gcmV0Owo+ID4gLQl9Cj4gPiAtCj4gCj4gU2luY2Ugd2l0aG91dCB0aGlzIGNv ZGUsIHBjaV9lcGZfdGVzdF9jb3JlX2luaXQoKSB3aWxsIG5vIGxvbmdlciBiZSBjYWxsZWQsCj4g YXMgdGhlcmUgaXMgY3VycmVudGx5IG5vIG9uZSB0aGF0IGNhbGxzIGVwZi0+Y29yZV9pbml0KCkg Zm9yIGEgRVBGIGRyaXZlcgo+IGFmdGVyIGl0IGhhcyBiZWVuIGJvdW5kLiAoRm9yIGRyaXZlcnMg dGhhdCBjYWxsIGR3X3BjaWVfZXBfaW5pdF9ub3RpZnkoKSBpbgo+IC5wcm9iZSgpKQo+IAoKVGhh bmtzIGEgbG90IGZvciB0ZXN0aW5nLCBOaWtsYXMhCgo+IEkgZ3Vlc3Mgb25lIHdheSB0byBzb2x2 ZSB0aGlzIHdvdWxkIGJlIGZvciB0aGUgRVBDIGNvcmUgdG8ga2VlcCB0cmFjayBvZgo+IHRoZSBj dXJyZW50IEVQQyAiY29yZSBzdGF0ZSIgKHVwL2Rvd24pLiBJZiB0aGUgY29yZSBpcyAidXAiIGF0 IEVQRiAuYmluZCgpCj4gdGltZSwgbm90aWZ5IHRoZSBFUEYgZHJpdmVyIGRpcmVjdGx5IGFmdGVy IC5iaW5kKCk/Cj4gCgpZZWFoLCB0aGF0J3MgYSBnb29kIHNvbHV0aW9uLiBCdXQgSSB0aGluayBp dCB3b3VsZCBiZSBiZXR0ZXIgaWYgdGhlIEVQQyBjYWNoZXMKYWxsIGV2ZW50cyBpZiB0aGUgRVBG IGRyaXZlcnMgYXJlIG5vdCBhdmFpbGFibGUgYW5kIGRpc3BhdGNoIHRoZW0gb25jZSB0aGUgYmlu ZApoYXBwZW5zIGZvciBlYWNoIEVQRiBkcml2ZXIuIEV2ZW4gdGhvdWdoIElOSVRfQ09NUExFVEUg aXMgdGhlIG9ubHkgZXZlbnQgdGhhdCBpcwpnZXR0aW5nIGdlbmVyYXRlZCBiZWZvcmUgYmluZCgp IG5vdywgSU1PIGl0IGlzIGJldHRlciB0byBhZGQgcHJvdmlzaW9uIHRvIGNhdGNoCm90aGVyIGV2 ZW50cyBhbHNvLgoKV2R5dD8KCi0gTWFuaQoKLS0gCuCuruCuo+Cuv+CuteCuo+CvjeCuo+CuqeCv jSDgrprgrqTgrr7grprgrr/grrXgrq7gr40KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFy bS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK