From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D7FCEC54E58 for ; Mon, 11 Mar 2024 14:58:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1606810E399; Mon, 11 Mar 2024 14:58:27 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=collabora.com header.i=@collabora.com header.b="SHLbD192"; dkim-atps=neutral Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) by gabe.freedesktop.org (Postfix) with ESMTPS id 82E5510E399 for ; Mon, 11 Mar 2024 14:58:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1710169103; bh=JYEfv+pOAbE2mpU6/gSIH2E4PeWMoYpcS68sBcZCRgc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=SHLbD192KRwwN3uzu/SenK0eBbjwG8Qf/DNNW5agjKlAt+OhshCEPDMkHXzeyWVtv 8EItQvEDIf7bv1Q0SXhuBkgltbufhRjrYsikVnxy1+Bm6Ng/+EFgsjesTUjk0gCZYN 61XxS392aC9RYGYbdMlpD+hTfHFr0xoo6Pi5/RHg8H/EYfgpyUpG+eX3/zA+QmcuK8 AY+Voysxq7g4deOZGEOMzV3+0e9mm9HAMsIg4+8FIFQdhfV0Yc1z+tF8KKCad/VU+l s5LAk6Al/xVGwlRjOyIxoTI7mswYI8ids7TP3k9TLmS1WCUntfw4hYz2KFQHELSPqY iwSZCu0kzGtgQ== Received: from localhost (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 69F0637813B6; Mon, 11 Mar 2024 14:58:23 +0000 (UTC) Date: Mon, 11 Mar 2024 15:58:22 +0100 From: Boris Brezillon To: Liviu Dudau Cc: Jani Nikula , dri-devel@lists.freedesktop.org, Steven Price Subject: Re: [PATCH] Revert "drm/panthor: Fix undefined panthor_device_suspend/resume symbol issue" Message-ID: <20240311155822.2a8507aa@collabora.com> In-Reply-To: References: <20240311111619.249776-1-jani.nikula@intel.com> <20240311124826.44cc69ba@collabora.com> <87cys1t299.fsf@intel.com> <20240311125445.4bab1712@collabora.com> <87a5n5t0mt.fsf@intel.com> Organization: Collabora X-Mailer: Claws Mail 4.2.0 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, 11 Mar 2024 14:41:42 +0000 Liviu Dudau wrote: > On Mon, Mar 11, 2024 at 02:26:50PM +0200, Jani Nikula wrote: > > On Mon, 11 Mar 2024, Boris Brezillon wrote: > > > On Mon, 11 Mar 2024 13:51:46 +0200 > > > Jani Nikula wrote: > > > > > >> On Mon, 11 Mar 2024, Boris Brezillon wrote: > > >> > On Mon, 11 Mar 2024 13:16:19 +0200 > > >> > Jani Nikula wrote: > > >> > > > >> >> This reverts commit 674dc7f61aefea81901c21402946074927e63f1a. > > >> >> > > >> >> The commit causes a recursive dependency in kconfig: > > >> >> > > >> >> drivers/iommu/Kconfig:14:error: recursive dependency detected! > > >> >> drivers/iommu/Kconfig:14: symbol IOMMU_SUPPORT is selected by DRM_PANTHOR > > >> >> drivers/gpu/drm/panthor/Kconfig:3: symbol DRM_PANTHOR depends on PM > > >> >> kernel/power/Kconfig:183: symbol PM is selected by PM_SLEEP > > >> >> kernel/power/Kconfig:117: symbol PM_SLEEP depends on HIBERNATE_CALLBACKS > > >> >> kernel/power/Kconfig:35: symbol HIBERNATE_CALLBACKS is selected by XEN_SAVE_RESTORE > > >> >> arch/x86/xen/Kconfig:67: symbol XEN_SAVE_RESTORE depends on XEN > > >> >> arch/x86/xen/Kconfig:6: symbol XEN depends on PARAVIRT > > >> >> arch/x86/Kconfig:781: symbol PARAVIRT is selected by HYPERV > > >> >> drivers/hv/Kconfig:5: symbol HYPERV depends on X86_LOCAL_APIC > > >> >> arch/x86/Kconfig:1106: symbol X86_LOCAL_APIC depends on X86_UP_APIC > > >> >> arch/x86/Kconfig:1081: symbol X86_UP_APIC prompt is visible depending on PCI_MSI > > >> >> drivers/pci/Kconfig:39: symbol PCI_MSI is selected by AMD_IOMMU > > >> >> drivers/iommu/amd/Kconfig:3: symbol AMD_IOMMU depends on IOMMU_SUPPORT > > >> >> For a resolution refer to Documentation/kbuild/kconfig-language.rst > > >> >> subsection "Kconfig recursive dependency limitations" > > >> >> > > >> >> Fixes: 674dc7f61aef ("drm/panthor: Fix undefined panthor_device_suspend/resume symbol issue") > > >> >> Cc: Boris Brezillon > > >> >> Cc: Liviu Dudau > > >> >> Cc: Steven Price > > >> >> Signed-off-by: Jani Nikula > > >> > > > >> > Acked-by: Boris Brezillon > > >> > > >> Your suggestion select -> depends on IOMMU_SUPPORT seems to also work, > > >> at least for me. Want to send a patch for that instead of me merging the > > >> revert? > > > > > > I replied on the other thread :-). I think we're better off reverting > > > the faulty commit, so we can discuss how to fix the original issue > > > properly without blocking the build. > > > > Thanks, pushed to drm-misc-next. > > So with this revert we're OK with an undefined symbol if !CONFIG_PM, but we're not happy > with a recursive dependency that is only triggered for COMPILE_TEST? I would've thought > IOMMU_SUPPORT options is a better one. No worries, we have plenty of time to fix this. Just didn't want to rush a fix before discussing it with you and Steve.