From: Stefan Hajnoczi <stefanha@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
qemu-devel@nongnu.org, "Thomas Huth" <thuth@redhat.com>,
"Eric Blake" <eblake@redhat.com>, "Mads Ynddal" <mads@ynddal.dk>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Cleber Rosa" <crosa@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH 1/2] tracetool: remove redundant --target-type / --target-name args
Date: Tue, 12 Mar 2024 14:50:57 -0400 [thread overview]
Message-ID: <20240312185057.GE389553@fedora> (raw)
In-Reply-To: <CAFn=p-bJNzH7_iFDjV-Fwg_yO3HPvwaSSxBnuhXD-T6tCTR1Fg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 734 bytes --]
On Mon, Jan 08, 2024 at 04:50:40PM -0500, John Snow wrote:
> On Mon, Jan 8, 2024 at 12:14 PM Daniel P. Berrangé <berrange@redhat.com> wrote:
> >
> > The --target-type and --target-name args are used to construct
> > the default probe prefix if '--probe-prefix' is not given. The
> > meson.build will always pass '--probe-prefix', so the other args
> > are effectively redundant.
> >
> > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
>
> Fine by me, provided there's no reason anyone is calling tracetool
> manually for some reason I haven't thought about. I assume we'll hear
> about it if so...
That's okay. tracetool.py is internal to QEMU so we're free to change
the command-line options.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-03-12 19:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-08 17:13 [PATCH 0/2] trace: fix ability to use systemtap with qemu tools Daniel P. Berrangé
2024-01-08 17:13 ` [PATCH 1/2] tracetool: remove redundant --target-type / --target-name args Daniel P. Berrangé
2024-01-08 21:50 ` John Snow
2024-03-12 18:50 ` Stefan Hajnoczi [this message]
2024-01-08 17:13 ` [PATCH 2/2] meson: generate .stp files for tools too Daniel P. Berrangé
2024-01-09 16:45 ` Eric Blake
2024-02-16 13:09 ` [PATCH 0/2] trace: fix ability to use systemtap with qemu tools Daniel P. Berrangé
2024-03-12 11:34 ` Daniel P. Berrangé
2024-03-12 18:42 ` Stefan Hajnoczi
2024-03-12 18:52 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240312185057.GE389553@fedora \
--to=stefanha@redhat.com \
--cc=berrange@redhat.com \
--cc=crosa@redhat.com \
--cc=eblake@redhat.com \
--cc=jsnow@redhat.com \
--cc=mads@ynddal.dk \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.