From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Chandan Babu R <chandanbabu@kernel.org>,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/5] block: move discard checks into the ioctl handler
Date: Tue, 12 Mar 2024 23:31:31 +0100 [thread overview]
Message-ID: <20240312223131.GA8115@lst.de> (raw)
In-Reply-To: <ZfDTZpuumZSn6oPp@kbusch-mbp.mynextlight.net>
On Tue, Mar 12, 2024 at 04:12:54PM -0600, Keith Busch wrote:
> > + if (!nr_sects)
> > return -EINVAL;
> > + if ((sector | nr_sects) & bs_mask)
> > return -EINVAL;
> > -
> > if (start + len > bdev_nr_bytes(bdev))
> > return -EINVAL;
>
> Maybe you want to shift lower bytes out of consideration, but it is
> different, right? For example, if I call this ioctl with start=5 and
> len=555, it would return EINVAL, but your change would let it succeed
> the same as if start=0, len=512.
We did the same before, just down in __blkdev_issue_discard instead of
in the ioctl handler.
next prev parent reply other threads:[~2024-03-12 22:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-12 14:45 RFCv2: fix fatal signal handling in __blkdev_issue_discard Christoph Hellwig
2024-03-12 14:45 ` [PATCH 1/5] block: move discard checks into the ioctl handler Christoph Hellwig
2024-03-12 22:12 ` Keith Busch
2024-03-12 22:31 ` Christoph Hellwig [this message]
2024-03-13 1:22 ` Keith Busch
2024-03-13 15:40 ` Keith Busch
2024-03-13 20:06 ` Christoph Hellwig
2024-03-13 20:08 ` Jens Axboe
2024-03-12 14:45 ` [PATCH 2/5] block: add a bio_chain_and_submit helper Christoph Hellwig
2024-03-12 14:51 ` Keith Busch
2024-03-12 21:06 ` Christoph Hellwig
2024-03-12 14:45 ` [PATCH 3/5] block: add a blk_alloc_discard_bio helper Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2024-03-12 14:48 RFCv2: fix fatal signal handling in __blkdev_issue_discard Christoph Hellwig
2024-03-12 14:48 ` [PATCH 1/5] block: move discard checks into the ioctl handler Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240312223131.GA8115@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=chandanbabu@kernel.org \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.