From: cem@kernel.org <cem@kernel.org>
To: kvm-riscv@lists.infradead.org
Subject: [PATCH 6/6] riscv: Add a wrapper to call sbi_ecall for base extension
Date: Wed, 13 Mar 2024 09:46:24 +0100 [thread overview]
Message-ID: <20240313084644.277426-7-cem@kernel.org> (raw)
In-Reply-To: <20240313084644.277426-1-cem@kernel.org>
From: Carlos Maiolino <cem@kernel.org>
All SBI extension functions accepts at most one argument, so create a
wrapper around sbi_ecall() to avoid needing to pass in arguments 1 to 5
all the time, also, the wrapper can specify SBI_EXT_BASE directly.
Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
---
riscv/sbi.c | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/riscv/sbi.c b/riscv/sbi.c
index 65492fd6..82513d61 100644
--- a/riscv/sbi.c
+++ b/riscv/sbi.c
@@ -36,6 +36,11 @@ static void gen_report(struct sbiret *ret,
report(ret->value == expected_value, "expected sbi.value");
}
+static inline struct sbiret __base_sbi_ecall(int fid, unsigned long arg0)
+{
+ return sbi_ecall(SBI_EXT_BASE, fid, arg0, 0, 0, 0, 0, 0);
+}
+
static void check_base(void)
{
struct sbiret ret;
@@ -46,7 +51,7 @@ static void check_base(void)
report_prefix_push("mvendorid");
if (env_or_skip("MVENDORID")) {
expected = strtol(getenv("MVENDORID"), NULL, 0);
- ret = sbi_ecall(SBI_EXT_BASE, SBI_EXT_BASE_GET_MVENDORID, 0, 0, 0, 0, 0, 0);
+ ret = __base_sbi_ecall(SBI_EXT_BASE_GET_MVENDORID, 0);
gen_report(&ret, 0, expected);
}
report_prefix_pop();
@@ -54,23 +59,21 @@ static void check_base(void)
report_prefix_push("sbi_impl_id");
if (env_or_skip("SBI_IMPLID")) {
expected = strtol(getenv("SBI_IMPLID"), NULL, 0);
- ret = sbi_ecall(SBI_EXT_BASE, SBI_EXT_BASE_GET_IMP_ID,
- SBI_EXT_BASE, 0, 0, 0, 0, 0);
+ ret = __base_sbi_ecall(SBI_EXT_BASE_GET_IMP_ID, SBI_EXT_BASE);
gen_report(&ret, 0, expected);
}
report_prefix_pop();
report_prefix_push("probe_ext");
expected = getenv("PROBE_EXT") ? strtol(getenv("PROBE_EXT"), NULL, 0) : 1;
- ret = sbi_ecall(SBI_EXT_BASE, SBI_EXT_BASE_PROBE_EXT, SBI_EXT_BASE, 0, 0, 0, 0, 0);
+ ret = __base_sbi_ecall(SBI_EXT_BASE_PROBE_EXT, SBI_EXT_BASE);
gen_report(&ret, 0, expected);
report_prefix_pop();
report_prefix_push("marchid");
if (env_or_skip("MARCHID")) {
expected = strtol(getenv("MARCHID"), NULL, 0);
- ret = sbi_ecall(SBI_EXT_BASE, SBI_EXT_BASE_PROBE_EXT,
- SBI_EXT_BASE_GET_MARCHID, 0, 0, 0, 0, 0);
+ ret = __base_sbi_ecall(SBI_EXT_BASE_PROBE_EXT, SBI_EXT_BASE_GET_MARCHID);
gen_report(&ret, 0, expected);
}
report_prefix_pop();
--
2.44.0
next prev parent reply other threads:[~2024-03-13 8:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 8:46 [PATCH V2 0/6] Add riscv tests to cover the base extension specs cem
2024-03-13 8:46 ` [PATCH V2 1/6] riscv: Add test to probe SBI Extension cem
2024-03-13 11:06 ` Andrew Jones
2024-03-13 8:46 ` [PATCH V2 2/6] riscv: Factor out environment variable check and report generation cem
2024-03-13 11:11 ` Andrew Jones
2024-03-13 8:46 ` [PATCH V2 3/6] riscv: Implement test for architecture ID register cem
2024-03-13 11:21 ` Andrew Jones
2024-03-13 8:46 ` [PATCH V2 4/6] riscv: Enable gen_report() to print the wrong value in case of failure cem
2024-03-13 11:19 ` Andrew Jones
2024-03-13 8:46 ` [PATCH V2 5/6] riscv: Test for specific SBI implementation ID cem
2024-03-13 11:23 ` Andrew Jones
2024-03-13 11:28 ` Andrew Jones
2024-03-13 8:46 ` cem [this message]
2024-03-13 11:33 ` [PATCH 6/6] riscv: Add a wrapper to call sbi_ecall for base extension Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240313084644.277426-7-cem@kernel.org \
--to=cem@kernel.org \
--cc=kvm-riscv@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.