All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Sven Auhagen <sven.auhagen@voleatech.de>
Cc: netfilter-devel@vger.kernel.org, pablo@netfilter.org
Subject: Re: Flowtable race condition error
Date: Wed, 13 Mar 2024 15:55:57 +0100	[thread overview]
Message-ID: <20240313145557.GD2899@breakpoint.cc> (raw)
In-Reply-To: <x6s4ukl7gfgkcap6b56o6wv6oqanyjx4u7fj5ldnjqna7yp6lu@2pxdntq2pe5f>

Sven Auhagen <sven.auhagen@voleatech.de> wrote:
> I have a race condition problem in the flowtable and could
> use some hint where to start debugging.
> 
> Every now and then a TCP FIN is closing the flowtable with a call
> to flow_offload_teardown.

I don't understand why this is done.  It seems buggy to do this.

The skb has not been seen by conntrack yet, so any reply packet coming
in between the flow_offload_teardown() call and the conntrack actually
moving to close state ...

> Right after another packet from the reply direction is readding
> the connection to the flowtable just before the FIN is actually
> transitioning the state from ESTABLISHED to FIN WAIT.

.. will re-add.

> Any idea why the state is deleted right away?

No idea, but it was intentional, see
b6f27d322a0a ("netfilter: nf_flow_table: tear down TCP flows if RST or FIN was seen")

  reply	other threads:[~2024-03-13 14:55 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-12 16:29 Flowtable race condition error Sven Auhagen
2024-03-13 14:55 ` Florian Westphal [this message]
2024-03-13 15:02   ` Florian Westphal
2024-03-13 15:06     ` Sven Auhagen
2024-03-13 15:25       ` Florian Westphal
2024-03-13 15:30         ` Sven Auhagen
2024-03-14  7:48         ` Sven Auhagen
2024-03-14  9:25           ` Florian Westphal
2024-03-14 10:08             ` Sven Auhagen
2024-03-14 11:21               ` Florian Westphal
2024-03-14 11:17 ` Pablo Neira Ayuso
2024-03-14 11:30   ` Sven Auhagen
2024-03-14 12:38     ` Pablo Neira Ayuso
2024-03-14 12:43       ` Sven Auhagen
2024-03-14 12:56         ` Pablo Neira Ayuso
2024-03-14 13:56           ` Sven Auhagen
2024-03-15 13:46           ` Sven Auhagen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240313145557.GD2899@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=sven.auhagen@voleatech.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.