From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADC0413DB9A for ; Wed, 13 Mar 2024 17:53:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710352431; cv=none; b=fz4KC6EaPo+ue8kR/bvQHLUUVyLmgoVXewFpo0QWOZ5TlqVA+YGZJtImTV4rmnwYXe8JtLwTOETGgAoHSMhhsX40MxEjYHlCME86VzfrIEOt/3VKADCururflpoCiPB7DoK33+EBcdxporZcxfENgnVXohK8bC0i+hUbAW1LFjY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710352431; c=relaxed/simple; bh=ikP1SQZvK81WwtXopq3dHhyUueLGCn0F9tCceqEbyeU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ryF9tGxDcwfh5wdIe6n/dPmuRwMBEEGQKsH2Y6C0qs35938UPHICLdlXZDWitGGK2q+FtegIbUAl60GWv46CucFis5A6yx3ZE2MA8WMezMpfXCnFy1GCTfK1W81yQ0Uxrgodu2jfaHKO8UCMJnpcKn6ZFqAvYcTeAybWsy3SOEQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=D8zvQJOD; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="D8zvQJOD" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-6e6ac58fceaso197939b3a.1 for ; Wed, 13 Mar 2024 10:53:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710352429; x=1710957229; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=P42L0V1byhnm9xVh8nwf+gtaXnbnBXKB7y3o50DEnDg=; b=D8zvQJODpgv7AIuJtS6cE34ZEwNLkubA98YOSqTLCzC69KQKzO2f3zGeK+Z5DUDzxi o+MhH1fXsTzC5+MTFYVzZwM9TKWdDIfSl1AGH4LSzvVuBGbMD9jG+UhqXrHUxeFvsP3d 9TbKrEZk62XKsAq5v22pZCQ97JzVgSroarKzmG+MUpGNK6RQn37mVHRtnV5W2hzV27QY PmCrm+BjGNdDurv7SBFLacgCV6vRcD2ofQILGoRLKueVEbpbDvkB323zb0PN2kMXj9gt xqGrrJBdBocY31UygcoLPWUorr0DO9CcXcsP4/rt5f53tS9eMDhWoE2TfEfjPvuLDUo/ vIjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710352429; x=1710957229; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=P42L0V1byhnm9xVh8nwf+gtaXnbnBXKB7y3o50DEnDg=; b=v3HGmt2GtCRnH8ZEZIZCP2F0ZJHJZlWWLfyL86nrTL/LV+CRUnYW4A8oboZ/66VdxA e4ilYyGRXvS1TI+9aS8hGyzVqH/MzWc0kyiJRGuSwMGAGv+XPSgALygxg9svgMu56bFj mLRbIwlsyuuLccpF9T0Bq8fc3jpNtIk2C/OFujyLGQWXOjTpTG2VuWoSUMDGqBKmuUh/ HpGsxFQxBNxYLZ3saWnC3Bm4goIzE7OHeEDYA2MstpmTzSgAyNCc8FuXRxjQAHmjxZYX cF3Y9P9x5wtBqF/M1LyBmGvA4nuCpi7v5l9EmkSto5z2u5+mcmFW8ti1n9bxn+Z4k3mB jqdw== X-Forwarded-Encrypted: i=1; AJvYcCXMHNYBu8MxxrUtS6Kwfkfo9TOT2LxGFSzqiAr7p6kTlmlyOOgf6b8l+JuVmrCI8Oy/SizfOgBdRNwd6lc6B+WmNrdSfWUsfK+4tJK/1Q== X-Gm-Message-State: AOJu0YwXsgFMEDGaPpX+hIWaZuKL9/r3KZaor+UnhX5tGQvgWGXfXFco 9feFA2uzSSk/4fciePcWh3F2j8flqoxfzsr4u+uBWqBZQKJiRXa5sj7B4BRa6Q== X-Google-Smtp-Source: AGHT+IFcf5q7ruVnxD8hAPCs04EkAgFwMtLJq7WsD337HPZnA1JczKQ1xXu4AYtawACMGMb2l439Qw== X-Received: by 2002:a05:6a20:12c9:b0:1a3:113a:bbd5 with SMTP id v9-20020a056a2012c900b001a3113abbd5mr5892663pzg.40.1710352428857; Wed, 13 Mar 2024 10:53:48 -0700 (PDT) Received: from thinkpad ([117.213.99.94]) by smtp.gmail.com with ESMTPSA id r6-20020a63e506000000b005dbd0facb4dsm7803062pgh.61.2024.03.13.10.53.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Mar 2024 10:53:48 -0700 (PDT) Date: Wed, 13 Mar 2024 23:23:33 +0530 From: Manivannan Sadhasivam To: Niklas Cassel Cc: Jingoo Han , Gustavo Pimentel , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Marek Vasut , Yoshihiro Shimoda , Thierry Reding , Jonathan Hunter , Kishon Vijay Abraham I , Vidya Sagar , Vignesh Raghavendra , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Minghuan Lian , Mingkai Hu , Roy Zang , Kunihiko Hayashi , Masami Hiramatsu , Kishon Vijay Abraham I , Jesper Nilsson , Srikanth Thokala , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@axis.com, Frank Li Subject: Re: [PATCH v9 07/10] PCI: dwc: ep: Remove "core_init_notifier" flag Message-ID: <20240313175333.GA126027@thinkpad> References: <20240304-pci-dbi-rework-v9-0-29d433d99cda@linaro.org> <20240304-pci-dbi-rework-v9-7-29d433d99cda@linaro.org> <20240311144559.GA2504@thinkpad> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Mar 11, 2024 at 10:54:28PM +0100, Niklas Cassel wrote: > On Mon, Mar 11, 2024 at 08:15:59PM +0530, Manivannan Sadhasivam wrote: > > > > > > I would say that it is the following change that breaks things: > > > > > > > - if (!core_init_notifier) { > > > > - ret = pci_epf_test_core_init(epf); > > > > - if (ret) > > > > - return ret; > > > > - } > > > > - > > > > > > Since without this code, pci_epf_test_core_init() will no longer be called, > > > as there is currently no one that calls epf->core_init() for a EPF driver > > > after it has been bound. (For drivers that call dw_pcie_ep_init_notify() in > > > .probe()) > > > > > > > Thanks a lot for testing, Niklas! > > > > > I guess one way to solve this would be for the EPC core to keep track of > > > the current EPC "core state" (up/down). If the core is "up" at EPF .bind() > > > time, notify the EPF driver directly after .bind()? > > > > > > > Yeah, that's a good solution. But I think it would be better if the EPC caches > > all events if the EPF drivers are not available and dispatch them once the bind > > happens for each EPF driver. Even though INIT_COMPLETE is the only event that is > > getting generated before bind() now, IMO it is better to add provision to catch > > other events also. > > > > Wdyt? > > I'm not sure. > What if the EPF goes up/down/up, it seems a bit silly to send all those > events to the EPF driver that will alloc+free+alloc. > > Do we know for sure that we will want to store + replay events other than > INIT_COMPLETE? > > And how many events should we store? > > > Until we can think of a good reason which events other than UP/DOWN we > can to store, I think that just storing the state as an integer in > struct pci_epc seems simpler. > Hmm, makes sense. > > Or I guess we could continue with a flag in struct pci_epc_features, > like has_perst_notifier, which would then require the EPC driver to > call both epc_notify_core_up() and epc_notify_core_down() when receiving > the PERST deassert/assert. > For a driver without the flag set, the EPC core would call > .epc_notify_core_up() after bind. (And .epc_notify_core_down() would never > be called, or it could call it before unbind().) > That way an EPF driver itself would not need any different handling > (all callbacks would always come, either triggered by an EPC driver that > has PERST GPIO irq, or triggered by the EPC core for a driver that lacks > a PERST GPIO). > For simplicity, I've just used a flag in 'struct pci_epc' to track the core_init and call the callback during bind(). But the series has grown big, so I decided to split it into two. One to address the DBI access issue and also remove the 'core_init_notifier' flag and another one to make EPF drivers more robust to handle the host reboot scenario. - Mani -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6DB13C54E66 for ; Wed, 13 Mar 2024 17:54:40 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=wQQy+2vx; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Tvynq0Yp5z3dX6 for ; Thu, 14 Mar 2024 04:54:39 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=wQQy+2vx; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linaro.org (client-ip=2607:f8b0:4864:20::436; helo=mail-pf1-x436.google.com; envelope-from=manivannan.sadhasivam@linaro.org; receiver=lists.ozlabs.org) Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Tvymz2TFbz3cG3 for ; Thu, 14 Mar 2024 04:53:53 +1100 (AEDT) Received: by mail-pf1-x436.google.com with SMTP id d2e1a72fcca58-6e6c10bdd2fso163781b3a.3 for ; Wed, 13 Mar 2024 10:53:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710352429; x=1710957229; darn=lists.ozlabs.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=P42L0V1byhnm9xVh8nwf+gtaXnbnBXKB7y3o50DEnDg=; b=wQQy+2vxvLAvNpqd3ubD/nJltqfAjlk8CQ9eCIl3gss64grF0YGr/tSa8cmrjRl0hA J6We1/VMIDulapyU1T5kpZwZQqE0QmxLaHmtRGrd9MLnv9KKmNBA5BRfYMH3BNcEXpTi rUwtjdTXU7v53cWELpp8DI0rrgwCWGks5j7LHpAdFXL4PHm2dQZqrYLU3kSgqXRObBMt EcIL0iwUrANtHIxGfEHjFc/mVZtSwQlLJjcbt1JTYkT/2fOQIm1WDkfnCAS7Dy0eVvwW 6LY4h2sx8KADpaSd8MsHkF83YZLZeciLZyjkGsBBrv8d9967jsvYk3uViQkz3PI7rvoV 2t8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710352429; x=1710957229; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=P42L0V1byhnm9xVh8nwf+gtaXnbnBXKB7y3o50DEnDg=; b=CkAIFDVr4VkZDz2QZqIEC5e6/3DQnJRrByX217+jzxUW94rZp+YDdLYQ/PO6LykBwZ qXNqSt4mNT6muYYbgC6Dxm2rWSUoQVx+6fSLRaofry76C36iLAyyLlT7jtvDamr7aopl UtO/DJ4J7eVDH8MG5SAEFbGnOHb+p+liakWlNwLtkcETqjqRIDyRi2ZvSpFVCyQqqBtX VSoGu7JqW55o1lvcSjXf7G+ZjCgF4kxm8lVYe7uGBzOy7RIwVoNjNCXzv+D6FfuLJ9T0 BPMTjb6e7HdyjAOYQ63VXcQ66gsZsf689sIFPRgDqmAvRKBgK2pDw2au9Lz20tKh0tEk Ra6g== X-Forwarded-Encrypted: i=1; AJvYcCVJ2wdgNcQnHWMdYrbIs3qi1bO4FtpAWte65Wmg6PcmDI/k0L0CWghUMRXTzQZHr4ZZfLQTe2/zBaZO4tvuoogJbCoKzU/RaKfR+Fw/8g== X-Gm-Message-State: AOJu0Yx6igamKeaJhpE7SEImBv3Q6gC3sTQVkWhBFQJruokioVEFk2tp vNKYMM1qhmbnrh2jftuR5J8WQKGLpH/K8FVB0xqG34/61j3Kx6K/vWRCDBspnA== X-Google-Smtp-Source: AGHT+IFcf5q7ruVnxD8hAPCs04EkAgFwMtLJq7WsD337HPZnA1JczKQ1xXu4AYtawACMGMb2l439Qw== X-Received: by 2002:a05:6a20:12c9:b0:1a3:113a:bbd5 with SMTP id v9-20020a056a2012c900b001a3113abbd5mr5892663pzg.40.1710352428857; Wed, 13 Mar 2024 10:53:48 -0700 (PDT) Received: from thinkpad ([117.213.99.94]) by smtp.gmail.com with ESMTPSA id r6-20020a63e506000000b005dbd0facb4dsm7803062pgh.61.2024.03.13.10.53.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Mar 2024 10:53:48 -0700 (PDT) Date: Wed, 13 Mar 2024 23:23:33 +0530 From: Manivannan Sadhasivam To: Niklas Cassel Subject: Re: [PATCH v9 07/10] PCI: dwc: ep: Remove "core_init_notifier" flag Message-ID: <20240313175333.GA126027@thinkpad> References: <20240304-pci-dbi-rework-v9-0-29d433d99cda@linaro.org> <20240304-pci-dbi-rework-v9-7-29d433d99cda@linaro.org> <20240311144559.GA2504@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Vignesh Raghavendra , Kunihiko Hayashi , linux-pci@vger.kernel.org, Lorenzo Pieralisi , Frank Li , Minghuan Lian , Thierry Reding , Kishon Vijay Abraham I , Fabio Estevam , Marek Vasut , Kishon Vijay Abraham I , Rob Herring , Jesper Nilsson , linux-tegra@vger.kernel.org, linux-arm-kernel@axis.com, Jonathan Hunter , NXP Linux Team , Richard Zhu , Srikanth Thokala , linux-arm-msm@vger.kernel.org, Sascha Hauer , linuxppc-dev@lists.ozlabs.org, Bjorn Helgaas , linux-omap@vger.kernel.org, Mingkai Hu , linux-arm-kernel@ lists.infradead.org, Roy Zang , Jingoo Han , Yoshihiro Shimoda , linux-kernel@vger.kernel.org, Vidya Sagar , linux-renesas-soc@vger.kernel.org, Masami Hiramatsu , Pengutronix Kernel Team , Gustavo Pimentel , Shawn Guo , Lucas Stach Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Mar 11, 2024 at 10:54:28PM +0100, Niklas Cassel wrote: > On Mon, Mar 11, 2024 at 08:15:59PM +0530, Manivannan Sadhasivam wrote: > > > > > > I would say that it is the following change that breaks things: > > > > > > > - if (!core_init_notifier) { > > > > - ret = pci_epf_test_core_init(epf); > > > > - if (ret) > > > > - return ret; > > > > - } > > > > - > > > > > > Since without this code, pci_epf_test_core_init() will no longer be called, > > > as there is currently no one that calls epf->core_init() for a EPF driver > > > after it has been bound. (For drivers that call dw_pcie_ep_init_notify() in > > > .probe()) > > > > > > > Thanks a lot for testing, Niklas! > > > > > I guess one way to solve this would be for the EPC core to keep track of > > > the current EPC "core state" (up/down). If the core is "up" at EPF .bind() > > > time, notify the EPF driver directly after .bind()? > > > > > > > Yeah, that's a good solution. But I think it would be better if the EPC caches > > all events if the EPF drivers are not available and dispatch them once the bind > > happens for each EPF driver. Even though INIT_COMPLETE is the only event that is > > getting generated before bind() now, IMO it is better to add provision to catch > > other events also. > > > > Wdyt? > > I'm not sure. > What if the EPF goes up/down/up, it seems a bit silly to send all those > events to the EPF driver that will alloc+free+alloc. > > Do we know for sure that we will want to store + replay events other than > INIT_COMPLETE? > > And how many events should we store? > > > Until we can think of a good reason which events other than UP/DOWN we > can to store, I think that just storing the state as an integer in > struct pci_epc seems simpler. > Hmm, makes sense. > > Or I guess we could continue with a flag in struct pci_epc_features, > like has_perst_notifier, which would then require the EPC driver to > call both epc_notify_core_up() and epc_notify_core_down() when receiving > the PERST deassert/assert. > For a driver without the flag set, the EPC core would call > .epc_notify_core_up() after bind. (And .epc_notify_core_down() would never > be called, or it could call it before unbind().) > That way an EPF driver itself would not need any different handling > (all callbacks would always come, either triggered by an EPC driver that > has PERST GPIO irq, or triggered by the EPC core for a driver that lacks > a PERST GPIO). > For simplicity, I've just used a flag in 'struct pci_epc' to track the core_init and call the callback during bind(). But the series has grown big, so I decided to split it into two. One to address the DBI access issue and also remove the 'core_init_notifier' flag and another one to make EPF drivers more robust to handle the host reboot scenario. - Mani -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C998EC54791 for ; Wed, 13 Mar 2024 17:54:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=E5Ug0hhiOL/kPLKC2GXl2h3FPmtbma53ZvXyG02xg2w=; b=ypb08CPnDG6IEp H9mGWbvOtLYlR2LJzfRHLnf6cqtsccxvvGcFaRhJw0fXnqCwpyIx+ZmFZMRUrq2vzg+6+lxEmiGNW JPwUo91pDPIVQ+gdHrYO3d8u/wtZdoy1E1xPY581aWB32z1h4yoNL9GN2MK7ANX2+0waDM2th/79Y yVL40/O96HfRnrTQKxLmh5nmKPIaMtoYS3+mPoziEckfG3uFanyVEhIhT2RCYmO21p3v9bUW7XDyq dgo+aUhaYfz6dAdok2u9rJQMgw9pNX07fPFy33xNfwgMYoLknbOWQFsPhwit/KIAkHRZa0vxL8OId NN43iCquDWNviyBhO5kg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rkSnf-0000000B9ZD-2PMT; Wed, 13 Mar 2024 17:53:59 +0000 Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rkSnc-0000000B9Vj-26xi for linux-arm-kernel@lists.infradead.org; Wed, 13 Mar 2024 17:53:58 +0000 Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-6e6b6a1b940so186194b3a.0 for ; Wed, 13 Mar 2024 10:53:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710352429; x=1710957229; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=P42L0V1byhnm9xVh8nwf+gtaXnbnBXKB7y3o50DEnDg=; b=OXT/ts+M+MIL049MYbXU4iTa+T3rWKy0wyLd1CSSZ0ADmJY4MCTPWdhJI0iL5Yw3U4 IKoolOXL2SGF5PBmPeUfAUGXGAQLTH6KT0lSF80SwZkxyYtuS1MP7yVLc9N3NE1qnQPz ZCSTWrcvVQxYwT6oSxQFrTrksWrwe6bllD2Hvq3EyDWmFyavdYGFMGfoiofr1eKfwBqC zl031Fivga4OOHaqcCegNHoU6NaPTKMyWyMj7S61urX5NYn67ET6cIdDG/d1HsWt1xL/ H0ToFD01tCKrlHHEfSueykpa5kVGGEteFDrkeK7SRu6B4kqlTC/oj3Rs9qIfQOHRpIly zCjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710352429; x=1710957229; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=P42L0V1byhnm9xVh8nwf+gtaXnbnBXKB7y3o50DEnDg=; b=CuBixOl7hGcJ81A5Itn0AsdgTaxFSgyz24/oib2AITjvz0+lZCIr611iT2gV1tSK90 Cy7vGo8Lg+Ahn/bC1tIs7oz2XJJNDrV8OljWhmAM4iqEZbPZM0OaIz3L/m1+RPt0dqr1 JhA2kbIdrJjCNZBMUfNTgY3oTWVJjLWKEdgK01LPowPmmJUTYXVm1QH3uT+44fPA8ruD 8BlhFTXALn5gsNjqo8+9nIWr12pQQRC7hlHm+HR48Sq7a8tzbOe7vxtWiUK07wYf2kMR YRdzxj7p95YyoVnbPK6YvEpI7KC6fXxqHRaxBwsH0NlkbhbebpGHK4AGdZUwzexL3jvU 7egg== X-Forwarded-Encrypted: i=1; AJvYcCXTv64IYPOgsukjNF4IVX6FUHxrsPdbvxIzjD6TI8tCi4eTuPfUtB1gv0yWshpGHZa5MCddhNttf4NpCA+hGM5xckojyw/VBebq//et4jtXS3DQdr4= X-Gm-Message-State: AOJu0Yy5mguySjLhjEKE/lefXEvKEW5svAcjcLROpkUKfGyP2FhEBiy8 02QE3gt9U2Wc+UTPPlkZo09SIdt/5DI47Z+O3RaH//iZ3LXgwOQZIKRBbRrtfw== X-Google-Smtp-Source: AGHT+IFcf5q7ruVnxD8hAPCs04EkAgFwMtLJq7WsD337HPZnA1JczKQ1xXu4AYtawACMGMb2l439Qw== X-Received: by 2002:a05:6a20:12c9:b0:1a3:113a:bbd5 with SMTP id v9-20020a056a2012c900b001a3113abbd5mr5892663pzg.40.1710352428857; Wed, 13 Mar 2024 10:53:48 -0700 (PDT) Received: from thinkpad ([117.213.99.94]) by smtp.gmail.com with ESMTPSA id r6-20020a63e506000000b005dbd0facb4dsm7803062pgh.61.2024.03.13.10.53.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Mar 2024 10:53:48 -0700 (PDT) Date: Wed, 13 Mar 2024 23:23:33 +0530 From: Manivannan Sadhasivam To: Niklas Cassel Cc: Jingoo Han , Gustavo Pimentel , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Marek Vasut , Yoshihiro Shimoda , Thierry Reding , Jonathan Hunter , Kishon Vijay Abraham I , Vidya Sagar , Vignesh Raghavendra , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Minghuan Lian , Mingkai Hu , Roy Zang , Kunihiko Hayashi , Masami Hiramatsu , Kishon Vijay Abraham I , Jesper Nilsson , Srikanth Thokala , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@axis.com, Frank Li Subject: Re: [PATCH v9 07/10] PCI: dwc: ep: Remove "core_init_notifier" flag Message-ID: <20240313175333.GA126027@thinkpad> References: <20240304-pci-dbi-rework-v9-0-29d433d99cda@linaro.org> <20240304-pci-dbi-rework-v9-7-29d433d99cda@linaro.org> <20240311144559.GA2504@thinkpad> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240313_105356_637871_3275E2B4 X-CRM114-Status: GOOD ( 33.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBNYXIgMTEsIDIwMjQgYXQgMTA6NTQ6MjhQTSArMDEwMCwgTmlrbGFzIENhc3NlbCB3 cm90ZToKPiBPbiBNb24sIE1hciAxMSwgMjAyNCBhdCAwODoxNTo1OVBNICswNTMwLCBNYW5pdmFu bmFuIFNhZGhhc2l2YW0gd3JvdGU6Cj4gPiA+IAo+ID4gPiBJIHdvdWxkIHNheSB0aGF0IGl0IGlz IHRoZSBmb2xsb3dpbmcgY2hhbmdlIHRoYXQgYnJlYWtzIHRoaW5nczoKPiA+ID4gCj4gPiA+ID4g LQlpZiAoIWNvcmVfaW5pdF9ub3RpZmllcikgewo+ID4gPiA+IC0JCXJldCA9IHBjaV9lcGZfdGVz dF9jb3JlX2luaXQoZXBmKTsKPiA+ID4gPiAtCQlpZiAocmV0KQo+ID4gPiA+IC0JCQlyZXR1cm4g cmV0Owo+ID4gPiA+IC0JfQo+ID4gPiA+IC0KPiA+ID4gCj4gPiA+IFNpbmNlIHdpdGhvdXQgdGhp cyBjb2RlLCBwY2lfZXBmX3Rlc3RfY29yZV9pbml0KCkgd2lsbCBubyBsb25nZXIgYmUgY2FsbGVk LAo+ID4gPiBhcyB0aGVyZSBpcyBjdXJyZW50bHkgbm8gb25lIHRoYXQgY2FsbHMgZXBmLT5jb3Jl X2luaXQoKSBmb3IgYSBFUEYgZHJpdmVyCj4gPiA+IGFmdGVyIGl0IGhhcyBiZWVuIGJvdW5kLiAo Rm9yIGRyaXZlcnMgdGhhdCBjYWxsIGR3X3BjaWVfZXBfaW5pdF9ub3RpZnkoKSBpbgo+ID4gPiAu cHJvYmUoKSkKPiA+ID4gCj4gPiAKPiA+IFRoYW5rcyBhIGxvdCBmb3IgdGVzdGluZywgTmlrbGFz IQo+ID4gCj4gPiA+IEkgZ3Vlc3Mgb25lIHdheSB0byBzb2x2ZSB0aGlzIHdvdWxkIGJlIGZvciB0 aGUgRVBDIGNvcmUgdG8ga2VlcCB0cmFjayBvZgo+ID4gPiB0aGUgY3VycmVudCBFUEMgImNvcmUg c3RhdGUiICh1cC9kb3duKS4gSWYgdGhlIGNvcmUgaXMgInVwIiBhdCBFUEYgLmJpbmQoKQo+ID4g PiB0aW1lLCBub3RpZnkgdGhlIEVQRiBkcml2ZXIgZGlyZWN0bHkgYWZ0ZXIgLmJpbmQoKT8KPiA+ ID4gCj4gPiAKPiA+IFllYWgsIHRoYXQncyBhIGdvb2Qgc29sdXRpb24uIEJ1dCBJIHRoaW5rIGl0 IHdvdWxkIGJlIGJldHRlciBpZiB0aGUgRVBDIGNhY2hlcwo+ID4gYWxsIGV2ZW50cyBpZiB0aGUg RVBGIGRyaXZlcnMgYXJlIG5vdCBhdmFpbGFibGUgYW5kIGRpc3BhdGNoIHRoZW0gb25jZSB0aGUg YmluZAo+ID4gaGFwcGVucyBmb3IgZWFjaCBFUEYgZHJpdmVyLiBFdmVuIHRob3VnaCBJTklUX0NP TVBMRVRFIGlzIHRoZSBvbmx5IGV2ZW50IHRoYXQgaXMKPiA+IGdldHRpbmcgZ2VuZXJhdGVkIGJl Zm9yZSBiaW5kKCkgbm93LCBJTU8gaXQgaXMgYmV0dGVyIHRvIGFkZCBwcm92aXNpb24gdG8gY2F0 Y2gKPiA+IG90aGVyIGV2ZW50cyBhbHNvLgo+ID4gCj4gPiBXZHl0Pwo+IAo+IEknbSBub3Qgc3Vy ZS4KPiBXaGF0IGlmIHRoZSBFUEYgZ29lcyB1cC9kb3duL3VwLCBpdCBzZWVtcyBhIGJpdCBzaWxs eSB0byBzZW5kIGFsbCB0aG9zZQo+IGV2ZW50cyB0byB0aGUgRVBGIGRyaXZlciB0aGF0IHdpbGwg YWxsb2MrZnJlZSthbGxvYy4KPiAKPiBEbyB3ZSBrbm93IGZvciBzdXJlIHRoYXQgd2Ugd2lsbCB3 YW50IHRvIHN0b3JlICsgcmVwbGF5IGV2ZW50cyBvdGhlciB0aGFuCj4gSU5JVF9DT01QTEVURT8K PiAKPiBBbmQgaG93IG1hbnkgZXZlbnRzIHNob3VsZCB3ZSBzdG9yZT8KPiAKPiAKPiBVbnRpbCB3 ZSBjYW4gdGhpbmsgb2YgYSBnb29kIHJlYXNvbiB3aGljaCBldmVudHMgb3RoZXIgdGhhbiBVUC9E T1dOIHdlCj4gY2FuIHRvIHN0b3JlLCBJIHRoaW5rIHRoYXQganVzdCBzdG9yaW5nIHRoZSBzdGF0 ZSBhcyBhbiBpbnRlZ2VyIGluCj4gc3RydWN0IHBjaV9lcGMgc2VlbXMgc2ltcGxlci4KPiAKCkht bSwgbWFrZXMgc2Vuc2UuCgo+IAo+IE9yIEkgZ3Vlc3Mgd2UgY291bGQgY29udGludWUgd2l0aCBh IGZsYWcgaW4gc3RydWN0IHBjaV9lcGNfZmVhdHVyZXMsCj4gbGlrZSBoYXNfcGVyc3Rfbm90aWZp ZXIsIHdoaWNoIHdvdWxkIHRoZW4gcmVxdWlyZSB0aGUgRVBDIGRyaXZlciB0bwo+IGNhbGwgYm90 aCBlcGNfbm90aWZ5X2NvcmVfdXAoKSBhbmQgZXBjX25vdGlmeV9jb3JlX2Rvd24oKSB3aGVuIHJl Y2VpdmluZwo+IHRoZSBQRVJTVCBkZWFzc2VydC9hc3NlcnQuCj4gRm9yIGEgZHJpdmVyIHdpdGhv dXQgdGhlIGZsYWcgc2V0LCB0aGUgRVBDIGNvcmUgd291bGQgY2FsbAo+IC5lcGNfbm90aWZ5X2Nv cmVfdXAoKSBhZnRlciBiaW5kLiAoQW5kIC5lcGNfbm90aWZ5X2NvcmVfZG93bigpIHdvdWxkIG5l dmVyCj4gYmUgY2FsbGVkLCBvciBpdCBjb3VsZCBjYWxsIGl0IGJlZm9yZSB1bmJpbmQoKS4pCj4g VGhhdCB3YXkgYW4gRVBGIGRyaXZlciBpdHNlbGYgd291bGQgbm90IG5lZWQgYW55IGRpZmZlcmVu dCBoYW5kbGluZwo+IChhbGwgY2FsbGJhY2tzIHdvdWxkIGFsd2F5cyBjb21lLCBlaXRoZXIgdHJp Z2dlcmVkIGJ5IGFuIEVQQyBkcml2ZXIgdGhhdAo+IGhhcyBQRVJTVCBHUElPIGlycSwgb3IgdHJp Z2dlcmVkIGJ5IHRoZSBFUEMgY29yZSBmb3IgYSBkcml2ZXIgdGhhdCBsYWNrcwo+IGEgUEVSU1Qg R1BJTykuCj4gCgpGb3Igc2ltcGxpY2l0eSwgSSd2ZSBqdXN0IHVzZWQgYSBmbGFnIGluICdzdHJ1 Y3QgcGNpX2VwYycgdG8gdHJhY2sgdGhlIGNvcmVfaW5pdAphbmQgY2FsbCB0aGUgY2FsbGJhY2sg ZHVyaW5nIGJpbmQoKS4KCkJ1dCB0aGUgc2VyaWVzIGhhcyBncm93biBiaWcsIHNvIEkgZGVjaWRl ZCB0byBzcGxpdCBpdCBpbnRvIHR3by4gT25lIHRvIGFkZHJlc3MKdGhlIERCSSBhY2Nlc3MgaXNz dWUgYW5kIGFsc28gcmVtb3ZlIHRoZSAnY29yZV9pbml0X25vdGlmaWVyJyBmbGFnIGFuZCBhbm90 aGVyCm9uZSB0byBtYWtlIEVQRiBkcml2ZXJzIG1vcmUgcm9idXN0IHRvIGhhbmRsZSB0aGUgaG9z dCByZWJvb3Qgc2NlbmFyaW8uCgotIE1hbmkKCi0tIArgrq7grqPgrr/grrXgrqPgr43grqPgrqng r40g4K6a4K6k4K6+4K6a4K6/4K614K6u4K+NCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1h cm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcv bWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==