From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 20BFEC54E66 for ; Wed, 13 Mar 2024 21:51:45 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=T0wvxe2J; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=LTOpLQYr; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Tw43M4Zmqz3vkd for ; Thu, 14 Mar 2024 08:51:43 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=T0wvxe2J; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=LTOpLQYr; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=170.10.129.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=peterx@redhat.com; receiver=lists.ozlabs.org) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Tw3yY2Prtz30h8 for ; Thu, 14 Mar 2024 08:47:33 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710366450; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dXyJDuJosTa0kFBnhKvW1aqbtapsaxz0OHU+bPr+fnc=; b=T0wvxe2JskXetd00jmZvrz41xDj5HAZ8lmEtTeF895rIlJ9au1ifo0DT7qMwgVqBlOHDe7 hW2GkKjyQ1dOheXdyilkypVjLB5y/YOzyrG9/VIyltN9PXFAmtQwJTqh0F073vL/0nv1dF rUxfxQT7xEExltFX5PMFc+qj0IjstE8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710366451; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dXyJDuJosTa0kFBnhKvW1aqbtapsaxz0OHU+bPr+fnc=; b=LTOpLQYraY+PadoDsrCsF/o6wp5PQyzoax3nyunILSykrbeR3qlKBOgNsV5BJHfMBAPB9h 75+kkIyYhkogEmLsgJFVQRwjCTEGt9ySRKcX14YcYbq3973E8Rkxe+im1Jc6zmbC/szqOn jtFO6qo3zzLmrWagCV60FlLpTQQDsAM= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-335-EmtVOPVMMuyGEYUgyK18mQ-1; Wed, 13 Mar 2024 17:47:29 -0400 X-MC-Unique: EmtVOPVMMuyGEYUgyK18mQ-1 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-690d3f5af86so1063716d6.0 for ; Wed, 13 Mar 2024 14:47:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710366449; x=1710971249; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dXyJDuJosTa0kFBnhKvW1aqbtapsaxz0OHU+bPr+fnc=; b=svIM2vAwDH6rlkybyz9BXjde15HfzKRm/yQSV5fK4UH/M8fa1CCps2emLk+ed3+qfE eNjX9yTRdBQrWAHtqrYdXdJkmqLDwSyhOq7jWxT0Ab5kY86lpqje8dYzNVhhSH/Bu1l+ q4g+06di8Zeh1R6HaCOqMQ5tlllZOCn9eP9h1mo7psNwojwXUa3XKIzh1EYpr4gNZ6LA 8jEhHuVPb8AZM5SmbfK7Uy30EbRYNsEwWOfqcvXroGj5KMCQ/f1LLJQAN2m+kCxq8DYC pEOXQ61JzoTCj6fh6X0i5gXxFr/I1FRz+Zi2tZatdBmT1LOo0hIFOJRdS6AuXlILdSqC 3uTA== X-Forwarded-Encrypted: i=1; AJvYcCVhVx54Ymztv/ZMZnRiWFdyPLiKNNOdsiYy0/KhiIPsVYKI/1wrnsIA8Q03+g5Pe8BkjSBeXD02ZrWnCjhAwv3AW2JcssQwQctn0EwUmw== X-Gm-Message-State: AOJu0YxjAgG433R6CqEROm9ynDtkKrajYO8iIb7QVV2ZdS6W6T1mqnTv Mui20CskExRB4fwmoA56ugYE0UTPQ58GK94h9NIlV66wdVgccdBo71RBkiXWP+uoWF0UmR9cvZF ptiBO7crsj9xtxZHB7vgjANWr51WoYJXN5MWVKTKAYgTVtogIyvYCIW7PhYMjg2b8ENx+NKc= X-Received: by 2002:a05:6214:aa7:b0:690:d74d:7e6d with SMTP id ew7-20020a0562140aa700b00690d74d7e6dmr2881509qvb.3.1710366448982; Wed, 13 Mar 2024 14:47:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IELbWWxNSgYU6xiV6giMb0Xazy3M+lqNjbyiI8S6tM3m0hmfGtXABqH+Dtrq87Nz5UyrTDJQA== X-Received: by 2002:a05:6214:aa7:b0:690:d74d:7e6d with SMTP id ew7-20020a0562140aa700b00690d74d7e6dmr2881487qvb.3.1710366448612; Wed, 13 Mar 2024 14:47:28 -0700 (PDT) Received: from x1n.redhat.com ([99.254.121.117]) by smtp.gmail.com with ESMTPSA id dv10-20020ad44eea000000b0069111c5cdd4sm60114qvb.100.2024.03.13.14.47.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Mar 2024 14:47:28 -0700 (PDT) From: peterx@redhat.com To: linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 05/13] mm/sparc: Change pXd_huge() behavior to exclude swap entries Date: Wed, 13 Mar 2024 17:47:11 -0400 Message-ID: <20240313214719.253873-6-peterx@redhat.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240313214719.253873-1-peterx@redhat.com> References: <20240313214719.253873-1-peterx@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Muchun Song , Jason Gunthorpe , Andreas Larsson , x86@kernel.org, peterx@redhat.com, Matthew Wilcox , Mike Rapoport , sparclinux@vger.kernel.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S . Miller" , linux-arm-kernel@lists.infradead.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" From: Peter Xu Please refer to the previous patch on the reasoning for x86. Now sparc is the only architecture that will allow swap entries to be reported as pXd_huge(). After this patch, all architectures should forbid swap entries in pXd_huge(). Cc: David S. Miller Cc: Andreas Larsson Cc: sparclinux@vger.kernel.org Signed-off-by: Peter Xu --- arch/sparc/mm/hugetlbpage.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/sparc/mm/hugetlbpage.c b/arch/sparc/mm/hugetlbpage.c index b432500c13a5..d31c2cec35c9 100644 --- a/arch/sparc/mm/hugetlbpage.c +++ b/arch/sparc/mm/hugetlbpage.c @@ -409,14 +409,12 @@ pte_t huge_ptep_get_and_clear(struct mm_struct *mm, unsigned long addr, int pmd_huge(pmd_t pmd) { - return !pmd_none(pmd) && - (pmd_val(pmd) & (_PAGE_VALID|_PAGE_PMD_HUGE)) != _PAGE_VALID; + return pmd_leaf(pmd);; } int pud_huge(pud_t pud) { - return !pud_none(pud) && - (pud_val(pud) & (_PAGE_VALID|_PAGE_PUD_HUGE)) != _PAGE_VALID; + return pud_leaf(pud); } static void hugetlb_free_pte_range(struct mmu_gather *tlb, pmd_t *pmd, -- 2.44.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9577E5A78A for ; Wed, 13 Mar 2024 21:47:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710366453; cv=none; b=JnO53qmVTtmikF8DVflhzsHX095inAbuOaqQUlmWkNhULAkg7AOB08DRdd9s8sDL6cd85kB+H9glu7gegjS6vPZsUvkLG8IxHmWhtfHMS+CSUZ0e06t0gBEbxuqug0Y8vEo52wnQi1lmFMfpjv/vrqhH2Xb4i3Mn5Oj39GTr04o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710366453; c=relaxed/simple; bh=iHHSvsdkBOFub0mcOT/89y75sePdz9RiRVPlZT5QMlQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ve/eBDzQ2fw5Sadps3RDxCWdSG925K1BBoCfUW5d3b9fUtX7douC3NGxlHOjNp7PQ+yrGetP5E3fhj3C3QcSQsjCKItxYDc7a6C/zGJW48yoC0DzyiumNMOq2CG8DvjwQ3W8QKJrAtXSrHB+vsvyF/WB3YCHyoBvEWGjHndmDX4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=LB8wzJ78; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LB8wzJ78" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710366450; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dXyJDuJosTa0kFBnhKvW1aqbtapsaxz0OHU+bPr+fnc=; b=LB8wzJ78SlFuj+V7wiruUtcK0Vzk5PHrJ5e3qM6DdeFc9ECKcrK9pJsCD7dAIRUQI3HvIa eZID2Y5Wbv/DQnjP3Xuuv8BRAtMeGEnNY1R/9pgGHH4RFAqEuAkFcyYNAY1HOrfWFpp81w MH5Ptbtnyl/w/iiETFNhLF/KGt0IsbI= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-388-k5CjuGDLMLCpu-n3mx7eqA-1; Wed, 13 Mar 2024 17:47:29 -0400 X-MC-Unique: k5CjuGDLMLCpu-n3mx7eqA-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-6818b8cb840so989036d6.1 for ; Wed, 13 Mar 2024 14:47:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710366449; x=1710971249; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dXyJDuJosTa0kFBnhKvW1aqbtapsaxz0OHU+bPr+fnc=; b=lcwJttYkI5DtnIQBP0Fm7cKaJMWTM81MnTveRUakO3g/QbSlq9EWjbhYDXtCvACBnq 1HP89OyK4TsFkNpD1j/4+BghwyD4t3oJ71rOoC2mtVMQpsy23O6/fd6CWrM9+cMnDlFI homf8Yb3mVx17VaoRFYTvt0UdlksFYxHPx0fVzEcD5T1MoGFpow1by3S/d3J+2N4ZIf1 GnkD17ABk8Anu1PMPdWKQWUNlS8EJpn+K6FR/kdJy3Lc2tJTBWlNzaU8j8YK50z/cBFq 9DmtZ/A4f1WoVRjzvd4GryHl563Ux4h1LYHUL8ZqcZ1F1s4PfzilrMy068tr9QkMVcAU G2og== X-Forwarded-Encrypted: i=1; AJvYcCWrgUbKPYY6yRqqDiulrGNxAhwgmKvcihEzjY0/5NXz8g3fRCnsLV/YTn8TOzrLizAqVeSa+zKxGTVgSemSRngL7oJ22YgWWLznsg== X-Gm-Message-State: AOJu0YwbWm4wOs0R1XSJfAsof8+5TwI3Npa8RULtpkwZDgNPqJ8L06Pa tDxoKAFRWqW+1u2G4ggysaF5L9VeJuraYAeV00wRN8FChccuOj3qqQYwyO2yyP7p3TmH8NmCY+4 N6yeDw+0vpKYacuF4H+dHIFNsfF5ELVLDMnqMjDRVMiiGzoUKXt1OyGsQfSU= X-Received: by 2002:a05:6214:aa7:b0:690:d74d:7e6d with SMTP id ew7-20020a0562140aa700b00690d74d7e6dmr2881504qvb.3.1710366448978; Wed, 13 Mar 2024 14:47:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IELbWWxNSgYU6xiV6giMb0Xazy3M+lqNjbyiI8S6tM3m0hmfGtXABqH+Dtrq87Nz5UyrTDJQA== X-Received: by 2002:a05:6214:aa7:b0:690:d74d:7e6d with SMTP id ew7-20020a0562140aa700b00690d74d7e6dmr2881487qvb.3.1710366448612; Wed, 13 Mar 2024 14:47:28 -0700 (PDT) Received: from x1n.redhat.com ([99.254.121.117]) by smtp.gmail.com with ESMTPSA id dv10-20020ad44eea000000b0069111c5cdd4sm60114qvb.100.2024.03.13.14.47.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Mar 2024 14:47:28 -0700 (PDT) From: peterx@redhat.com To: linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: linux-arm-kernel@lists.infradead.org, Matthew Wilcox , linuxppc-dev@lists.ozlabs.org, Christophe Leroy , Andrew Morton , x86@kernel.org, peterx@redhat.com, Mike Rapoport , Muchun Song , sparclinux@vger.kernel.org, Jason Gunthorpe , "David S . Miller" , Andreas Larsson Subject: [PATCH 05/13] mm/sparc: Change pXd_huge() behavior to exclude swap entries Date: Wed, 13 Mar 2024 17:47:11 -0400 Message-ID: <20240313214719.253873-6-peterx@redhat.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240313214719.253873-1-peterx@redhat.com> References: <20240313214719.253873-1-peterx@redhat.com> Precedence: bulk X-Mailing-List: sparclinux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Peter Xu Please refer to the previous patch on the reasoning for x86. Now sparc is the only architecture that will allow swap entries to be reported as pXd_huge(). After this patch, all architectures should forbid swap entries in pXd_huge(). Cc: David S. Miller Cc: Andreas Larsson Cc: sparclinux@vger.kernel.org Signed-off-by: Peter Xu --- arch/sparc/mm/hugetlbpage.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/sparc/mm/hugetlbpage.c b/arch/sparc/mm/hugetlbpage.c index b432500c13a5..d31c2cec35c9 100644 --- a/arch/sparc/mm/hugetlbpage.c +++ b/arch/sparc/mm/hugetlbpage.c @@ -409,14 +409,12 @@ pte_t huge_ptep_get_and_clear(struct mm_struct *mm, unsigned long addr, int pmd_huge(pmd_t pmd) { - return !pmd_none(pmd) && - (pmd_val(pmd) & (_PAGE_VALID|_PAGE_PMD_HUGE)) != _PAGE_VALID; + return pmd_leaf(pmd);; } int pud_huge(pud_t pud) { - return !pud_none(pud) && - (pud_val(pud) & (_PAGE_VALID|_PAGE_PUD_HUGE)) != _PAGE_VALID; + return pud_leaf(pud); } static void hugetlb_free_pte_range(struct mmu_gather *tlb, pmd_t *pmd, -- 2.44.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1521AC54E66 for ; Wed, 13 Mar 2024 21:50:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rP7jwy9bjyWBqit9KDhjmmA9ufarx4dLvpTmcWkixs8=; b=chiA4NwnLXKUdZ NKRPn/M0/1s19ns4WUV+8YIIRlvalyu4TIiuxZSvBpmpVGcv5Of2lhSetyr6W/pue4eds759zDgsO wLU9yomOqpU6v24GdGo8ME4/ofEV1j7tqMPPtQU6XsaDIzqcN2Ulll05VHr/0X6P1XZV3y39U4eRl u2/YMXfCZuObtfdkh+fFc4Vs2FjHV2Q0VIKqDcGoPyUNMXEVpEWHyp9jCV9q33oVD7ROtS2EZQKXT r4dYxScKagFGX/8tOS68EK+oHMVBjqt5AA9F7VcyjeESwBD7O6FTwVzY5+0CyVcRssj+Z1WrAYzgV YtNgkccQfCUZpso/j8Pw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rkWU4-0000000C1m0-0uHf; Wed, 13 Mar 2024 21:50:02 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rkWTE-0000000C1Mv-324B for linux-arm-kernel@bombadil.infradead.org; Wed, 13 Mar 2024 21:49:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Type:Content-Transfer-Encoding :MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=dXyJDuJosTa0kFBnhKvW1aqbtapsaxz0OHU+bPr+fnc=; b=F10dGWxc5ivqPYGcMb21OxCEPb sa4BYZv7UKLMrsUFn9Q1M3ELGu5/Hu+yYXpwrFjlL0/eQBY/7qbvItWQHo8+D/gQZdkjDRlFqwLtm yl2/lx1tQy5Zjjl7D7TnoVNnwkYM+8rArRtcqFDbalqOMOoNcPjlD0dtTSKDM+zCF+cnP/7lvj5XP hp6FKfbeKXmwwp86+nHh/8Bl4SI3ikH7a/r282RZwFw7ynLj8wnXMFAEimhbe5g3eYG3g78o9sOY/ Ol9G89AKrK3Hm+OoRNXkj7Lepf6WlZspF868QvgGlSc6U9FVYZKHYuMMW514bHzrkYtjHTHFdawkG nfXvgLAQ==; Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by desiato.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rkWTA-0000000ACEP-3pTI for linux-arm-kernel@lists.infradead.org; Wed, 13 Mar 2024 21:49:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710366541; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dXyJDuJosTa0kFBnhKvW1aqbtapsaxz0OHU+bPr+fnc=; b=gr/HbIAy9zjVJUbIte8BiqAx9LncGKiQBOpYE8Wngq09ERl5os5c4nGkdGa0zDEOWNI4GS YHBjpBAdotMP0ijwVpO2/ior6RGa2eVxEFxci6o6fzNHa5ikipyqHstIba3EKuwXKEJ9Fy H8VXZobGiK1xetBPSknxGQJoYVwMw0Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710366542; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dXyJDuJosTa0kFBnhKvW1aqbtapsaxz0OHU+bPr+fnc=; b=Ca+EVIge3KfSaidgqN1KJYfYohk7wlUHfsn+FsqH6Q4To1K3vJpALV7oq29jj/5p7J3mB/ 97g/nsYWaN42wmEuvzRo4WFOUNQ/vcI7dxrvk9a47F+fZYM4aXxUxET8VD851wuijOqT+C ed1xBHZl7IMQU4DMRDHYXKEFiBcuJk4= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-515-2Sr-g-8VOkK4pY-dzacNUg-1; Wed, 13 Mar 2024 17:47:29 -0400 X-MC-Unique: 2Sr-g-8VOkK4pY-dzacNUg-1 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-6818b8cb840so989096d6.1 for ; Wed, 13 Mar 2024 14:47:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710366449; x=1710971249; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dXyJDuJosTa0kFBnhKvW1aqbtapsaxz0OHU+bPr+fnc=; b=cXubSpqH/bQmMyJNTzeq2aKfGj0TN4neu1Z4QvhK/cejqMKDPu67UDimWTx2L2DvyD A/v0hdwl+ltA9uy7Qqf2xj+uZ3ZMoxezZMm5Oc/jzAxLCkdbOcRwtuIMqWiBCh9GosqS z2tkALJmE7wy0e/Q/qWkJS0cy1l5pAxid23XGS5r13GTHsLAkF50Whykw+dfxfjVHHi6 4MOdtN6y6z/6F7KIQWeV9iVWNRcGnoDcX1mzEcQo0WchARoxRyCDXZxQUQKDEWvwoKdN 0lPYAdsrr1BfTP6HSlDgfp3loKZcxILI+FMpZ4+TvLe1pz77upqcJu+hRFZZr8+sipU6 FuOQ== X-Gm-Message-State: AOJu0YxjMzr9qU+6PKKP3IBMy4YzcIB7/aZ0jLmPZxG63r0NFjjd1scr vI2gQgrMFp/Uj8LMTGPUtFfuKFtd2xsd6Vc23M+/X+MYzY7Dy36JAKeZ9s1xtYUKXKtEHr3wvUN zQySkRPR66Ibfj+fDh6xm36PSNd8+GIL9JQVxI8R03KEUHvaLxkAWItdpX+LEkBdloZER8skO X-Received: by 2002:a05:6214:aa7:b0:690:d74d:7e6d with SMTP id ew7-20020a0562140aa700b00690d74d7e6dmr2881497qvb.3.1710366448975; Wed, 13 Mar 2024 14:47:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IELbWWxNSgYU6xiV6giMb0Xazy3M+lqNjbyiI8S6tM3m0hmfGtXABqH+Dtrq87Nz5UyrTDJQA== X-Received: by 2002:a05:6214:aa7:b0:690:d74d:7e6d with SMTP id ew7-20020a0562140aa700b00690d74d7e6dmr2881487qvb.3.1710366448612; Wed, 13 Mar 2024 14:47:28 -0700 (PDT) Received: from x1n.redhat.com ([99.254.121.117]) by smtp.gmail.com with ESMTPSA id dv10-20020ad44eea000000b0069111c5cdd4sm60114qvb.100.2024.03.13.14.47.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Mar 2024 14:47:28 -0700 (PDT) From: peterx@redhat.com To: linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: linux-arm-kernel@lists.infradead.org, Matthew Wilcox , linuxppc-dev@lists.ozlabs.org, Christophe Leroy , Andrew Morton , x86@kernel.org, peterx@redhat.com, Mike Rapoport , Muchun Song , sparclinux@vger.kernel.org, Jason Gunthorpe , "David S . Miller" , Andreas Larsson Subject: [PATCH 05/13] mm/sparc: Change pXd_huge() behavior to exclude swap entries Date: Wed, 13 Mar 2024 17:47:11 -0400 Message-ID: <20240313214719.253873-6-peterx@redhat.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240313214719.253873-1-peterx@redhat.com> References: <20240313214719.253873-1-peterx@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240313_214905_461347_DFFD399D X-CRM114-Status: GOOD ( 12.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Peter Xu Please refer to the previous patch on the reasoning for x86. Now sparc is the only architecture that will allow swap entries to be reported as pXd_huge(). After this patch, all architectures should forbid swap entries in pXd_huge(). Cc: David S. Miller Cc: Andreas Larsson Cc: sparclinux@vger.kernel.org Signed-off-by: Peter Xu --- arch/sparc/mm/hugetlbpage.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/sparc/mm/hugetlbpage.c b/arch/sparc/mm/hugetlbpage.c index b432500c13a5..d31c2cec35c9 100644 --- a/arch/sparc/mm/hugetlbpage.c +++ b/arch/sparc/mm/hugetlbpage.c @@ -409,14 +409,12 @@ pte_t huge_ptep_get_and_clear(struct mm_struct *mm, unsigned long addr, int pmd_huge(pmd_t pmd) { - return !pmd_none(pmd) && - (pmd_val(pmd) & (_PAGE_VALID|_PAGE_PMD_HUGE)) != _PAGE_VALID; + return pmd_leaf(pmd);; } int pud_huge(pud_t pud) { - return !pud_none(pud) && - (pud_val(pud) & (_PAGE_VALID|_PAGE_PUD_HUGE)) != _PAGE_VALID; + return pud_leaf(pud); } static void hugetlb_free_pte_range(struct mmu_gather *tlb, pmd_t *pmd, -- 2.44.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel