From: "Theodore Ts'o" <tytso@mit.edu>
To: Kent Overstreet <kent.overstreet@linux.dev>
Cc: torvalds@linux-foundation.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org,
Christian Brauner <brauner@kernel.org>,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH 3/3] ext4: Add support for FS_IOC_GETFSSYSFSPATH
Date: Fri, 15 Mar 2024 12:45:50 -0400 [thread overview]
Message-ID: <20240315164550.GD324770@mit.edu> (raw)
In-Reply-To: <20240315035308.3563511-4-kent.overstreet@linux.dev>
On Thu, Mar 14, 2024 at 11:53:02PM -0400, Kent Overstreet wrote:
> the new sysfs path ioctl lets us get the /sys/fs/ path for a given
> filesystem in a fs agnostic way, potentially nudging us towards
> standarizing some of our reporting.
>
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -5346,6 +5346,7 @@ static int __ext4_fill_super(struct fs_context *fc, struct super_block *sb)
> sb->s_quota_types = QTYPE_MASK_USR | QTYPE_MASK_GRP | QTYPE_MASK_PRJ;
> #endif
> super_set_uuid(sb, es->s_uuid, sizeof(es->s_uuid));
> + super_set_sysfs_name_bdev(sb);
Should we perhaps be hoisting this call up to the VFS layer, so that
all file systems would benefit?
- Ted
next prev parent reply other threads:[~2024-03-15 16:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-15 3:52 [PATCH 0/3] bit more FS_IOC_GETFSUUID, FS_IOC_GETFSSYSFSPATH Kent Overstreet
2024-03-15 3:53 ` [PATCH 1/3] bcachefs: Switch to uuid_to_fsid() Kent Overstreet
2024-03-15 3:53 ` [PATCH 2/3] bcachefs: Initialize super_block->s_uuid Kent Overstreet
2024-03-15 3:53 ` [PATCH 3/3] ext4: Add support for FS_IOC_GETFSSYSFSPATH Kent Overstreet
2024-03-15 16:45 ` Theodore Ts'o [this message]
2024-03-15 16:50 ` Kent Overstreet
2024-03-18 21:51 ` Kiselev, Oleg
2024-03-18 22:22 ` Dave Chinner
2024-03-20 1:49 ` Darrick J. Wong
2024-03-22 23:03 ` Andreas Dilger
2024-05-02 20:00 ` [PATCH 0/3] bit more FS_IOC_GETFSUUID, FS_IOC_GETFSSYSFSPATH Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240315164550.GD324770@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=brauner@kernel.org \
--cc=kent.overstreet@linux.dev \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.