From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D47B2A8E5; Fri, 15 Mar 2024 17:24:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710523452; cv=none; b=o46xlcvn7DmbO/xB2hOzH6LieTzltFhtCMQWby33Tbz+/wcsgHnqHZZ0gJKm3hRnbB9lq8dr7/Urj+MTrT3LRwOGjhjsC+BE98+wkFGgctDZNxRqQsEYtjLSjUj7lBAzyWmPALzsk9YwFeq4gLPFuaaLGHY5SJZF1ITH0u9Wz9E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710523452; c=relaxed/simple; bh=P4ahuRqKcidMxXgK+Vt8kDvXfaSyEoM6o0sLAnkmz8U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ia77GXD/lzlNYShHR1dH4y+Dsz4UbHL60DcrC+piaQ5UzEC1TFlmDHWoVVa3y0boK1oKYIB2c7meAqLwoWZsO60/cfR6rcvryBG7eN+CRBtk90SW5YKE4pe1CqhYQC6RzJQzolYm5+YrtZuBCOtXN5CUhE+t8AwsazLGUtjyfBI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qDIRyhBj; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qDIRyhBj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6FAD8C433C7; Fri, 15 Mar 2024 17:24:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710523451; bh=P4ahuRqKcidMxXgK+Vt8kDvXfaSyEoM6o0sLAnkmz8U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qDIRyhBj+o7szPndtNfibGKwc6B/jmsPBQrnW4leDPaJq2jC3GYZhfTPg3rZw/T4J UoZaf6MUTmg6m1hY4ah5sznYGxq0ri35iUeAk8gAmGzlD26PL43Yq5VUAtNf9r8RgZ fHzKRtC2d3NGOYtFwwMfTVpfdD04NAW37cRVpbnx5fGcX8rlEYUUcn3ZG6iLj3UvG5 i/dS/yLOEiBMuUFWB3L6gGwRcQHW6x3jWcj4IzTMvL0USM+067bzArXCv8dCbSmruA 3gDqwiRv0SYucUSJOoY5Wwjn77KIJ9gmcx4uJmAAV0kv+WnHkvPO/L4ZDurN7U+Dqv s3SFEZB1M1B0A== Date: Fri, 15 Mar 2024 11:24:09 -0600 From: Rob Herring To: "Peng Fan (OSS)" Cc: Abel Vesa , Michael Turquette , Stephen Boyd , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , linux-clk@vger.kernel.org, imx@lists.linux.dev, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan Subject: Re: [PATCH v4 2/6] dt-bindindgs: clock: nxp: support i.MX95 Camera CSR module Message-ID: <20240315172409.GA1506658-robh@kernel.org> References: <20240314-imx95-blk-ctl-v4-0-d23de23b6ff2@nxp.com> <20240314-imx95-blk-ctl-v4-2-d23de23b6ff2@nxp.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240314-imx95-blk-ctl-v4-2-d23de23b6ff2@nxp.com> On Thu, Mar 14, 2024 at 09:25:11PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > The i.MX95 Camera CSR is a set of registers that provides various > configuration and status of the Camera modules’ operations. Registers > are available to enable clock gating to the ISP and CSI-2 pixel > formatters, enable transport of various pixel data and non-pixel data > types, control their routing, and other functions. Status registers > provide pixel data type error information and pending transaction > from Camera NoC initiators. > > This patch is to add clock features for Camera CSR. > > Signed-off-by: Peng Fan > --- > .../bindings/clock/nxp,imx95-camera-csr.yaml | 50 ++++++++++++++++++++++ > include/dt-bindings/clock/nxp,imx95-clock.h | 7 +++ > 2 files changed, 57 insertions(+) > > diff --git a/Documentation/devicetree/bindings/clock/nxp,imx95-camera-csr.yaml b/Documentation/devicetree/bindings/clock/nxp,imx95-camera-csr.yaml > new file mode 100644 > index 000000000000..e62494e3a8b1 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/nxp,imx95-camera-csr.yaml > @@ -0,0 +1,50 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/nxp,imx95-camera-csr.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP i.MX95 Camera MIX Block Control > + > +maintainers: > + - Peng Fan > + > +properties: > + compatible: > + items: > + - const: nxp,imx95-camera-csr > + - const: syscon > + > + reg: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + '#clock-cells': > + const: 1 > + description: > + The clock consumer should specify the desired clock by having the clock > + ID in its "clocks" phandle cell. See > + include/dt-bindings/clock/nxp,imx95-clock.h > + > +required: > + - compatible > + - reg > + - '#clock-cells' > + > +additionalProperties: false > + > +examples: > + - | > + syscon@4c410000 { > + compatible = "nxp,imx95-camera-csr", "syscon"; > + reg = <0x4ac10000 0x10000>; > + #clock-cells = <1>; > + clocks = <&scmi_clk 62>; > + power-domains = <&scmi_devpd 3>; > + }; > +... > diff --git a/include/dt-bindings/clock/nxp,imx95-clock.h b/include/dt-bindings/clock/nxp,imx95-clock.h > index 9d8f0a6d12d0..c671c4dbb4d5 100644 > --- a/include/dt-bindings/clock/nxp,imx95-clock.h > +++ b/include/dt-bindings/clock/nxp,imx95-clock.h > @@ -11,4 +11,11 @@ > #define IMX95_CLK_VPUBLK_JPEG_DEC 2 > #define IMX95_CLK_VPUBLK_END 3 > > +#define IMX95_CLK_CAMBLK_CSI2_FOR0 0 > +#define IMX95_CLK_CAMBLK_CSI2_FOR1 1 > +#define IMX95_CLK_CAMBLK_ISP_AXI 2 > +#define IMX95_CLK_CAMBLK_ISP_PIXEL 3 > +#define IMX95_CLK_CAMBLK_ISP 4 > +#define IMX95_CLK_CAMBLK_END 5 Same issue here. With that dropped, Reviewed-by: Rob Herring From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4E6D8C54E58 for ; Fri, 15 Mar 2024 17:24:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sJNk4Bq6rEro8oBxAKe3eJ32MkjWs1tEHip+sPHntEI=; b=N6qAUTKx7CMtXB IMYgXnRtyKJFOJU1DnJptxDdyGvzhbP5UY7y6O4gCWQhDAp+oYeZgn11A5d6WMIcP+z62Atsffewy wGJI2mos1IqRLo3m2wmDx9p8aCyKanHUgZbLEONxYgkL4K6tI+Dl6Smi3To3PlW6Hw1kEWiH/NRzI Dum90d5ATMb8mVWwmJtKjXkB4zponQGMrO4RqTvYYhbi5YgRujxceVv0S/kzB9iIpCat1IglNr+hm xy4TMrwH/uRoslRTMsuoKnoskeq3RB5f3s4u/33wP3TCdzwcU1tUi+iKs0IDamsK8gzOJOzDnUB2s V+g7OyysvONAQrbR8zwQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rlBI4-000000010GC-20Zb; Fri, 15 Mar 2024 17:24:20 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rlBI1-000000010FA-0BSW for linux-arm-kernel@lists.infradead.org; Fri, 15 Mar 2024 17:24:19 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 69046CE2111; Fri, 15 Mar 2024 17:24:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6FAD8C433C7; Fri, 15 Mar 2024 17:24:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710523451; bh=P4ahuRqKcidMxXgK+Vt8kDvXfaSyEoM6o0sLAnkmz8U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qDIRyhBj+o7szPndtNfibGKwc6B/jmsPBQrnW4leDPaJq2jC3GYZhfTPg3rZw/T4J UoZaf6MUTmg6m1hY4ah5sznYGxq0ri35iUeAk8gAmGzlD26PL43Yq5VUAtNf9r8RgZ fHzKRtC2d3NGOYtFwwMfTVpfdD04NAW37cRVpbnx5fGcX8rlEYUUcn3ZG6iLj3UvG5 i/dS/yLOEiBMuUFWB3L6gGwRcQHW6x3jWcj4IzTMvL0USM+067bzArXCv8dCbSmruA 3gDqwiRv0SYucUSJOoY5Wwjn77KIJ9gmcx4uJmAAV0kv+WnHkvPO/L4ZDurN7U+Dqv s3SFEZB1M1B0A== Date: Fri, 15 Mar 2024 11:24:09 -0600 From: Rob Herring To: "Peng Fan (OSS)" Cc: Abel Vesa , Michael Turquette , Stephen Boyd , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , linux-clk@vger.kernel.org, imx@lists.linux.dev, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan Subject: Re: [PATCH v4 2/6] dt-bindindgs: clock: nxp: support i.MX95 Camera CSR module Message-ID: <20240315172409.GA1506658-robh@kernel.org> References: <20240314-imx95-blk-ctl-v4-0-d23de23b6ff2@nxp.com> <20240314-imx95-blk-ctl-v4-2-d23de23b6ff2@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240314-imx95-blk-ctl-v4-2-d23de23b6ff2@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240315_102417_462270_ED721CEE X-CRM114-Status: GOOD ( 18.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBNYXIgMTQsIDIwMjQgYXQgMDk6MjU6MTFQTSArMDgwMCwgUGVuZyBGYW4gKE9TUykg d3JvdGU6Cj4gRnJvbTogUGVuZyBGYW4gPHBlbmcuZmFuQG54cC5jb20+Cj4gCj4gVGhlIGkuTVg5 NSBDYW1lcmEgQ1NSIGlzIGEgc2V0IG9mIHJlZ2lzdGVycyB0aGF0IHByb3ZpZGVzIHZhcmlvdXMK PiBjb25maWd1cmF0aW9uIGFuZCBzdGF0dXMgb2YgdGhlIENhbWVyYSBtb2R1bGVz4oCZIG9wZXJh dGlvbnMuIFJlZ2lzdGVycwo+IGFyZSBhdmFpbGFibGUgdG8gZW5hYmxlIGNsb2NrIGdhdGluZyB0 byB0aGUgSVNQIGFuZCBDU0ktMiBwaXhlbAo+IGZvcm1hdHRlcnMsIGVuYWJsZSB0cmFuc3BvcnQg b2YgdmFyaW91cyBwaXhlbCBkYXRhIGFuZCBub24tcGl4ZWwgZGF0YQo+IHR5cGVzLCBjb250cm9s IHRoZWlyIHJvdXRpbmcsIGFuZCBvdGhlciBmdW5jdGlvbnMuIFN0YXR1cyByZWdpc3RlcnMKPiBw cm92aWRlIHBpeGVsIGRhdGEgdHlwZSBlcnJvciBpbmZvcm1hdGlvbiBhbmQgcGVuZGluZyB0cmFu c2FjdGlvbgo+IGZyb20gQ2FtZXJhIE5vQyBpbml0aWF0b3JzLgo+IAo+IFRoaXMgcGF0Y2ggaXMg dG8gYWRkIGNsb2NrIGZlYXR1cmVzIGZvciBDYW1lcmEgQ1NSLgo+IAo+IFNpZ25lZC1vZmYtYnk6 IFBlbmcgRmFuIDxwZW5nLmZhbkBueHAuY29tPgo+IC0tLQo+ICAuLi4vYmluZGluZ3MvY2xvY2sv bnhwLGlteDk1LWNhbWVyYS1jc3IueWFtbCAgICAgICB8IDUwICsrKysrKysrKysrKysrKysrKysr KysKPiAgaW5jbHVkZS9kdC1iaW5kaW5ncy9jbG9jay9ueHAsaW14OTUtY2xvY2suaCAgICAgICAg fCAgNyArKysKPiAgMiBmaWxlcyBjaGFuZ2VkLCA1NyBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAt LWdpdCBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9jbG9jay9ueHAsaW14OTUt Y2FtZXJhLWNzci55YW1sIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Nsb2Nr L254cCxpbXg5NS1jYW1lcmEtY3NyLnlhbWwKPiBuZXcgZmlsZSBtb2RlIDEwMDY0NAo+IGluZGV4 IDAwMDAwMDAwMDAwMC4uZTYyNDk0ZTNhOGIxCj4gLS0tIC9kZXYvbnVsbAo+ICsrKyBiL0RvY3Vt ZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9jbG9jay9ueHAsaW14OTUtY2FtZXJhLWNzci55 YW1sCj4gQEAgLTAsMCArMSw1MCBAQAo+ICsjIFNQRFgtTGljZW5zZS1JZGVudGlmaWVyOiAoR1BM LTIuMC1vbmx5IE9SIEJTRC0yLUNsYXVzZSkKPiArJVlBTUwgMS4yCj4gKy0tLQo+ICskaWQ6IGh0 dHA6Ly9kZXZpY2V0cmVlLm9yZy9zY2hlbWFzL2Nsb2NrL254cCxpbXg5NS1jYW1lcmEtY3NyLnlh bWwjCj4gKyRzY2hlbWE6IGh0dHA6Ly9kZXZpY2V0cmVlLm9yZy9tZXRhLXNjaGVtYXMvY29yZS55 YW1sIwo+ICsKPiArdGl0bGU6IE5YUCBpLk1YOTUgQ2FtZXJhIE1JWCBCbG9jayBDb250cm9sCj4g Kwo+ICttYWludGFpbmVyczoKPiArICAtIFBlbmcgRmFuIDxwZW5nLmZhbkBueHAuY29tPgo+ICsK PiArcHJvcGVydGllczoKPiArICBjb21wYXRpYmxlOgo+ICsgICAgaXRlbXM6Cj4gKyAgICAgIC0g Y29uc3Q6IG54cCxpbXg5NS1jYW1lcmEtY3NyCj4gKyAgICAgIC0gY29uc3Q6IHN5c2Nvbgo+ICsK PiArICByZWc6Cj4gKyAgICBtYXhJdGVtczogMQo+ICsKPiArICBwb3dlci1kb21haW5zOgo+ICsg ICAgbWF4SXRlbXM6IDEKPiArCj4gKyAgY2xvY2tzOgo+ICsgICAgbWF4SXRlbXM6IDEKPiArCj4g KyAgJyNjbG9jay1jZWxscyc6Cj4gKyAgICBjb25zdDogMQo+ICsgICAgZGVzY3JpcHRpb246Cj4g KyAgICAgIFRoZSBjbG9jayBjb25zdW1lciBzaG91bGQgc3BlY2lmeSB0aGUgZGVzaXJlZCBjbG9j ayBieSBoYXZpbmcgdGhlIGNsb2NrCj4gKyAgICAgIElEIGluIGl0cyAiY2xvY2tzIiBwaGFuZGxl IGNlbGwuIFNlZQo+ICsgICAgICBpbmNsdWRlL2R0LWJpbmRpbmdzL2Nsb2NrL254cCxpbXg5NS1j bG9jay5oCj4gKwo+ICtyZXF1aXJlZDoKPiArICAtIGNvbXBhdGlibGUKPiArICAtIHJlZwo+ICsg IC0gJyNjbG9jay1jZWxscycKPiArCj4gK2FkZGl0aW9uYWxQcm9wZXJ0aWVzOiBmYWxzZQo+ICsK PiArZXhhbXBsZXM6Cj4gKyAgLSB8Cj4gKyAgICBzeXNjb25ANGM0MTAwMDAgewo+ICsgICAgICBj b21wYXRpYmxlID0gIm54cCxpbXg5NS1jYW1lcmEtY3NyIiwgInN5c2NvbiI7Cj4gKyAgICAgIHJl ZyA9IDwweDRhYzEwMDAwIDB4MTAwMDA+Owo+ICsgICAgICAjY2xvY2stY2VsbHMgPSA8MT47Cj4g KyAgICAgIGNsb2NrcyA9IDwmc2NtaV9jbGsgNjI+Owo+ICsgICAgICBwb3dlci1kb21haW5zID0g PCZzY21pX2RldnBkIDM+Owo+ICsgICAgfTsKPiArLi4uCj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUv ZHQtYmluZGluZ3MvY2xvY2svbnhwLGlteDk1LWNsb2NrLmggYi9pbmNsdWRlL2R0LWJpbmRpbmdz L2Nsb2NrL254cCxpbXg5NS1jbG9jay5oCj4gaW5kZXggOWQ4ZjBhNmQxMmQwLi5jNjcxYzRkYmI0 ZDUgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS9kdC1iaW5kaW5ncy9jbG9jay9ueHAsaW14OTUtY2xv Y2suaAo+ICsrKyBiL2luY2x1ZGUvZHQtYmluZGluZ3MvY2xvY2svbnhwLGlteDk1LWNsb2NrLmgK PiBAQCAtMTEsNCArMTEsMTEgQEAKPiAgI2RlZmluZSBJTVg5NV9DTEtfVlBVQkxLX0pQRUdfREVD CQkyCj4gICNkZWZpbmUgSU1YOTVfQ0xLX1ZQVUJMS19FTkQJCQkzCj4gIAo+ICsjZGVmaW5lIElN WDk1X0NMS19DQU1CTEtfQ1NJMl9GT1IwCQkwCj4gKyNkZWZpbmUgSU1YOTVfQ0xLX0NBTUJMS19D U0kyX0ZPUjEJCTEKPiArI2RlZmluZSBJTVg5NV9DTEtfQ0FNQkxLX0lTUF9BWEkJCTIKPiArI2Rl ZmluZSBJTVg5NV9DTEtfQ0FNQkxLX0lTUF9QSVhFTAkJMwo+ICsjZGVmaW5lIElNWDk1X0NMS19D QU1CTEtfSVNQCQkJNAo+ICsjZGVmaW5lIElNWDk1X0NMS19DQU1CTEtfRU5ECQkJNQoKU2FtZSBp c3N1ZSBoZXJlLiBXaXRoIHRoYXQgZHJvcHBlZCwKClJldmlld2VkLWJ5OiBSb2IgSGVycmluZyA8 cm9iaEBrZXJuZWwub3JnPgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBs aXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vbGludXgtYXJtLWtlcm5lbAo=