Re: [Buildroot] [PATCH 1/1] package/squid: fix build with host gcc 10

From: Peter Seiderer via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/squid: fix build with host gcc 10
Date: Sun, 17 Mar 2024 13:25:10 +0100	[thread overview]
Message-ID: <20240317132510.2e4ea2ca@gmx.net> (raw)
In-Reply-To: <20240317110444.258643-1-fontaine.fabrice@gmail.com>

Hello Fabrice,

On Sun, 17 Mar 2024 12:04:44 +0100, Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Pass -std=c++17 to fix the following build failure with host gcc 10
> raised since bump to version 6.6 in commit
> c13199c9326fa2daa574f08ec8fc063a48d0eb06:
>
> /usr/bin/g++ -O2 -I/home/buildroot/instance-0/output-1/host/include -o cf_gen ./cf_gen.cc -I. -I../include/ -I../src
> ./cf_gen.cc: In function 'int main(int, char**)':
> ./cf_gen.cc:268:63: error: forming reference to void
>   268 |                     auto &newEntry = entries.emplace_back(name);
>       |                                                               ^
>
> Fixes:
>  - http://autobuild.buildroot.org/results/613fee008c77f8dbbe04df9a4ce4347e43de9ef9
>  - https://bugs.buildroot.org/show_bug.cgi?id=15997
>

Thanks for taking care, maybe add 'Reported-by:' and 'Suggested-by:'?

Regards,
Peter

> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/squid/squid.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/squid/squid.mk b/package/squid/squid.mk
> index 3a9edac71e..6a2b522336 100644
> --- a/package/squid/squid.mk
> +++ b/package/squid/squid.mk
> @@ -21,7 +21,7 @@ SQUID_CONF_ENV = \
>  	ac_cv_func_strnstr=no \
>  	ac_cv_have_squid=yes \
>  	BUILDCXX="$(HOSTCXX)" \
> -	BUILDCXXFLAGS="$(HOST_CXXFLAGS)"
> +	BUILDCXXFLAGS="$(HOST_CXXFLAGS) -std=c++17"
>  SQUID_CONF_OPTS = \
>  	--enable-async-io=8 \
>  	--enable-linux-netfilter \

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot