From: Sven Schnelle <svens@stackframe.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org, Helge Deller <deller@gmx.de>,
Sven Schnelle <svens@stackframe.org>
Subject: [PATCH 7/7] target/hppa: fix do_stdby_e()
Date: Sun, 17 Mar 2024 23:14:31 +0100 [thread overview]
Message-ID: <20240317221431.251515-8-svens@stackframe.org> (raw)
In-Reply-To: <20240317221431.251515-1-svens@stackframe.org>
stdby,e,m was writing data from the wrong half of the register
into memory for cases 0-3.
Signed-off-by: Sven Schnelle <svens@stackframe.org>
---
target/hppa/op_helper.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/target/hppa/op_helper.c b/target/hppa/op_helper.c
index 480fe80844..6cf49f33b7 100644
--- a/target/hppa/op_helper.c
+++ b/target/hppa/op_helper.c
@@ -281,17 +281,17 @@ static void do_stdby_e(CPUHPPAState *env, target_ulong addr, uint64_t val,
case 3:
/* The 3 byte store must appear atomic. */
if (parallel) {
- atomic_store_mask32(env, addr - 3, val, 0xffffff00u, ra);
+ atomic_store_mask32(env, addr - 3, val >> 32, 0xffffff00u, ra);
} else {
- cpu_stw_data_ra(env, addr - 3, val >> 16, ra);
- cpu_stb_data_ra(env, addr - 1, val >> 8, ra);
+ cpu_stw_data_ra(env, addr - 3, val >> 48, ra);
+ cpu_stb_data_ra(env, addr - 1, val >> 40, ra);
}
break;
case 2:
- cpu_stw_data_ra(env, addr - 2, val >> 16, ra);
+ cpu_stw_data_ra(env, addr - 2, val >> 48, ra);
break;
case 1:
- cpu_stb_data_ra(env, addr - 1, val >> 24, ra);
+ cpu_stb_data_ra(env, addr - 1, val >> 56, ra);
break;
default:
/* Nothing is stored, but protection is checked and the
--
2.43.2
next prev parent reply other threads:[~2024-03-17 22:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-17 22:14 [PATCH 0/7] few fixes for hppa target Sven Schnelle
2024-03-17 22:14 ` [PATCH 1/7] target/hppa: ldcw,s uses static shift of 3 Sven Schnelle
2024-03-18 20:31 ` Richard Henderson
2024-03-17 22:14 ` [PATCH 2/7] target/hppa: fix shrp for wide mode Sven Schnelle
2024-03-18 20:28 ` Helge Deller
2024-03-18 20:35 ` Richard Henderson
2024-03-17 22:14 ` [PATCH 3/7] target/hppa: fix access_id check Sven Schnelle
2024-03-18 20:37 ` Helge Deller
2024-03-18 21:12 ` Richard Henderson
2024-03-19 7:10 ` Sven Schnelle
2024-03-17 22:14 ` [PATCH 4/7] target/hppa: exit tb on flush cache instructions Sven Schnelle
2024-03-18 20:42 ` Helge Deller
2024-03-18 21:16 ` Richard Henderson
2024-03-17 22:14 ` [PATCH 5/7] target/hppa: copy new_spc to iasq_f on be,n instruction Sven Schnelle
2024-03-18 21:27 ` Richard Henderson
2024-03-19 7:08 ` Sven Schnelle
2024-03-17 22:14 ` [PATCH 6/7] target/hppa: mask privilege bits in mfia Sven Schnelle
2024-03-18 20:45 ` Helge Deller
2024-03-18 21:32 ` Richard Henderson
2024-03-17 22:14 ` Sven Schnelle [this message]
2024-03-18 21:38 ` [PATCH 7/7] target/hppa: fix do_stdby_e() Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240317221431.251515-8-svens@stackframe.org \
--to=svens@stackframe.org \
--cc=deller@gmx.de \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.