Re: dumpcap coredump for 82599 NIC

[Stephen Hemminger <stephen@networkplumber.org>]

On Mon, 18 Mar 2024 10:48:03 +0800
"junwang01@cestc.cn" <junwang01@cestc.cn> wrote:

> The issue indeed lies with the ixgbe driver. After making the following modifications, dpdk-dumpcap is now functioning properly.
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
> index d6cf00317e77b64f9822c155115f388ae62241eb..99b26f3c758b3c7ced5d59c6b27f305efe6cc33c 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -4301,48 +4301,50 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,
>  	wait = 1;
>  #endif
>  
> -	if (vf)
> -		diag = ixgbevf_check_link(hw, &link_speed, &link_up, wait);
> -	else
> -		diag = ixgbe_check_link(hw, &link_speed, &link_up, wait);
> +	if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
> +		if (vf)
> +			diag = ixgbevf_check_link(hw, &link_speed, &link_up, wait);
> +		else
> +			diag = ixgbe_check_link(hw, &link_speed, &link_up, wait);
>  
> -	if (diag != 0) {
> -		link.link_speed = RTE_ETH_SPEED_NUM_100M;
> -		link.link_duplex = RTE_ETH_LINK_FULL_DUPLEX;
> -		return rte_eth_linkstatus_set(dev, &link);
> -	}
> +		if (diag != 0) {
> +			link.link_speed = RTE_ETH_SPEED_NUM_100M;
> +			link.link_duplex = RTE_ETH_LINK_FULL_DUPLEX;
> +			return rte_eth_linkstatus_set(dev, &link);
> +		}
> +
> +		if (ixgbe_get_media_type(hw) == ixgbe_media_type_fiber &&
> +		    !ad->sdp3_no_tx_disable) {
> +			esdp_reg = IXGBE_READ_REG(hw, IXGBE_ESDP);
> +			if ((esdp_reg & IXGBE_ESDP_SDP3))
> +				link_up = 0;
> +		}
>  
> -	if (ixgbe_get_media_type(hw) == ixgbe_media_type_fiber &&
> -	    !ad->sdp3_no_tx_disable) {
> -		esdp_reg = IXGBE_READ_REG(hw, IXGBE_ESDP);
> -		if ((esdp_reg & IXGBE_ESDP_SDP3))
> -			link_up = 0;
> -	}
> -
> -	if (link_up == 0) {
> -		if (ixgbe_get_media_type(hw) == ixgbe_media_type_fiber) {
> -			ixgbe_dev_wait_setup_link_complete(dev, 0);
> -			/* NOTE: review for potential ordering optimization */
> -			if (!__atomic_test_and_set(&ad->link_thread_running, __ATOMIC_SEQ_CST)) {
> -				/* To avoid race condition between threads, set
> -				 * the IXGBE_FLAG_NEED_LINK_CONFIG flag only
> -				 * when there is no link thread running.
> -				 */
> -				intr->flags |= IXGBE_FLAG_NEED_LINK_CONFIG;
> -				if (rte_thread_create_internal_control(&ad->link_thread_tid,
> -						"ixgbe-link",
> -						ixgbe_dev_setup_link_thread_handler, dev) < 0) {
> +		if (link_up == 0) {
> +			if (ixgbe_get_media_type(hw) == ixgbe_media_type_fiber) {
> +				ixgbe_dev_wait_setup_link_complete(dev, 0);
> +				/* NOTE: review for potential ordering optimization */
> +				if (!__atomic_test_and_set(&ad->link_thread_running, __ATOMIC_SEQ_CST)) {
> +					/* To avoid race condition between threads, set
> +					 * the IXGBE_FLAG_NEED_LINK_CONFIG flag only
> +					 * when there is no link thread running.
> +					 */
> +					intr->flags |= IXGBE_FLAG_NEED_LINK_CONFIG;
> +					if (rte_thread_create_internal_control(&ad->link_thread_tid,
> +							"ixgbe-link",
> +							ixgbe_dev_setup_link_thread_handler, dev) < 0) {
> +						PMD_DRV_LOG(ERR,
> +							"Create link thread failed!");
> +						/* NOTE: review for potential ordering optimization */
> +						__atomic_clear(&ad->link_thread_running, __ATOMIC_SEQ_CST);
> +					}
> +				} else {
>  					PMD_DRV_LOG(ERR,
> -						"Create link thread failed!");
> -					/* NOTE: review for potential ordering optimization */
> -					__atomic_clear(&ad->link_thread_running, __ATOMIC_SEQ_CST);
> +						"Other link thread is running now!");
>  				}
> -			} else {
> -				PMD_DRV_LOG(ERR,
> -					"Other link thread is running now!");
>  			}
> +			return rte_eth_linkstatus_set(dev, &link);
>  		}
> -		return rte_eth_linkstatus_set(dev, &link);
>  	}
>  
>  	link.link_status = RTE_ETH_LINK_UP;
> 
>

Please send this to mailing list.
Ideally it would go to Ixgbe maintainer but there doesn't appear to be one right now.