From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B427E2D056 for ; Mon, 18 Mar 2024 10:08:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710756513; cv=none; b=uaOFl4VIEYuMjWhBOAR0XdxxyIeWRYUISamLl0pDhnwkeOVg9IktMh0hrAb4ovFkmr7ACrirTsCeLCYdl/Q4DBBezwkQDMlP6FFr77yeK7PqFzs0z5pR54cxFI+SoY/Aj/hsEQ5hkBFTakBnXR8aC9jp8NCiKhjWzbT9nV7DwbA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710756513; c=relaxed/simple; bh=SKxxVVLrLgCMai9NymuNZ03A7FVr1sh5FEFl0ejBPYo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=sD3Dmk7uBgftYSJYl6jZnHDv0dBlGld6Dxg1+eFdT39teJI+InEevuBTD3P6GgHBcq/q46QiupxHVGG8PAaubqik5gn7Xzb50fD5xTyTQPzqud3KOg5cVT0Z28Ti7DxMWtbOzuu3Ryb4PCKQCmTjAKdwhFx2rsxQa5xkjRPf9r0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=oJcnXoyQ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oJcnXoyQ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 940E8C433C7; Mon, 18 Mar 2024 10:08:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710756513; bh=SKxxVVLrLgCMai9NymuNZ03A7FVr1sh5FEFl0ejBPYo=; h=From:To:Cc:Subject:Date:Reply-to:From; b=oJcnXoyQbABQS0QSYJdUh06YXYlPaQamAV4OVg5ahihbyJDmEf2p9VrMcC0TrAeIi jBW3YLmgZF8dkrSgv+S+rrVnq6eOTP3BQX3nZ+bS6bMCJOSE3u2725ZRoEBAzVGFc7 0Q3i+cH+sFWehxYJXomgRa0KqReI48plM+2wkVjZFRzREzFNBCy2zRm+ZlglHT1FBW 2Uv/6gULdILNkzgphk+JldZtVM/Davh/txVYIEVJn81M+4AQX/s4vlgNZSAgMifMa0 RbjvFN4U4LVlrIT9edPhskIHKT/yGXdaUn/c8A7ntTaPfGKoutcdO1UoIwPe4DySCP mQHvgsI02A+JA== From: Lee Jones To: linux-cve-announce@vger.kernel.org Cc: Lee Jones Subject: CVE-2023-52609: binder: fix race between mmput() and do_exit() Date: Mon, 18 Mar 2024 10:07:59 +0000 Message-ID: <20240318100758.2828621-9-lee@kernel.org> X-Mailer: git-send-email 2.44.0.291.gc1ea87d7ee-goog Precedence: bulk X-Mailing-List: linux-cve-announce@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Reply-to: , X-Developer-Signature: v=1; a=openpgp-sha256; l=3865; i=lee@kernel.org; h=from:subject; bh=SKxxVVLrLgCMai9NymuNZ03A7FVr1sh5FEFl0ejBPYo=; b=owEBbQKS/ZANAwAKAVGvii+H/HdhAcsmYgBl+BJ/x6y4kjNu7nsZb6/1YmC9i0vreEBvsUM/8 0jLEC0jHcyJAjMEAAEKAB0WIQR2tsk1o74gmpTwh0hRr4ovh/x3YQUCZfgSfwAKCRBRr4ovh/x3 YXN1EACvCiwpYd+bCUcQtXEnEuoUok80UMyUtoWdjTRChrQh5Aj9ijkGXs6pZBFDMjrA4Xai/jt xDk19gv04qgowiZpPY8VLs9t+FUf7QRWCu9MnB2RwntMxGkMn7ZULWT4yQJE+OQ1S9RApACW4uw +hSx/4YoSNATWLLVo/IxRRw65hxDUFeJVLNNYn36atE8KaSz6Nsqeo7aOXzk8pqwI+Z6f0s234h G1mUGBkZG2f4xw6+/43//U+yTazXTGDn+JdqHUL46WbUJiVHgREhxf38mUdUxZVPqomBWBB0ymW GGUaDMC0c02k4UOMJeJw/buUB2YmgnMlsXyxmaFRnCbLo7mJX03Nf11TasIMVA9/Hlw2omH+fHw 1TWmZvhckL4ORcZOK6fxNvuNTzmf8F9AyU1BSnXvJFyL530QICOMjSCGMyIEc1onE45HWVUm0ur x8HFG43LMZc1mwjqGEPfszTUqxf/rFc2wXyi2s0wuszIaBmYrJUY3K7EFbyzNI8ceHTFaNaw8qD p1e8axPwF/l6asQI+XZMYTZgC5XW2Q+GW+C2WJslHqbIWCBP6TGMZw8IeXN3GTR97kXU3vzIn75 i9M0cT3LgfeXCnMx3z0hCZZ+E859f7dWthpcvehen24KOwFcdJgPW/hmoRa9fUT22ZYdO9hcZ77 aq2wc0vMd6CZhdQ== X-Developer-Key: i=lee@kernel.org; a=openpgp; fpr=76B6C935A3BE209A94F0874851AF8A2F87FC7761 Content-Transfer-Encoding: 8bit Description =========== In the Linux kernel, the following vulnerability has been resolved: binder: fix race between mmput() and do_exit() Task A calls binder_update_page_range() to allocate and insert pages on a remote address space from Task B. For this, Task A pins the remote mm via mmget_not_zero() first. This can race with Task B do_exit() and the final mmput() refcount decrement will come from Task A. Task A | Task B ------------------+------------------ mmget_not_zero() | | do_exit() | exit_mm() | mmput() mmput() | exit_mmap() | remove_vma() | fput() | In this case, the work of ____fput() from Task B is queued up in Task A as TWA_RESUME. So in theory, Task A returns to userspace and the cleanup work gets executed. However, Task A instead sleep, waiting for a reply from Task B that never comes (it's dead). This means the binder_deferred_release() is blocked until an unrelated binder event forces Task A to go back to userspace. All the associated death notifications will also be delayed until then. In order to fix this use mmput_async() that will schedule the work in the corresponding mm->async_put_work WQ instead of Task A. The Linux kernel CVE team has assigned CVE-2023-52609 to this issue. Affected and fixed versions =========================== Issue introduced in 2.6.29 with commit 457b9a6f09f0 and fixed in 4.19.306 with commit 95b1d336b064 Issue introduced in 2.6.29 with commit 457b9a6f09f0 and fixed in 5.4.268 with commit 252a2a5569eb Issue introduced in 2.6.29 with commit 457b9a6f09f0 and fixed in 5.10.209 with commit 7e7a0d86542b Issue introduced in 2.6.29 with commit 457b9a6f09f0 and fixed in 5.15.148 with commit 98fee5bee97a Issue introduced in 2.6.29 with commit 457b9a6f09f0 and fixed in 6.1.75 with commit 6696f76c32ff Issue introduced in 2.6.29 with commit 457b9a6f09f0 and fixed in 6.6.14 with commit 67f16bf2cc16 Issue introduced in 2.6.29 with commit 457b9a6f09f0 and fixed in 6.7.2 with commit 77d210e8db4d Issue introduced in 2.6.29 with commit 457b9a6f09f0 and fixed in 6.8 with commit 9a9ab0d96362 Please see https://www.kernel.org or a full list of currently supported kernel versions by the kernel community. Unaffected versions might change over time as fixes are backported to older supported kernel versions. The official CVE entry at https://cve.org/CVERecord/?id=CVE-2023-52609 will be updated if fixes are backported, please check that for the most up to date information about this issue. Affected files ============== The file(s) affected by this issue are: drivers/android/binder_alloc.c Mitigation ========== The Linux kernel CVE team recommends that you update to the latest stable kernel version for this, and many other bugfixes. Individual changes are never tested alone, but rather are part of a larger kernel release. Cherry-picking individual commits is not recommended or supported by the Linux kernel community at all. If however, updating to the latest release is impossible, the individual changes to resolve this issue can be found at these commits: https://git.kernel.org/stable/c/95b1d336b0642198b56836b89908d07b9a0c9608 https://git.kernel.org/stable/c/252a2a5569eb9f8d16428872cc24dea1ac0bb097 https://git.kernel.org/stable/c/7e7a0d86542b0ea903006d3f42f33c4f7ead6918 https://git.kernel.org/stable/c/98fee5bee97ad47b527a997d5786410430d1f0e9 https://git.kernel.org/stable/c/6696f76c32ff67fec26823fc2df46498e70d9bf3 https://git.kernel.org/stable/c/67f16bf2cc1698fd50e01ee8a2becc5a8e6d3a3e https://git.kernel.org/stable/c/77d210e8db4d61d43b2d16df66b1ec46fad2ee01 https://git.kernel.org/stable/c/9a9ab0d963621d9d12199df9817e66982582d5a5