From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D9484F1E3; Mon, 18 Mar 2024 15:24:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710775494; cv=none; b=gli7FOGOVQrRaXgHeZmaprCD4otMo4Ev3MQdG2ISooikYazkFCAuGsJjYFCJcFrgY7z9eF8M5WQ8VWIDFG8Np58tSUPlfvsE6Fp0lUFsbWUBw//kIlfJ683tfplHyaNHX0TQ7/8grIXkKDApsiRE/J+N6jnBL173l9Y0eWDtZXU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710775494; c=relaxed/simple; bh=TW2sVKXmKodNGaQrOPxiyaWbuxEcgOd4Z5b5YRJ1Vrk=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=o3utBA7WVyMa7m2XSdfMmt69hyuAqGh8krFfMo4EztcT7D113zB0OyPNW0m+X7u4H64rhxayDVxvZBoQ5/3MtttT9uHGn9YqT1epE94SkfYt9zqqroCW/ai7eT6laYMDnjhvfi4LFS37PKW0uG0hqemlHcndAUSDpb8X9Wp06no= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4TyzD607c6z6K6Pl; Mon, 18 Mar 2024 23:24:22 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 0E2E1140A30; Mon, 18 Mar 2024 23:24:48 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 18 Mar 2024 15:24:47 +0000 Date: Mon, 18 Mar 2024 15:24:46 +0000 From: Jonathan Cameron To: Sean Anderson CC: Jonathan Cameron , "O'Griofa, Conall" , "linux-iio@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Lars-Peter Clausen Subject: Re: [PATCH] iio: xilinx-ams: Don't include ams_ctrl_channels in scan_mask Message-ID: <20240318152446.00001345@Huawei.com> In-Reply-To: <7ee83f15-88fc-4530-84b7-b8ee31663dbc@linux.dev> References: <20240311162800.11074-1-sean.anderson@linux.dev> <20240314154824.37150a54@jic23-huawei> <3b481539-0c9c-4110-ad03-bd252e80efb0@linux.dev> <20240316133627.5d2bf585@jic23-huawei> <7ee83f15-88fc-4530-84b7-b8ee31663dbc@linux.dev> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: lhrpeml100003.china.huawei.com (7.191.160.210) To lhrpeml500005.china.huawei.com (7.191.163.240) On Mon, 18 Mar 2024 11:18:43 -0400 Sean Anderson wrote: > On 3/16/24 09:36, Jonathan Cameron wrote: > > On Fri, 15 Mar 2024 13:47:40 -0400 > > Sean Anderson wrote: > > =20 > >> Hi Conall, > >>=20 > >> On 3/15/24 09:18, O'Griofa, Conall wrote: =20 > >> > [AMD Official Use Only - General] > >> >=20 > >> > Hi, > >> >=20 > >> > I think there was a fix for this issue applied to the version that w= as running on 5.15 that didn't seem to make it into the upstream driver. > >> > Please see link for reference https://github.com/Xilinx/linux-xlnx/c= ommit/608426961f16ab149b1b699f1c35f7ad244c0720 > >> >=20 > >> > I think a similar fix to the above patch is may be beneficial? =20 > >>=20 > >> These patches look functionally identical to me. =20 > >=20 > > Because there are no channels with scan index between > > 22 * 2 + 16 (that patch) and 22 * 3 (your patch) that is > > the effect is indeed the same. But given the issues is the > > 64 limit on maximum scan index, 22 * 3 =3D 66 is an ugly value > > to compare with. > >=20 > > I'm still very against the use of scan_index for anything other > > than scan indices (which is why partly how this bug wasn't noticed > > in the first palce). So the check should be scan_index !=3D -1 > > and uses of those values elsewhere in the driver should be fixed > > (which looks simple to do from a quick glance at the code). =20 >=20 > OK, so how do the sysfs files get named then? Using channel and channel2 as appropriate (+ index and modified which change the meaning of channel2) - scan_index never had anything to do with sysfs file names - just the value in bufferX/in_xyz_scan_index >=20 > --Sean >=20 > >>=20 > >> --Sean > >> =20 > >> >> -----Original Message----- > >> >> From: Sean Anderson > >> >> Sent: Thursday, March 14, 2024 5:30 PM > >> >> To: Jonathan Cameron > >> >> Cc: linux-iio@vger.kernel.org; O'Griofa, Conall ; > >> >> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;= Lars-Peter > >> >> Clausen > >> >> Subject: Re: [PATCH] iio: xilinx-ams: Don't include ams_ctrl_channe= ls in > >> >> scan_mask > >> >> > >> >> Caution: This message originated from an External Source. Use prope= r caution > >> >> when opening attachments, clicking links, or responding. > >> >> > >> >> > >> >> On 3/14/24 11:48, Jonathan Cameron wrote: =20 > >> >> > On Mon, 11 Mar 2024 12:28:00 -0400 > >> >> > Sean Anderson wrote: > >> >> > =20 > >> >> >> ams_enable_channel_sequence constructs a "scan_mask" for all the= PS > >> >> >> and PL channels. This works out fine, since scan_index for these > >> >> >> channels is less than 64. However, it also includes the > >> >> >> ams_ctrl_channels, where scan_index is greater than 64, triggeri= ng > >> >> >> undefined behavior. Since we don't need these channels anyway, j= ust =20 > >> >> exclude them. =20 > >> >> >> > >> >> >> Fixes: d5c70627a794 ("iio: adc: Add Xilinx AMS driver") > >> >> >> Signed-off-by: Sean Anderson =20 > >> >> > > >> >> > Hi Sean, > >> >> > > >> >> > I'd ideally like to understand why we have channels with such lar= ge > >> >> > scan indexes. Those values should only be used for buffered capt= ure. > >> >> > It feels like they are being abused here. Can we set them to -1 > >> >> > instead and check based on that? > >> >> > For a channel, a scan index of -1 means it can't be captured via = the > >> >> > buffered interfaces but only accessed via sysfs reads. > >> >> > I think that's what we have here? =20 > >> >> > >> >> From what I can tell, none of the channels support buffered reads. = And we can't > >> >> nai=CC=88vely convert the scan_index to -1, since that causes sysfs= naming conflicts > >> >> (not to mention the compatibility break). > >> >> =20 > >> >> > > >> >> > I just feel like if we leave these as things stand, we will get b= itten > >> >> > by similar bugs in the future. At least with -1 it should be obv= ious why! =20 > >> >> > >> >> There are just as likely to be bugs confusing the PL/PS subdevices.= .. > >> >> > >> >> FWIW I had no trouble identifying the channels involved with this b= ug. > >> >> > >> >> --Sean > >> >> =20 > >> >> > Jonathan > >> >> > > >> >> > =20 > >> >> >> --- > >> >> >> > >> >> >> drivers/iio/adc/xilinx-ams.c | 8 ++++++-- > >> >> >> 1 file changed, 6 insertions(+), 2 deletions(-) > >> >> >> > >> >> >> diff --git a/drivers/iio/adc/xilinx-ams.c > >> >> >> b/drivers/iio/adc/xilinx-ams.c index a55396c1f8b2..4de7ce598e4d > >> >> >> 100644 > >> >> >> --- a/drivers/iio/adc/xilinx-ams.c > >> >> >> +++ b/drivers/iio/adc/xilinx-ams.c > >> >> >> @@ -414,8 +414,12 @@ static void ams_enable_channel_sequence(str= uct > >> >> >> iio_dev *indio_dev) > >> >> >> > >> >> >> /* Run calibration of PS & PL as part of the sequence */ > >> >> >> scan_mask =3D BIT(0) | BIT(AMS_PS_SEQ_MAX); > >> >> >> - for (i =3D 0; i < indio_dev->num_channels; i++) > >> >> >> - scan_mask |=3D BIT_ULL(indio_dev->channels[i].scan_= index); > >> >> >> + for (i =3D 0; i < indio_dev->num_channels; i++) { > >> >> >> + const struct iio_chan_spec *chan =3D > >> >> >> + &indio_dev->channels[i]; > >> >> >> + > >> >> >> + if (chan->scan_index < AMS_CTRL_SEQ_BASE) > >> >> >> + scan_mask |=3D BIT_ULL(chan->scan_index); > >> >> >> + } > >> >> >> > >> >> >> if (ams->ps_base) { > >> >> >> /* put sysmon in a soft reset to change the sequenc= e */ =20 > >> >> > =20 > >> =20 > > =20 >=20 >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 11EFEC54E5D for ; Mon, 18 Mar 2024 15:25:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YcyM/lqpRiuyBvzczROGQ6WGN4uA4k9gxRW+om+maec=; b=UEeH5gZmn8aGs8 SwuVtWoVeO83JJGVFqvGdi/aNmoAE1VcZSPtUi3dHL1kRak8no2mKatszy2ejMuCplEpNLxxMfzmD ztsKiBibKqLvn9w9fHM15/mKDbAVFWxhvhFfNTRswm/F10Ev81jSXi0jrW+LEva2e6fabz8JdnhAy +EBwp5+lFe3+YWE9i5qaWRaQrMRjTsVRbFHiFRmSezphUBQblSlbUQi8G0lKtdBupy4PtIw+ERR82 hOvSFw8Cr4vD8FOevWq+gxXRo1Nj7o0mbNpOEfslrowXqg8ybSyIqahpNnHiJOWwFp4qT7tExn5ju PhIYom3Jn1qXeGLf+EZQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmErM-000000091V0-0yeK; Mon, 18 Mar 2024 15:25:08 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmErH-000000091Pr-04Xv for linux-arm-kernel@lists.infradead.org; Mon, 18 Mar 2024 15:25:06 +0000 Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4TyzD607c6z6K6Pl; Mon, 18 Mar 2024 23:24:22 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 0E2E1140A30; Mon, 18 Mar 2024 23:24:48 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 18 Mar 2024 15:24:47 +0000 Date: Mon, 18 Mar 2024 15:24:46 +0000 From: Jonathan Cameron To: Sean Anderson CC: Jonathan Cameron , "O'Griofa, Conall" , "linux-iio@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Lars-Peter Clausen Subject: Re: [PATCH] iio: xilinx-ams: Don't include ams_ctrl_channels in scan_mask Message-ID: <20240318152446.00001345@Huawei.com> In-Reply-To: <7ee83f15-88fc-4530-84b7-b8ee31663dbc@linux.dev> References: <20240311162800.11074-1-sean.anderson@linux.dev> <20240314154824.37150a54@jic23-huawei> <3b481539-0c9c-4110-ad03-bd252e80efb0@linux.dev> <20240316133627.5d2bf585@jic23-huawei> <7ee83f15-88fc-4530-84b7-b8ee31663dbc@linux.dev> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml100003.china.huawei.com (7.191.160.210) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240318_082503_389334_60A3BF2C X-CRM114-Status: GOOD ( 44.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAxOCBNYXIgMjAyNCAxMToxODo0MyAtMDQwMApTZWFuIEFuZGVyc29uIDxzZWFuLmFu ZGVyc29uQGxpbnV4LmRldj4gd3JvdGU6Cgo+IE9uIDMvMTYvMjQgMDk6MzYsIEpvbmF0aGFuIENh bWVyb24gd3JvdGU6Cj4gPiBPbiBGcmksIDE1IE1hciAyMDI0IDEzOjQ3OjQwIC0wNDAwCj4gPiBT ZWFuIEFuZGVyc29uIDxzZWFuLmFuZGVyc29uQGxpbnV4LmRldj4gd3JvdGU6Cj4gPiAgIAo+ID4+ IEhpIENvbmFsbCwKPiA+PiAKPiA+PiBPbiAzLzE1LzI0IDA5OjE4LCBPJ0dyaW9mYSwgQ29uYWxs IHdyb3RlOiAgCj4gPj4gPiBbQU1EIE9mZmljaWFsIFVzZSBPbmx5IC0gR2VuZXJhbF0KPiA+PiA+ IAo+ID4+ID4gSGksCj4gPj4gPiAKPiA+PiA+IEkgdGhpbmsgdGhlcmUgd2FzIGEgZml4IGZvciB0 aGlzIGlzc3VlIGFwcGxpZWQgdG8gdGhlIHZlcnNpb24gdGhhdCB3YXMgcnVubmluZyBvbiA1LjE1 IHRoYXQgZGlkbid0IHNlZW0gdG8gbWFrZSBpdCBpbnRvIHRoZSB1cHN0cmVhbSBkcml2ZXIuCj4g Pj4gPiBQbGVhc2Ugc2VlIGxpbmsgZm9yIHJlZmVyZW5jZSBodHRwczovL2dpdGh1Yi5jb20vWGls aW54L2xpbnV4LXhsbngvY29tbWl0LzYwODQyNjk2MWYxNmFiMTQ5YjFiNjk5ZjFjMzVmN2FkMjQ0 YzA3MjAKPiA+PiA+IAo+ID4+ID4gSSB0aGluayBhIHNpbWlsYXIgZml4IHRvIHRoZSBhYm92ZSBw YXRjaCBpcyBtYXkgYmUgYmVuZWZpY2lhbD8gICAgCj4gPj4gCj4gPj4gVGhlc2UgcGF0Y2hlcyBs b29rIGZ1bmN0aW9uYWxseSBpZGVudGljYWwgdG8gbWUuICAKPiA+IAo+ID4gQmVjYXVzZSB0aGVy ZSBhcmUgbm8gY2hhbm5lbHMgd2l0aCBzY2FuIGluZGV4IGJldHdlZW4KPiA+IDIyICogMiArIDE2 ICh0aGF0IHBhdGNoKSBhbmQgMjIgKiAzICh5b3VyIHBhdGNoKSB0aGF0IGlzCj4gPiB0aGUgZWZm ZWN0IGlzIGluZGVlZCB0aGUgc2FtZS4gQnV0IGdpdmVuIHRoZSBpc3N1ZXMgaXMgdGhlCj4gPiA2 NCBsaW1pdCBvbiBtYXhpbXVtIHNjYW4gaW5kZXgsIDIyICogMyA9IDY2IGlzIGFuIHVnbHkgdmFs dWUKPiA+IHRvIGNvbXBhcmUgd2l0aC4KPiA+IAo+ID4gSSdtIHN0aWxsIHZlcnkgYWdhaW5zdCB0 aGUgdXNlIG9mIHNjYW5faW5kZXggZm9yIGFueXRoaW5nIG90aGVyCj4gPiB0aGFuIHNjYW4gaW5k aWNlcyAod2hpY2ggaXMgd2h5IHBhcnRseSBob3cgdGhpcyBidWcgd2Fzbid0IG5vdGljZWQKPiA+ IGluIHRoZSBmaXJzdCBwYWxjZSkuIFNvIHRoZSBjaGVjayBzaG91bGQgYmUgc2Nhbl9pbmRleCAh PSAtMQo+ID4gYW5kIHVzZXMgb2YgdGhvc2UgdmFsdWVzIGVsc2V3aGVyZSBpbiB0aGUgZHJpdmVy IHNob3VsZCBiZSBmaXhlZAo+ID4gKHdoaWNoIGxvb2tzIHNpbXBsZSB0byBkbyBmcm9tIGEgcXVp Y2sgZ2xhbmNlIGF0IHRoZSBjb2RlKS4gIAo+IAo+IE9LLCBzbyBob3cgZG8gdGhlIHN5c2ZzIGZp bGVzIGdldCBuYW1lZCB0aGVuPwoKVXNpbmcgY2hhbm5lbCBhbmQgY2hhbm5lbDIgYXMgYXBwcm9w cmlhdGUgKCsgaW5kZXggYW5kIG1vZGlmaWVkCndoaWNoIGNoYW5nZSB0aGUgbWVhbmluZyBvZiBj aGFubmVsMikgLSBzY2FuX2luZGV4IG5ldmVyIGhhZAphbnl0aGluZyB0byBkbyB3aXRoIHN5c2Zz IGZpbGUgbmFtZXMgLSBqdXN0IHRoZSB2YWx1ZSBpbgpidWZmZXJYL2luX3h5el9zY2FuX2luZGV4 Cgo+IAo+IC0tU2Vhbgo+IAo+ID4+IAo+ID4+IC0tU2Vhbgo+ID4+ICAgCj4gPj4gPj4gLS0tLS1P cmlnaW5hbCBNZXNzYWdlLS0tLS0KPiA+PiA+PiBGcm9tOiBTZWFuIEFuZGVyc29uIDxzZWFuLmFu ZGVyc29uQGxpbnV4LmRldj4KPiA+PiA+PiBTZW50OiBUaHVyc2RheSwgTWFyY2ggMTQsIDIwMjQg NTozMCBQTQo+ID4+ID4+IFRvOiBKb25hdGhhbiBDYW1lcm9uIDxqaWMyM0BrZXJuZWwub3JnPgo+ ID4+ID4+IENjOiBsaW51eC1paW9Admdlci5rZXJuZWwub3JnOyBPJ0dyaW9mYSwgQ29uYWxsIDxj b25hbGwub2dyaW9mYUBhbWQuY29tPjsKPiA+PiA+PiBsaW51eC1hcm0ta2VybmVsQGxpc3RzLmlu ZnJhZGVhZC5vcmc7IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc7IExhcnMtUGV0ZXIKPiA+ PiA+PiBDbGF1c2VuIDxsYXJzQG1ldGFmb28uZGU+Cj4gPj4gPj4gU3ViamVjdDogUmU6IFtQQVRD SF0gaWlvOiB4aWxpbngtYW1zOiBEb24ndCBpbmNsdWRlIGFtc19jdHJsX2NoYW5uZWxzIGluCj4g Pj4gPj4gc2Nhbl9tYXNrCj4gPj4gPj4KPiA+PiA+PiBDYXV0aW9uOiBUaGlzIG1lc3NhZ2Ugb3Jp Z2luYXRlZCBmcm9tIGFuIEV4dGVybmFsIFNvdXJjZS4gVXNlIHByb3BlciBjYXV0aW9uCj4gPj4g Pj4gd2hlbiBvcGVuaW5nIGF0dGFjaG1lbnRzLCBjbGlja2luZyBsaW5rcywgb3IgcmVzcG9uZGlu Zy4KPiA+PiA+Pgo+ID4+ID4+Cj4gPj4gPj4gT24gMy8xNC8yNCAxMTo0OCwgSm9uYXRoYW4gQ2Ft ZXJvbiB3cm90ZTogICAgCj4gPj4gPj4gPiBPbiBNb24sIDExIE1hciAyMDI0IDEyOjI4OjAwIC0w NDAwCj4gPj4gPj4gPiBTZWFuIEFuZGVyc29uIDxzZWFuLmFuZGVyc29uQGxpbnV4LmRldj4gd3Jv dGU6Cj4gPj4gPj4gPiAgICAKPiA+PiA+PiA+PiBhbXNfZW5hYmxlX2NoYW5uZWxfc2VxdWVuY2Ug Y29uc3RydWN0cyBhICJzY2FuX21hc2siIGZvciBhbGwgdGhlIFBTCj4gPj4gPj4gPj4gYW5kIFBM IGNoYW5uZWxzLiBUaGlzIHdvcmtzIG91dCBmaW5lLCBzaW5jZSBzY2FuX2luZGV4IGZvciB0aGVz ZQo+ID4+ID4+ID4+IGNoYW5uZWxzIGlzIGxlc3MgdGhhbiA2NC4gSG93ZXZlciwgaXQgYWxzbyBp bmNsdWRlcyB0aGUKPiA+PiA+PiA+PiBhbXNfY3RybF9jaGFubmVscywgd2hlcmUgc2Nhbl9pbmRl eCBpcyBncmVhdGVyIHRoYW4gNjQsIHRyaWdnZXJpbmcKPiA+PiA+PiA+PiB1bmRlZmluZWQgYmVo YXZpb3IuIFNpbmNlIHdlIGRvbid0IG5lZWQgdGhlc2UgY2hhbm5lbHMgYW55d2F5LCBqdXN0ICAg IAo+ID4+ID4+IGV4Y2x1ZGUgdGhlbS4gICAgCj4gPj4gPj4gPj4KPiA+PiA+PiA+PiBGaXhlczog ZDVjNzA2MjdhNzk0ICgiaWlvOiBhZGM6IEFkZCBYaWxpbnggQU1TIGRyaXZlciIpCj4gPj4gPj4g Pj4gU2lnbmVkLW9mZi1ieTogU2VhbiBBbmRlcnNvbiA8c2Vhbi5hbmRlcnNvbkBsaW51eC5kZXY+ ICAgIAo+ID4+ID4+ID4KPiA+PiA+PiA+IEhpIFNlYW4sCj4gPj4gPj4gPgo+ID4+ID4+ID4gSSdk IGlkZWFsbHkgbGlrZSB0byB1bmRlcnN0YW5kIHdoeSB3ZSBoYXZlIGNoYW5uZWxzIHdpdGggc3Vj aCBsYXJnZQo+ID4+ID4+ID4gc2NhbiBpbmRleGVzLiAgVGhvc2UgdmFsdWVzIHNob3VsZCBvbmx5 IGJlIHVzZWQgZm9yIGJ1ZmZlcmVkIGNhcHR1cmUuCj4gPj4gPj4gPiBJdCBmZWVscyBsaWtlIHRo ZXkgYXJlIGJlaW5nIGFidXNlZCBoZXJlLiAgQ2FuIHdlIHNldCB0aGVtIHRvIC0xCj4gPj4gPj4g PiBpbnN0ZWFkIGFuZCBjaGVjayBiYXNlZCBvbiB0aGF0Pwo+ID4+ID4+ID4gRm9yIGEgY2hhbm5l bCwgYSBzY2FuIGluZGV4IG9mIC0xIG1lYW5zIGl0IGNhbid0IGJlIGNhcHR1cmVkIHZpYSB0aGUK PiA+PiA+PiA+IGJ1ZmZlcmVkIGludGVyZmFjZXMgYnV0IG9ubHkgYWNjZXNzZWQgdmlhIHN5c2Zz IHJlYWRzLgo+ID4+ID4+ID4gSSB0aGluayB0aGF0J3Mgd2hhdCB3ZSBoYXZlIGhlcmU/ICAgIAo+ ID4+ID4+Cj4gPj4gPj4gRnJvbSB3aGF0IEkgY2FuIHRlbGwsIG5vbmUgb2YgdGhlIGNoYW5uZWxz IHN1cHBvcnQgYnVmZmVyZWQgcmVhZHMuIEFuZCB3ZSBjYW4ndAo+ID4+ID4+IG5hacyIdmVseSBj b252ZXJ0IHRoZSBzY2FuX2luZGV4IHRvIC0xLCBzaW5jZSB0aGF0IGNhdXNlcyBzeXNmcyBuYW1p bmcgY29uZmxpY3RzCj4gPj4gPj4gKG5vdCB0byBtZW50aW9uIHRoZSBjb21wYXRpYmlsaXR5IGJy ZWFrKS4KPiA+PiA+PiAgICAKPiA+PiA+PiA+Cj4gPj4gPj4gPiBJIGp1c3QgZmVlbCBsaWtlIGlm IHdlIGxlYXZlIHRoZXNlIGFzIHRoaW5ncyBzdGFuZCwgd2Ugd2lsbCBnZXQgYml0dGVuCj4gPj4g Pj4gPiBieSBzaW1pbGFyIGJ1Z3MgaW4gdGhlIGZ1dHVyZS4gIEF0IGxlYXN0IHdpdGggLTEgaXQg c2hvdWxkIGJlIG9idmlvdXMgd2h5ISAgICAKPiA+PiA+Pgo+ID4+ID4+IFRoZXJlIGFyZSBqdXN0 IGFzIGxpa2VseSB0byBiZSBidWdzIGNvbmZ1c2luZyB0aGUgUEwvUFMgc3ViZGV2aWNlcy4uLgo+ ID4+ID4+Cj4gPj4gPj4gRldJVyBJIGhhZCBubyB0cm91YmxlIGlkZW50aWZ5aW5nIHRoZSBjaGFu bmVscyBpbnZvbHZlZCB3aXRoIHRoaXMgYnVnLgo+ID4+ID4+Cj4gPj4gPj4gLS1TZWFuCj4gPj4g Pj4gICAgCj4gPj4gPj4gPiBKb25hdGhhbgo+ID4+ID4+ID4KPiA+PiA+PiA+ICAgIAo+ID4+ID4+ ID4+IC0tLQo+ID4+ID4+ID4+Cj4gPj4gPj4gPj4gIGRyaXZlcnMvaWlvL2FkYy94aWxpbngtYW1z LmMgfCA4ICsrKysrKy0tCj4gPj4gPj4gPj4gIDEgZmlsZSBjaGFuZ2VkLCA2IGluc2VydGlvbnMo KyksIDIgZGVsZXRpb25zKC0pCj4gPj4gPj4gPj4KPiA+PiA+PiA+PiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9paW8vYWRjL3hpbGlueC1hbXMuYwo+ID4+ID4+ID4+IGIvZHJpdmVycy9paW8vYWRjL3hp bGlueC1hbXMuYyBpbmRleCBhNTUzOTZjMWY4YjIuLjRkZTdjZTU5OGU0ZAo+ID4+ID4+ID4+IDEw MDY0NAo+ID4+ID4+ID4+IC0tLSBhL2RyaXZlcnMvaWlvL2FkYy94aWxpbngtYW1zLmMKPiA+PiA+ PiA+PiArKysgYi9kcml2ZXJzL2lpby9hZGMveGlsaW54LWFtcy5jCj4gPj4gPj4gPj4gQEAgLTQx NCw4ICs0MTQsMTIgQEAgc3RhdGljIHZvaWQgYW1zX2VuYWJsZV9jaGFubmVsX3NlcXVlbmNlKHN0 cnVjdAo+ID4+ID4+ID4+IGlpb19kZXYgKmluZGlvX2RldikKPiA+PiA+PiA+Pgo+ID4+ID4+ID4+ ICAgICAgLyogUnVuIGNhbGlicmF0aW9uIG9mIFBTICYgUEwgYXMgcGFydCBvZiB0aGUgc2VxdWVu Y2UgKi8KPiA+PiA+PiA+PiAgICAgIHNjYW5fbWFzayA9IEJJVCgwKSB8IEJJVChBTVNfUFNfU0VR X01BWCk7Cj4gPj4gPj4gPj4gLSAgICBmb3IgKGkgPSAwOyBpIDwgaW5kaW9fZGV2LT5udW1fY2hh bm5lbHM7IGkrKykKPiA+PiA+PiA+PiAtICAgICAgICAgICAgc2Nhbl9tYXNrIHw9IEJJVF9VTEwo aW5kaW9fZGV2LT5jaGFubmVsc1tpXS5zY2FuX2luZGV4KTsKPiA+PiA+PiA+PiArICAgIGZvciAo aSA9IDA7IGkgPCBpbmRpb19kZXYtPm51bV9jaGFubmVsczsgaSsrKSB7Cj4gPj4gPj4gPj4gKyAg ICAgICAgICAgIGNvbnN0IHN0cnVjdCBpaW9fY2hhbl9zcGVjICpjaGFuID0KPiA+PiA+PiA+PiAr ICZpbmRpb19kZXYtPmNoYW5uZWxzW2ldOwo+ID4+ID4+ID4+ICsKPiA+PiA+PiA+PiArICAgICAg ICAgICAgaWYgKGNoYW4tPnNjYW5faW5kZXggPCBBTVNfQ1RSTF9TRVFfQkFTRSkKPiA+PiA+PiA+ PiArICAgICAgICAgICAgICAgICAgICBzY2FuX21hc2sgfD0gQklUX1VMTChjaGFuLT5zY2FuX2lu ZGV4KTsKPiA+PiA+PiA+PiArICAgIH0KPiA+PiA+PiA+Pgo+ID4+ID4+ID4+ICAgICAgaWYgKGFt cy0+cHNfYmFzZSkgewo+ID4+ID4+ID4+ICAgICAgICAgICAgICAvKiBwdXQgc3lzbW9uIGluIGEg c29mdCByZXNldCB0byBjaGFuZ2UgdGhlIHNlcXVlbmNlICovICAgIAo+ID4+ID4+ID4gICAgCj4g Pj4gICAKPiA+ICAgCj4gCj4gCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5l bEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4v bGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=