From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A5E1C54E58 for ; Mon, 18 Mar 2024 15:33:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9157310F31A; Mon, 18 Mar 2024 15:33:33 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="kc4tIsMT"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5AA2210F31A for ; Mon, 18 Mar 2024 15:33:31 +0000 (UTC) Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C2CE01B1C; Mon, 18 Mar 2024 16:33:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1710775983; bh=3RSr8iMZm26LvuIqeREkoGQz0HYx6DB2UxS3ouoY8cQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kc4tIsMTOCx93b8KvSCy3HhebHNltygT2gNxhsxQkVIueh2gAUAFSbXbgUdBHDcV8 IRxLXWg7xB/DjWWU15zV8Dnit96KUwNJyK+uSdFtTjjW/p+EsCI5Mwy6DIPS8oq4kO fTIfHoKUkAdlXMmy7fPARntNR5ygsNKdv005MCTM= Date: Mon, 18 Mar 2024 17:33:26 +0200 From: Laurent Pinchart To: Sui Jingfeng Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm: bridge: thc63lvd1024: Switch to use of_graph_get_remote_node() Message-ID: <20240318153326.GD13682@pendragon.ideasonboard.com> References: <20240316172800.1168390-1-sui.jingfeng@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240316172800.1168390-1-sui.jingfeng@linux.dev> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Sui, Thank you for the patch. On Sun, Mar 17, 2024 at 01:28:00AM +0800, Sui Jingfeng wrote: > To reduce boilerplate, use of_graph_get_remote_node() helper instead of > the hand-rolling code. > > Signed-off-by: Sui Jingfeng > --- > drivers/gpu/drm/bridge/thc63lvd1024.c | 24 +++--------------------- > 1 file changed, 3 insertions(+), 21 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/thc63lvd1024.c b/drivers/gpu/drm/bridge/thc63lvd1024.c > index d4c1a601bbb5..5f99f9724081 100644 > --- a/drivers/gpu/drm/bridge/thc63lvd1024.c > +++ b/drivers/gpu/drm/bridge/thc63lvd1024.c > @@ -123,28 +123,10 @@ static int thc63_parse_dt(struct thc63_dev *thc63) > struct device_node *endpoint; > struct device_node *remote; > > - endpoint = of_graph_get_endpoint_by_regs(thc63->dev->of_node, > - THC63_RGB_OUT0, -1); > - if (!endpoint) { > - dev_err(thc63->dev, "Missing endpoint in port@%u\n", > - THC63_RGB_OUT0); > - return -ENODEV; > - } > - > - remote = of_graph_get_remote_port_parent(endpoint); > - of_node_put(endpoint); > - if (!remote) { > - dev_err(thc63->dev, "Endpoint in port@%u unconnected\n", > - THC63_RGB_OUT0); > + remote = of_graph_get_remote_node(thc63->dev->of_node, > + THC63_RGB_OUT0, -1); > + if (!remote) The old logic is equivalent to of_graph_get_remote_node(), but now the driver will fail probing without an error message. That's not very nice as it leads to difficult to debug problems. I would keep one dev_err() here: dev_err(thc63->dev, "No remote endpoint for port@%u\n", THC63_RGB_OUT0); As your patch has been merged already, would you like to post a follow-up patch to fix this ? > return -ENODEV; > - } > - > - if (!of_device_is_available(remote)) { > - dev_err(thc63->dev, "port@%u remote endpoint is disabled\n", > - THC63_RGB_OUT0); > - of_node_put(remote); > - return -ENODEV; > - } > > thc63->next = of_drm_find_bridge(remote); > of_node_put(remote); -- Regards, Laurent Pinchart