From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8515BC54E58 for ; Mon, 18 Mar 2024 16:16:47 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=QzZuBY7h; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Tz0NY5bxcz3vb9 for ; Tue, 19 Mar 2024 03:16:45 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=QzZuBY7h; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nvidia.com (client-ip=2a01:111:f403:240a::601; helo=nam04-mw2-obe.outbound.protection.outlook.com; envelope-from=jgg@nvidia.com; receiver=lists.ozlabs.org) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on20601.outbound.protection.outlook.com [IPv6:2a01:111:f403:240a::601]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Tz0Mh6rCTz3cNN for ; Tue, 19 Mar 2024 03:15:57 +1100 (AEDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e+CcdGzsnTq72yJAOE+f8Me64HjGti6A26PWbOMrP9LABVfDZd5KReGe/kTpZ1XR/0AtN1nfXox3rlh3cvZtbrYpfKLKPBrgjSKAM/jb+9n/wZazTNXs9m4dpfGNRIX0TEkmVsmY6fz/dFd0n8IvSrWz9q363qOXaqq0VhOPqVG+3nRmTn9WzIe3gQPBiY/IOP7O/oCgsf7wGKzw1xvFPpGRgKCaT97ei1AIjBH3W7ktfh7pign0vjWX0xYLmWwYBT5W49GMgE74PaSNoC+4UuQJzZFKUulPc8NaryvfBTi7QHw+UmZZgNji6vjjz4XyVkh9WNahxGnju+n3uQStUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dlv9s2X6IUZXoWRPusJ/nMrZ6cYw3m45dbmZorYVX7Y=; b=dEsp+C/289gGr6movhZhmTpf5fAFa3IVXYDdL7+OGeCNrSY62JV3JmuJv7AQT33mzSikZgaDEYgX6HYzMsn9MRHhGJnqlgX4sVbaQBASZUjVUABBHA+dwKJLwCUEhrIK2jxXJl69bqoFMG5+btyksOkKCi4SR8R1SgNRUpkdFhcPEDBXyxYwfs+6K8jLwzqz5PWJh9DY+1sgeoQbfeKceUMHMrDydmUdlXEPqVu5gX5iz9NQUWAnU4p+jKJpWGXz/o2ANXNBv8DXd9S6NLpJRRTiz+qb9RXcax9RupgqaRvtzQ1mY+r85mKUfUNnJb3h8mef/S8zMAGMxrME35OuVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dlv9s2X6IUZXoWRPusJ/nMrZ6cYw3m45dbmZorYVX7Y=; b=QzZuBY7hXHCOR8706MkWbH1fDoSq2MN/Ob7GM/NjS74eXtzpITp3CC9bmX3IGr9mNw93+0Tyi8JlwgkOwCiwsDiSyMl0P5M1J4u5gAR0QAz6xdw74EFoUP13hFo7j6Fm5DEw4DtsMTIW+qTU3sQWTzzR3vDmXqzx5O1beJAkwl1GQS8Afujp1LXSzeo92aXztc8WxD0Uo3CfPZcGB6YIjVaRUSDm27pPZJRO7LJkUJCIJZY07leuZ2RiJcnpFQPZ+rAEgq81xxYP8Ksu6AGDir/sAZPBuFtCXyJoB1lZIaRruUU6ksq0rhtN8vHJ9VqO5s+iXPTHZyF9qC0QvJwIIA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DM6PR12MB3849.namprd12.prod.outlook.com (2603:10b6:5:1c7::26) by CH3PR12MB8331.namprd12.prod.outlook.com (2603:10b6:610:12f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.26; Mon, 18 Mar 2024 16:15:21 +0000 Received: from DM6PR12MB3849.namprd12.prod.outlook.com ([fe80::6aec:dbca:a593:a222]) by DM6PR12MB3849.namprd12.prod.outlook.com ([fe80::6aec:dbca:a593:a222%5]) with mapi id 15.20.7386.025; Mon, 18 Mar 2024 16:15:21 +0000 Date: Mon, 18 Mar 2024 13:15:19 -0300 From: Jason Gunthorpe To: Christophe Leroy Subject: Re: [PATCH 09/13] mm/powerpc: Redefine pXd_huge() with pXd_leaf() Message-ID: <20240318161519.GA5825@nvidia.com> References: <20240313214719.253873-1-peterx@redhat.com> <20240313214719.253873-10-peterx@redhat.com> <7b7d6ce1-4a3f-4392-951d-a9bd146c954c@csgroup.eu> <1f6ad500-3ff7-44d4-8223-067bd2ed9ffe@csgroup.eu> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1f6ad500-3ff7-44d4-8223-067bd2ed9ffe@csgroup.eu> X-ClientProxiedBy: SA9PR13CA0141.namprd13.prod.outlook.com (2603:10b6:806:27::26) To DM6PR12MB3849.namprd12.prod.outlook.com (2603:10b6:5:1c7::26) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB3849:EE_|CH3PR12MB8331:EE_ X-MS-Office365-Filtering-Correlation-Id: 21eacb3b-8bd6-4b62-a007-08dc47669c17 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VeKXYvAoK6iWXmAcXLaQEH4lPt94aqq5ovoSX7V3j15TdBEc7W4CWTVb4GuQrIsYtcEn2mr8Y031SJcq0lDu6/8ciSsxpyRcnYGNyPe5HuoXyea7ddZlen3EnoV+xkxHAMeLbZc+sUFV3X7YIAxpv8yNywKaXKDpucWj49i3yGvn4Rmc8QOenBXgMulnvoxda/8Q4rX+V+eliOpyIVoqKF5jeWwIev8VxDgxNPW/XPEDS9xAvC28QBdb5gImHjBjbRSm3MSq7FymDuEGdc51Hrsczy7FTDrQ8s77Tm2DUvQ5YrhEyQ7Q5LZpH1K2cM6u1XxEWmoQJRjtflJFMogrMDAiq+h43g+TovnTPRxVBpKQ7JwmUpYgRZSYeVhkBN4zHpJAmqZsqooTuupFc2zfdLi93rV+EuQUa8v2xBK0s7CuE/OdNz1eUNWYySCi3HcTOQWy8lrJut1qCU8cssJS9DfHGiSfbvnNriv6rgZr+RFKplNXdC+NaK/C+TdoLPgn/kEG1pJ4dmCRkDpd26wwyjPvbX1jihoLvtNQ7nu1pAdnRY79lgcpPsZShhzWjVoY35wbGf6xDeJTwrYYNppqvAHARxi7+r4GitMqw8oQ3d6aNDXWWCQF6uUekUvbnNzT7d7t0IzW2KOQstVWUVwyEXm/qADHXC1ekb/Uk6/oM6Q= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB3849.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(366007)(1800799015)(7416005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bHhHUWZoQllXU0VoeTFmTE9SZkdIbU96VFpLSHdrSFJJd0s1blBzMFZ5NExp?= =?utf-8?B?dG01RGwzOEN3Y1Ztck9ScjZnaUpKYXJkSjFjcFlBdkhCUzNwc2MwTXRGcWcr?= =?utf-8?B?MmhzdWNQcUp6WFd6Wi82MWZRV3V4YjBERUJqdHdvWUlRNlpwYVJZOGcrREFL?= =?utf-8?B?Skl4U1RFUUlZbWVvYnJGSVNncWZIWjlDQmNOSXJhb0VMUWhSSHJhMVlpb2hP?= =?utf-8?B?NS80N2drWXpYQ21HVnAzS2hnTnZOblBVb1BtOE9vVENDSERLNkJGcU9RZHkx?= =?utf-8?B?WDk5MnZQUXRJdHcvT1Z2TmNxRENHVGtzMGNiU1htUUkrTEJxblh6QXpJS2Mx?= =?utf-8?B?THhEek0zM2xVWVJESDRhNDFXTUtrajhqQWwwaGVucldqWmdLMkxYUEN1ZUhI?= =?utf-8?B?cVZObFBFRjdUcUhablVkOElYMXkyTFd4NVMvS3NBN2EyVjR2WUthOFdCVzJr?= =?utf-8?B?Z2ZUOVBmTyt3RStOSlJhclkyRVFjREtjTkpzR0xMY0ZGU0VraWNSKzJtUzNS?= =?utf-8?B?RTVsN1dRYnFMMnlsYUNpd2hsMGhaTTNxQVlEV0Z3RmM1OTJJbzJPRmR0Mm9R?= =?utf-8?B?aUtFOFVJVjZPZElkRk4yWGcrWjZuNGtUdnhjOFpJZ04yNWQxaGdsamN0M1Rw?= =?utf-8?B?TGc5YWExdElLb0tsTnlRdGxHM1BhSjB5ZW5id0lwLzlLSGNHMVBaZjk0bXJN?= =?utf-8?B?a1JFbDlkemR6S3ppcSttT2dYOFlselJWZ1RLVGZkeEZlVWp3bG5KSnFtbWkw?= =?utf-8?B?aS9nV2VQd3dqcUxodzF1ekJBbTlDQXU0SXcvL25WUnBSMDhaNm8xanV4Nlcr?= =?utf-8?B?Q0FlZ0hOYm1yTFhwSVF1dHhiZXJ1NHNXRlliOWNlZjM1VUhrWlI3Wm5qRHpD?= =?utf-8?B?ZjU5dW84UWNUZXJXUWVQWmZEbXlJYllHbWVWL2tjdlN1MGt0ekwyMnVyZWxV?= =?utf-8?B?VjM4VzJmc2NxUy9NTWdINDIrL0RyVVI2ZHpndGJWWW5PaDdkSmhTUTBzbDJZ?= =?utf-8?B?MFJFUndqVEhrTDhjUUFiVDUwbkpIM3cvMXBhWWRNNzRXWXJJODc0Slc4eFVq?= =?utf-8?B?bDF2TXk2Z1hsQ1BsaUxRT1A4OFJJWlo2TG1OanBJaC8yeU1NelFCOU1SK2VT?= =?utf-8?B?RXE4THp0bGx0YVZTQmtPYy9BZFEzSWowWnhpbFgxMHFyU29odE1pd1BOTmMy?= =?utf-8?B?S3UwZWxyN0FzblNIdHp5SnpjaER2N3o0eXVQR2F0WTRpRWx6N0QyMVRUVVVv?= =?utf-8?B?QUd2M01DcUs5N29OZ3hjWmY1aWN5b21tQzJwZjZkekliU01WUDFBTjQyMzNS?= =?utf-8?B?cmZLcUtoenBWUWY2a0QxVGpweVp3MWY2WExmcnd1K01UWmxPOUZmeTZzQ1Ey?= =?utf-8?B?ZnBPdDhDNWcyTFlBV3dCTzhCOVB6MCszeVdIejJlY2xCUkk1V2szZTRHdXJl?= =?utf-8?B?NFpCTjBzY0k3N0xOSVI4eTV2OXNhTDhqZ2RzUGp6NWR1VHhlQVBWMlo1SWZF?= =?utf-8?B?ckpXOVVsN2diK0w0OHY2MlRTVlp0cW9DQllSTEZTTFBjMEpBRi83bFN1LzQ2?= =?utf-8?B?TTJJZ3E3bGw0ajZwSkhwdGN5YTdzcVRmYXV4MlFydFpha3YrMnpKa3hxYkdE?= =?utf-8?B?VlBXbitWb3lqUnVTUzdTRzRGNG1oZCtPRVg5Mkg1SERpTkRFUFhEZFk5U0lK?= =?utf-8?B?OS9tL1NsdHZwTkg5bDhPdE5HUUJSWlFNOWxSTUhDK0ZRQ0JrQWQvS0Y1eFZu?= =?utf-8?B?QWxWVWNBVGVzNzdwcFozQThiY2M0RnlndlBzVnNvRXpvYmFJS3djRTd3eGp2?= =?utf-8?B?b3Bja0JHdUppSGJjSTRNQllGTmlzTThaMkJHbnJSaFNsVUFacno4STlHRUU5?= =?utf-8?B?OGxxckZhZkhZVUl3MElRNFlCZGpQTmJveWtxc2F4aE52SVRTYmVLYUNoQ3Jt?= =?utf-8?B?WldzQzBFS2djaG5YVnRSRk81bWZqVmI3UXRKc0dzc1A3QXRGdmtnQ3R5Z1Iv?= =?utf-8?B?RkxwY01pT21NcVF1bnRPRG5OR0UvSzdwL3ZNVkUwRTliYnRLdDMyUXFacURW?= =?utf-8?B?UG5ZTVFOQ04wbXk5enFjd2s3NDZSSndrMklKQW1CTEdkM1RIRGNuUm0yZU1V?= =?utf-8?Q?fYwU=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 21eacb3b-8bd6-4b62-a007-08dc47669c17 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3849.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2024 16:15:21.2007 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ptvgPTtAQp9uxgSCr5rnubGdY/jszhNphhnpNM1hGNKovsx6qNC1ywe+pYvIhi6b X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8331 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Muchun Song , "x86@kernel.org" , Nicholas Piggin , "linux-kernel@vger.kernel.org" , Matthew Wilcox , "Naveen N. Rao" , "Aneesh Kumar K.V" , "linux-mm@kvack.org" , Peter Xu , Mike Rapoport , "sparclinux@vger.kernel.org" , Andrew Morton , "linuxppc-dev@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Mar 14, 2024 at 01:11:59PM +0000, Christophe Leroy wrote: > > > Le 14/03/2024 à 13:53, Peter Xu a écrit : > > On Thu, Mar 14, 2024 at 08:45:34AM +0000, Christophe Leroy wrote: > >> > >> > >> Le 13/03/2024 à 22:47, peterx@redhat.com a écrit : > >>> From: Peter Xu > >>> > >>> PowerPC book3s 4K mostly has the same definition on both, except pXd_huge() > >>> constantly returns 0 for hash MMUs. As Michael Ellerman pointed out [1], > >>> it is safe to check _PAGE_PTE on hash MMUs, as the bit will never be set so > >>> it will keep returning false. > >>> > >>> As a reference, __p[mu]d_mkhuge() will trigger a BUG_ON trying to create > >>> such huge mappings for 4K hash MMUs. Meanwhile, the major powerpc hugetlb > >>> pgtable walker __find_linux_pte() already used pXd_leaf() to check hugetlb > >>> mappings. > >>> > >>> The goal should be that we will have one API pXd_leaf() to detect all kinds > >>> of huge mappings. AFAICT we need to use the pXd_leaf() impl (rather than > >>> pXd_huge() ones) to make sure ie. THPs on hash MMU will also return true. > >> > >> All kinds of huge mappings ? > >> > >> pXd_leaf() will detect only leaf mappings (like pXd_huge() ). There are > >> also huge mappings through hugepd. On powerpc 8xx we have 8M huge pages > >> and 512k huge pages. A PGD entry covers 4M so pgd_leaf() won't report > >> those huge pages. > > > > Ah yes, I should always mention this is in the context of leaf huge pages > > only. Are the examples you provided all fall into hugepd category? If so > > I can reword the commit message, as: > > On powerpc 8xx, only the 8M huge pages fall into the hugepd case. > > The 512k hugepages are at PTE level, they are handled more or less like > CONT_PTE on ARM. see function set_huge_pte_at() for more context. > > You can also look at pte_leaf_size() and pgd_leaf_size(). IMHO leaf should return false if the thing is pointing to a next level page table, even if that next level is fully populated with contiguous pages. This seems more aligned with the contig page direction that hugepd should be moved over to.. > By the way pgd_leaf_size() looks odd because it is called only when > pgd_leaf_size() returns true, which never happens for 8M pages. Like this, you should reach the actual final leaf that the HW will load and leaf_size() should say it is greater size than the current table level. Other levels should return 0. If necessary the core MM code should deal with this by iterating over adjacent tables. Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2088.outbound.protection.outlook.com [40.107.101.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0911381AB; Mon, 18 Mar 2024 16:15:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.101.88 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710778525; cv=fail; b=pcNG8sc/b0QkX3szTvzGAMDqaxeFAnrSWx1AnuAQUrR3SifXBuWo3EJ9QrcidDWxz9Lr/tYtcZSjthVvSbaVft2uSgUhDggNMjo+mxtIzwWYDJaWUI6ZRPhwFwjZJt+NxlJA8d72GwKlKM/3NFlQ0LvtNn2IG+XWaNDI6A6y9qo= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710778525; c=relaxed/simple; bh=PJtS7zI0u2qOVABnmf7JxLmekBIS12Spk/QjUoD8sT0=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=uSFVzVx4ZbwtiiuvjbY2w47cJ92eoT6bPqoFgZTUE+Fnei/sD06BYXu+71GPPYqgu71QTrvLptN+g+tr6KVh4yVBRe05+R7TNBtKLi9BE1S4MCXo7lWMg3yk09ZNSnid+SPZBu22IZYhT7sPWUbUz1h5dkltslX3Zojb2ku0k+g= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=QzZuBY7h; arc=fail smtp.client-ip=40.107.101.88 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="QzZuBY7h" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e+CcdGzsnTq72yJAOE+f8Me64HjGti6A26PWbOMrP9LABVfDZd5KReGe/kTpZ1XR/0AtN1nfXox3rlh3cvZtbrYpfKLKPBrgjSKAM/jb+9n/wZazTNXs9m4dpfGNRIX0TEkmVsmY6fz/dFd0n8IvSrWz9q363qOXaqq0VhOPqVG+3nRmTn9WzIe3gQPBiY/IOP7O/oCgsf7wGKzw1xvFPpGRgKCaT97ei1AIjBH3W7ktfh7pign0vjWX0xYLmWwYBT5W49GMgE74PaSNoC+4UuQJzZFKUulPc8NaryvfBTi7QHw+UmZZgNji6vjjz4XyVkh9WNahxGnju+n3uQStUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dlv9s2X6IUZXoWRPusJ/nMrZ6cYw3m45dbmZorYVX7Y=; b=dEsp+C/289gGr6movhZhmTpf5fAFa3IVXYDdL7+OGeCNrSY62JV3JmuJv7AQT33mzSikZgaDEYgX6HYzMsn9MRHhGJnqlgX4sVbaQBASZUjVUABBHA+dwKJLwCUEhrIK2jxXJl69bqoFMG5+btyksOkKCi4SR8R1SgNRUpkdFhcPEDBXyxYwfs+6K8jLwzqz5PWJh9DY+1sgeoQbfeKceUMHMrDydmUdlXEPqVu5gX5iz9NQUWAnU4p+jKJpWGXz/o2ANXNBv8DXd9S6NLpJRRTiz+qb9RXcax9RupgqaRvtzQ1mY+r85mKUfUNnJb3h8mef/S8zMAGMxrME35OuVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dlv9s2X6IUZXoWRPusJ/nMrZ6cYw3m45dbmZorYVX7Y=; b=QzZuBY7hXHCOR8706MkWbH1fDoSq2MN/Ob7GM/NjS74eXtzpITp3CC9bmX3IGr9mNw93+0Tyi8JlwgkOwCiwsDiSyMl0P5M1J4u5gAR0QAz6xdw74EFoUP13hFo7j6Fm5DEw4DtsMTIW+qTU3sQWTzzR3vDmXqzx5O1beJAkwl1GQS8Afujp1LXSzeo92aXztc8WxD0Uo3CfPZcGB6YIjVaRUSDm27pPZJRO7LJkUJCIJZY07leuZ2RiJcnpFQPZ+rAEgq81xxYP8Ksu6AGDir/sAZPBuFtCXyJoB1lZIaRruUU6ksq0rhtN8vHJ9VqO5s+iXPTHZyF9qC0QvJwIIA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DM6PR12MB3849.namprd12.prod.outlook.com (2603:10b6:5:1c7::26) by CH3PR12MB8331.namprd12.prod.outlook.com (2603:10b6:610:12f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.26; Mon, 18 Mar 2024 16:15:21 +0000 Received: from DM6PR12MB3849.namprd12.prod.outlook.com ([fe80::6aec:dbca:a593:a222]) by DM6PR12MB3849.namprd12.prod.outlook.com ([fe80::6aec:dbca:a593:a222%5]) with mapi id 15.20.7386.025; Mon, 18 Mar 2024 16:15:21 +0000 Date: Mon, 18 Mar 2024 13:15:19 -0300 From: Jason Gunthorpe To: Christophe Leroy Cc: Peter Xu , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "linux-arm-kernel@lists.infradead.org" , Matthew Wilcox , "linuxppc-dev@lists.ozlabs.org" , Andrew Morton , "x86@kernel.org" , Mike Rapoport , Muchun Song , "sparclinux@vger.kernel.org" , Michael Ellerman , Nicholas Piggin , "Aneesh Kumar K.V" , "Naveen N. Rao" Subject: Re: [PATCH 09/13] mm/powerpc: Redefine pXd_huge() with pXd_leaf() Message-ID: <20240318161519.GA5825@nvidia.com> References: <20240313214719.253873-1-peterx@redhat.com> <20240313214719.253873-10-peterx@redhat.com> <7b7d6ce1-4a3f-4392-951d-a9bd146c954c@csgroup.eu> <1f6ad500-3ff7-44d4-8223-067bd2ed9ffe@csgroup.eu> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1f6ad500-3ff7-44d4-8223-067bd2ed9ffe@csgroup.eu> X-ClientProxiedBy: SA9PR13CA0141.namprd13.prod.outlook.com (2603:10b6:806:27::26) To DM6PR12MB3849.namprd12.prod.outlook.com (2603:10b6:5:1c7::26) Precedence: bulk X-Mailing-List: sparclinux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB3849:EE_|CH3PR12MB8331:EE_ X-MS-Office365-Filtering-Correlation-Id: 21eacb3b-8bd6-4b62-a007-08dc47669c17 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VeKXYvAoK6iWXmAcXLaQEH4lPt94aqq5ovoSX7V3j15TdBEc7W4CWTVb4GuQrIsYtcEn2mr8Y031SJcq0lDu6/8ciSsxpyRcnYGNyPe5HuoXyea7ddZlen3EnoV+xkxHAMeLbZc+sUFV3X7YIAxpv8yNywKaXKDpucWj49i3yGvn4Rmc8QOenBXgMulnvoxda/8Q4rX+V+eliOpyIVoqKF5jeWwIev8VxDgxNPW/XPEDS9xAvC28QBdb5gImHjBjbRSm3MSq7FymDuEGdc51Hrsczy7FTDrQ8s77Tm2DUvQ5YrhEyQ7Q5LZpH1K2cM6u1XxEWmoQJRjtflJFMogrMDAiq+h43g+TovnTPRxVBpKQ7JwmUpYgRZSYeVhkBN4zHpJAmqZsqooTuupFc2zfdLi93rV+EuQUa8v2xBK0s7CuE/OdNz1eUNWYySCi3HcTOQWy8lrJut1qCU8cssJS9DfHGiSfbvnNriv6rgZr+RFKplNXdC+NaK/C+TdoLPgn/kEG1pJ4dmCRkDpd26wwyjPvbX1jihoLvtNQ7nu1pAdnRY79lgcpPsZShhzWjVoY35wbGf6xDeJTwrYYNppqvAHARxi7+r4GitMqw8oQ3d6aNDXWWCQF6uUekUvbnNzT7d7t0IzW2KOQstVWUVwyEXm/qADHXC1ekb/Uk6/oM6Q= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB3849.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(366007)(1800799015)(7416005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bHhHUWZoQllXU0VoeTFmTE9SZkdIbU96VFpLSHdrSFJJd0s1blBzMFZ5NExp?= =?utf-8?B?dG01RGwzOEN3Y1Ztck9ScjZnaUpKYXJkSjFjcFlBdkhCUzNwc2MwTXRGcWcr?= =?utf-8?B?MmhzdWNQcUp6WFd6Wi82MWZRV3V4YjBERUJqdHdvWUlRNlpwYVJZOGcrREFL?= =?utf-8?B?Skl4U1RFUUlZbWVvYnJGSVNncWZIWjlDQmNOSXJhb0VMUWhSSHJhMVlpb2hP?= =?utf-8?B?NS80N2drWXpYQ21HVnAzS2hnTnZOblBVb1BtOE9vVENDSERLNkJGcU9RZHkx?= =?utf-8?B?WDk5MnZQUXRJdHcvT1Z2TmNxRENHVGtzMGNiU1htUUkrTEJxblh6QXpJS2Mx?= =?utf-8?B?THhEek0zM2xVWVJESDRhNDFXTUtrajhqQWwwaGVucldqWmdLMkxYUEN1ZUhI?= =?utf-8?B?cVZObFBFRjdUcUhablVkOElYMXkyTFd4NVMvS3NBN2EyVjR2WUthOFdCVzJr?= =?utf-8?B?Z2ZUOVBmTyt3RStOSlJhclkyRVFjREtjTkpzR0xMY0ZGU0VraWNSKzJtUzNS?= =?utf-8?B?RTVsN1dRYnFMMnlsYUNpd2hsMGhaTTNxQVlEV0Z3RmM1OTJJbzJPRmR0Mm9R?= =?utf-8?B?aUtFOFVJVjZPZElkRk4yWGcrWjZuNGtUdnhjOFpJZ04yNWQxaGdsamN0M1Rw?= =?utf-8?B?TGc5YWExdElLb0tsTnlRdGxHM1BhSjB5ZW5id0lwLzlLSGNHMVBaZjk0bXJN?= =?utf-8?B?a1JFbDlkemR6S3ppcSttT2dYOFlselJWZ1RLVGZkeEZlVWp3bG5KSnFtbWkw?= =?utf-8?B?aS9nV2VQd3dqcUxodzF1ekJBbTlDQXU0SXcvL25WUnBSMDhaNm8xanV4Nlcr?= =?utf-8?B?Q0FlZ0hOYm1yTFhwSVF1dHhiZXJ1NHNXRlliOWNlZjM1VUhrWlI3Wm5qRHpD?= =?utf-8?B?ZjU5dW84UWNUZXJXUWVQWmZEbXlJYllHbWVWL2tjdlN1MGt0ekwyMnVyZWxV?= =?utf-8?B?VjM4VzJmc2NxUy9NTWdINDIrL0RyVVI2ZHpndGJWWW5PaDdkSmhTUTBzbDJZ?= =?utf-8?B?MFJFUndqVEhrTDhjUUFiVDUwbkpIM3cvMXBhWWRNNzRXWXJJODc0Slc4eFVq?= =?utf-8?B?bDF2TXk2Z1hsQ1BsaUxRT1A4OFJJWlo2TG1OanBJaC8yeU1NelFCOU1SK2VT?= =?utf-8?B?RXE4THp0bGx0YVZTQmtPYy9BZFEzSWowWnhpbFgxMHFyU29odE1pd1BOTmMy?= =?utf-8?B?S3UwZWxyN0FzblNIdHp5SnpjaER2N3o0eXVQR2F0WTRpRWx6N0QyMVRUVVVv?= =?utf-8?B?QUd2M01DcUs5N29OZ3hjWmY1aWN5b21tQzJwZjZkekliU01WUDFBTjQyMzNS?= =?utf-8?B?cmZLcUtoenBWUWY2a0QxVGpweVp3MWY2WExmcnd1K01UWmxPOUZmeTZzQ1Ey?= =?utf-8?B?ZnBPdDhDNWcyTFlBV3dCTzhCOVB6MCszeVdIejJlY2xCUkk1V2szZTRHdXJl?= =?utf-8?B?NFpCTjBzY0k3N0xOSVI4eTV2OXNhTDhqZ2RzUGp6NWR1VHhlQVBWMlo1SWZF?= =?utf-8?B?ckpXOVVsN2diK0w0OHY2MlRTVlp0cW9DQllSTEZTTFBjMEpBRi83bFN1LzQ2?= =?utf-8?B?TTJJZ3E3bGw0ajZwSkhwdGN5YTdzcVRmYXV4MlFydFpha3YrMnpKa3hxYkdE?= =?utf-8?B?VlBXbitWb3lqUnVTUzdTRzRGNG1oZCtPRVg5Mkg1SERpTkRFUFhEZFk5U0lK?= =?utf-8?B?OS9tL1NsdHZwTkg5bDhPdE5HUUJSWlFNOWxSTUhDK0ZRQ0JrQWQvS0Y1eFZu?= =?utf-8?B?QWxWVWNBVGVzNzdwcFozQThiY2M0RnlndlBzVnNvRXpvYmFJS3djRTd3eGp2?= =?utf-8?B?b3Bja0JHdUppSGJjSTRNQllGTmlzTThaMkJHbnJSaFNsVUFacno4STlHRUU5?= =?utf-8?B?OGxxckZhZkhZVUl3MElRNFlCZGpQTmJveWtxc2F4aE52SVRTYmVLYUNoQ3Jt?= =?utf-8?B?WldzQzBFS2djaG5YVnRSRk81bWZqVmI3UXRKc0dzc1A3QXRGdmtnQ3R5Z1Iv?= =?utf-8?B?RkxwY01pT21NcVF1bnRPRG5OR0UvSzdwL3ZNVkUwRTliYnRLdDMyUXFacURW?= =?utf-8?B?UG5ZTVFOQ04wbXk5enFjd2s3NDZSSndrMklKQW1CTEdkM1RIRGNuUm0yZU1V?= =?utf-8?Q?fYwU=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 21eacb3b-8bd6-4b62-a007-08dc47669c17 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3849.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2024 16:15:21.2007 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ptvgPTtAQp9uxgSCr5rnubGdY/jszhNphhnpNM1hGNKovsx6qNC1ywe+pYvIhi6b X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8331 On Thu, Mar 14, 2024 at 01:11:59PM +0000, Christophe Leroy wrote: > > > Le 14/03/2024 à 13:53, Peter Xu a écrit : > > On Thu, Mar 14, 2024 at 08:45:34AM +0000, Christophe Leroy wrote: > >> > >> > >> Le 13/03/2024 à 22:47, peterx@redhat.com a écrit : > >>> From: Peter Xu > >>> > >>> PowerPC book3s 4K mostly has the same definition on both, except pXd_huge() > >>> constantly returns 0 for hash MMUs. As Michael Ellerman pointed out [1], > >>> it is safe to check _PAGE_PTE on hash MMUs, as the bit will never be set so > >>> it will keep returning false. > >>> > >>> As a reference, __p[mu]d_mkhuge() will trigger a BUG_ON trying to create > >>> such huge mappings for 4K hash MMUs. Meanwhile, the major powerpc hugetlb > >>> pgtable walker __find_linux_pte() already used pXd_leaf() to check hugetlb > >>> mappings. > >>> > >>> The goal should be that we will have one API pXd_leaf() to detect all kinds > >>> of huge mappings. AFAICT we need to use the pXd_leaf() impl (rather than > >>> pXd_huge() ones) to make sure ie. THPs on hash MMU will also return true. > >> > >> All kinds of huge mappings ? > >> > >> pXd_leaf() will detect only leaf mappings (like pXd_huge() ). There are > >> also huge mappings through hugepd. On powerpc 8xx we have 8M huge pages > >> and 512k huge pages. A PGD entry covers 4M so pgd_leaf() won't report > >> those huge pages. > > > > Ah yes, I should always mention this is in the context of leaf huge pages > > only. Are the examples you provided all fall into hugepd category? If so > > I can reword the commit message, as: > > On powerpc 8xx, only the 8M huge pages fall into the hugepd case. > > The 512k hugepages are at PTE level, they are handled more or less like > CONT_PTE on ARM. see function set_huge_pte_at() for more context. > > You can also look at pte_leaf_size() and pgd_leaf_size(). IMHO leaf should return false if the thing is pointing to a next level page table, even if that next level is fully populated with contiguous pages. This seems more aligned with the contig page direction that hugepd should be moved over to.. > By the way pgd_leaf_size() looks odd because it is called only when > pgd_leaf_size() returns true, which never happens for 8M pages. Like this, you should reach the actual final leaf that the HW will load and leaf_size() should say it is greater size than the current table level. Other levels should return 0. If necessary the core MM code should deal with this by iterating over adjacent tables. Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 27D40C54E58 for ; Mon, 18 Mar 2024 16:15:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZsZZa5GSrLQQYHezCWoh/6CH58sBiRgyCDmx7+65EdI=; b=GNtl5hafis+APO mL48KUMR+G8Q8o03+elsrUyNEdXjvJfiRsbfX7COU0Y6iLwIsfd4teDoUMUzYF5YDskg1hsllkbsj vsmE46yta/i1jB2D3YrQX0y8FN3tTPFJ16Vkyu3pFxLP0ZALeaw9JgfjoTwm4MVUzkcou35u+vRtl TUIvG69r62nRetau/kyhyPtEIyzUDV8jzJAKKGLUfUbgtGPmHo3bxBny3kUjxFkLRGCmdFgpPSbPe J57lhpdkocDHqTiN8w5qeNGsnEVzwoJoy/fzkvsLB1N7bdkfxUV1h1RgVaTxufR1kGYbBHxp/6HW4 249iaxA94Rdxc6sT4jPA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmFeC-00000009BLj-244V; Mon, 18 Mar 2024 16:15:36 +0000 Received: from mail-mw2nam04on20601.outbound.protection.outlook.com ([2a01:111:f403:240a::601] helo=NAM04-MW2-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmFe8-00000009BHs-2asR for linux-arm-kernel@lists.infradead.org; Mon, 18 Mar 2024 16:15:33 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e+CcdGzsnTq72yJAOE+f8Me64HjGti6A26PWbOMrP9LABVfDZd5KReGe/kTpZ1XR/0AtN1nfXox3rlh3cvZtbrYpfKLKPBrgjSKAM/jb+9n/wZazTNXs9m4dpfGNRIX0TEkmVsmY6fz/dFd0n8IvSrWz9q363qOXaqq0VhOPqVG+3nRmTn9WzIe3gQPBiY/IOP7O/oCgsf7wGKzw1xvFPpGRgKCaT97ei1AIjBH3W7ktfh7pign0vjWX0xYLmWwYBT5W49GMgE74PaSNoC+4UuQJzZFKUulPc8NaryvfBTi7QHw+UmZZgNji6vjjz4XyVkh9WNahxGnju+n3uQStUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dlv9s2X6IUZXoWRPusJ/nMrZ6cYw3m45dbmZorYVX7Y=; b=dEsp+C/289gGr6movhZhmTpf5fAFa3IVXYDdL7+OGeCNrSY62JV3JmuJv7AQT33mzSikZgaDEYgX6HYzMsn9MRHhGJnqlgX4sVbaQBASZUjVUABBHA+dwKJLwCUEhrIK2jxXJl69bqoFMG5+btyksOkKCi4SR8R1SgNRUpkdFhcPEDBXyxYwfs+6K8jLwzqz5PWJh9DY+1sgeoQbfeKceUMHMrDydmUdlXEPqVu5gX5iz9NQUWAnU4p+jKJpWGXz/o2ANXNBv8DXd9S6NLpJRRTiz+qb9RXcax9RupgqaRvtzQ1mY+r85mKUfUNnJb3h8mef/S8zMAGMxrME35OuVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dlv9s2X6IUZXoWRPusJ/nMrZ6cYw3m45dbmZorYVX7Y=; b=QzZuBY7hXHCOR8706MkWbH1fDoSq2MN/Ob7GM/NjS74eXtzpITp3CC9bmX3IGr9mNw93+0Tyi8JlwgkOwCiwsDiSyMl0P5M1J4u5gAR0QAz6xdw74EFoUP13hFo7j6Fm5DEw4DtsMTIW+qTU3sQWTzzR3vDmXqzx5O1beJAkwl1GQS8Afujp1LXSzeo92aXztc8WxD0Uo3CfPZcGB6YIjVaRUSDm27pPZJRO7LJkUJCIJZY07leuZ2RiJcnpFQPZ+rAEgq81xxYP8Ksu6AGDir/sAZPBuFtCXyJoB1lZIaRruUU6ksq0rhtN8vHJ9VqO5s+iXPTHZyF9qC0QvJwIIA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DM6PR12MB3849.namprd12.prod.outlook.com (2603:10b6:5:1c7::26) by CH3PR12MB8331.namprd12.prod.outlook.com (2603:10b6:610:12f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.26; Mon, 18 Mar 2024 16:15:21 +0000 Received: from DM6PR12MB3849.namprd12.prod.outlook.com ([fe80::6aec:dbca:a593:a222]) by DM6PR12MB3849.namprd12.prod.outlook.com ([fe80::6aec:dbca:a593:a222%5]) with mapi id 15.20.7386.025; Mon, 18 Mar 2024 16:15:21 +0000 Date: Mon, 18 Mar 2024 13:15:19 -0300 From: Jason Gunthorpe To: Christophe Leroy Cc: Peter Xu , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "linux-arm-kernel@lists.infradead.org" , Matthew Wilcox , "linuxppc-dev@lists.ozlabs.org" , Andrew Morton , "x86@kernel.org" , Mike Rapoport , Muchun Song , "sparclinux@vger.kernel.org" , Michael Ellerman , Nicholas Piggin , "Aneesh Kumar K.V" , "Naveen N. Rao" Subject: Re: [PATCH 09/13] mm/powerpc: Redefine pXd_huge() with pXd_leaf() Message-ID: <20240318161519.GA5825@nvidia.com> References: <20240313214719.253873-1-peterx@redhat.com> <20240313214719.253873-10-peterx@redhat.com> <7b7d6ce1-4a3f-4392-951d-a9bd146c954c@csgroup.eu> <1f6ad500-3ff7-44d4-8223-067bd2ed9ffe@csgroup.eu> Content-Disposition: inline In-Reply-To: <1f6ad500-3ff7-44d4-8223-067bd2ed9ffe@csgroup.eu> X-ClientProxiedBy: SA9PR13CA0141.namprd13.prod.outlook.com (2603:10b6:806:27::26) To DM6PR12MB3849.namprd12.prod.outlook.com (2603:10b6:5:1c7::26) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB3849:EE_|CH3PR12MB8331:EE_ X-MS-Office365-Filtering-Correlation-Id: 21eacb3b-8bd6-4b62-a007-08dc47669c17 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VeKXYvAoK6iWXmAcXLaQEH4lPt94aqq5ovoSX7V3j15TdBEc7W4CWTVb4GuQrIsYtcEn2mr8Y031SJcq0lDu6/8ciSsxpyRcnYGNyPe5HuoXyea7ddZlen3EnoV+xkxHAMeLbZc+sUFV3X7YIAxpv8yNywKaXKDpucWj49i3yGvn4Rmc8QOenBXgMulnvoxda/8Q4rX+V+eliOpyIVoqKF5jeWwIev8VxDgxNPW/XPEDS9xAvC28QBdb5gImHjBjbRSm3MSq7FymDuEGdc51Hrsczy7FTDrQ8s77Tm2DUvQ5YrhEyQ7Q5LZpH1K2cM6u1XxEWmoQJRjtflJFMogrMDAiq+h43g+TovnTPRxVBpKQ7JwmUpYgRZSYeVhkBN4zHpJAmqZsqooTuupFc2zfdLi93rV+EuQUa8v2xBK0s7CuE/OdNz1eUNWYySCi3HcTOQWy8lrJut1qCU8cssJS9DfHGiSfbvnNriv6rgZr+RFKplNXdC+NaK/C+TdoLPgn/kEG1pJ4dmCRkDpd26wwyjPvbX1jihoLvtNQ7nu1pAdnRY79lgcpPsZShhzWjVoY35wbGf6xDeJTwrYYNppqvAHARxi7+r4GitMqw8oQ3d6aNDXWWCQF6uUekUvbnNzT7d7t0IzW2KOQstVWUVwyEXm/qADHXC1ekb/Uk6/oM6Q= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB3849.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(366007)(1800799015)(7416005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bHhHUWZoQllXU0VoeTFmTE9SZkdIbU96VFpLSHdrSFJJd0s1blBzMFZ5NExp?= =?utf-8?B?dG01RGwzOEN3Y1Ztck9ScjZnaUpKYXJkSjFjcFlBdkhCUzNwc2MwTXRGcWcr?= =?utf-8?B?MmhzdWNQcUp6WFd6Wi82MWZRV3V4YjBERUJqdHdvWUlRNlpwYVJZOGcrREFL?= =?utf-8?B?Skl4U1RFUUlZbWVvYnJGSVNncWZIWjlDQmNOSXJhb0VMUWhSSHJhMVlpb2hP?= =?utf-8?B?NS80N2drWXpYQ21HVnAzS2hnTnZOblBVb1BtOE9vVENDSERLNkJGcU9RZHkx?= =?utf-8?B?WDk5MnZQUXRJdHcvT1Z2TmNxRENHVGtzMGNiU1htUUkrTEJxblh6QXpJS2Mx?= =?utf-8?B?THhEek0zM2xVWVJESDRhNDFXTUtrajhqQWwwaGVucldqWmdLMkxYUEN1ZUhI?= =?utf-8?B?cVZObFBFRjdUcUhablVkOElYMXkyTFd4NVMvS3NBN2EyVjR2WUthOFdCVzJr?= =?utf-8?B?Z2ZUOVBmTyt3RStOSlJhclkyRVFjREtjTkpzR0xMY0ZGU0VraWNSKzJtUzNS?= =?utf-8?B?RTVsN1dRYnFMMnlsYUNpd2hsMGhaTTNxQVlEV0Z3RmM1OTJJbzJPRmR0Mm9R?= =?utf-8?B?aUtFOFVJVjZPZElkRk4yWGcrWjZuNGtUdnhjOFpJZ04yNWQxaGdsamN0M1Rw?= =?utf-8?B?TGc5YWExdElLb0tsTnlRdGxHM1BhSjB5ZW5id0lwLzlLSGNHMVBaZjk0bXJN?= =?utf-8?B?a1JFbDlkemR6S3ppcSttT2dYOFlselJWZ1RLVGZkeEZlVWp3bG5KSnFtbWkw?= =?utf-8?B?aS9nV2VQd3dqcUxodzF1ekJBbTlDQXU0SXcvL25WUnBSMDhaNm8xanV4Nlcr?= =?utf-8?B?Q0FlZ0hOYm1yTFhwSVF1dHhiZXJ1NHNXRlliOWNlZjM1VUhrWlI3Wm5qRHpD?= =?utf-8?B?ZjU5dW84UWNUZXJXUWVQWmZEbXlJYllHbWVWL2tjdlN1MGt0ekwyMnVyZWxV?= =?utf-8?B?VjM4VzJmc2NxUy9NTWdINDIrL0RyVVI2ZHpndGJWWW5PaDdkSmhTUTBzbDJZ?= =?utf-8?B?MFJFUndqVEhrTDhjUUFiVDUwbkpIM3cvMXBhWWRNNzRXWXJJODc0Slc4eFVq?= =?utf-8?B?bDF2TXk2Z1hsQ1BsaUxRT1A4OFJJWlo2TG1OanBJaC8yeU1NelFCOU1SK2VT?= =?utf-8?B?RXE4THp0bGx0YVZTQmtPYy9BZFEzSWowWnhpbFgxMHFyU29odE1pd1BOTmMy?= =?utf-8?B?S3UwZWxyN0FzblNIdHp5SnpjaER2N3o0eXVQR2F0WTRpRWx6N0QyMVRUVVVv?= =?utf-8?B?QUd2M01DcUs5N29OZ3hjWmY1aWN5b21tQzJwZjZkekliU01WUDFBTjQyMzNS?= =?utf-8?B?cmZLcUtoenBWUWY2a0QxVGpweVp3MWY2WExmcnd1K01UWmxPOUZmeTZzQ1Ey?= =?utf-8?B?ZnBPdDhDNWcyTFlBV3dCTzhCOVB6MCszeVdIejJlY2xCUkk1V2szZTRHdXJl?= =?utf-8?B?NFpCTjBzY0k3N0xOSVI4eTV2OXNhTDhqZ2RzUGp6NWR1VHhlQVBWMlo1SWZF?= =?utf-8?B?ckpXOVVsN2diK0w0OHY2MlRTVlp0cW9DQllSTEZTTFBjMEpBRi83bFN1LzQ2?= =?utf-8?B?TTJJZ3E3bGw0ajZwSkhwdGN5YTdzcVRmYXV4MlFydFpha3YrMnpKa3hxYkdE?= =?utf-8?B?VlBXbitWb3lqUnVTUzdTRzRGNG1oZCtPRVg5Mkg1SERpTkRFUFhEZFk5U0lK?= =?utf-8?B?OS9tL1NsdHZwTkg5bDhPdE5HUUJSWlFNOWxSTUhDK0ZRQ0JrQWQvS0Y1eFZu?= =?utf-8?B?QWxWVWNBVGVzNzdwcFozQThiY2M0RnlndlBzVnNvRXpvYmFJS3djRTd3eGp2?= =?utf-8?B?b3Bja0JHdUppSGJjSTRNQllGTmlzTThaMkJHbnJSaFNsVUFacno4STlHRUU5?= =?utf-8?B?OGxxckZhZkhZVUl3MElRNFlCZGpQTmJveWtxc2F4aE52SVRTYmVLYUNoQ3Jt?= =?utf-8?B?WldzQzBFS2djaG5YVnRSRk81bWZqVmI3UXRKc0dzc1A3QXRGdmtnQ3R5Z1Iv?= =?utf-8?B?RkxwY01pT21NcVF1bnRPRG5OR0UvSzdwL3ZNVkUwRTliYnRLdDMyUXFacURW?= =?utf-8?B?UG5ZTVFOQ04wbXk5enFjd2s3NDZSSndrMklKQW1CTEdkM1RIRGNuUm0yZU1V?= =?utf-8?Q?fYwU=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 21eacb3b-8bd6-4b62-a007-08dc47669c17 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3849.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2024 16:15:21.2007 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ptvgPTtAQp9uxgSCr5rnubGdY/jszhNphhnpNM1hGNKovsx6qNC1ywe+pYvIhi6b X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8331 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240318_091532_672482_87B13BA4 X-CRM114-Status: GOOD ( 20.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBNYXIgMTQsIDIwMjQgYXQgMDE6MTE6NTlQTSArMDAwMCwgQ2hyaXN0b3BoZSBMZXJv eSB3cm90ZToKPiAKPiAKPiBMZSAxNC8wMy8yMDI0IMOgIDEzOjUzLCBQZXRlciBYdSBhIMOpY3Jp dMKgOgo+ID4gT24gVGh1LCBNYXIgMTQsIDIwMjQgYXQgMDg6NDU6MzRBTSArMDAwMCwgQ2hyaXN0 b3BoZSBMZXJveSB3cm90ZToKPiA+Pgo+ID4+Cj4gPj4gTGUgMTMvMDMvMjAyNCDDoCAyMjo0Nywg cGV0ZXJ4QHJlZGhhdC5jb20gYSDDqWNyaXTCoDoKPiA+Pj4gRnJvbTogUGV0ZXIgWHUgPHBldGVy eEByZWRoYXQuY29tPgo+ID4+Pgo+ID4+PiBQb3dlclBDIGJvb2szcyA0SyBtb3N0bHkgaGFzIHRo ZSBzYW1lIGRlZmluaXRpb24gb24gYm90aCwgZXhjZXB0IHBYZF9odWdlKCkKPiA+Pj4gY29uc3Rh bnRseSByZXR1cm5zIDAgZm9yIGhhc2ggTU1Vcy4gIEFzIE1pY2hhZWwgRWxsZXJtYW4gcG9pbnRl ZCBvdXQgWzFdLAo+ID4+PiBpdCBpcyBzYWZlIHRvIGNoZWNrIF9QQUdFX1BURSBvbiBoYXNoIE1N VXMsIGFzIHRoZSBiaXQgd2lsbCBuZXZlciBiZSBzZXQgc28KPiA+Pj4gaXQgd2lsbCBrZWVwIHJl dHVybmluZyBmYWxzZS4KPiA+Pj4KPiA+Pj4gQXMgYSByZWZlcmVuY2UsIF9fcFttdV1kX21raHVn ZSgpIHdpbGwgdHJpZ2dlciBhIEJVR19PTiB0cnlpbmcgdG8gY3JlYXRlCj4gPj4+IHN1Y2ggaHVn ZSBtYXBwaW5ncyBmb3IgNEsgaGFzaCBNTVVzLiAgTWVhbndoaWxlLCB0aGUgbWFqb3IgcG93ZXJw YyBodWdldGxiCj4gPj4+IHBndGFibGUgd2Fsa2VyIF9fZmluZF9saW51eF9wdGUoKSBhbHJlYWR5 IHVzZWQgcFhkX2xlYWYoKSB0byBjaGVjayBodWdldGxiCj4gPj4+IG1hcHBpbmdzLgo+ID4+Pgo+ ID4+PiBUaGUgZ29hbCBzaG91bGQgYmUgdGhhdCB3ZSB3aWxsIGhhdmUgb25lIEFQSSBwWGRfbGVh ZigpIHRvIGRldGVjdCBhbGwga2luZHMKPiA+Pj4gb2YgaHVnZSBtYXBwaW5ncy4gIEFGQUlDVCB3 ZSBuZWVkIHRvIHVzZSB0aGUgcFhkX2xlYWYoKSBpbXBsIChyYXRoZXIgdGhhbgo+ID4+PiBwWGRf aHVnZSgpIG9uZXMpIHRvIG1ha2Ugc3VyZSBpZS4gVEhQcyBvbiBoYXNoIE1NVSB3aWxsIGFsc28g cmV0dXJuIHRydWUuCj4gPj4KPiA+PiBBbGwga2luZHMgb2YgaHVnZSBtYXBwaW5ncyA/Cj4gPj4K PiA+PiBwWGRfbGVhZigpIHdpbGwgZGV0ZWN0IG9ubHkgbGVhZiBtYXBwaW5ncyAobGlrZSBwWGRf aHVnZSgpICkuIFRoZXJlIGFyZQo+ID4+IGFsc28gaHVnZSBtYXBwaW5ncyB0aHJvdWdoIGh1Z2Vw ZC4gT24gcG93ZXJwYyA4eHggd2UgaGF2ZSA4TSBodWdlIHBhZ2VzCj4gPj4gYW5kIDUxMmsgaHVn ZSBwYWdlcy4gQSBQR0QgZW50cnkgY292ZXJzIDRNIHNvIHBnZF9sZWFmKCkgd29uJ3QgcmVwb3J0 Cj4gPj4gdGhvc2UgaHVnZSBwYWdlcy4KPiA+IAo+ID4gQWggeWVzLCBJIHNob3VsZCBhbHdheXMg bWVudGlvbiB0aGlzIGlzIGluIHRoZSBjb250ZXh0IG9mIGxlYWYgaHVnZSBwYWdlcwo+ID4gb25s eS4gIEFyZSB0aGUgZXhhbXBsZXMgeW91IHByb3ZpZGVkIGFsbCBmYWxsIGludG8gaHVnZXBkIGNh dGVnb3J5PyAgSWYgc28KPiA+IEkgY2FuIHJld29yZCB0aGUgY29tbWl0IG1lc3NhZ2UsIGFzOgo+ IAo+IE9uIHBvd2VycGMgOHh4LCBvbmx5IHRoZSA4TSBodWdlIHBhZ2VzIGZhbGwgaW50byB0aGUg aHVnZXBkIGNhc2UuCj4gCj4gVGhlIDUxMmsgaHVnZXBhZ2VzIGFyZSBhdCBQVEUgbGV2ZWwsIHRo ZXkgYXJlIGhhbmRsZWQgbW9yZSBvciBsZXNzIGxpa2UgCj4gQ09OVF9QVEUgb24gQVJNLiBzZWUg ZnVuY3Rpb24gc2V0X2h1Z2VfcHRlX2F0KCkgZm9yIG1vcmUgY29udGV4dC4KPiAKPiBZb3UgY2Fu IGFsc28gbG9vayBhdCBwdGVfbGVhZl9zaXplKCkgYW5kIHBnZF9sZWFmX3NpemUoKS4KCklNSE8g bGVhZiBzaG91bGQgcmV0dXJuIGZhbHNlIGlmIHRoZSB0aGluZyBpcyBwb2ludGluZyB0byBhIG5l eHQgbGV2ZWwKcGFnZSB0YWJsZSwgZXZlbiBpZiB0aGF0IG5leHQgbGV2ZWwgaXMgZnVsbHkgcG9w dWxhdGVkIHdpdGggY29udGlndW91cwpwYWdlcy4KClRoaXMgc2VlbXMgbW9yZSBhbGlnbmVkIHdp dGggdGhlIGNvbnRpZyBwYWdlIGRpcmVjdGlvbiB0aGF0IGh1Z2VwZApzaG91bGQgYmUgbW92ZWQg b3ZlciB0by4uCgo+IEJ5IHRoZSB3YXkgcGdkX2xlYWZfc2l6ZSgpIGxvb2tzIG9kZCBiZWNhdXNl IGl0IGlzIGNhbGxlZCBvbmx5IHdoZW4gCj4gcGdkX2xlYWZfc2l6ZSgpIHJldHVybnMgdHJ1ZSwg d2hpY2ggbmV2ZXIgaGFwcGVucyBmb3IgOE0gcGFnZXMuCgpMaWtlIHRoaXMsIHlvdSBzaG91bGQg cmVhY2ggdGhlIGFjdHVhbCBmaW5hbCBsZWFmIHRoYXQgdGhlIEhXIHdpbGwKbG9hZCBhbmQgbGVh Zl9zaXplKCkgc2hvdWxkIHNheSBpdCBpcyBncmVhdGVyIHNpemUgdGhhbiB0aGUgY3VycmVudAp0 YWJsZSBsZXZlbC4gT3RoZXIgbGV2ZWxzIHNob3VsZCByZXR1cm4gMC4KCklmIG5lY2Vzc2FyeSB0 aGUgY29yZSBNTSBjb2RlIHNob3VsZCBkZWFsIHdpdGggdGhpcyBieSBpdGVyYXRpbmcgb3Zlcgph ZGphY2VudCB0YWJsZXMuCgpKYXNvbgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtl cm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt YW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=