From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 70EACC54E58 for ; Mon, 18 Mar 2024 20:02:27 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 1638160830; Mon, 18 Mar 2024 20:02:27 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id t6AqpCItaTVX; Mon, 18 Mar 2024 20:02:26 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 68335607E0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1710792146; bh=4Nif+R+uIeAEicEQtBLuFIAt04fj4KzhHhsjSDA4fK8=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=dAmmsFFDvsdqF2MyxbwosG07nRinjGPV4I+ItJVstkHe5VgM7DOXSlniAUTSEMAsd sUm+CrfBSafCKvS/h12RnW16XUTkoMUA0DWmE7g8X5NMPF9O1QTi3zLAYROpng2Hbm Gh5LUMD8AxxA0N2HF54si8/aUAd7i3IM5WRnVoCiFsZI8orBMMouyx1YwtlYORg6En MJBqv6yNt86+1VkxQtmIEHqg1SEI2XpPrXtbVs9Sq3axKXnnXM/uQ9pB6QzOAPwdiu wPs3qB39LNo+k/qMcyNO18rbYe1lz6NPeI5gVHGROc6amql+B0cRWDQGEVgUkoSLTO LeWvXoP0iH+MQ== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 68335607E0; Mon, 18 Mar 2024 20:02:26 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 1CFEA1BF2C1 for ; Mon, 18 Mar 2024 20:02:25 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 0830581452 for ; Mon, 18 Mar 2024 20:02:25 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qU7EJBuZJ2Vt for ; Mon, 18 Mar 2024 20:02:24 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org 66F9A8144A DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 66F9A8144A Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by smtp1.osuosl.org (Postfix) with ESMTPS id 66F9A8144A for ; Mon, 18 Mar 2024 20:02:24 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id ECD9560D2B; Mon, 18 Mar 2024 20:02:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4DEC5C43390; Mon, 18 Mar 2024 20:02:20 +0000 (UTC) Date: Mon, 18 Mar 2024 20:02:18 +0000 From: Simon Horman To: Mateusz Polchlopek Message-ID: <20240318200218.GB185808@kernel.org> References: <20240308113919.11787-1-mateusz.polchlopek@intel.com> <20240308113919.11787-2-mateusz.polchlopek@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240308113919.11787-2-mateusz.polchlopek@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710792142; bh=4M30qJs3MhfwH6o1pNlm9jq/i1wEFxv2FMm/CPETW/k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kORWP9pQFM9AzKD5QcuSi8LIAmHK/Tr0ixrLcuhvlOiIgnPM/VTnimS8udP1Ec5qp +HCa/Lyi/cSr4yQb3I2WsHxPtpt4CoGXOQ5p2BpvB+4amJy87ADb+x6O/YD+mvCnv4 oYrs0epOAYLhBhuh0cG3eBBfgEt9ASB4KV4BYqTXeFSM37hooYFvis2jNZwFPQJsfJ 2yNzVCAob5xofUoFcoBrgaDhaX07vw+1IocZe5zc+GRTAxFSY/Nr+76Unoha8R783k 3SZGawFEEgdF/Je2xJ0rBb1vpp4w7bOniPxUYUTbU9te1wfx2wcG1mTHzQahDLDnh6 xHZAGszKndZbg== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=none dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=kORWP9pQ Subject: Re: [Intel-wired-lan] [PATCH iwl-next v7 1/6] devlink: extend devlink_param *set pointer X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: andrew@lunn.ch, jiri@resnulli.us, michal.wilczynski@intel.com, netdev@vger.kernel.org, lukasz.czapnik@intel.com, victor.raj@intel.com, kuba@kernel.org, anthony.l.nguyen@intel.com, Jiri Pirko , przemyslaw.kitszel@intel.com, intel-wired-lan@lists.osuosl.org Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Fri, Mar 08, 2024 at 06:39:14AM -0500, Mateusz Polchlopek wrote: > Extend devlink_param *set function pointer to take extack as a param. > Sometimes it is needed to pass information to the end user from set > function. It is more proper to use for that netlink instead of passing > message to dmesg. > > Reviewed-by: Jiri Pirko > Signed-off-by: Mateusz Polchlopek Hi Mateusz, FWIIW, I think there are several (new?) users of this callback present in net-next now which will also need to be updated. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19F7059B5B for ; Mon, 18 Mar 2024 20:02:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710792143; cv=none; b=eyfz6F8RCsYttpm68cpkyBuu2j29Hy9WbQWBV3i0wGCbzHQRSKD5TIIEvfwWZkyXO/xyjaUQ/V/zQ90nSRaueEdOtjJNYWtxM03ptNcJP0FsVYN6XHQaGbtfvKdb+nbC+BrklrMIS0j+G429F5jcJ752Kk0BiG+PS4MXoWriiuo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710792143; c=relaxed/simple; bh=4M30qJs3MhfwH6o1pNlm9jq/i1wEFxv2FMm/CPETW/k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Vz7ll966g4rJiUdFIk72KaCfBRwPgYA+JKZIC/dOn1qIIrmM2mw1KO/ox9ulTs8th2ZIFVoZI/g44BQQWiSwVaR5yOXMSalNTr4Vkh58qsH8CTvt5AFLopVLi1g5nIxWQTnYmOYpFb8i5EE5nnD4xCXvyPbiCFzjnzIJoahAdB4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kORWP9pQ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kORWP9pQ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4DEC5C43390; Mon, 18 Mar 2024 20:02:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710792142; bh=4M30qJs3MhfwH6o1pNlm9jq/i1wEFxv2FMm/CPETW/k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kORWP9pQFM9AzKD5QcuSi8LIAmHK/Tr0ixrLcuhvlOiIgnPM/VTnimS8udP1Ec5qp +HCa/Lyi/cSr4yQb3I2WsHxPtpt4CoGXOQ5p2BpvB+4amJy87ADb+x6O/YD+mvCnv4 oYrs0epOAYLhBhuh0cG3eBBfgEt9ASB4KV4BYqTXeFSM37hooYFvis2jNZwFPQJsfJ 2yNzVCAob5xofUoFcoBrgaDhaX07vw+1IocZe5zc+GRTAxFSY/Nr+76Unoha8R783k 3SZGawFEEgdF/Je2xJ0rBb1vpp4w7bOniPxUYUTbU9te1wfx2wcG1mTHzQahDLDnh6 xHZAGszKndZbg== Date: Mon, 18 Mar 2024 20:02:18 +0000 From: Simon Horman To: Mateusz Polchlopek Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, anthony.l.nguyen@intel.com, kuba@kernel.org, jiri@resnulli.us, przemyslaw.kitszel@intel.com, andrew@lunn.ch, victor.raj@intel.com, michal.wilczynski@intel.com, lukasz.czapnik@intel.com, Jiri Pirko Subject: Re: [Intel-wired-lan] [PATCH iwl-next v7 1/6] devlink: extend devlink_param *set pointer Message-ID: <20240318200218.GB185808@kernel.org> References: <20240308113919.11787-1-mateusz.polchlopek@intel.com> <20240308113919.11787-2-mateusz.polchlopek@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240308113919.11787-2-mateusz.polchlopek@intel.com> On Fri, Mar 08, 2024 at 06:39:14AM -0500, Mateusz Polchlopek wrote: > Extend devlink_param *set function pointer to take extack as a param. > Sometimes it is needed to pass information to the end user from set > function. It is more proper to use for that netlink instead of passing > message to dmesg. > > Reviewed-by: Jiri Pirko > Signed-off-by: Mateusz Polchlopek Hi Mateusz, FWIIW, I think there are several (new?) users of this callback present in net-next now which will also need to be updated.