From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manojkiran Eda Date: Tue, 19 Mar 2024 09:35:25 -0000 Subject: [PATCH v2 0/4] Add eSPI device driver (flash channel) Message-ID: <20240319093405.39833-1-manojkiran.eda@gmail.com> List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hello everyone, I'm presenting a revised version of the eSPI device driver patch series found at the following link: https://lore.kernel.org/openbmc/20220516005412.4844-1-chiawei_wang at aspeedtech.com/ This update addresses the issues identified during the review process. While the previous patch series attempted to incorporate support for all four different channels of eSPI using the ioctl interface , this new series focuses on upstreaming the flash channel (using the mtd interface) initially, ensuring that all review comments are duly addressed, before progressing further. Diff between PACTH v1-v2: 1. The commit is split into multiple commits as per the review comments. 2. Explicity renamed the driver to indicate that it only support master attached flash storage (mafs). 3. Added new kconfig options to enable/disable eSPI mafs support. Results: Successfully conducted a flash update via eSPI. Manojkiran Eda (4): Add eSPI device driver (flash channel) mtd: Replace module_init with subsys_initcall ARM: dts: aspeed: Add eSPI node dt-bindings: aspeed: Add eSPI controller .../bindings/soc/aspeed/aspeed,espi.yaml | 94 ++++ arch/arm/boot/dts/aspeed/aspeed-g5.dtsi | 19 + arch/arm/boot/dts/aspeed/aspeed-g6.dtsi | 20 + drivers/mtd/mtdcore.c | 2 +- drivers/soc/aspeed/Kconfig | 38 ++ drivers/soc/aspeed/Makefile | 2 + drivers/soc/aspeed/aspeed-espi-ctrl.c | 197 ++++++++ drivers/soc/aspeed/aspeed-espi-ctrl.h | 169 +++++++ drivers/soc/aspeed/aspeed-espi-flash-mafs.c | 467 ++++++++++++++++++ drivers/soc/aspeed/aspeed-espi-flash.h | 71 +++ 10 files changed, 1078 insertions(+), 1 deletion(-) create mode 100644 Documentation/devicetree/bindings/soc/aspeed/aspeed,espi.yaml create mode 100644 drivers/soc/aspeed/aspeed-espi-ctrl.c create mode 100644 drivers/soc/aspeed/aspeed-espi-ctrl.h create mode 100644 drivers/soc/aspeed/aspeed-espi-flash-mafs.c create mode 100644 drivers/soc/aspeed/aspeed-espi-flash.h -- 2.40.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2F41C54E5D for ; Tue, 19 Mar 2024 09:35:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=uHUMczR59dn6nkHK8dYZJ8W+C0p0YWDLbq+YYnINyig=; b=zd7Mcyz2oysq3/ DpBdz0o+LnoyBFdvTrfh7kbUY6jESM49yfZtJ4358UZsp1/hmEXyukLF+HGvzY3nkMtXdfrY4BnFw T10VpdD3MYxXHJfSxh2XRkB1T3UfGiZDb/0mBOGxgF/JtdzMAhqVmQLjiCiTMrgN6DXAPXtPT4e8E ixeOCEI5Gj41kKHtDpwTgCmUdPZJjXmPuogxwEWn25W0CpCHNJPACULAIlSp16h8n9Oji2wGI52qm eXlOjLJIdGBkCPWYFs7bFpv5s4BXrasRKBsZbIVBqbRt9U0SJ/mljnb1c8rRZ23BhPE/jdQF002JR 3BTtltSBmvKDCzRvY1jA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmVsX-0000000C6qe-1TO1; Tue, 19 Mar 2024 09:35:29 +0000 Received: from mail-pg1-x52d.google.com ([2607:f8b0:4864:20::52d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmVsT-0000000C6pU-0MWz; Tue, 19 Mar 2024 09:35:26 +0000 Received: by mail-pg1-x52d.google.com with SMTP id 41be03b00d2f7-5d42e7ab8a9so3125594a12.3; Tue, 19 Mar 2024 02:35:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710840921; x=1711445721; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=32AXx27SSzTCLszDWarNun8O1zcaf1jj0VawsZbBOHE=; b=Sk/Axg73nc+0G/R8+t+KlNkUPnw4gzlB4ozafC5UzeSJ4lcZVxlmDNexFYIoVp6Waz rp9hU44lcJVAcVqyeXqePpKDVGp2Vf7jHNvm9kZmKYy9MdAI8G91pnUl2FPWesQWhghX CW+GUCNaJxR2HV0fI6sTvp4w3xYz16pCpEy/hL4DroJHlSkasFLhcyRc8bezu8XNO6EB ytXoArtd24uh8ZSzh2aYFhtwSkkgp/0am8RkY757R4epVb9UxoCaaZq59480Od2jLFws QElUCXlwvjTDzMmKL5oRV2J0ti508W0GpB1JuaIyryUKXVKz5ejo4mgj5HJgJ37LyX/1 bsQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710840921; x=1711445721; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=32AXx27SSzTCLszDWarNun8O1zcaf1jj0VawsZbBOHE=; b=eA2PLYSoEe1TsFtPcZuVCPpwY0/GO0hB3C0drAIIuHnAM6IgFZohYIp5Me7CvqfXo5 lIJCNBRSfTqgg9jdo5opAV44cl3kRT5EEACCg7AhjkdGT8wpxgp+hp3gzxrLPy4CvMvF sLErisj5Z/NTL2vJhYiHzbLPpjqifPtLdaqf2a+RlttW/psDdAwFLNmlFKj3/Ejst/Ty ztA2itC5ExGDKVQSyXm7fIYYqvr14IRZHomj/u6QMAYssmsR9KpcLmn4WSuHV7uH+Jlm Kb9KNMQ9/FVzjTdkmE0z0d+kAYOe/f3NX3lBqVoI5ayyLp3y4xcy12z8b6HdoP44ceuk eoRA== X-Forwarded-Encrypted: i=1; AJvYcCUvA9fm2zW4SAHrPOjMGNdHdqHVmHCbJc22oJrOMk55wv+tfKqG7TqCowHhrFKbQk/7qYuLByQ6cr2R7lg8uv+QYtEZN0YU8fdf6mG5dtkNIAxY/0IZwWMkhUQ5Vm2TtZGP2SXF6CgWn1liH93FKmNsFkUu X-Gm-Message-State: AOJu0YxIYS/E8z42+Xd+vy/gi3x3b1vdeN1phH/7hmLg5+D/CDokgSAc KNla91zvtSQ7X2UAJM2782n2t+V13igOL99llgdN/h9hiM79NJoH X-Google-Smtp-Source: AGHT+IHDM7HsAh3M015ITHV9MavYe4suAIxVy7uxIJgbuM/TKnaJlg+0UVSfSczJwcMqkUErwsaA9g== X-Received: by 2002:a05:6a20:d49b:b0:1a3:55d2:1489 with SMTP id im27-20020a056a20d49b00b001a355d21489mr2341521pzb.7.1710840921367; Tue, 19 Mar 2024 02:35:21 -0700 (PDT) Received: from localhost.localdomain ([129.41.58.3]) by smtp.gmail.com with ESMTPSA id n5-20020a170903110500b001ddc0bc5934sm10942432plh.249.2024.03.19.02.35.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Mar 2024 02:35:21 -0700 (PDT) From: Manojkiran Eda To: patrick.rudolph@9elements.com, chiawei_wang@aspeedtech.com, ryan_chen@aspeedtech.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, joel@jms.id.au, andrew@codeconstruct.com.au, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, manojkiran.eda@gmail.com, jk@codeconstruct.com.au, openbmc@lists.ozlabs.org Subject: [PATCH v2 0/4] Add eSPI device driver (flash channel) Date: Tue, 19 Mar 2024 15:04:01 +0530 Message-Id: <20240319093405.39833-1-manojkiran.eda@gmail.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240319_023525_258747_191CDD2F X-CRM114-Status: GOOD ( 12.91 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Hello everyone, I'm presenting a revised version of the eSPI device driver patch series found at the following link: https://lore.kernel.org/openbmc/20220516005412.4844-1-chiawei_wang@aspeedtech.com/ This update addresses the issues identified during the review process. While the previous patch series attempted to incorporate support for all four different channels of eSPI using the ioctl interface , this new series focuses on upstreaming the flash channel (using the mtd interface) initially, ensuring that all review comments are duly addressed, before progressing further. Diff between PACTH v1-v2: 1. The commit is split into multiple commits as per the review comments. 2. Explicity renamed the driver to indicate that it only support master attached flash storage (mafs). 3. Added new kconfig options to enable/disable eSPI mafs support. Results: Successfully conducted a flash update via eSPI. Manojkiran Eda (4): Add eSPI device driver (flash channel) mtd: Replace module_init with subsys_initcall ARM: dts: aspeed: Add eSPI node dt-bindings: aspeed: Add eSPI controller .../bindings/soc/aspeed/aspeed,espi.yaml | 94 ++++ arch/arm/boot/dts/aspeed/aspeed-g5.dtsi | 19 + arch/arm/boot/dts/aspeed/aspeed-g6.dtsi | 20 + drivers/mtd/mtdcore.c | 2 +- drivers/soc/aspeed/Kconfig | 38 ++ drivers/soc/aspeed/Makefile | 2 + drivers/soc/aspeed/aspeed-espi-ctrl.c | 197 ++++++++ drivers/soc/aspeed/aspeed-espi-ctrl.h | 169 +++++++ drivers/soc/aspeed/aspeed-espi-flash-mafs.c | 467 ++++++++++++++++++ drivers/soc/aspeed/aspeed-espi-flash.h | 71 +++ 10 files changed, 1078 insertions(+), 1 deletion(-) create mode 100644 Documentation/devicetree/bindings/soc/aspeed/aspeed,espi.yaml create mode 100644 drivers/soc/aspeed/aspeed-espi-ctrl.c create mode 100644 drivers/soc/aspeed/aspeed-espi-ctrl.h create mode 100644 drivers/soc/aspeed/aspeed-espi-flash-mafs.c create mode 100644 drivers/soc/aspeed/aspeed-espi-flash.h -- 2.40.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 08C74C54E60 for ; Tue, 19 Mar 2024 09:36:15 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=TcRk8frN; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4TzRRy4by0z3dRp for ; Tue, 19 Mar 2024 20:36:14 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=TcRk8frN; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::532; helo=mail-pg1-x532.google.com; envelope-from=manojkiran.eda@gmail.com; receiver=lists.ozlabs.org) Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4TzRR10bggz3bnv; Tue, 19 Mar 2024 20:35:24 +1100 (AEDT) Received: by mail-pg1-x532.google.com with SMTP id 41be03b00d2f7-5ce07cf1e5dso3609813a12.2; Tue, 19 Mar 2024 02:35:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710840921; x=1711445721; darn=lists.ozlabs.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=32AXx27SSzTCLszDWarNun8O1zcaf1jj0VawsZbBOHE=; b=TcRk8frNUEgasru2+4PU1q6NpHClOL40K3o0mKZOazTq1pne/HPo9XU+OtIDEibEqU KQslEL1Ougo/Kwy8TUNxqKEzpT6LGnR27NWFrzeoSp9dlmSo0RlcJ2+0hyBXgoePuRPW rDttLuFODcIiWgSOhuM74kxZwRv2WxQQ2qx9GIkmH4ULyo5Qcmevb71vaiYuvnokiC2W IyYlMGSQWTadG/+y6lxZv83UNXyEHKeUk/WVBDQKwdL0ENIib0WaiWuvFprI1c70XNjH TpDrWN90cSOYIPjsz//rzrjaMRtNZki6gVs271HPKEYCVPBqho8w597BzpdOWCe0U2lw SGUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710840921; x=1711445721; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=32AXx27SSzTCLszDWarNun8O1zcaf1jj0VawsZbBOHE=; b=PLCJANpuyfn/4zH095u4/rZRwoN0Sk7W6qpiH8L9G/QqiHHfHvdcortr/BNUfckMS+ 7CRBlInGWLZsDubMyqtVghDbivD6uFnrU6zE+qMI2g7x+fqOw5h8E6x9QgNf4If5HUML fuO3lpm6nqqK43SvEkd/KJS4L8UBTKB+OtTgHhnRl69t5EY8w72bTvp3y/CVlMRKiSux 9S6boNd7XLbUNGhaOtGdhUkR+KG8k10OogofkloVUB8AShzKK4jmX+zsixoYa95QgkeB z9ouY3WGuUhN87c93eiZL0C4toRsIZn/QU/iteGc7kj3ZsQyz+tOrn9NlMraizT63iOU a60Q== X-Forwarded-Encrypted: i=1; AJvYcCVUaLCDL2LgLYJhJcOfRR782plgRDfr4fVr2KlELbMAFexWZHqAfNXBYqZ9B2+ei8Yl5ELtbzIodPk0NCCUOKakXwS3FeGDNGmnABrpAxXBeVBwthyKwHYsmoxVfY7Pz9YhANUkb5yB X-Gm-Message-State: AOJu0YwIonbRApx8nduAx8BZryGzzLGae1n39eYHWYkHeYPyxQdAaFGH u6C1X2aaaTwkXWE46vn7CQPtUNvl4BICAleDYutSuW7iZNaLl9q/ X-Google-Smtp-Source: AGHT+IHDM7HsAh3M015ITHV9MavYe4suAIxVy7uxIJgbuM/TKnaJlg+0UVSfSczJwcMqkUErwsaA9g== X-Received: by 2002:a05:6a20:d49b:b0:1a3:55d2:1489 with SMTP id im27-20020a056a20d49b00b001a355d21489mr2341521pzb.7.1710840921367; Tue, 19 Mar 2024 02:35:21 -0700 (PDT) Received: from localhost.localdomain ([129.41.58.3]) by smtp.gmail.com with ESMTPSA id n5-20020a170903110500b001ddc0bc5934sm10942432plh.249.2024.03.19.02.35.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Mar 2024 02:35:21 -0700 (PDT) From: Manojkiran Eda To: patrick.rudolph@9elements.com, chiawei_wang@aspeedtech.com, ryan_chen@aspeedtech.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org Subject: [PATCH v2 0/4] Add eSPI device driver (flash channel) Date: Tue, 19 Mar 2024 15:04:01 +0530 Message-Id: <20240319093405.39833-1-manojkiran.eda@gmail.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: conor+dt@kernel.org, vigneshr@ti.com, richard@nod.at, openbmc@lists.ozlabs.org, robh+dt@kernel.org, joel@jms.id.au, krzysztof.kozlowski+dt@linaro.org, miquel.raynal@bootlin.com, jk@codeconstruct.com.au, manojkiran.eda@gmail.com Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" Hello everyone, I'm presenting a revised version of the eSPI device driver patch series found at the following link: https://lore.kernel.org/openbmc/20220516005412.4844-1-chiawei_wang@aspeedtech.com/ This update addresses the issues identified during the review process. While the previous patch series attempted to incorporate support for all four different channels of eSPI using the ioctl interface , this new series focuses on upstreaming the flash channel (using the mtd interface) initially, ensuring that all review comments are duly addressed, before progressing further. Diff between PACTH v1-v2: 1. The commit is split into multiple commits as per the review comments. 2. Explicity renamed the driver to indicate that it only support master attached flash storage (mafs). 3. Added new kconfig options to enable/disable eSPI mafs support. Results: Successfully conducted a flash update via eSPI. Manojkiran Eda (4): Add eSPI device driver (flash channel) mtd: Replace module_init with subsys_initcall ARM: dts: aspeed: Add eSPI node dt-bindings: aspeed: Add eSPI controller .../bindings/soc/aspeed/aspeed,espi.yaml | 94 ++++ arch/arm/boot/dts/aspeed/aspeed-g5.dtsi | 19 + arch/arm/boot/dts/aspeed/aspeed-g6.dtsi | 20 + drivers/mtd/mtdcore.c | 2 +- drivers/soc/aspeed/Kconfig | 38 ++ drivers/soc/aspeed/Makefile | 2 + drivers/soc/aspeed/aspeed-espi-ctrl.c | 197 ++++++++ drivers/soc/aspeed/aspeed-espi-ctrl.h | 169 +++++++ drivers/soc/aspeed/aspeed-espi-flash-mafs.c | 467 ++++++++++++++++++ drivers/soc/aspeed/aspeed-espi-flash.h | 71 +++ 10 files changed, 1078 insertions(+), 1 deletion(-) create mode 100644 Documentation/devicetree/bindings/soc/aspeed/aspeed,espi.yaml create mode 100644 drivers/soc/aspeed/aspeed-espi-ctrl.c create mode 100644 drivers/soc/aspeed/aspeed-espi-ctrl.h create mode 100644 drivers/soc/aspeed/aspeed-espi-flash-mafs.c create mode 100644 drivers/soc/aspeed/aspeed-espi-flash.h -- 2.40.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6545CC54E5D for ; Tue, 19 Mar 2024 09:35:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=5CESVhBPuCkLJwXIFx6f8WS+f6zPDS9ppMlEkYg8Ezs=; b=01YcLqHHDPXusD XTDIwZ7qg2l1lTo37rXFW50/BHZUs9mEPkSpRh4m+zUoQp8HLxKttyY3QUDweBbbLm7ggyVadTGzg Ev6iHWVX4qUU1/ovJ/AmZ/Urn8+emGNrPRjqzV5f2A4VwB9/cSIitdfSCW0YBWBjbnGSjUzJCfR44 6mTFWtJ7Kyqf2mpSHp6/MBqKEwapoAVu0bCMcnLWGvHAHy26sZovIRQ09JFf/y6j8q4r24kA6xeRf RhyIWORebwU8xPVLKvuBcAq0eXL59/IMbEGm4p4QJTXyfiisZcm6c7sIoLWplk9OYuEf8v1VzvPAw ghis17QCmoa3639MILuQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmVsW-0000000C6q9-2Koh; Tue, 19 Mar 2024 09:35:28 +0000 Received: from mail-pg1-x52d.google.com ([2607:f8b0:4864:20::52d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmVsT-0000000C6pU-0MWz; Tue, 19 Mar 2024 09:35:26 +0000 Received: by mail-pg1-x52d.google.com with SMTP id 41be03b00d2f7-5d42e7ab8a9so3125594a12.3; Tue, 19 Mar 2024 02:35:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710840921; x=1711445721; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=32AXx27SSzTCLszDWarNun8O1zcaf1jj0VawsZbBOHE=; b=Sk/Axg73nc+0G/R8+t+KlNkUPnw4gzlB4ozafC5UzeSJ4lcZVxlmDNexFYIoVp6Waz rp9hU44lcJVAcVqyeXqePpKDVGp2Vf7jHNvm9kZmKYy9MdAI8G91pnUl2FPWesQWhghX CW+GUCNaJxR2HV0fI6sTvp4w3xYz16pCpEy/hL4DroJHlSkasFLhcyRc8bezu8XNO6EB ytXoArtd24uh8ZSzh2aYFhtwSkkgp/0am8RkY757R4epVb9UxoCaaZq59480Od2jLFws QElUCXlwvjTDzMmKL5oRV2J0ti508W0GpB1JuaIyryUKXVKz5ejo4mgj5HJgJ37LyX/1 bsQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710840921; x=1711445721; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=32AXx27SSzTCLszDWarNun8O1zcaf1jj0VawsZbBOHE=; b=eA2PLYSoEe1TsFtPcZuVCPpwY0/GO0hB3C0drAIIuHnAM6IgFZohYIp5Me7CvqfXo5 lIJCNBRSfTqgg9jdo5opAV44cl3kRT5EEACCg7AhjkdGT8wpxgp+hp3gzxrLPy4CvMvF sLErisj5Z/NTL2vJhYiHzbLPpjqifPtLdaqf2a+RlttW/psDdAwFLNmlFKj3/Ejst/Ty ztA2itC5ExGDKVQSyXm7fIYYqvr14IRZHomj/u6QMAYssmsR9KpcLmn4WSuHV7uH+Jlm Kb9KNMQ9/FVzjTdkmE0z0d+kAYOe/f3NX3lBqVoI5ayyLp3y4xcy12z8b6HdoP44ceuk eoRA== X-Forwarded-Encrypted: i=1; AJvYcCUvA9fm2zW4SAHrPOjMGNdHdqHVmHCbJc22oJrOMk55wv+tfKqG7TqCowHhrFKbQk/7qYuLByQ6cr2R7lg8uv+QYtEZN0YU8fdf6mG5dtkNIAxY/0IZwWMkhUQ5Vm2TtZGP2SXF6CgWn1liH93FKmNsFkUu X-Gm-Message-State: AOJu0YxIYS/E8z42+Xd+vy/gi3x3b1vdeN1phH/7hmLg5+D/CDokgSAc KNla91zvtSQ7X2UAJM2782n2t+V13igOL99llgdN/h9hiM79NJoH X-Google-Smtp-Source: AGHT+IHDM7HsAh3M015ITHV9MavYe4suAIxVy7uxIJgbuM/TKnaJlg+0UVSfSczJwcMqkUErwsaA9g== X-Received: by 2002:a05:6a20:d49b:b0:1a3:55d2:1489 with SMTP id im27-20020a056a20d49b00b001a355d21489mr2341521pzb.7.1710840921367; Tue, 19 Mar 2024 02:35:21 -0700 (PDT) Received: from localhost.localdomain ([129.41.58.3]) by smtp.gmail.com with ESMTPSA id n5-20020a170903110500b001ddc0bc5934sm10942432plh.249.2024.03.19.02.35.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Mar 2024 02:35:21 -0700 (PDT) From: Manojkiran Eda To: patrick.rudolph@9elements.com, chiawei_wang@aspeedtech.com, ryan_chen@aspeedtech.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, joel@jms.id.au, andrew@codeconstruct.com.au, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, manojkiran.eda@gmail.com, jk@codeconstruct.com.au, openbmc@lists.ozlabs.org Subject: [PATCH v2 0/4] Add eSPI device driver (flash channel) Date: Tue, 19 Mar 2024 15:04:01 +0530 Message-Id: <20240319093405.39833-1-manojkiran.eda@gmail.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240319_023525_258747_191CDD2F X-CRM114-Status: GOOD ( 12.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello everyone, I'm presenting a revised version of the eSPI device driver patch series found at the following link: https://lore.kernel.org/openbmc/20220516005412.4844-1-chiawei_wang@aspeedtech.com/ This update addresses the issues identified during the review process. While the previous patch series attempted to incorporate support for all four different channels of eSPI using the ioctl interface , this new series focuses on upstreaming the flash channel (using the mtd interface) initially, ensuring that all review comments are duly addressed, before progressing further. Diff between PACTH v1-v2: 1. The commit is split into multiple commits as per the review comments. 2. Explicity renamed the driver to indicate that it only support master attached flash storage (mafs). 3. Added new kconfig options to enable/disable eSPI mafs support. Results: Successfully conducted a flash update via eSPI. Manojkiran Eda (4): Add eSPI device driver (flash channel) mtd: Replace module_init with subsys_initcall ARM: dts: aspeed: Add eSPI node dt-bindings: aspeed: Add eSPI controller .../bindings/soc/aspeed/aspeed,espi.yaml | 94 ++++ arch/arm/boot/dts/aspeed/aspeed-g5.dtsi | 19 + arch/arm/boot/dts/aspeed/aspeed-g6.dtsi | 20 + drivers/mtd/mtdcore.c | 2 +- drivers/soc/aspeed/Kconfig | 38 ++ drivers/soc/aspeed/Makefile | 2 + drivers/soc/aspeed/aspeed-espi-ctrl.c | 197 ++++++++ drivers/soc/aspeed/aspeed-espi-ctrl.h | 169 +++++++ drivers/soc/aspeed/aspeed-espi-flash-mafs.c | 467 ++++++++++++++++++ drivers/soc/aspeed/aspeed-espi-flash.h | 71 +++ 10 files changed, 1078 insertions(+), 1 deletion(-) create mode 100644 Documentation/devicetree/bindings/soc/aspeed/aspeed,espi.yaml create mode 100644 drivers/soc/aspeed/aspeed-espi-ctrl.c create mode 100644 drivers/soc/aspeed/aspeed-espi-ctrl.h create mode 100644 drivers/soc/aspeed/aspeed-espi-flash-mafs.c create mode 100644 drivers/soc/aspeed/aspeed-espi-flash.h -- 2.40.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23DA851C28; Tue, 19 Mar 2024 09:35:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710840923; cv=none; b=XQl8O4swyayx5A3yvxKccyagFpP2aTX5DialzNWGjO4zu1s+4HAD1X0M96/0Wt2owLeAtmMTe0IcjTdl4fJMfK+pfKrtzm6Rltkvl/6joLoxngMKxHUi0DfUNid3N+cYGRtAdxG7hIt6iEEDLkBDCSgIibCmOWflHkTUc8i+YIE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710840923; c=relaxed/simple; bh=UL1jVOoSsazd/6Mg7jjvAVM7p2M7LyFsuVPFJZXsGIw=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=e1yL0Pqk6RGH2R69uen7Ol9TidHgMNH9h6U3UOCxawNjut0y4pnKghheSBh1DLHOaudgK/R4EiPUdrzidK/ra0niqcUHLTsHJUR5k5TFIhiDLrfewR+V3PetX8p09OTdcv5I5N94gjsTTP6Ac1APjdqs7I4Xr7SmVgGKQ4I1q+E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cotPKsz4; arc=none smtp.client-ip=209.85.215.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cotPKsz4" Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-5d4a1e66750so3241807a12.0; Tue, 19 Mar 2024 02:35:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710840921; x=1711445721; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=32AXx27SSzTCLszDWarNun8O1zcaf1jj0VawsZbBOHE=; b=cotPKsz4/8tg+EsAoTC70E4rmMCNO+axhCnuh454mXks4xzwBN2V3psrT6xijxQGet aSzmpRb5RaX9IjX+8zsfdSaWD5hVGePLM/Bb/eiHVxBl8O8OFCbPaKaVIanYd9xseyZt 5H+ZeKE0INFfVfw/Y0sMOkclgMhHrDUEhSdRj40K4Gshi6jjHO6LbvkaXkFu8I9I+gc8 5MdvHqho8dSGySOXV7yIHNzUdzQBAdi90VyCbmdclb6gfStvK29IEL92ouIq4dOVFC1c K+y1D+oBqw+vDSg/ZQMSWgkp9oM6J5quE3xeEiYxW2KDJXhSMg6MbwXqVFlV5NBpZt1A Omlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710840921; x=1711445721; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=32AXx27SSzTCLszDWarNun8O1zcaf1jj0VawsZbBOHE=; b=sprxSlxquPEIA23gAzCrXrVCWLg5AjOygIO8fimeqLhbplgvchESLTvDGvQOmpMISU B9YYQn6AQVIMhh9Jwa+1h9lnNU1TZMatxudWFpZ2FVpQhRGmH24N1674ua+wR+9Aa7S0 Siihn93Wbi1XHPmysvBXoUvozAhwQCiD7fkwoBR42uaDAWG+oN4UHlVgYgmnRA3Cksg0 ZNScyC+uAM3slJO0jmt9LvhvMAqnF21ggPgmqGKHa2i4qV+kGx1/qDLJxSMTjM9ytEC/ 1SuVvEpoo4COdyRAwV8YEv8AcUePVCvm6dc/GxOJsXxW+GpHW0Pj6gDA0SEUKEHIrXCb Zrxw== X-Forwarded-Encrypted: i=1; AJvYcCUxmLUinwAF1uOQI6zoYxlthjJ9R2TiphddaiTxJExvH1mrNWKa4TbaOVnUpH5vIPhdJL3J+YCfkOkEYZUEd1upR99g1JWxtpniQL94SQ5aS142hHq60HyQ2A5rI6lSycC8zuPRpfRXXQ== X-Gm-Message-State: AOJu0YzB4lf31fyV1IQpR509GaphJBg+4jPedXzQnXdGtwsWB9TQLGQi TljF0WPPf6maS4D+GshJ4maKkDvUC93dLz0YK+HSKkOUd7S7Fmlu X-Google-Smtp-Source: AGHT+IHDM7HsAh3M015ITHV9MavYe4suAIxVy7uxIJgbuM/TKnaJlg+0UVSfSczJwcMqkUErwsaA9g== X-Received: by 2002:a05:6a20:d49b:b0:1a3:55d2:1489 with SMTP id im27-20020a056a20d49b00b001a355d21489mr2341521pzb.7.1710840921367; Tue, 19 Mar 2024 02:35:21 -0700 (PDT) Received: from localhost.localdomain ([129.41.58.3]) by smtp.gmail.com with ESMTPSA id n5-20020a170903110500b001ddc0bc5934sm10942432plh.249.2024.03.19.02.35.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Mar 2024 02:35:21 -0700 (PDT) From: Manojkiran Eda To: patrick.rudolph@9elements.com, chiawei_wang@aspeedtech.com, ryan_chen@aspeedtech.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, joel@jms.id.au, andrew@codeconstruct.com.au, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, manojkiran.eda@gmail.com, jk@codeconstruct.com.au, openbmc@lists.ozlabs.org Subject: [PATCH v2 0/4] Add eSPI device driver (flash channel) Date: Tue, 19 Mar 2024 15:04:01 +0530 Message-Id: <20240319093405.39833-1-manojkiran.eda@gmail.com> X-Mailer: git-send-email 2.40.1 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hello everyone, I'm presenting a revised version of the eSPI device driver patch series found at the following link: https://lore.kernel.org/openbmc/20220516005412.4844-1-chiawei_wang@aspeedtech.com/ This update addresses the issues identified during the review process. While the previous patch series attempted to incorporate support for all four different channels of eSPI using the ioctl interface , this new series focuses on upstreaming the flash channel (using the mtd interface) initially, ensuring that all review comments are duly addressed, before progressing further. Diff between PACTH v1-v2: 1. The commit is split into multiple commits as per the review comments. 2. Explicity renamed the driver to indicate that it only support master attached flash storage (mafs). 3. Added new kconfig options to enable/disable eSPI mafs support. Results: Successfully conducted a flash update via eSPI. Manojkiran Eda (4): Add eSPI device driver (flash channel) mtd: Replace module_init with subsys_initcall ARM: dts: aspeed: Add eSPI node dt-bindings: aspeed: Add eSPI controller .../bindings/soc/aspeed/aspeed,espi.yaml | 94 ++++ arch/arm/boot/dts/aspeed/aspeed-g5.dtsi | 19 + arch/arm/boot/dts/aspeed/aspeed-g6.dtsi | 20 + drivers/mtd/mtdcore.c | 2 +- drivers/soc/aspeed/Kconfig | 38 ++ drivers/soc/aspeed/Makefile | 2 + drivers/soc/aspeed/aspeed-espi-ctrl.c | 197 ++++++++ drivers/soc/aspeed/aspeed-espi-ctrl.h | 169 +++++++ drivers/soc/aspeed/aspeed-espi-flash-mafs.c | 467 ++++++++++++++++++ drivers/soc/aspeed/aspeed-espi-flash.h | 71 +++ 10 files changed, 1078 insertions(+), 1 deletion(-) create mode 100644 Documentation/devicetree/bindings/soc/aspeed/aspeed,espi.yaml create mode 100644 drivers/soc/aspeed/aspeed-espi-ctrl.c create mode 100644 drivers/soc/aspeed/aspeed-espi-ctrl.h create mode 100644 drivers/soc/aspeed/aspeed-espi-flash-mafs.c create mode 100644 drivers/soc/aspeed/aspeed-espi-flash.h -- 2.40.1