From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miquel Raynal Date: Tue, 19 Mar 2024 10:53:09 +0100 Subject: [PATCH v2 2/4] mtd: Replace module_init with subsys_initcall In-Reply-To: <4e3fbff7-6edc-4196-bc72-1095f14d0dfa@linaro.org> References: <20240319093405.39833-1-manojkiran.eda@gmail.com> <20240319093405.39833-3-manojkiran.eda@gmail.com> <4e3fbff7-6edc-4196-bc72-1095f14d0dfa@linaro.org> Message-ID: <20240319105309.7cdfe106@xps-13> List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi, krzysztof.kozlowski at linaro.org wrote on Tue, 19 Mar 2024 10:51:00 +0100: > On 19/03/2024 10:34, Manojkiran Eda wrote: > > While engaged in development on the espi kernel device driver[1], > > I noticed that the espi flash driver, utilizing the mtd subsystem, > > appears to initialize before the mtdcore subsystem registers the > > NAK > > You incorrectly ordered your call, so now to fix this you incorrectly > re-order rest of kernel. No. Fix your code to handle modules, probe > deferrals and device links. Agreed. You shall not need this. Maybe just moving the driver to the right location (spi) might fix it. Thanks, Miqu?l From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2570AC54E60 for ; Tue, 19 Mar 2024 09:53:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IAa24KwfAhS8cLPplRaC4D+lmgfxiTtP8F7Rn8ZGoro=; b=oQXKCbxHFcdWuu 6xoNQ6vaNFYXMPQ0ocQNSofMKbeaE5zjcb1DFDtLBaV/e0BQlfuIxWzcrqeQnITpRnabFy/lZqZiu 9cCSsfljvFyqm9NaPSaI3NQ3UrNa2hYjd9bisfECHYjVDIQhiRyHyZhWkfAEQUtlOAb4voAZtugsE cgy1XElsazdEE4lwbTJWVkAxJqsXisWvrdrByETc+jpxilPaxw3MSiSURq12mbbwG0RmoWLFG85M0 qKK7ArcJP4J+WUH9fCM50IkaIAteIcFmV/f9lSiF4yCzNgsTqiCmxP87Zjtlf8vUJxJKFkGkoWPWy RcBO+Us2wQn4QDQOfNSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmW9r-0000000CB7N-261Z; Tue, 19 Mar 2024 09:53:23 +0000 Received: from relay9-d.mail.gandi.net ([2001:4b98:dc4:8::229]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmW9m-0000000CB52-1s4t; Tue, 19 Mar 2024 09:53:21 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id B3CB1FF80D; Tue, 19 Mar 2024 09:53:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1710841993; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+EBDDiNG/eNmY+ueIncptOoRVdMb4em3Z5Wr8wvDjWc=; b=LyzUosUWbZmhrAA4qvwA0ojyg9rDBL6yH+R73/Cl/AGOQYhPpeDYpbVg1jJWu+O1/a6MiY GBtEWVlXLRdBYAfeMbmpOHGLpgAKW+VDmM+X3OTurys03prNWASCLdD7QloxLQT5lWKEcK Jwor7i4jxb3XKQjqvKriBWQQpRtMnJVJicefmt3ecDm2AlHMHsSaMVfI95oAdTr03N/yRg +qp5UgKZGXIpdlewjym3wvEOhprR6T9pCv9wPgYXSxkC5i1o17+vt8Cbj0CF15sCTGTSpK SRTtIkMjzAFEMh75v0eGJSLFpvSufCkkMYqFgr3oJdm08AfYkBdvYQMPZiXCvw== Date: Tue, 19 Mar 2024 10:53:09 +0100 From: Miquel Raynal To: Krzysztof Kozlowski Cc: Manojkiran Eda , patrick.rudolph@9elements.com, chiawei_wang@aspeedtech.com, ryan_chen@aspeedtech.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, joel@jms.id.au, andrew@codeconstruct.com.au, richard@nod.at, vigneshr@ti.com, jk@codeconstruct.com.au, openbmc@lists.ozlabs.org Subject: Re: [PATCH v2 2/4] mtd: Replace module_init with subsys_initcall Message-ID: <20240319105309.7cdfe106@xps-13> In-Reply-To: <4e3fbff7-6edc-4196-bc72-1095f14d0dfa@linaro.org> References: <20240319093405.39833-1-manojkiran.eda@gmail.com> <20240319093405.39833-3-manojkiran.eda@gmail.com> <4e3fbff7-6edc-4196-bc72-1095f14d0dfa@linaro.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: miquel.raynal@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240319_025318_784574_12D649A9 X-CRM114-Status: UNSURE ( 9.14 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGksCgprcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmcgd3JvdGUgb24gVHVlLCAxOSBNYXIg MjAyNCAxMDo1MTowMCArMDEwMDoKCj4gT24gMTkvMDMvMjAyNCAxMDozNCwgTWFub2praXJhbiBF ZGEgd3JvdGU6Cj4gPiBXaGlsZSBlbmdhZ2VkIGluIGRldmVsb3BtZW50IG9uIHRoZSBlc3BpIGtl cm5lbCBkZXZpY2UgZHJpdmVyWzFdLAo+ID4gSSBub3RpY2VkIHRoYXQgdGhlIGVzcGkgZmxhc2gg ZHJpdmVyLCB1dGlsaXppbmcgdGhlIG10ZCBzdWJzeXN0ZW0sCj4gPiBhcHBlYXJzIHRvIGluaXRp YWxpemUgYmVmb3JlIHRoZSBtdGRjb3JlIHN1YnN5c3RlbSByZWdpc3RlcnMgdGhlICAKPiAKPiBO QUsKPiAKPiBZb3UgaW5jb3JyZWN0bHkgb3JkZXJlZCB5b3VyIGNhbGwsIHNvIG5vdyB0byBmaXgg dGhpcyB5b3UgaW5jb3JyZWN0bHkKPiByZS1vcmRlciByZXN0IG9mIGtlcm5lbC4gTm8uIEZpeCB5 b3VyIGNvZGUgdG8gaGFuZGxlIG1vZHVsZXMsIHByb2JlCj4gZGVmZXJyYWxzIGFuZCBkZXZpY2Ug bGlua3MuCgpBZ3JlZWQuIFlvdSBzaGFsbCBub3QgbmVlZCB0aGlzLiBNYXliZSBqdXN0IG1vdmlu ZyB0aGUgZHJpdmVyIHRvIHRoZQpyaWdodCBsb2NhdGlvbiAoc3BpKSBtaWdodCBmaXggaXQuCgpU aGFua3MsCk1pcXXDqGwKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpMaW51eCBNVEQgZGlzY3Vzc2lvbiBtYWlsaW5nIGxpc3QKaHR0cDovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1tdGQvCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 78CFEC54E71 for ; Wed, 20 Mar 2024 02:47:12 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=LyzUosUW; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4TztKW07j9z3cN6 for ; Wed, 20 Mar 2024 13:47:11 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=LyzUosUW; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=bootlin.com (client-ip=2001:4b98:dc4:8::240; helo=mslow1.mail.gandi.net; envelope-from=miquel.raynal@bootlin.com; receiver=lists.ozlabs.org) Received: from mslow1.mail.gandi.net (mslow1.mail.gandi.net [IPv6:2001:4b98:dc4:8::240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4TzRy80Q3cz3cVv; Tue, 19 Mar 2024 20:58:55 +1100 (AEDT) Received: from relay9-d.mail.gandi.net (unknown [IPv6:2001:4b98:dc4:8::229]) by mslow1.mail.gandi.net (Postfix) with ESMTP id 482DBC3985; Tue, 19 Mar 2024 09:53:33 +0000 (UTC) Received: by mail.gandi.net (Postfix) with ESMTPSA id B3CB1FF80D; Tue, 19 Mar 2024 09:53:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1710841993; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+EBDDiNG/eNmY+ueIncptOoRVdMb4em3Z5Wr8wvDjWc=; b=LyzUosUWbZmhrAA4qvwA0ojyg9rDBL6yH+R73/Cl/AGOQYhPpeDYpbVg1jJWu+O1/a6MiY GBtEWVlXLRdBYAfeMbmpOHGLpgAKW+VDmM+X3OTurys03prNWASCLdD7QloxLQT5lWKEcK Jwor7i4jxb3XKQjqvKriBWQQpRtMnJVJicefmt3ecDm2AlHMHsSaMVfI95oAdTr03N/yRg +qp5UgKZGXIpdlewjym3wvEOhprR6T9pCv9wPgYXSxkC5i1o17+vt8Cbj0CF15sCTGTSpK SRTtIkMjzAFEMh75v0eGJSLFpvSufCkkMYqFgr3oJdm08AfYkBdvYQMPZiXCvw== Date: Tue, 19 Mar 2024 10:53:09 +0100 From: Miquel Raynal To: Krzysztof Kozlowski Subject: Re: [PATCH v2 2/4] mtd: Replace module_init with subsys_initcall Message-ID: <20240319105309.7cdfe106@xps-13> In-Reply-To: <4e3fbff7-6edc-4196-bc72-1095f14d0dfa@linaro.org> References: <20240319093405.39833-1-manojkiran.eda@gmail.com> <20240319093405.39833-3-manojkiran.eda@gmail.com> <4e3fbff7-6edc-4196-bc72-1095f14d0dfa@linaro.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com X-Mailman-Approved-At: Wed, 20 Mar 2024 13:46:22 +1100 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, conor+dt@kernel.org, ryan_chen@aspeedtech.com, vigneshr@ti.com, linux-aspeed@lists.ozlabs.org, richard@nod.at, chiawei_wang@aspeedtech.com, linux-kernel@vger.kernel.org, joel@jms.id.au, robh+dt@kernel.org, linux-mtd@lists.infradead.org, patrick.rudolph@9elements.com, krzysztof.kozlowski+dt@linaro.org, jk@codeconstruct.com.au, openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, Manojkiran Eda Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" Hi, krzysztof.kozlowski@linaro.org wrote on Tue, 19 Mar 2024 10:51:00 +0100: > On 19/03/2024 10:34, Manojkiran Eda wrote: > > While engaged in development on the espi kernel device driver[1], > > I noticed that the espi flash driver, utilizing the mtd subsystem, > > appears to initialize before the mtdcore subsystem registers the =20 >=20 > NAK >=20 > You incorrectly ordered your call, so now to fix this you incorrectly > re-order rest of kernel. No. Fix your code to handle modules, probe > deferrals and device links. Agreed. You shall not need this. Maybe just moving the driver to the right location (spi) might fix it. Thanks, Miqu=C3=A8l From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A3B47C54E60 for ; Tue, 19 Mar 2024 09:53:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SudJKmvXNPej97XHI68O8RlcM9O3su1DYSSx62NFtgc=; b=a0b7tzmvftX4Di AUD1z4lrKjmME3e7z9zpGVpiXodB6HP3HktiFkxDNyXrNswyhEUN/vC5Vu3LopaEr0STNbs1Z2eJ4 y0WoDxlxaXZA4/LCS1tx/RJcKDuNUmXq5nyXEBv0unzS0TWuCBKlbwxFsQ6kdlWcmKNwzg3v7uuM6 YT28Tl9tE4WA8PU0SDwgFvN1pUfOhbBf5EdTIMTMw5Uw3Cz7OykAnR4TBCWgcTCK65gkv923ahz5A PdzpHoaVbi8NzJHw3LKpSFHOiZ9mW9PYfPDVvOkTUKYgiFG0KHGKyH6V1DgeHdaJMBoHldeTZpLJl 5eLfCC57yUlcCS3v6VJg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmW9q-0000000CB6m-12Tk; Tue, 19 Mar 2024 09:53:22 +0000 Received: from relay9-d.mail.gandi.net ([2001:4b98:dc4:8::229]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmW9m-0000000CB52-1s4t; Tue, 19 Mar 2024 09:53:21 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id B3CB1FF80D; Tue, 19 Mar 2024 09:53:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1710841993; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+EBDDiNG/eNmY+ueIncptOoRVdMb4em3Z5Wr8wvDjWc=; b=LyzUosUWbZmhrAA4qvwA0ojyg9rDBL6yH+R73/Cl/AGOQYhPpeDYpbVg1jJWu+O1/a6MiY GBtEWVlXLRdBYAfeMbmpOHGLpgAKW+VDmM+X3OTurys03prNWASCLdD7QloxLQT5lWKEcK Jwor7i4jxb3XKQjqvKriBWQQpRtMnJVJicefmt3ecDm2AlHMHsSaMVfI95oAdTr03N/yRg +qp5UgKZGXIpdlewjym3wvEOhprR6T9pCv9wPgYXSxkC5i1o17+vt8Cbj0CF15sCTGTSpK SRTtIkMjzAFEMh75v0eGJSLFpvSufCkkMYqFgr3oJdm08AfYkBdvYQMPZiXCvw== Date: Tue, 19 Mar 2024 10:53:09 +0100 From: Miquel Raynal To: Krzysztof Kozlowski Cc: Manojkiran Eda , patrick.rudolph@9elements.com, chiawei_wang@aspeedtech.com, ryan_chen@aspeedtech.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, joel@jms.id.au, andrew@codeconstruct.com.au, richard@nod.at, vigneshr@ti.com, jk@codeconstruct.com.au, openbmc@lists.ozlabs.org Subject: Re: [PATCH v2 2/4] mtd: Replace module_init with subsys_initcall Message-ID: <20240319105309.7cdfe106@xps-13> In-Reply-To: <4e3fbff7-6edc-4196-bc72-1095f14d0dfa@linaro.org> References: <20240319093405.39833-1-manojkiran.eda@gmail.com> <20240319093405.39833-3-manojkiran.eda@gmail.com> <4e3fbff7-6edc-4196-bc72-1095f14d0dfa@linaro.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: miquel.raynal@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240319_025318_784574_12D649A9 X-CRM114-Status: UNSURE ( 9.14 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGksCgprcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmcgd3JvdGUgb24gVHVlLCAxOSBNYXIg MjAyNCAxMDo1MTowMCArMDEwMDoKCj4gT24gMTkvMDMvMjAyNCAxMDozNCwgTWFub2praXJhbiBF ZGEgd3JvdGU6Cj4gPiBXaGlsZSBlbmdhZ2VkIGluIGRldmVsb3BtZW50IG9uIHRoZSBlc3BpIGtl cm5lbCBkZXZpY2UgZHJpdmVyWzFdLAo+ID4gSSBub3RpY2VkIHRoYXQgdGhlIGVzcGkgZmxhc2gg ZHJpdmVyLCB1dGlsaXppbmcgdGhlIG10ZCBzdWJzeXN0ZW0sCj4gPiBhcHBlYXJzIHRvIGluaXRp YWxpemUgYmVmb3JlIHRoZSBtdGRjb3JlIHN1YnN5c3RlbSByZWdpc3RlcnMgdGhlICAKPiAKPiBO QUsKPiAKPiBZb3UgaW5jb3JyZWN0bHkgb3JkZXJlZCB5b3VyIGNhbGwsIHNvIG5vdyB0byBmaXgg dGhpcyB5b3UgaW5jb3JyZWN0bHkKPiByZS1vcmRlciByZXN0IG9mIGtlcm5lbC4gTm8uIEZpeCB5 b3VyIGNvZGUgdG8gaGFuZGxlIG1vZHVsZXMsIHByb2JlCj4gZGVmZXJyYWxzIGFuZCBkZXZpY2Ug bGlua3MuCgpBZ3JlZWQuIFlvdSBzaGFsbCBub3QgbmVlZCB0aGlzLiBNYXliZSBqdXN0IG1vdmlu ZyB0aGUgZHJpdmVyIHRvIHRoZQpyaWdodCBsb2NhdGlvbiAoc3BpKSBtaWdodCBmaXggaXQuCgpU aGFua3MsCk1pcXXDqGwKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlz dHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B0737D091; Tue, 19 Mar 2024 09:53:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.199 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710841998; cv=none; b=P6WzyhgVqDcDgpGSnxbFKwWLBLkXZYr6Di5ZaIx2T9ySBvo2P7kSSc03pbqNp35ZtRBJuMWnODzsmMIFAhpqS9T6k+DAbGm4F0Xw8RnVcbM5L8TFK1UTt4CtIzgOxuubqJt/XjHT55vi9HUcE3ZTMSw6XNFZJ7N8D4yRb/y0KWI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710841998; c=relaxed/simple; bh=+EBDDiNG/eNmY+ueIncptOoRVdMb4em3Z5Wr8wvDjWc=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=eT599ovg/h5gksf2peHpljZwiDViu2tXiZysqg9Bue1Vclz+uCcWAd1DfKeeJQAVCPWrNav/K6tB85rJ13rxWMY6jxeenEC4zNWQoMwg2f3yH0Xpkc8wmzkY9rJd52x1G7/bRE5sRxBeNrIgrPh82HTH+zD/Uyav2iY2GhR5atI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=LyzUosUW; arc=none smtp.client-ip=217.70.183.199 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="LyzUosUW" Received: by mail.gandi.net (Postfix) with ESMTPSA id B3CB1FF80D; Tue, 19 Mar 2024 09:53:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1710841993; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+EBDDiNG/eNmY+ueIncptOoRVdMb4em3Z5Wr8wvDjWc=; b=LyzUosUWbZmhrAA4qvwA0ojyg9rDBL6yH+R73/Cl/AGOQYhPpeDYpbVg1jJWu+O1/a6MiY GBtEWVlXLRdBYAfeMbmpOHGLpgAKW+VDmM+X3OTurys03prNWASCLdD7QloxLQT5lWKEcK Jwor7i4jxb3XKQjqvKriBWQQpRtMnJVJicefmt3ecDm2AlHMHsSaMVfI95oAdTr03N/yRg +qp5UgKZGXIpdlewjym3wvEOhprR6T9pCv9wPgYXSxkC5i1o17+vt8Cbj0CF15sCTGTSpK SRTtIkMjzAFEMh75v0eGJSLFpvSufCkkMYqFgr3oJdm08AfYkBdvYQMPZiXCvw== Date: Tue, 19 Mar 2024 10:53:09 +0100 From: Miquel Raynal To: Krzysztof Kozlowski Cc: Manojkiran Eda , patrick.rudolph@9elements.com, chiawei_wang@aspeedtech.com, ryan_chen@aspeedtech.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, joel@jms.id.au, andrew@codeconstruct.com.au, richard@nod.at, vigneshr@ti.com, jk@codeconstruct.com.au, openbmc@lists.ozlabs.org Subject: Re: [PATCH v2 2/4] mtd: Replace module_init with subsys_initcall Message-ID: <20240319105309.7cdfe106@xps-13> In-Reply-To: <4e3fbff7-6edc-4196-bc72-1095f14d0dfa@linaro.org> References: <20240319093405.39833-1-manojkiran.eda@gmail.com> <20240319093405.39833-3-manojkiran.eda@gmail.com> <4e3fbff7-6edc-4196-bc72-1095f14d0dfa@linaro.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com Hi, krzysztof.kozlowski@linaro.org wrote on Tue, 19 Mar 2024 10:51:00 +0100: > On 19/03/2024 10:34, Manojkiran Eda wrote: > > While engaged in development on the espi kernel device driver[1], > > I noticed that the espi flash driver, utilizing the mtd subsystem, > > appears to initialize before the mtdcore subsystem registers the =20 >=20 > NAK >=20 > You incorrectly ordered your call, so now to fix this you incorrectly > re-order rest of kernel. No. Fix your code to handle modules, probe > deferrals and device links. Agreed. You shall not need this. Maybe just moving the driver to the right location (spi) might fix it. Thanks, Miqu=C3=A8l