From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6357CC54E60 for ; Tue, 19 Mar 2024 12:20:36 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 0FEDF400F0; Tue, 19 Mar 2024 12:20:36 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wZXMfDLCtDal; Tue, 19 Mar 2024 12:20:35 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 1967640210 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1710850835; bh=/JUzSNwMGiexr9JmNWOvy45OaME6cGyDhUFtqcrgpGg=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=PbycGobGLPaQ2eHE5dCgLqDru2Sr/DWBURIWE3eSsZNpaFzAI704UGSaZbVw1PW2O KYXuLUfjWsu9cNxCftyxVTL7RbFClLw9JjTbgDw2QEY4OlPkCNgR64YW5mQ4Y7vEwC HOWTkDhayTlSYfarIJQr3rr4WFBrPaak4mOYN/q019so7hCAVc9LSJt0miZB3RSZZF S0ZB2cEUoMCmmlJZUeeuIG5SEi+B7jGR1MQA3Ji/p3ClnH6QV9u1/HDjp+0nVXHESf wlv8enhICgs4rhyQYFUXKV6YsbdwL87pP+UwZcxhv6iZrrBfERMvktBdvwIzALi/H5 B80dPDlmu66Tg== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id 1967640210; Tue, 19 Mar 2024 12:20:35 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 173131BF406 for ; Tue, 19 Mar 2024 12:20:34 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 0FAC840BAC for ; Tue, 19 Mar 2024 12:20:34 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id O5eU8-rqfC0F for ; Tue, 19 Mar 2024 12:20:33 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=145.40.73.55; helo=sin.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org 1CC7640B9B DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 1CC7640B9B Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by smtp2.osuosl.org (Postfix) with ESMTPS id 1CC7640B9B for ; Tue, 19 Mar 2024 12:20:32 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 8D465CE09CF; Tue, 19 Mar 2024 12:20:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 83730C433F1; Tue, 19 Mar 2024 12:20:26 +0000 (UTC) Date: Tue, 19 Mar 2024 12:20:24 +0000 From: Simon Horman To: Erwan Velu Message-ID: <20240319122024.GJ185808@kernel.org> References: <20240313090719.33627-2-e.velu@criteo.com> <20240318174503.GE1623@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710850828; bh=tNjc7nnylbSais8DsBZzrd94/93ipPvqn/Y1zZVH5cY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SbHqefuwZCTg0JhEXhmcav1tqE1RvW1qxgfFL3NcJMxJPjvFqXymUJMuM5zHZPQyH RpqEg6luMeCCical3TSfiYCfH13sfAD8yFcNsk51GavJpxfWumLcUBMKrf6sq6Eldf /9bX5L3dLu0QFgZ2565+JYS1Xjeo1f7GHysCEYqFj32ovCjs0jMxBVXrvJDPJVLvB8 kP+xLED7mQkRw9KWRzyRfiu50/5WMhqSLooGP2y9osfNbxjUg/zA6/4X6uaKfQ+6cB skse6WaHo5ZIvL8Q5I3wNfbuaOpBOLOiV2SJuvn69xr90FmtJ15sohFbmZQPc/D9SP L+GFTTTCp1SwA== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=none dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=SbHqefuw Subject: Re: [Intel-wired-lan] [PATCH v4 iwl-net] i40e: Prevent setting MTU if greater than MFS X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Erwan Velu , intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org, Eric Dumazet , Tony Nguyen , netdev@vger.kernel.org, Jakub Kicinski , Paolo Abeni , "David S. Miller" Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, Mar 19, 2024 at 12:38:03PM +0100, Erwan Velu wrote: > > Le 18/03/2024 à 18:45, Simon Horman a écrit : > > [...] > > Hi Erwan, all, > > > > As a fix, I think this patch warrants a fixes tag. > > Perhaps this one is appropriate? > > > > Fixes: 41c445ff0f48 ("i40e: main driver core") > > Simon > > Isn't that a bit too generic ? Yes, maybe it is. What we would be after is the first commit where the user can hit the problem the patch addresses. > [..] > > > I am fine with this patch, so please take what follows as a suggestion > > for improvement, possibly as a follow-up. Not as a hard requirement from > > my side. > > > > The part of this function between the two hunks of this patch is: > > > > netdev_err(netdev, "Error changing mtu to %d, Max is %d\n", > > new_mtu, frame_size - I40E_PACKET_HDR_PAD); > > > > My reading is that with this patch two different limits are > > checked wrt maximum MTU size: > > > > 1. A VSI level limit, which relates to RX buffer size > > 2. A PHY level limit that relates to the MFS > > > > That seems fine to me. But the log message for 1 (above) does > > not seem particularly informative wrt which limit has been exceeded. > > I got some comments around this. > > I wanted to keep my patch being focused on the mfs issue, but I can offer a > patch to get a similar output for this. What WRT stands for ? > > > I wanted also to make another patch for this : > > dev_warn(&pdev->dev, "MFS for port %x has been set below the default: > %x\n",pf->hw.port, val); > > The MFS reported as hex without a "0x" prefix is very misleading, I can > offer a patch for this too. FWIIW, I think handling these questions in follow-up patches is fine. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DE037F469; Tue, 19 Mar 2024 12:20:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710850829; cv=none; b=SJg46Jq2QP1sJ2QfiTBhnXOoz+9v79bJnprKApU5qRhPNRbRDdKvw0s5G459JwhbJXGeYBUXkjXOKmM3q3vbEDXLoHH+77jKCkO99VihpiHi4AE4yl1/ZWaLrvUSPAD75+nOdSTe0DxvfCkG7ngOiz63TKOAJU8fLeMfsmN7oCo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710850829; c=relaxed/simple; bh=tNjc7nnylbSais8DsBZzrd94/93ipPvqn/Y1zZVH5cY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TeCIRmvRxJ+lMV/bhShrDULYigrKKVeOWUL15Hj7uE1hKK6b069oJNP3oMYVMWs4UKLz44C236euh930KF2HJXHN7+7ugK58yiK4QISzMYOlZYHe6G5yoU1WnP2frp0OoTEBSJHOP2c3TFgv39/usIzcTfCF6ZmNGsntGd7M+lA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SbHqefuw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SbHqefuw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 83730C433F1; Tue, 19 Mar 2024 12:20:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710850828; bh=tNjc7nnylbSais8DsBZzrd94/93ipPvqn/Y1zZVH5cY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SbHqefuwZCTg0JhEXhmcav1tqE1RvW1qxgfFL3NcJMxJPjvFqXymUJMuM5zHZPQyH RpqEg6luMeCCical3TSfiYCfH13sfAD8yFcNsk51GavJpxfWumLcUBMKrf6sq6Eldf /9bX5L3dLu0QFgZ2565+JYS1Xjeo1f7GHysCEYqFj32ovCjs0jMxBVXrvJDPJVLvB8 kP+xLED7mQkRw9KWRzyRfiu50/5WMhqSLooGP2y9osfNbxjUg/zA6/4X6uaKfQ+6cB skse6WaHo5ZIvL8Q5I3wNfbuaOpBOLOiV2SJuvn69xr90FmtJ15sohFbmZQPc/D9SP L+GFTTTCp1SwA== Date: Tue, 19 Mar 2024 12:20:24 +0000 From: Simon Horman To: Erwan Velu Cc: Erwan Velu , Jesse Brandeburg , Tony Nguyen , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 iwl-net] i40e: Prevent setting MTU if greater than MFS Message-ID: <20240319122024.GJ185808@kernel.org> References: <20240313090719.33627-2-e.velu@criteo.com> <20240318174503.GE1623@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Mar 19, 2024 at 12:38:03PM +0100, Erwan Velu wrote: > > Le 18/03/2024 à 18:45, Simon Horman a écrit : > > [...] > > Hi Erwan, all, > > > > As a fix, I think this patch warrants a fixes tag. > > Perhaps this one is appropriate? > > > > Fixes: 41c445ff0f48 ("i40e: main driver core") > > Simon > > Isn't that a bit too generic ? Yes, maybe it is. What we would be after is the first commit where the user can hit the problem the patch addresses. > [..] > > > I am fine with this patch, so please take what follows as a suggestion > > for improvement, possibly as a follow-up. Not as a hard requirement from > > my side. > > > > The part of this function between the two hunks of this patch is: > > > > netdev_err(netdev, "Error changing mtu to %d, Max is %d\n", > > new_mtu, frame_size - I40E_PACKET_HDR_PAD); > > > > My reading is that with this patch two different limits are > > checked wrt maximum MTU size: > > > > 1. A VSI level limit, which relates to RX buffer size > > 2. A PHY level limit that relates to the MFS > > > > That seems fine to me. But the log message for 1 (above) does > > not seem particularly informative wrt which limit has been exceeded. > > I got some comments around this. > > I wanted to keep my patch being focused on the mfs issue, but I can offer a > patch to get a similar output for this. What WRT stands for ? > > > I wanted also to make another patch for this : > > dev_warn(&pdev->dev, "MFS for port %x has been set below the default: > %x\n",pf->hw.port, val); > > The MFS reported as hex without a "0x" prefix is very misleading, I can > offer a patch for this too. FWIIW, I think handling these questions in follow-up patches is fine.