From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE19F2B9A3; Tue, 19 Mar 2024 13:43:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710855791; cv=none; b=QElO1ro5KKjDiWOByXCa1sY5H1b5ggKK0mM/LCvR267eIPWhgwiNhF1MexdwqVCg0rL0JRKG4fNbuSmOKiqtLZgq8lRxnFhUaXhS+Cf+cD6tuitTkdqhPVrvQwKUJIcEJg72/1z/hsRW8+whK98b+pXxos9KALRGJjo1kR5WBTQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710855791; c=relaxed/simple; bh=WiMdARSt5/lB+0Mj4JwQzBZi0dW5Rc1+tnx2BDCH/jw=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ocZ8UW2R3vj2f0ieDhnq7y76d4uguP4yNmEoLq91n4ZlpsktfKqVQPCxf+Nze1jLjIanO3fi5WkAD8m2YZFNHBUXEeLjFT6Abv3jke+Pksv76aPENA4u+uziksPJMWvEovxZ3wyzJNI4T7R66dMnKL5LkBI2It7/ZguoRFQsvgs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4TzXw66VT8z67byW; Tue, 19 Mar 2024 21:42:30 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id D76BF1400D4; Tue, 19 Mar 2024 21:42:59 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 19 Mar 2024 13:42:59 +0000 Date: Tue, 19 Mar 2024 13:42:58 +0000 From: Jonathan Cameron To: Sean Anderson CC: Jonathan Cameron , "O'Griofa, Conall" , "linux-iio@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Lars-Peter Clausen Subject: Re: [PATCH] iio: xilinx-ams: Don't include ams_ctrl_channels in scan_mask Message-ID: <20240319134258.0000574d@Huawei.com> In-Reply-To: <7ddf8d4a-5b68-432d-93c1-ff270403cb60@linux.dev> References: <20240311162800.11074-1-sean.anderson@linux.dev> <20240314154824.37150a54@jic23-huawei> <3b481539-0c9c-4110-ad03-bd252e80efb0@linux.dev> <20240316133627.5d2bf585@jic23-huawei> <7ee83f15-88fc-4530-84b7-b8ee31663dbc@linux.dev> <20240318152446.00001345@Huawei.com> <7ddf8d4a-5b68-432d-93c1-ff270403cb60@linux.dev> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: lhrpeml500003.china.huawei.com (7.191.162.67) To lhrpeml500005.china.huawei.com (7.191.163.240) On Mon, 18 Mar 2024 11:28:49 -0400 Sean Anderson wrote: > On 3/18/24 11:24, Jonathan Cameron wrote: > > On Mon, 18 Mar 2024 11:18:43 -0400 > > Sean Anderson wrote: > > =20 > >> On 3/16/24 09:36, Jonathan Cameron wrote: =20 > >> > On Fri, 15 Mar 2024 13:47:40 -0400 > >> > Sean Anderson wrote: > >> > =20 > >> >> Hi Conall, > >> >>=20 > >> >> On 3/15/24 09:18, O'Griofa, Conall wrote: =20 > >> >> > [AMD Official Use Only - General] > >> >> >=20 > >> >> > Hi, > >> >> >=20 > >> >> > I think there was a fix for this issue applied to the version tha= t was running on 5.15 that didn't seem to make it into the upstream driver. > >> >> > Please see link for reference https://github.com/Xilinx/linux-xln= x/commit/608426961f16ab149b1b699f1c35f7ad244c0720 > >> >> >=20 > >> >> > I think a similar fix to the above patch is may be beneficial? = =20 > >> >>=20 > >> >> These patches look functionally identical to me. =20 > >> >=20 > >> > Because there are no channels with scan index between > >> > 22 * 2 + 16 (that patch) and 22 * 3 (your patch) that is > >> > the effect is indeed the same. But given the issues is the > >> > 64 limit on maximum scan index, 22 * 3 =3D 66 is an ugly value > >> > to compare with. > >> >=20 > >> > I'm still very against the use of scan_index for anything other > >> > than scan indices (which is why partly how this bug wasn't noticed > >> > in the first palce). So the check should be scan_index !=3D -1 > >> > and uses of those values elsewhere in the driver should be fixed > >> > (which looks simple to do from a quick glance at the code). =20 > >>=20 > >> OK, so how do the sysfs files get named then? =20 > >=20 > > Using channel and channel2 as appropriate (+ index and modified > > which change the meaning of channel2) - scan_index never had > > anything to do with sysfs file names - just the value in > > bufferX/in_xyz_scan_index =20 >=20 > I tried to prototype setting scan_index to -1, but when registering chann= els I saw >=20 > [ 1.637049] iio iio:device0: tried to double register : in_voltage_raw > [ 1.637245] xilinx-ams ffa50000.ams: Failed to register sysfs interfac= es > [ 1.637433] xilinx-ams: probe of ffa50000.ams failed with error -16 >=20 > And AIUI .channel is filled in by ams_parse_firmware. Is indexed set for the channel? Check it at the point of calling devm_iio_device_register() as the code that builds the channels in this driver is complex, so maybe it's getting overwritten? There might be a core bug somewhere, but there are other drivers using -1 scan index without hitting this problem so my first instinct is something is getting wrongly set in the driver. Jonathan >=20 > --Sean >=20 > >>=20 > >> --Sean > >> =20 > >> >>=20 > >> >> --Sean > >> >> =20 > >> >> >> -----Original Message----- > >> >> >> From: Sean Anderson > >> >> >> Sent: Thursday, March 14, 2024 5:30 PM > >> >> >> To: Jonathan Cameron > >> >> >> Cc: linux-iio@vger.kernel.org; O'Griofa, Conall ; > >> >> >> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.o= rg; Lars-Peter > >> >> >> Clausen > >> >> >> Subject: Re: [PATCH] iio: xilinx-ams: Don't include ams_ctrl_cha= nnels in > >> >> >> scan_mask > >> >> >> > >> >> >> Caution: This message originated from an External Source. Use pr= oper caution > >> >> >> when opening attachments, clicking links, or responding. > >> >> >> > >> >> >> > >> >> >> On 3/14/24 11:48, Jonathan Cameron wrote: =20 > >> >> >> > On Mon, 11 Mar 2024 12:28:00 -0400 > >> >> >> > Sean Anderson wrote: > >> >> >> > =20 > >> >> >> >> ams_enable_channel_sequence constructs a "scan_mask" for all = the PS > >> >> >> >> and PL channels. This works out fine, since scan_index for th= ese > >> >> >> >> channels is less than 64. However, it also includes the > >> >> >> >> ams_ctrl_channels, where scan_index is greater than 64, trigg= ering > >> >> >> >> undefined behavior. Since we don't need these channels anyway= , just =20 > >> >> >> exclude them. =20 > >> >> >> >> > >> >> >> >> Fixes: d5c70627a794 ("iio: adc: Add Xilinx AMS driver") > >> >> >> >> Signed-off-by: Sean Anderson =20 > >> >> >> > > >> >> >> > Hi Sean, > >> >> >> > > >> >> >> > I'd ideally like to understand why we have channels with such = large > >> >> >> > scan indexes. Those values should only be used for buffered c= apture. > >> >> >> > It feels like they are being abused here. Can we set them to = -1 > >> >> >> > instead and check based on that? > >> >> >> > For a channel, a scan index of -1 means it can't be captured v= ia the > >> >> >> > buffered interfaces but only accessed via sysfs reads. > >> >> >> > I think that's what we have here? =20 > >> >> >> > >> >> >> From what I can tell, none of the channels support buffered read= s. And we can't > >> >> >> nai=CC=88vely convert the scan_index to -1, since that causes sy= sfs naming conflicts > >> >> >> (not to mention the compatibility break). > >> >> >> =20 > >> >> >> > > >> >> >> > I just feel like if we leave these as things stand, we will ge= t bitten > >> >> >> > by similar bugs in the future. At least with -1 it should be = obvious why! =20 > >> >> >> > >> >> >> There are just as likely to be bugs confusing the PL/PS subdevic= es... > >> >> >> > >> >> >> FWIW I had no trouble identifying the channels involved with thi= s bug. > >> >> >> > >> >> >> --Sean > >> >> >> =20 > >> >> >> > Jonathan > >> >> >> > > >> >> >> > =20 > >> >> >> >> --- > >> >> >> >> > >> >> >> >> drivers/iio/adc/xilinx-ams.c | 8 ++++++-- > >> >> >> >> 1 file changed, 6 insertions(+), 2 deletions(-) > >> >> >> >> > >> >> >> >> diff --git a/drivers/iio/adc/xilinx-ams.c > >> >> >> >> b/drivers/iio/adc/xilinx-ams.c index a55396c1f8b2..4de7ce598e= 4d > >> >> >> >> 100644 > >> >> >> >> --- a/drivers/iio/adc/xilinx-ams.c > >> >> >> >> +++ b/drivers/iio/adc/xilinx-ams.c > >> >> >> >> @@ -414,8 +414,12 @@ static void ams_enable_channel_sequence(= struct > >> >> >> >> iio_dev *indio_dev) > >> >> >> >> > >> >> >> >> /* Run calibration of PS & PL as part of the sequence */ > >> >> >> >> scan_mask =3D BIT(0) | BIT(AMS_PS_SEQ_MAX); > >> >> >> >> - for (i =3D 0; i < indio_dev->num_channels; i++) > >> >> >> >> - scan_mask |=3D BIT_ULL(indio_dev->channels[i].sc= an_index); > >> >> >> >> + for (i =3D 0; i < indio_dev->num_channels; i++) { > >> >> >> >> + const struct iio_chan_spec *chan =3D > >> >> >> >> + &indio_dev->channels[i]; > >> >> >> >> + > >> >> >> >> + if (chan->scan_index < AMS_CTRL_SEQ_BASE) > >> >> >> >> + scan_mask |=3D BIT_ULL(chan->scan_index); > >> >> >> >> + } > >> >> >> >> > >> >> >> >> if (ams->ps_base) { > >> >> >> >> /* put sysmon in a soft reset to change the sequ= ence */ =20 > >> >> >> > =20 > >> >> =20 > >> > =20 > >>=20 > >> =20 > > =20 >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B501C54E60 for ; Tue, 19 Mar 2024 13:43:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Sv8rmCGkhJmWJkqF/ud4xYpFNPt7HxPt1lj/FgIjofo=; b=QtbogQGIKcfcoL WNRG9duHg5w90catS1bPmwkyrurOUil8kEoBmoDNSLybVBRx62xn1tIHHvz07X6WMl7GrQAhS6567 tTI5WqWV5NIKIBI64G3NGvEB1Yx0rK8NNAlplHA1hxNDSkMiyo1/ojZgaP4xEZmGzPAfKU1cCJnPD +nnvC5eMA0GEBP4oHfoSCH4QB/QrEGWWNSoFJehYAQTHYFQQsk4oZqqVgVybL6+DX8BM0u3C64EDy mtbXkIM975WHXcmpbh8YqXpNeF1cGDakRIdfxfiym4ux4b3RgJ2XGq0+piZh1ygvnQLvL3JrPxWNd 0w2B/30OjtQySHX7Xt/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmZkI-0000000CqR3-2TKd; Tue, 19 Mar 2024 13:43:14 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmZkF-0000000CqPx-0Gvp for linux-arm-kernel@lists.infradead.org; Tue, 19 Mar 2024 13:43:13 +0000 Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4TzXw66VT8z67byW; Tue, 19 Mar 2024 21:42:30 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id D76BF1400D4; Tue, 19 Mar 2024 21:42:59 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 19 Mar 2024 13:42:59 +0000 Date: Tue, 19 Mar 2024 13:42:58 +0000 From: Jonathan Cameron To: Sean Anderson CC: Jonathan Cameron , "O'Griofa, Conall" , "linux-iio@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Lars-Peter Clausen Subject: Re: [PATCH] iio: xilinx-ams: Don't include ams_ctrl_channels in scan_mask Message-ID: <20240319134258.0000574d@Huawei.com> In-Reply-To: <7ddf8d4a-5b68-432d-93c1-ff270403cb60@linux.dev> References: <20240311162800.11074-1-sean.anderson@linux.dev> <20240314154824.37150a54@jic23-huawei> <3b481539-0c9c-4110-ad03-bd252e80efb0@linux.dev> <20240316133627.5d2bf585@jic23-huawei> <7ee83f15-88fc-4530-84b7-b8ee31663dbc@linux.dev> <20240318152446.00001345@Huawei.com> <7ddf8d4a-5b68-432d-93c1-ff270403cb60@linux.dev> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml500003.china.huawei.com (7.191.162.67) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240319_064311_505107_C17D7DFC X-CRM114-Status: GOOD ( 47.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAxOCBNYXIgMjAyNCAxMToyODo0OSAtMDQwMApTZWFuIEFuZGVyc29uIDxzZWFuLmFu ZGVyc29uQGxpbnV4LmRldj4gd3JvdGU6Cgo+IE9uIDMvMTgvMjQgMTE6MjQsIEpvbmF0aGFuIENh bWVyb24gd3JvdGU6Cj4gPiBPbiBNb24sIDE4IE1hciAyMDI0IDExOjE4OjQzIC0wNDAwCj4gPiBT ZWFuIEFuZGVyc29uIDxzZWFuLmFuZGVyc29uQGxpbnV4LmRldj4gd3JvdGU6Cj4gPiAgIAo+ID4+ IE9uIDMvMTYvMjQgMDk6MzYsIEpvbmF0aGFuIENhbWVyb24gd3JvdGU6ICAKPiA+PiA+IE9uIEZy aSwgMTUgTWFyIDIwMjQgMTM6NDc6NDAgLTA0MDAKPiA+PiA+IFNlYW4gQW5kZXJzb24gPHNlYW4u YW5kZXJzb25AbGludXguZGV2PiB3cm90ZToKPiA+PiA+ICAgICAKPiA+PiA+PiBIaSBDb25hbGws Cj4gPj4gPj4gCj4gPj4gPj4gT24gMy8xNS8yNCAwOToxOCwgTydHcmlvZmEsIENvbmFsbCB3cm90 ZTogICAgCj4gPj4gPj4gPiBbQU1EIE9mZmljaWFsIFVzZSBPbmx5IC0gR2VuZXJhbF0KPiA+PiA+ PiA+IAo+ID4+ID4+ID4gSGksCj4gPj4gPj4gPiAKPiA+PiA+PiA+IEkgdGhpbmsgdGhlcmUgd2Fz IGEgZml4IGZvciB0aGlzIGlzc3VlIGFwcGxpZWQgdG8gdGhlIHZlcnNpb24gdGhhdCB3YXMgcnVu bmluZyBvbiA1LjE1IHRoYXQgZGlkbid0IHNlZW0gdG8gbWFrZSBpdCBpbnRvIHRoZSB1cHN0cmVh bSBkcml2ZXIuCj4gPj4gPj4gPiBQbGVhc2Ugc2VlIGxpbmsgZm9yIHJlZmVyZW5jZSBodHRwczov L2dpdGh1Yi5jb20vWGlsaW54L2xpbnV4LXhsbngvY29tbWl0LzYwODQyNjk2MWYxNmFiMTQ5YjFi Njk5ZjFjMzVmN2FkMjQ0YzA3MjAKPiA+PiA+PiA+IAo+ID4+ID4+ID4gSSB0aGluayBhIHNpbWls YXIgZml4IHRvIHRoZSBhYm92ZSBwYXRjaCBpcyBtYXkgYmUgYmVuZWZpY2lhbD8gICAgICAKPiA+ PiA+PiAKPiA+PiA+PiBUaGVzZSBwYXRjaGVzIGxvb2sgZnVuY3Rpb25hbGx5IGlkZW50aWNhbCB0 byBtZS4gICAgCj4gPj4gPiAKPiA+PiA+IEJlY2F1c2UgdGhlcmUgYXJlIG5vIGNoYW5uZWxzIHdp dGggc2NhbiBpbmRleCBiZXR3ZWVuCj4gPj4gPiAyMiAqIDIgKyAxNiAodGhhdCBwYXRjaCkgYW5k IDIyICogMyAoeW91ciBwYXRjaCkgdGhhdCBpcwo+ID4+ID4gdGhlIGVmZmVjdCBpcyBpbmRlZWQg dGhlIHNhbWUuIEJ1dCBnaXZlbiB0aGUgaXNzdWVzIGlzIHRoZQo+ID4+ID4gNjQgbGltaXQgb24g bWF4aW11bSBzY2FuIGluZGV4LCAyMiAqIDMgPSA2NiBpcyBhbiB1Z2x5IHZhbHVlCj4gPj4gPiB0 byBjb21wYXJlIHdpdGguCj4gPj4gPiAKPiA+PiA+IEknbSBzdGlsbCB2ZXJ5IGFnYWluc3QgdGhl IHVzZSBvZiBzY2FuX2luZGV4IGZvciBhbnl0aGluZyBvdGhlcgo+ID4+ID4gdGhhbiBzY2FuIGlu ZGljZXMgKHdoaWNoIGlzIHdoeSBwYXJ0bHkgaG93IHRoaXMgYnVnIHdhc24ndCBub3RpY2VkCj4g Pj4gPiBpbiB0aGUgZmlyc3QgcGFsY2UpLiBTbyB0aGUgY2hlY2sgc2hvdWxkIGJlIHNjYW5faW5k ZXggIT0gLTEKPiA+PiA+IGFuZCB1c2VzIG9mIHRob3NlIHZhbHVlcyBlbHNld2hlcmUgaW4gdGhl IGRyaXZlciBzaG91bGQgYmUgZml4ZWQKPiA+PiA+ICh3aGljaCBsb29rcyBzaW1wbGUgdG8gZG8g ZnJvbSBhIHF1aWNrIGdsYW5jZSBhdCB0aGUgY29kZSkuICAgIAo+ID4+IAo+ID4+IE9LLCBzbyBo b3cgZG8gdGhlIHN5c2ZzIGZpbGVzIGdldCBuYW1lZCB0aGVuPyAgCj4gPiAKPiA+IFVzaW5nIGNo YW5uZWwgYW5kIGNoYW5uZWwyIGFzIGFwcHJvcHJpYXRlICgrIGluZGV4IGFuZCBtb2RpZmllZAo+ ID4gd2hpY2ggY2hhbmdlIHRoZSBtZWFuaW5nIG9mIGNoYW5uZWwyKSAtIHNjYW5faW5kZXggbmV2 ZXIgaGFkCj4gPiBhbnl0aGluZyB0byBkbyB3aXRoIHN5c2ZzIGZpbGUgbmFtZXMgLSBqdXN0IHRo ZSB2YWx1ZSBpbgo+ID4gYnVmZmVyWC9pbl94eXpfc2Nhbl9pbmRleCAgCj4gCj4gSSB0cmllZCB0 byBwcm90b3R5cGUgc2V0dGluZyBzY2FuX2luZGV4IHRvIC0xLCBidXQgd2hlbiByZWdpc3Rlcmlu ZyBjaGFubmVscyBJIHNhdwo+IAo+IFsgICAgMS42MzcwNDldIGlpbyBpaW86ZGV2aWNlMDogdHJp ZWQgdG8gZG91YmxlIHJlZ2lzdGVyIDogaW5fdm9sdGFnZV9yYXcKPiBbICAgIDEuNjM3MjQ1XSB4 aWxpbngtYW1zIGZmYTUwMDAwLmFtczogRmFpbGVkIHRvIHJlZ2lzdGVyIHN5c2ZzIGludGVyZmFj ZXMKPiBbICAgIDEuNjM3NDMzXSB4aWxpbngtYW1zOiBwcm9iZSBvZiBmZmE1MDAwMC5hbXMgZmFp bGVkIHdpdGggZXJyb3IgLTE2Cj4gCj4gQW5kIEFJVUkgLmNoYW5uZWwgaXMgZmlsbGVkIGluIGJ5 IGFtc19wYXJzZV9maXJtd2FyZS4KCklzIGluZGV4ZWQgc2V0IGZvciB0aGUgY2hhbm5lbD8gIENo ZWNrIGl0IGF0IHRoZSBwb2ludCBvZiBjYWxsaW5nCmRldm1faWlvX2RldmljZV9yZWdpc3Rlcigp IGFzIHRoZSBjb2RlIHRoYXQgYnVpbGRzIHRoZSBjaGFubmVscyBpbiB0aGlzCmRyaXZlciBpcyBj b21wbGV4LCBzbyBtYXliZSBpdCdzIGdldHRpbmcgb3ZlcndyaXR0ZW4/CgpUaGVyZSBtaWdodCBi ZSBhIGNvcmUgYnVnIHNvbWV3aGVyZSwgYnV0IHRoZXJlIGFyZSBvdGhlciBkcml2ZXJzIHVzaW5n Ci0xIHNjYW4gaW5kZXggd2l0aG91dCBoaXR0aW5nIHRoaXMgcHJvYmxlbSBzbyBteSBmaXJzdCBp bnN0aW5jdCBpcwpzb21ldGhpbmcgaXMgZ2V0dGluZyB3cm9uZ2x5IHNldCBpbiB0aGUgZHJpdmVy LgoKSm9uYXRoYW4KCj4gCj4gLS1TZWFuCj4gCj4gPj4gCj4gPj4gLS1TZWFuCj4gPj4gICAKPiA+ PiA+PiAKPiA+PiA+PiAtLVNlYW4KPiA+PiA+PiAgICAgCj4gPj4gPj4gPj4gLS0tLS1PcmlnaW5h bCBNZXNzYWdlLS0tLS0KPiA+PiA+PiA+PiBGcm9tOiBTZWFuIEFuZGVyc29uIDxzZWFuLmFuZGVy c29uQGxpbnV4LmRldj4KPiA+PiA+PiA+PiBTZW50OiBUaHVyc2RheSwgTWFyY2ggMTQsIDIwMjQg NTozMCBQTQo+ID4+ID4+ID4+IFRvOiBKb25hdGhhbiBDYW1lcm9uIDxqaWMyM0BrZXJuZWwub3Jn Pgo+ID4+ID4+ID4+IENjOiBsaW51eC1paW9Admdlci5rZXJuZWwub3JnOyBPJ0dyaW9mYSwgQ29u YWxsIDxjb25hbGwub2dyaW9mYUBhbWQuY29tPjsKPiA+PiA+PiA+PiBsaW51eC1hcm0ta2VybmVs QGxpc3RzLmluZnJhZGVhZC5vcmc7IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc7IExhcnMt UGV0ZXIKPiA+PiA+PiA+PiBDbGF1c2VuIDxsYXJzQG1ldGFmb28uZGU+Cj4gPj4gPj4gPj4gU3Vi amVjdDogUmU6IFtQQVRDSF0gaWlvOiB4aWxpbngtYW1zOiBEb24ndCBpbmNsdWRlIGFtc19jdHJs X2NoYW5uZWxzIGluCj4gPj4gPj4gPj4gc2Nhbl9tYXNrCj4gPj4gPj4gPj4KPiA+PiA+PiA+PiBD YXV0aW9uOiBUaGlzIG1lc3NhZ2Ugb3JpZ2luYXRlZCBmcm9tIGFuIEV4dGVybmFsIFNvdXJjZS4g VXNlIHByb3BlciBjYXV0aW9uCj4gPj4gPj4gPj4gd2hlbiBvcGVuaW5nIGF0dGFjaG1lbnRzLCBj bGlja2luZyBsaW5rcywgb3IgcmVzcG9uZGluZy4KPiA+PiA+PiA+Pgo+ID4+ID4+ID4+Cj4gPj4g Pj4gPj4gT24gMy8xNC8yNCAxMTo0OCwgSm9uYXRoYW4gQ2FtZXJvbiB3cm90ZTogICAgICAKPiA+ PiA+PiA+PiA+IE9uIE1vbiwgMTEgTWFyIDIwMjQgMTI6Mjg6MDAgLTA0MDAKPiA+PiA+PiA+PiA+ IFNlYW4gQW5kZXJzb24gPHNlYW4uYW5kZXJzb25AbGludXguZGV2PiB3cm90ZToKPiA+PiA+PiA+ PiA+ICAgICAgCj4gPj4gPj4gPj4gPj4gYW1zX2VuYWJsZV9jaGFubmVsX3NlcXVlbmNlIGNvbnN0 cnVjdHMgYSAic2Nhbl9tYXNrIiBmb3IgYWxsIHRoZSBQUwo+ID4+ID4+ID4+ID4+IGFuZCBQTCBj aGFubmVscy4gVGhpcyB3b3JrcyBvdXQgZmluZSwgc2luY2Ugc2Nhbl9pbmRleCBmb3IgdGhlc2UK PiA+PiA+PiA+PiA+PiBjaGFubmVscyBpcyBsZXNzIHRoYW4gNjQuIEhvd2V2ZXIsIGl0IGFsc28g aW5jbHVkZXMgdGhlCj4gPj4gPj4gPj4gPj4gYW1zX2N0cmxfY2hhbm5lbHMsIHdoZXJlIHNjYW5f aW5kZXggaXMgZ3JlYXRlciB0aGFuIDY0LCB0cmlnZ2VyaW5nCj4gPj4gPj4gPj4gPj4gdW5kZWZp bmVkIGJlaGF2aW9yLiBTaW5jZSB3ZSBkb24ndCBuZWVkIHRoZXNlIGNoYW5uZWxzIGFueXdheSwg anVzdCAgICAgIAo+ID4+ID4+ID4+IGV4Y2x1ZGUgdGhlbS4gICAgICAKPiA+PiA+PiA+PiA+Pgo+ ID4+ID4+ID4+ID4+IEZpeGVzOiBkNWM3MDYyN2E3OTQgKCJpaW86IGFkYzogQWRkIFhpbGlueCBB TVMgZHJpdmVyIikKPiA+PiA+PiA+PiA+PiBTaWduZWQtb2ZmLWJ5OiBTZWFuIEFuZGVyc29uIDxz ZWFuLmFuZGVyc29uQGxpbnV4LmRldj4gICAgICAKPiA+PiA+PiA+PiA+Cj4gPj4gPj4gPj4gPiBI aSBTZWFuLAo+ID4+ID4+ID4+ID4KPiA+PiA+PiA+PiA+IEknZCBpZGVhbGx5IGxpa2UgdG8gdW5k ZXJzdGFuZCB3aHkgd2UgaGF2ZSBjaGFubmVscyB3aXRoIHN1Y2ggbGFyZ2UKPiA+PiA+PiA+PiA+ IHNjYW4gaW5kZXhlcy4gIFRob3NlIHZhbHVlcyBzaG91bGQgb25seSBiZSB1c2VkIGZvciBidWZm ZXJlZCBjYXB0dXJlLgo+ID4+ID4+ID4+ID4gSXQgZmVlbHMgbGlrZSB0aGV5IGFyZSBiZWluZyBh YnVzZWQgaGVyZS4gIENhbiB3ZSBzZXQgdGhlbSB0byAtMQo+ID4+ID4+ID4+ID4gaW5zdGVhZCBh bmQgY2hlY2sgYmFzZWQgb24gdGhhdD8KPiA+PiA+PiA+PiA+IEZvciBhIGNoYW5uZWwsIGEgc2Nh biBpbmRleCBvZiAtMSBtZWFucyBpdCBjYW4ndCBiZSBjYXB0dXJlZCB2aWEgdGhlCj4gPj4gPj4g Pj4gPiBidWZmZXJlZCBpbnRlcmZhY2VzIGJ1dCBvbmx5IGFjY2Vzc2VkIHZpYSBzeXNmcyByZWFk cy4KPiA+PiA+PiA+PiA+IEkgdGhpbmsgdGhhdCdzIHdoYXQgd2UgaGF2ZSBoZXJlPyAgICAgIAo+ ID4+ID4+ID4+Cj4gPj4gPj4gPj4gRnJvbSB3aGF0IEkgY2FuIHRlbGwsIG5vbmUgb2YgdGhlIGNo YW5uZWxzIHN1cHBvcnQgYnVmZmVyZWQgcmVhZHMuIEFuZCB3ZSBjYW4ndAo+ID4+ID4+ID4+IG5h acyIdmVseSBjb252ZXJ0IHRoZSBzY2FuX2luZGV4IHRvIC0xLCBzaW5jZSB0aGF0IGNhdXNlcyBz eXNmcyBuYW1pbmcgY29uZmxpY3RzCj4gPj4gPj4gPj4gKG5vdCB0byBtZW50aW9uIHRoZSBjb21w YXRpYmlsaXR5IGJyZWFrKS4KPiA+PiA+PiA+PiAgICAgIAo+ID4+ID4+ID4+ID4KPiA+PiA+PiA+ PiA+IEkganVzdCBmZWVsIGxpa2UgaWYgd2UgbGVhdmUgdGhlc2UgYXMgdGhpbmdzIHN0YW5kLCB3 ZSB3aWxsIGdldCBiaXR0ZW4KPiA+PiA+PiA+PiA+IGJ5IHNpbWlsYXIgYnVncyBpbiB0aGUgZnV0 dXJlLiAgQXQgbGVhc3Qgd2l0aCAtMSBpdCBzaG91bGQgYmUgb2J2aW91cyB3aHkhICAgICAgCj4g Pj4gPj4gPj4KPiA+PiA+PiA+PiBUaGVyZSBhcmUganVzdCBhcyBsaWtlbHkgdG8gYmUgYnVncyBj b25mdXNpbmcgdGhlIFBML1BTIHN1YmRldmljZXMuLi4KPiA+PiA+PiA+Pgo+ID4+ID4+ID4+IEZX SVcgSSBoYWQgbm8gdHJvdWJsZSBpZGVudGlmeWluZyB0aGUgY2hhbm5lbHMgaW52b2x2ZWQgd2l0 aCB0aGlzIGJ1Zy4KPiA+PiA+PiA+Pgo+ID4+ID4+ID4+IC0tU2Vhbgo+ID4+ID4+ID4+ICAgICAg Cj4gPj4gPj4gPj4gPiBKb25hdGhhbgo+ID4+ID4+ID4+ID4KPiA+PiA+PiA+PiA+ICAgICAgCj4g Pj4gPj4gPj4gPj4gLS0tCj4gPj4gPj4gPj4gPj4KPiA+PiA+PiA+PiA+PiAgZHJpdmVycy9paW8v YWRjL3hpbGlueC1hbXMuYyB8IDggKysrKysrLS0KPiA+PiA+PiA+PiA+PiAgMSBmaWxlIGNoYW5n ZWQsIDYgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPiA+PiA+PiA+PiA+Pgo+ID4+ID4+ ID4+ID4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2lpby9hZGMveGlsaW54LWFtcy5jCj4gPj4gPj4g Pj4gPj4gYi9kcml2ZXJzL2lpby9hZGMveGlsaW54LWFtcy5jIGluZGV4IGE1NTM5NmMxZjhiMi4u NGRlN2NlNTk4ZTRkCj4gPj4gPj4gPj4gPj4gMTAwNjQ0Cj4gPj4gPj4gPj4gPj4gLS0tIGEvZHJp dmVycy9paW8vYWRjL3hpbGlueC1hbXMuYwo+ID4+ID4+ID4+ID4+ICsrKyBiL2RyaXZlcnMvaWlv L2FkYy94aWxpbngtYW1zLmMKPiA+PiA+PiA+PiA+PiBAQCAtNDE0LDggKzQxNCwxMiBAQCBzdGF0 aWMgdm9pZCBhbXNfZW5hYmxlX2NoYW5uZWxfc2VxdWVuY2Uoc3RydWN0Cj4gPj4gPj4gPj4gPj4g aWlvX2RldiAqaW5kaW9fZGV2KQo+ID4+ID4+ID4+ID4+Cj4gPj4gPj4gPj4gPj4gICAgICAvKiBS dW4gY2FsaWJyYXRpb24gb2YgUFMgJiBQTCBhcyBwYXJ0IG9mIHRoZSBzZXF1ZW5jZSAqLwo+ID4+ ID4+ID4+ID4+ICAgICAgc2Nhbl9tYXNrID0gQklUKDApIHwgQklUKEFNU19QU19TRVFfTUFYKTsK PiA+PiA+PiA+PiA+PiAtICAgIGZvciAoaSA9IDA7IGkgPCBpbmRpb19kZXYtPm51bV9jaGFubmVs czsgaSsrKQo+ID4+ID4+ID4+ID4+IC0gICAgICAgICAgICBzY2FuX21hc2sgfD0gQklUX1VMTChp bmRpb19kZXYtPmNoYW5uZWxzW2ldLnNjYW5faW5kZXgpOwo+ID4+ID4+ID4+ID4+ICsgICAgZm9y IChpID0gMDsgaSA8IGluZGlvX2Rldi0+bnVtX2NoYW5uZWxzOyBpKyspIHsKPiA+PiA+PiA+PiA+ PiArICAgICAgICAgICAgY29uc3Qgc3RydWN0IGlpb19jaGFuX3NwZWMgKmNoYW4gPQo+ID4+ID4+ ID4+ID4+ICsgJmluZGlvX2Rldi0+Y2hhbm5lbHNbaV07Cj4gPj4gPj4gPj4gPj4gKwo+ID4+ID4+ ID4+ID4+ICsgICAgICAgICAgICBpZiAoY2hhbi0+c2Nhbl9pbmRleCA8IEFNU19DVFJMX1NFUV9C QVNFKQo+ID4+ID4+ID4+ID4+ICsgICAgICAgICAgICAgICAgICAgIHNjYW5fbWFzayB8PSBCSVRf VUxMKGNoYW4tPnNjYW5faW5kZXgpOwo+ID4+ID4+ID4+ID4+ICsgICAgfQo+ID4+ID4+ID4+ID4+ Cj4gPj4gPj4gPj4gPj4gICAgICBpZiAoYW1zLT5wc19iYXNlKSB7Cj4gPj4gPj4gPj4gPj4gICAg ICAgICAgICAgIC8qIHB1dCBzeXNtb24gaW4gYSBzb2Z0IHJlc2V0IHRvIGNoYW5nZSB0aGUgc2Vx dWVuY2UgKi8gICAgICAKPiA+PiA+PiA+PiA+ICAgICAgCj4gPj4gPj4gICAgIAo+ID4+ID4gICAg IAo+ID4+IAo+ID4+ICAgCj4gPiAgIAo+IAoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFy bS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK