From: Daniel Thompson <daniel.thompson@linaro.org>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: lee@kernel.org, jingoohan1@gmail.com, deller@gmx.de,
andy@kernel.org, geert@linux-m68k.org, dan.carpenter@linaro.org,
sam@ravnborg.org, dri-devel@lists.freedesktop.org,
linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH v2 3/6] backlight: omap1: Replace FB_BLANK_ states with simple on/off
Date: Tue, 19 Mar 2024 15:25:13 +0000 [thread overview]
Message-ID: <20240319152513.GA9963@aspen.lan> (raw)
In-Reply-To: <20240319093915.31778-4-tzimmermann@suse.de>
On Tue, Mar 19, 2024 at 10:37:22AM +0100, Thomas Zimmermann wrote:
> The backlight is on for fb_blank eq FB_BLANK_UNBLANK, or off for
> any other value in fb_blank. But the field fb_blank in struct
> backlight_properties is deprecated and should not be used any
> longer.
>
> Replace the test for fb_blank in omap's backlight code with a
> simple boolean parameter and push the test into the update_status
> helper. Instead of reading fb_blank directly, decode the backlight
> device's status with backlight_is_blank().
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Daniel.
next prev parent reply other threads:[~2024-03-19 15:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 9:37 [PATCH v2 0/6] backlight: Remove struct backlight_properties.fb_blank Thomas Zimmermann
2024-03-19 9:37 ` [PATCH v2 1/6] auxdisplay: ht16k33: Replace use of fb_blank with backlight helper Thomas Zimmermann
2024-03-19 9:37 ` [PATCH v2 2/6] backlight: omap1: Remove unused struct omap_backlight_config.set_power Thomas Zimmermann
2024-03-19 9:37 ` [PATCH v2 3/6] backlight: omap1: Replace FB_BLANK_ states with simple on/off Thomas Zimmermann
2024-03-19 15:25 ` Daniel Thompson [this message]
2024-03-19 9:37 ` [PATCH v2 4/6] fbdev: omap2/omapfb: Replace use of fb_blank with backlight helpers Thomas Zimmermann
2024-03-19 9:37 ` [PATCH v2 5/6] staging: fbtft: Remove reference to fb_blank Thomas Zimmermann
2024-03-22 9:52 ` Greg KH
2024-03-19 9:37 ` [PATCH v2 6/6] backlight: Remove fb_blank from struct backlight_properties Thomas Zimmermann
2024-03-20 8:46 ` FLAVIO SULIGOI
2024-03-20 8:51 ` Thomas Zimmermann
2024-03-20 9:00 ` EXTERNAL: " FLAVIO SULIGOI
2024-03-21 18:21 ` [PATCH v2 0/6] backlight: Remove struct backlight_properties.fb_blank Lee Jones
2024-03-27 14:40 ` Lee Jones
2024-03-27 14:41 ` Lee Jones
2024-03-28 10:32 ` [GIT PULL] Immutable branch between MFD, Auxdisplay, Staging, fbdev and OMAP due for the v6.9 merge window Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240319152513.GA9963@aspen.lan \
--to=daniel.thompson@linaro.org \
--cc=andy@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=jingoohan1@gmail.com \
--cc=lee@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=sam@ravnborg.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.