From: Petr Vorel <pvorel@suse.cz>
To: Shiyang Ruan <ruansy.fnst@fujitsu.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2] getxattr01: Convert to new API
Date: Wed, 20 Mar 2024 17:37:01 +0100 [thread overview]
Message-ID: <20240320163701.GB496781@pevik> (raw)
In-Reply-To: <20240314101344.4000544-1-ruansy.fnst@fujitsu.com>
Hi,
> -/*
> +/*\
> + * [Description]
> + *
> * Basic tests for getxattr(2) and make sure getxattr(2) handles error
> * conditions correctly.
> *
> @@ -31,112 +15,53 @@
> * getxattr(2) should return -1 and set errno to ENODATA
> * 2. Buffer size is smaller than attribute value size,
> * getxattr(2) should return -1 and set errno to ERANGE
> - * 3. Get attribute, getxattr(2) should succeed
> - * 4. Verify the attribute got by getxattr(2) is same as the value we set
> + * 3. Get attribute, getxattr(2) should succeed, and the attribute got by
> + * getxattr(2) should be same as the value we set
> */
* There are 4 test cases:
Without space here the list will not be formatted correctly :(.
Currently it's needed to add it.
* 1. Get an non-existing attribute,
* getxattr(2) should return -1 and set errno to ENODATA
* 2. Buffer size is smaller than attribute value size,
* getxattr(2) should return -1 and set errno to ERANGE
* 3. Get attribute, getxattr(2) should succeed, and the attribute got by
* getxattr(2) should be same as the value we set
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-03-20 16:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-21 16:11 [LTP] [PATCH 1/2] getxattr04,05: Add [Description] tag Shiyang Ruan
2024-01-21 16:11 ` [LTP] [PATCH 2/2] getxattr01: Convert to new API Shiyang Ruan
2024-03-05 20:52 ` Avinesh Kumar
2024-03-14 10:13 ` [LTP] [PATCH v2] " Shiyang Ruan via ltp
2024-03-20 16:34 ` Petr Vorel
2024-03-20 16:37 ` Petr Vorel [this message]
2024-03-21 10:13 ` [LTP] [PATCH v3] " Shiyang Ruan via ltp
2024-03-22 5:33 ` Petr Vorel
2024-03-05 21:24 ` [LTP] [PATCH v2] getxattr04, 05: Change to docparse comment and typo fixes Avinesh Kumar
2024-03-06 21:48 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240320163701.GB496781@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=ruansy.fnst@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.