From: Jakub Kicinski <kuba@kernel.org>
To: Nicolas Cavallari <nicolas.cavallari@green-communications.fr>
Cc: "David S. Miller" <davem@davemloft.net>,
David Ahern <dsahern@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipv6: delay procfs initialization after the ipv6 structs are ready
Date: Wed, 20 Mar 2024 20:39:41 -0700 [thread overview]
Message-ID: <20240320203941.70facba3@kernel.org> (raw)
In-Reply-To: <20240320171858.2671-1-nicolas.cavallari@green-communications.fr>
On Wed, 20 Mar 2024 18:17:36 +0100 Nicolas Cavallari wrote:
> procfs files are created before the structure they reference are
> initialized. For example, if6_proc_init() creates procfs files that
> access structures initialized by addrconf_init().
>
> If ipv6 is compiled as a module and a program manages to open an ipv6
> procfs file during the loading of the module, it can oops the kernel.
>
> It appears that we were unlucky enough to reproduce this problem
> multiple times already, out of maybe 100 boots:
I haven't investigated too closely but looks like this breaks
all selftests. Please run all net/forwarding selftests before
posting v2?
prev parent reply other threads:[~2024-03-21 3:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 17:17 [PATCH] ipv6: delay procfs initialization after the ipv6 structs are ready Nicolas Cavallari
2024-03-20 22:18 ` Kuniyuki Iwashima
2024-03-21 1:36 ` Shigeru Yoshida
2024-03-21 3:39 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240320203941.70facba3@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.cavallari@green-communications.fr \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.