From: Jakub Kicinski <kuba@kernel.org>
To: Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: Breno Leitao <leitao@debian.org>, Kalle Valo <kvalo@kernel.org>,
Jeff Johnson <jjohnson@kernel.org>, <keescook@chromium.org>,
"open list:NETWORKING DRIVERS (WIRELESS)"
<linux-wireless@vger.kernel.org>,
"open list:QUALCOMM ATHEROS ATH10K WIRELESS DRIVER"
<ath10k@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ath10k: allocate dummy net_device dynamically
Date: Thu, 21 Mar 2024 07:28:21 -0700 [thread overview]
Message-ID: <20240321072821.59f56757@kernel.org> (raw)
In-Reply-To: <9fcdb857-da62-4832-ae11-043fe993e4ad@quicinc.com>
On Wed, 20 Mar 2024 08:12:46 -0700 Jeff Johnson wrote:
> NAK this based upon the ath11k patch results.
The ath11 patch is much more complex, I'd wager this one is fine.
> As suggested there we should just use kmalloc/kfree to match the existing logic.
Please no. There is no magic here. alloc + free must match whether
you're using magic object alloc wrapper (alloc_netdev()) or straight
up kzalloc().
next prev parent reply other threads:[~2024-03-21 14:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 10:47 [PATCH] ath10k: allocate dummy net_device dynamically Breno Leitao
2024-03-19 16:05 ` Jeff Johnson
2024-03-19 17:15 ` Breno Leitao
2024-03-19 18:46 ` Jeff Johnson
2024-03-20 15:12 ` Jeff Johnson
2024-03-20 15:25 ` Kalle Valo
2024-03-20 17:01 ` Breno Leitao
2024-03-21 14:28 ` Jakub Kicinski [this message]
2024-03-21 22:02 ` Jeff Johnson
2024-03-21 22:17 ` Jakub Kicinski
2024-03-22 14:58 ` Breno Leitao
2024-03-22 15:23 ` Jakub Kicinski
2024-03-27 14:38 ` Breno Leitao
2024-03-27 14:45 ` Jakub Kicinski
2024-03-27 15:42 ` Jeff Johnson
2024-03-27 16:17 ` Jakub Kicinski
2024-03-27 15:26 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240321072821.59f56757@kernel.org \
--to=kuba@kernel.org \
--cc=ath10k@lists.infradead.org \
--cc=jjohnson@kernel.org \
--cc=keescook@chromium.org \
--cc=kvalo@kernel.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_jjohnson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.