From: Jakub Kicinski <kuba@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Russell King <linux@armlinux.org.uk>,
Gregory Clement <gregory.clement@bootlin.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH RFC 2/7] net: Add helpers for netdev LEDs
Date: Thu, 21 Mar 2024 08:01:55 -0700 [thread overview]
Message-ID: <20240321080155.1352b481@kernel.org> (raw)
In-Reply-To: <20240317-v6-8-0-net-next-mv88e6xxx-leds-v4-v1-2-80a4e6c6293e@lunn.ch>
On Sun, 17 Mar 2024 16:45:15 -0500 Andrew Lunn wrote:
> + struct device *dev = &ndev->dev;
> + struct netdev_led *netdev_led;
> + struct led_classdev *cdev;
> + u32 index;
> + int err;
> +
> + netdev_led = devm_kzalloc(dev, sizeof(*netdev_led), GFP_KERNEL);
> + if (!netdev_led)
> + return -ENOMEM;
Are we guaranteed to have a real bus device under ndev->dev ?
I'm not aware of any use of devres in netdev core today.
next prev parent reply other threads:[~2024-03-21 15:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-17 21:45 [PATCH RFC 0/7] net: Add generic support for netdev LEDs Andrew Lunn
2024-03-17 21:45 ` [PATCH RFC 1/7] dsa: move call to driver port_setup after creation of netdev Andrew Lunn
2024-03-17 21:45 ` [PATCH RFC 2/7] net: Add helpers for netdev LEDs Andrew Lunn
2024-03-21 15:01 ` Jakub Kicinski [this message]
2024-03-21 15:35 ` Andrew Lunn
2024-03-21 15:43 ` Jakub Kicinski
2024-03-22 18:33 ` Josua Mayer
2024-03-22 18:56 ` Andrew Lunn
2024-03-17 21:45 ` [PATCH RFC 3/7] net: dsa: mv88e6xxx: Add helpers for 6352 LED blink and brightness Andrew Lunn
2024-03-17 21:45 ` [PATCH RFC 4/7] net: dsa: mv88e6xxx: Tie the low level LED functions to device ops Andrew Lunn
2024-03-17 21:45 ` [PATCH RFC 5/7] net: dsa: Add helpers to convert netdev to ds or port index Andrew Lunn
2024-03-17 21:45 ` [PATCH RFC 6/7] dsa: mv88e6xxx: Create port/netdev LEDs Andrew Lunn
2024-03-17 21:45 ` [PATCH RFC 7/7] arm: boot: dts: mvebu: linksys-mamba: Add Ethernet LEDs Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240321080155.1352b481@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=gregory.clement@bootlin.com \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.