From: kernel test robot <lkp@intel.com>
To: David Howells <dhowells@redhat.com>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [dhowells-fs:netfs-writeback 8/21] fs/fuse/file.c:2050:12: warning: 'fuse_writepage_locked' defined but not used
Date: Thu, 21 Mar 2024 15:10:08 +0800 [thread overview]
Message-ID: <202403211454.VerZc1o2-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git netfs-writeback
head: 866387129eff9ec1e77d0a32544f08884c96b072
commit: 6fb9391d86852e9b8983d6ecaa8272d0e3a7dc1c [8/21] mm: Kill ->launder_folio()
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20240321/202403211454.VerZc1o2-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240321/202403211454.VerZc1o2-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202403211454.VerZc1o2-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> fs/fuse/file.c:2050:12: warning: 'fuse_writepage_locked' defined but not used [-Wunused-function]
2050 | static int fuse_writepage_locked(struct folio *folio)
| ^~~~~~~~~~~~~~~~~~~~~
vim +/fuse_writepage_locked +2050 fs/fuse/file.c
660585b56e63ca Miklos Szeredi 2021-09-01 2049
e0887e095a803d Matthew Wilcox (Oracle 2024-02-28 @2050) static int fuse_writepage_locked(struct folio *folio)
3be5a52b30aa5c Miklos Szeredi 2008-04-30 2051 {
e0887e095a803d Matthew Wilcox (Oracle 2024-02-28 2052) struct address_space *mapping = folio->mapping;
3be5a52b30aa5c Miklos Szeredi 2008-04-30 2053 struct inode *inode = mapping->host;
3be5a52b30aa5c Miklos Szeredi 2008-04-30 2054 struct fuse_conn *fc = get_fuse_conn(inode);
3be5a52b30aa5c Miklos Szeredi 2008-04-30 2055 struct fuse_inode *fi = get_fuse_inode(inode);
33826ebbbe4b45 Miklos Szeredi 2019-09-10 2056 struct fuse_writepage_args *wpa;
33826ebbbe4b45 Miklos Szeredi 2019-09-10 2057 struct fuse_args_pages *ap;
e0887e095a803d Matthew Wilcox (Oracle 2024-02-28 2058) struct folio *tmp_folio;
72523425fb434e Miklos Szeredi 2013-10-01 2059 int error = -ENOMEM;
3be5a52b30aa5c Miklos Szeredi 2008-04-30 2060
e0887e095a803d Matthew Wilcox (Oracle 2024-02-28 2061) folio_start_writeback(folio);
3be5a52b30aa5c Miklos Szeredi 2008-04-30 2062
33826ebbbe4b45 Miklos Szeredi 2019-09-10 2063 wpa = fuse_writepage_args_alloc();
33826ebbbe4b45 Miklos Szeredi 2019-09-10 2064 if (!wpa)
3be5a52b30aa5c Miklos Szeredi 2008-04-30 2065 goto err;
33826ebbbe4b45 Miklos Szeredi 2019-09-10 2066 ap = &wpa->ia.ap;
3be5a52b30aa5c Miklos Szeredi 2008-04-30 2067
e0887e095a803d Matthew Wilcox (Oracle 2024-02-28 2068) tmp_folio = folio_alloc(GFP_NOFS | __GFP_HIGHMEM, 0);
e0887e095a803d Matthew Wilcox (Oracle 2024-02-28 2069) if (!tmp_folio)
3be5a52b30aa5c Miklos Szeredi 2008-04-30 2070 goto err_free;
3be5a52b30aa5c Miklos Szeredi 2008-04-30 2071
72523425fb434e Miklos Szeredi 2013-10-01 2072 error = -EIO;
a9667ac88e2b20 Miklos Szeredi 2021-09-01 2073 wpa->ia.ff = fuse_write_file_get(fi);
33826ebbbe4b45 Miklos Szeredi 2019-09-10 2074 if (!wpa->ia.ff)
27f1b36326bc8b Maxim Patlasov 2014-07-10 2075 goto err_nofile;
72523425fb434e Miklos Szeredi 2013-10-01 2076
660585b56e63ca Miklos Szeredi 2021-09-01 2077 fuse_writepage_add_to_bucket(fc, wpa);
e0887e095a803d Matthew Wilcox (Oracle 2024-02-28 2078) fuse_write_args_fill(&wpa->ia, wpa->ia.ff, folio_pos(folio), 0);
3be5a52b30aa5c Miklos Szeredi 2008-04-30 2079
e0887e095a803d Matthew Wilcox (Oracle 2024-02-28 2080) folio_copy(tmp_folio, folio);
33826ebbbe4b45 Miklos Szeredi 2019-09-10 2081 wpa->ia.write.in.write_flags |= FUSE_WRITE_CACHE;
33826ebbbe4b45 Miklos Szeredi 2019-09-10 2082 wpa->next = NULL;
33826ebbbe4b45 Miklos Szeredi 2019-09-10 2083 ap->args.in_pages = true;
33826ebbbe4b45 Miklos Szeredi 2019-09-10 2084 ap->num_pages = 1;
e0887e095a803d Matthew Wilcox (Oracle 2024-02-28 2085) ap->pages[0] = &tmp_folio->page;
33826ebbbe4b45 Miklos Szeredi 2019-09-10 2086 ap->descs[0].offset = 0;
33826ebbbe4b45 Miklos Szeredi 2019-09-10 2087 ap->descs[0].length = PAGE_SIZE;
33826ebbbe4b45 Miklos Szeredi 2019-09-10 2088 ap->args.end = fuse_writepage_end;
33826ebbbe4b45 Miklos Szeredi 2019-09-10 2089 wpa->inode = inode;
3be5a52b30aa5c Miklos Szeredi 2008-04-30 2090
93f78d882865cb Tejun Heo 2015-05-22 2091 inc_wb_stat(&inode_to_bdi(inode)->wb, WB_WRITEBACK);
e0887e095a803d Matthew Wilcox (Oracle 2024-02-28 2092) node_stat_add_folio(tmp_folio, NR_WRITEBACK_TEMP);
3be5a52b30aa5c Miklos Szeredi 2008-04-30 2093
f15ecfef058d94 Kirill Tkhai 2018-11-09 2094 spin_lock(&fi->lock);
6b2fb79963fbed Maxim Patlasov 2019-09-19 2095 tree_insert(&fi->writepages, wpa);
33826ebbbe4b45 Miklos Szeredi 2019-09-10 2096 list_add_tail(&wpa->queue_entry, &fi->queued_writes);
3be5a52b30aa5c Miklos Szeredi 2008-04-30 2097 fuse_flush_writepages(inode);
f15ecfef058d94 Kirill Tkhai 2018-11-09 2098 spin_unlock(&fi->lock);
3be5a52b30aa5c Miklos Szeredi 2008-04-30 2099
e0887e095a803d Matthew Wilcox (Oracle 2024-02-28 2100) folio_end_writeback(folio);
4a4ac4eba1010e Maxim Patlasov 2013-08-12 2101
3be5a52b30aa5c Miklos Szeredi 2008-04-30 2102 return 0;
3be5a52b30aa5c Miklos Szeredi 2008-04-30 2103
27f1b36326bc8b Maxim Patlasov 2014-07-10 2104 err_nofile:
e0887e095a803d Matthew Wilcox (Oracle 2024-02-28 2105) folio_put(tmp_folio);
3be5a52b30aa5c Miklos Szeredi 2008-04-30 2106 err_free:
33826ebbbe4b45 Miklos Szeredi 2019-09-10 2107 kfree(wpa);
3be5a52b30aa5c Miklos Szeredi 2008-04-30 2108 err:
e0887e095a803d Matthew Wilcox (Oracle 2024-02-28 2109) mapping_set_error(folio->mapping, error);
e0887e095a803d Matthew Wilcox (Oracle 2024-02-28 2110) folio_end_writeback(folio);
72523425fb434e Miklos Szeredi 2013-10-01 2111 return error;
3be5a52b30aa5c Miklos Szeredi 2008-04-30 2112 }
3be5a52b30aa5c Miklos Szeredi 2008-04-30 2113
:::::: The code at line 2050 was first introduced by commit
:::::: e0887e095a803d238bd3e2b280baa4c5e70c650c fuse: Convert fuse_writepage_locked to take a folio
:::::: TO: Matthew Wilcox (Oracle) <willy@infradead.org>
:::::: CC: Miklos Szeredi <mszeredi@redhat.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2024-03-21 7:10 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202403211454.VerZc1o2-lkp@intel.com \
--to=lkp@intel.com \
--cc=dhowells@redhat.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.