From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0166C54E58 for ; Fri, 22 Mar 2024 01:48:40 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 6ECFE40511; Fri, 22 Mar 2024 01:48:40 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eywGjZuAaDCG; Fri, 22 Mar 2024 01:48:39 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 9BA6A4060F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1711072119; bh=xEs+nxPabscqfZYnqP1XSpV1Ny+o8wv2NPvfwWpfoJs=; h=Date:From:To:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=GfHzT2aXfQxmnVWlrANb6pikuhLgIJnNGFn3ZDIi5Bc2OPbnblO57zgrrOB6HSlcA W35mxsBxFL7oGZU90Pv7FrPDz1PhXOfa73pWuc2TsgIXv2/N6tdIzrFOFYzG38Dz92 jkQHwaJZ0+eswev7pHBjxwb5yMS1CH57aUR/TqPBR7QKUPwgZHSJHXV46HzeaE2SZo tNkpSKdk5MNFsYcL765Wi3c75t4M1rtDQdP/Sty0GBTUQC/Un8DlrUbGT0Olnk2qCT yB48Vt4hSPWCTZ7lYOhtq/2dDNEa4zGZxacBf9UFs6topiWhfK4QR+xCu/4Ct31SXc L3yH1+QeEOVyA== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id 9BA6A4060F; Fri, 22 Mar 2024 01:48:39 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 31A841BF25B for ; Fri, 22 Mar 2024 01:48:38 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 1B9DB60684 for ; Fri, 22 Mar 2024 01:48:38 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id H-oLG4VOM1oM for ; Fri, 22 Mar 2024 01:48:37 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=145.40.73.55; helo=sin.source.kernel.org; envelope-from=kuba@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org 0A0056078D DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 0A0056078D Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by smtp3.osuosl.org (Postfix) with ESMTPS id 0A0056078D for ; Fri, 22 Mar 2024 01:48:36 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 8F69FCE13D4; Fri, 22 Mar 2024 01:48:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BEC36C43390; Fri, 22 Mar 2024 01:48:29 +0000 (UTC) Date: Thu, 21 Mar 2024 18:48:28 -0700 From: Jakub Kicinski To: Jesse Brandeburg Message-ID: <20240321184828.3e22c698@kernel.org> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711072110; bh=xEs+nxPabscqfZYnqP1XSpV1Ny+o8wv2NPvfwWpfoJs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=SuYk7s2UjAWtsP6/F+h81BmUN58VCzNgEdB/VXdXyezkhoLn6Lqz+ITt0UJdCIcfc MiXw6aa2rxAKAjEikmm/XzpOegE/dWexDUa7SrwVZVVEyfwTMPigrjfeLC+u/6G91E jBraP1oU9V17rWifPfU6wXvsHCGENphUzV0qbInwg+d38pnyh8NBpVfuXFxZsbYLhF yJzOiZWaMrBi0k7B5AA+IfOfUa1BN4GJYeg7J0M0hUJoS4m5WR9ZgGj8++Y8oYmU+y tyBk7Yb4Q0wEoxrpcBbdi+zKXgP3dg6BFGK8x57EMhjLsLiEMhWO6yq8+Aas3hui6I m+Va6UdQhsoPw== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=none dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=SuYk7s2U Subject: Re: [Intel-wired-lan] [PATCH net] ice: Fix freeing uninitialized pointers X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jiri Pirko , Pucha Himasekhar Reddy , Paolo Abeni , Maciej Fijalkowski , Kees Cook , netdev@vger.kernel.org, Lukasz Czapnik , kernel-janitors@vger.kernel.org, LKML , Julia Lawall , Alexander Lobakin , Eric Dumazet , David Laight , intel-wired-lan@lists.osuosl.org, Jonathan Cameron , Przemek Kitszel , Tony Nguyen , Dan Williams , Andy Shevchenko , "David S. Miller" , Dan Carpenter Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Thu, 21 Mar 2024 15:27:47 -0700 Jesse Brandeburg wrote: > The gist of it is that we should instead be using inline declarations,=20 > which I also agree is a reasonable style for this. It more clearly shows= =20 > the __free(kfree) and the allocation (kzalloc, kcalloc, etc) on the same= =20 > (or virtually the same) line of code. >=20 > I'm curious if Jakub would dislike this less? Accept? At present I find this construct unreadable. I may get used to it, hard to say. Also I don't see the benefit of the auto-freeing construct, I'd venture a guess that all the bugs it may prevent would have been caught by smatch. But I'm an old curmudgeon stuck in my ways. Feel free to experiment in Intel drivers, and we'll see how it works out =F0=9F=A4=B7=EF=B8=8F From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59B5F65C; Fri, 22 Mar 2024 01:48:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711072113; cv=none; b=misYYZLdtM5Jo7wnqv6xnEnH+ip8bKXUX1RFanYZnJUsRuoOt4YAalJ+fMIphcjtqWBILQcS/Up0MDsN00t01EowlgUTeL87M+V4Vs+ELuu8YF/JepvcGDq/X7JjJ0M12laSKlKYTBL5MZBfz3ztEFm6X2xuG1lSbRHVRkGyzoI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711072113; c=relaxed/simple; bh=xEs+nxPabscqfZYnqP1XSpV1Ny+o8wv2NPvfwWpfoJs=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=LKfqR6jzs/NkuNmuPqQjP0+YSiAzDF5kxUDFqWcpE2d8aEo7PGIUYzpgBVfJpxsFoZn6cvLBbgEIccHw7VXKUpKGsmIyLQWKJsvqpjv9lmR7/MiV/KCLkqrln4I2t8+iuaEomyVJmLRxIfb3s8hPfNicod40/648teEL+o1sX10= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SuYk7s2U; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SuYk7s2U" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BEC36C43390; Fri, 22 Mar 2024 01:48:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711072110; bh=xEs+nxPabscqfZYnqP1XSpV1Ny+o8wv2NPvfwWpfoJs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=SuYk7s2UjAWtsP6/F+h81BmUN58VCzNgEdB/VXdXyezkhoLn6Lqz+ITt0UJdCIcfc MiXw6aa2rxAKAjEikmm/XzpOegE/dWexDUa7SrwVZVVEyfwTMPigrjfeLC+u/6G91E jBraP1oU9V17rWifPfU6wXvsHCGENphUzV0qbInwg+d38pnyh8NBpVfuXFxZsbYLhF yJzOiZWaMrBi0k7B5AA+IfOfUa1BN4GJYeg7J0M0hUJoS4m5WR9ZgGj8++Y8oYmU+y tyBk7Yb4Q0wEoxrpcBbdi+zKXgP3dg6BFGK8x57EMhjLsLiEMhWO6yq8+Aas3hui6I m+Va6UdQhsoPw== Date: Thu, 21 Mar 2024 18:48:28 -0700 From: Jakub Kicinski To: Jesse Brandeburg Cc: Julia Lawall , Andy Shevchenko , Dan Carpenter , , , , "Maciej Fijalkowski" , Przemek Kitszel , Tony Nguyen , LKML , Alexander Lobakin , David Laight , "David S. Miller" , Eric Dumazet , Jiri Pirko , "Jonathan Cameron" , Kees Cook , Lukasz Czapnik , Paolo Abeni , "Pucha Himasekhar Reddy" , Dan Williams Subject: Re: [PATCH net] ice: Fix freeing uninitialized pointers Message-ID: <20240321184828.3e22c698@kernel.org> In-Reply-To: References: Precedence: bulk X-Mailing-List: kernel-janitors@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, 21 Mar 2024 15:27:47 -0700 Jesse Brandeburg wrote: > The gist of it is that we should instead be using inline declarations,=20 > which I also agree is a reasonable style for this. It more clearly shows= =20 > the __free(kfree) and the allocation (kzalloc, kcalloc, etc) on the same= =20 > (or virtually the same) line of code. >=20 > I'm curious if Jakub would dislike this less? Accept? At present I find this construct unreadable. I may get used to it, hard to say. Also I don't see the benefit of the auto-freeing construct, I'd venture a guess that all the bugs it may prevent would have been caught by smatch. But I'm an old curmudgeon stuck in my ways. Feel free to experiment in Intel drivers, and we'll see how it works out =F0=9F=A4=B7=EF=B8=8F