All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Jan Stancek <jstancek@redhat.com>
Cc: liwan@redhat.com, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2] syscalls/timer_getoverrun01: use kernel_timer_t type
Date: Fri, 22 Mar 2024 06:11:32 +0100	[thread overview]
Message-ID: <20240322051132.GB572447@pevik> (raw)
In-Reply-To: <cf3287a8009ab6104a4dec45b7b8160f35a358b0.1711045522.git.jstancek@redhat.com>

Hi Jan,

...
> +++ b/testcases/kernel/syscalls/timer_getoverrun/timer_getoverrun01.c
> @@ -19,10 +19,11 @@
>  #include <time.h>
>  #include "tst_safe_clocks.h"
>  #include "lapi/syscalls.h"
> +#include "lapi/common_timers.h"

>  static void run(void)
>  {
> -	timer_t timer;
> +	kernel_timer_t timer;

Good catch.
Reviewed-by: Petr Vorel <pvorel@suse.cz>

BTW in v1 you used memset(&timer, 0, sizeof(timer_t));
Could have we used with current compilers just timer_t timer = {} instead of
memset()? Or what is the reason we keep using memset() instead of {}?

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  parent reply	other threads:[~2024-03-22  5:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-21 18:14 [LTP] [PATCH] syscalls/timer_getoverrun01: initialize timer variable Jan Stancek
2024-03-21 18:25 ` [LTP] [PATCH v2] syscalls/timer_getoverrun01: use kernel_timer_t type Jan Stancek
2024-03-22  1:32   ` Li Wang
2024-03-22  5:11   ` Petr Vorel [this message]
2024-03-22  8:51     ` Jan Stancek
2024-03-22  9:34       ` Petr Vorel
2024-03-25  7:40         ` Jan Stancek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240322051132.GB572447@pevik \
    --to=pvorel@suse.cz \
    --cc=jstancek@redhat.com \
    --cc=liwan@redhat.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.