All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: intel-xe@lists.freedesktop.org
Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
	"Matthew Brost" <matthew.brost@intel.com>,
	stable@vger.kernel.org
Subject: [PATCH v2 3/7] drm/xe: Make TLB invalidation fences unordered
Date: Fri, 22 Mar 2024 10:02:09 +0100	[thread overview]
Message-ID: <20240322090213.6091-4-thomas.hellstrom@linux.intel.com> (raw)
In-Reply-To: <20240322090213.6091-1-thomas.hellstrom@linux.intel.com>

They can actually complete out-of-order, so allocate a unique
fence context for each fence.

Fixes: 5387e865d90e ("drm/xe: Add TLB invalidation fence after rebinds issued from execs")
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: <stable@vger.kernel.org> # v6.8+
Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
---
 drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c | 1 -
 drivers/gpu/drm/xe/xe_gt_types.h            | 7 -------
 drivers/gpu/drm/xe/xe_pt.c                  | 3 +--
 3 files changed, 1 insertion(+), 10 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c b/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c
index 25b4111097bc..93df2d7969b3 100644
--- a/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c
+++ b/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c
@@ -63,7 +63,6 @@ int xe_gt_tlb_invalidation_init(struct xe_gt *gt)
 	INIT_LIST_HEAD(&gt->tlb_invalidation.pending_fences);
 	spin_lock_init(&gt->tlb_invalidation.pending_lock);
 	spin_lock_init(&gt->tlb_invalidation.lock);
-	gt->tlb_invalidation.fence_context = dma_fence_context_alloc(1);
 	INIT_DELAYED_WORK(&gt->tlb_invalidation.fence_tdr,
 			  xe_gt_tlb_fence_timeout);
 
diff --git a/drivers/gpu/drm/xe/xe_gt_types.h b/drivers/gpu/drm/xe/xe_gt_types.h
index f6da2ad9719f..2143dffcaf11 100644
--- a/drivers/gpu/drm/xe/xe_gt_types.h
+++ b/drivers/gpu/drm/xe/xe_gt_types.h
@@ -179,13 +179,6 @@ struct xe_gt {
 		 * xe_gt_tlb_fence_timeout after the timeut interval is over.
 		 */
 		struct delayed_work fence_tdr;
-		/** @tlb_invalidation.fence_context: context for TLB invalidation fences */
-		u64 fence_context;
-		/**
-		 * @tlb_invalidation.fence_seqno: seqno to TLB invalidation fences, protected by
-		 * tlb_invalidation.lock
-		 */
-		u32 fence_seqno;
 		/** @tlb_invalidation.lock: protects TLB invalidation fences */
 		spinlock_t lock;
 	} tlb_invalidation;
diff --git a/drivers/gpu/drm/xe/xe_pt.c b/drivers/gpu/drm/xe/xe_pt.c
index 632c1919471d..d1b999dbc906 100644
--- a/drivers/gpu/drm/xe/xe_pt.c
+++ b/drivers/gpu/drm/xe/xe_pt.c
@@ -1135,8 +1135,7 @@ static int invalidation_fence_init(struct xe_gt *gt,
 	spin_lock_irq(&gt->tlb_invalidation.lock);
 	dma_fence_init(&ifence->base.base, &invalidation_fence_ops,
 		       &gt->tlb_invalidation.lock,
-		       gt->tlb_invalidation.fence_context,
-		       ++gt->tlb_invalidation.fence_seqno);
+		       dma_fence_context_alloc(1), 1);
 	spin_unlock_irq(&gt->tlb_invalidation.lock);
 
 	INIT_LIST_HEAD(&ifence->base.link);
-- 
2.44.0


  parent reply	other threads:[~2024-03-22  9:02 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-22  9:02 [PATCH v2 0/7] drm/xe: Rework rebinding and allow same-vm eviction Thomas Hellström
2024-03-22  9:02 ` [PATCH v2 1/7] drm/xe: Use ring ops TLB invalidation for rebinds Thomas Hellström
2024-03-22 17:47   ` Matthew Brost
2024-03-22  9:02 ` [PATCH v2 2/7] drm/xe: Rework rebinding Thomas Hellström
2024-03-22  9:02 ` Thomas Hellström [this message]
2024-03-22 18:00   ` [PATCH v2 3/7] drm/xe: Make TLB invalidation fences unordered Matthew Brost
2024-03-22  9:02 ` [PATCH v2 4/7] drm/xe: Reserve fences where needed Thomas Hellström
2024-03-22 18:28   ` Matthew Brost
2024-03-22  9:02 ` [PATCH v2 5/7] drm/xe: Move vma rebinding to the drm_exec locking loop Thomas Hellström
2024-03-22 18:30   ` Matthew Brost
2024-03-22  9:02 ` [PATCH v2 6/7] drm/xe/bo: Forward the decision to evict local objects during validation Thomas Hellström
2024-03-22 18:51   ` Matthew Brost
2024-03-22  9:02 ` [PATCH v2 7/7] drm/xe/bo: Allow eviction of unbound local bos Thomas Hellström
2024-03-22 18:52   ` Matthew Brost
2024-03-22  9:16 ` ✓ CI.Patch_applied: success for drm/xe: Rework rebinding and allow same-vm eviction (rev2) Patchwork
2024-03-22  9:16 ` ✓ CI.checkpatch: " Patchwork
2024-03-22  9:17 ` ✓ CI.KUnit: " Patchwork
2024-03-22  9:28 ` ✓ CI.Build: " Patchwork
2024-03-22  9:30 ` ✓ CI.Hooks: " Patchwork
2024-03-22  9:32 ` ✓ CI.checksparse: " Patchwork
2024-03-22 10:06 ` ✓ CI.BAT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240322090213.6091-4-thomas.hellstrom@linux.intel.com \
    --to=thomas.hellstrom@linux.intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.brost@intel.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.