From: Petr Vorel <pvorel@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v4] Refactor fork14 using new LTP API
Date: Fri, 22 Mar 2024 10:36:55 +0100 [thread overview]
Message-ID: <20240322093655.GB604328@pevik> (raw)
In-Reply-To: <fa3e5a8a-eb2b-462f-a58e-a56284725e17@suse.com>
Hi Andrea,
> > generally LGTM.
> > With using .skip_in_compat and SPDX GPL-2.0-only:
> Totally forgot the license..
Thanks for sending v5.
...
> > > - default:
> > > - SAFE_WAITPID(cleanup, -1, NULL, 0);
> > > - if (prev_failed > 0 && i >= LARGE) {
> > > - tst_resm(TFAIL, "Fork succeeds incorrectly");
> > > - reproduced = 1;
> > > - goto clear_memory_map;
> > > - }
> > > + ret = waitpid(pid, NULL, 0);
> > Why not SAFE_WAITPID() as it was originally?
> Was discussed with Cyril in the previous review. It's because we don't want
> it to fail only once.
Ah, I'm sorry, I overlooked it.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2024-03-22 9:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 12:45 [LTP] [PATCH v4] Refactor fork14 using new LTP API Andrea Cervesato
2024-03-22 6:42 ` Petr Vorel
2024-03-22 8:59 ` Andrea Cervesato via ltp
2024-03-22 9:36 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240322093655.GB604328@pevik \
--to=pvorel@suse.cz \
--cc=andrea.cervesato@suse.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.