From: Tony Lindgren <tony@atomide.com>
To: Nick Bowler <nbowler@draconx.ca>
Cc: linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org,
regressions@lists.linux.dev, linux-serial@vger.kernel.org
Subject: Re: PROBLEM: Sun Ultra 60 hangs on boot since Linux 6.8
Date: Sat, 23 Mar 2024 08:49:25 +0200 [thread overview]
Message-ID: <20240323064925.GE5132@atomide.com> (raw)
In-Reply-To: <193a134c-f0da-4a45-b45a-a3605f91cfa4@draconx.ca>
* Nick Bowler <nbowler@draconx.ca> [240322 14:12]:
> On 2024-03-22 05:06, Tony Lindgren wrote:
> [...]
> > I can't reproduce this on qemu-system-sparc64, probably as it does not use
> > the sunsab driver.
> >
> > I noticed something though, I think we need to test for the port device
> > instead for being runtime PM enabled.
> >
> > Can you please test if the updated patch below make things work again?
>
> Yes, with the below patch applied on top of 6.8 things are working.
OK great thanks for testing, I'll send out a proper patch.
Regards,
Tony
> > 8< -------------------
> > diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
> > --- a/drivers/tty/serial/serial_core.c
> > +++ b/drivers/tty/serial/serial_core.c
> > @@ -156,7 +156,7 @@ static void __uart_start(struct uart_state *state)
> > * enabled, serial_port_runtime_resume() calls start_tx() again
> > * after enabling the device.
> > */
> > - if (pm_runtime_active(&port_dev->dev))
> > + if (!pm_runtime_enabled(port->dev) || pm_runtime_active(&port_dev->dev))
> > port->ops->start_tx(port);
> > pm_runtime_mark_last_busy(&port_dev->dev);
> > pm_runtime_put_autosuspend(&port_dev->dev)
next prev parent reply other threads:[~2024-03-23 6:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 4:29 PROBLEM: Sun Ultra 60 hangs on boot since Linux 6.8 Nick Bowler
2024-03-22 5:15 ` Tony Lindgren
2024-03-22 6:36 ` Nick Bowler
2024-03-22 6:48 ` Tony Lindgren
2024-03-22 9:06 ` Tony Lindgren
2024-03-22 14:12 ` Nick Bowler
2024-03-23 6:49 ` Tony Lindgren [this message]
2024-03-25 7:39 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240323064925.GE5132@atomide.com \
--to=tony@atomide.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=nbowler@draconx.ca \
--cc=regressions@lists.linux.dev \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.