From: Conor Dooley <conor@kernel.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Javier Carrasco <javier.carrasco.cruz@gmail.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Matt Ranostay <matt@ranostay.sg>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: iio: health: maxim,max30102: fix compatible check
Date: Mon, 25 Mar 2024 19:05:18 +0000 [thread overview]
Message-ID: <20240325-partake-nearby-4e129032a347@spud> (raw)
In-Reply-To: <20240324110715.0832e6d6@jic23-huawei>
[-- Attachment #1: Type: text/plain, Size: 1196 bytes --]
On Sun, Mar 24, 2024 at 11:07:15AM +0000, Jonathan Cameron wrote:
> On Sun, 17 Mar 2024 14:37:39 +0000
> Conor Dooley <conor@kernel.org> wrote:
>
> > On Sat, Mar 16, 2024 at 11:56:57PM +0100, Javier Carrasco wrote:
> > > The "maxim,green-led-current-microamp" property is only available for
> > > the max30105 part (it provides an extra green LED), and must be set to
> > > false for the max30102 part.
> > >
> > > Instead, the max30100 part has been used for that, which is not
> > > supported by this binding (it has its own binding).
> > >
> > > This error was introduced during the txt to yaml conversion.
> > >
> > > Fixes: 5a6a65b11e3a ("dt-bindings:iio:health:maxim,max30102: txt to yaml conversion")
> > > Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
> >
> > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> Applied to the fixes-togreg branch of iio.git (which I'll rebase on rc1 once available)
> and marked for stable. Not really a critical thing to backport, but maybe it is worth
> doing as risk is very low
Yeah, I figure stuff like this is worth just backporting in case someone
is using a stable tree to add some new board.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2024-03-25 19:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-16 22:56 [PATCH] dt-bindings: iio: health: maxim,max30102: fix compatible check Javier Carrasco
2024-03-17 14:37 ` Conor Dooley
2024-03-24 11:07 ` Jonathan Cameron
2024-03-25 19:05 ` Conor Dooley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240325-partake-nearby-4e129032a347@spud \
--to=conor@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=javier.carrasco.cruz@gmail.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@ranostay.sg \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.