From: Jakub Kicinski <kuba@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, dw@davidwei.uk, jiri@resnulli.us,
Sven Eckelmann <sven@narfation.org>,
Jason@zx2c4.com, mareklindner@neomailbox.ch,
sw@simonwunderlich.de, a@unstable.cc, pshelar@ovn.org,
wireguard@lists.zx2c4.com, dev@openvswitch.org
Subject: Re: [PATCH net-next v2 3/3] genetlink: remove linux/genetlink.h
Date: Mon, 25 Mar 2024 18:58:51 -0700 [thread overview]
Message-ID: <20240325185851.1c876761@kernel.org> (raw)
In-Reply-To: <ZgG4IebcrI1RCKAe@smile.fi.intel.com>
On Mon, 25 Mar 2024 19:45:05 +0200 Andy Shevchenko wrote:
> > +/* Non-parallel generic netlink requests are serialized by a global lock. */
>
> While at it, maybe drop extra space? (I noticed it was originally like this.
Fair, I'll post v3.
> > +#define MODULE_ALIAS_GENL_FAMILY(family) \
> > + MODULE_ALIAS_NET_PF_PROTO_NAME(PF_NETLINK, NETLINK_GENERIC, "-family-" family)
>
> I would still make this TAB indented.
That one I'd prefer to keep. Coin toss between going over 80 chars
and having someone atypical indent.
--
pw-bot: cr
prev parent reply other threads:[~2024-03-26 1:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 17:37 [PATCH net-next v2 0/3] genetlink: remove linux/genetlink.h Jakub Kicinski
2024-03-25 17:37 ` [PATCH net-next v2 1/3] netlink: create a new header for internal genetlink symbols Jakub Kicinski
2024-03-25 17:37 ` [PATCH net-next v2 2/3] net: openvswitch: remove unnecessary linux/genetlink.h include Jakub Kicinski
2024-03-25 17:37 ` [PATCH net-next v2 3/3] genetlink: remove linux/genetlink.h Jakub Kicinski
2024-03-25 17:45 ` Andy Shevchenko
2024-03-26 1:58 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240325185851.1c876761@kernel.org \
--to=kuba@kernel.org \
--cc=Jason@zx2c4.com \
--cc=a@unstable.cc \
--cc=andriy.shevchenko@linux.intel.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=mareklindner@neomailbox.ch \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pshelar@ovn.org \
--cc=sven@narfation.org \
--cc=sw@simonwunderlich.de \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.