From: Jakub Kicinski <kuba@kernel.org>
To: Balazs Scheidler <bazsi77@gmail.com>
Cc: kerneljasonxing@gmail.com, kuniyu@amazon.com,
netdev@vger.kernel.org, Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
David Ahern <dsahern@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Balazs Scheidler <balazs.scheidler@axoflow.com>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 2/2] net: udp: add IP/port data to the tracepoint udp/udp_fail_queue_rcv_skb
Date: Mon, 25 Mar 2024 19:28:55 -0700 [thread overview]
Message-ID: <20240325192855.1fb3c331@kernel.org> (raw)
In-Reply-To: <34a9c221a6d644f18c826a1beddba58af6b7a64c.1711361723.git.balazs.scheidler@axoflow.com>
On Mon, 25 Mar 2024 11:29:18 +0100 Balazs Scheidler wrote:
> + memset(__entry->saddr, 0, sizeof(struct sockaddr_in6));
> + memset(__entry->daddr, 0, sizeof(struct sockaddr_in6));
Indent with tabs please, checkpatch says:
ERROR: code indent should use tabs where possible
#59: FILE: include/trace/events/udp.h:38:
+ memset(__entry->saddr, 0, sizeof(struct sockaddr_in6));$
WARNING: please, no spaces at the start of a line
#59: FILE: include/trace/events/udp.h:38:
+ memset(__entry->saddr, 0, sizeof(struct sockaddr_in6));$
ERROR: code indent should use tabs where possible
#60: FILE: include/trace/events/udp.h:39:
+ memset(__entry->daddr, 0, sizeof(struct sockaddr_in6));$
WARNING: please, no spaces at the start of a line
#60: FILE: include/trace/events/udp.h:39:
+ memset(__entry->daddr, 0, sizeof(struct sockaddr_in6));$
--
pw-bot: cr
next prev parent reply other threads:[~2024-03-26 2:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1711361723.git.balazs.scheidler@axoflow.com>
2024-03-25 10:29 ` [PATCH net-next v3 1/2] net: port TP_STORE_ADDR_PORTS_SKB macro to be tcp/udp independent Balazs Scheidler
2024-03-26 7:39 ` Jason Xing
2024-03-25 10:29 ` [PATCH net-next v3 2/2] net: udp: add IP/port data to the tracepoint udp/udp_fail_queue_rcv_skb Balazs Scheidler
2024-03-26 2:28 ` Jakub Kicinski [this message]
2024-03-26 7:25 ` Jason Xing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240325192855.1fb3c331@kernel.org \
--to=kuba@kernel.org \
--cc=balazs.scheidler@axoflow.com \
--cc=bazsi77@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kerneljasonxing@gmail.com \
--cc=kuniyu@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rostedt@goodmis.org \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.