From: Stefan Hajnoczi <stefanha@redhat.com>
To: Fiona Ebner <f.ebner@proxmox.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
qemu-stable@nongnu.org, hreitz@redhat.com, kwolf@redhat.com,
fam@euphon.net, t.lamprecht@proxmox.com, w.bumiller@proxmox.com
Subject: Re: [PATCH v3 4/4] iotests: add test for stream job with an unaligned prefetch read
Date: Mon, 25 Mar 2024 16:09:39 -0400 [thread overview]
Message-ID: <20240325200939.GD1944176@fedora> (raw)
In-Reply-To: <20240322095009.346989-5-f.ebner@proxmox.com>
[-- Attachment #1: Type: text/plain, Size: 970 bytes --]
On Fri, Mar 22, 2024 at 10:50:09AM +0100, Fiona Ebner wrote:
> Previously, bdrv_pad_request() could not deal with a NULL qiov when
> a read needed to be aligned. During prefetch, a stream job will pass a
> NULL qiov. Add a test case to cover this scenario.
>
> By accident, also covers a previous race during shutdown, where block
> graph changes during iteration in bdrv_flush_all() could lead to
> unreferencing the wrong block driver state and an assertion failure
> later.
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>
> No changes in v3.
> New in v2.
>
> .../tests/stream-unaligned-prefetch | 86 +++++++++++++++++++
> .../tests/stream-unaligned-prefetch.out | 5 ++
> 2 files changed, 91 insertions(+)
> create mode 100755 tests/qemu-iotests/tests/stream-unaligned-prefetch
> create mode 100644 tests/qemu-iotests/tests/stream-unaligned-prefetch.out
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-03-25 20:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 9:50 [PATCH v3 0/4] fix two edge cases related to stream block jobs Fiona Ebner
2024-03-22 9:50 ` [PATCH v3 1/4] block/io: accept NULL qiov in bdrv_pad_request Fiona Ebner
2024-03-25 19:56 ` Stefan Hajnoczi
2024-03-22 9:50 ` [PATCH v3 2/4] block-backend: fix edge case in bdrv_next() where BDS associated to BB changes Fiona Ebner
2024-03-25 20:06 ` Stefan Hajnoczi
2024-03-26 12:44 ` Kevin Wolf
2024-06-03 14:17 ` Fiona Ebner
2024-06-03 16:21 ` Kevin Wolf
2024-06-04 7:58 ` Fiona Ebner
2024-06-04 15:28 ` Kevin Wolf
2024-06-05 14:14 ` Fiona Ebner
2024-03-22 9:50 ` [PATCH v3 3/4] block-backend: fix edge case in bdrv_next_cleanup() " Fiona Ebner
2024-03-25 20:07 ` Stefan Hajnoczi
2024-03-22 9:50 ` [PATCH v3 4/4] iotests: add test for stream job with an unaligned prefetch read Fiona Ebner
2024-03-25 20:09 ` Stefan Hajnoczi [this message]
2024-03-25 20:11 ` [PATCH v3 0/4] fix two edge cases related to stream block jobs Stefan Hajnoczi
2024-03-26 12:53 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240325200939.GD1944176@fedora \
--to=stefanha@redhat.com \
--cc=f.ebner@proxmox.com \
--cc=fam@euphon.net \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=t.lamprecht@proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.