From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
Chandan Babu R <chandan.babu@oracle.com>,
Dave Chinner <david@fromorbit.com>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 09/11] xfs: rework splitting of indirect block reservations
Date: Tue, 26 Mar 2024 06:51:51 +0100 [thread overview]
Message-ID: <20240326055151.GC6808@lst.de> (raw)
In-Reply-To: <20240325235543.GF6414@frogsfrogsfrogs>
On Mon, Mar 25, 2024 at 04:55:43PM -0700, Darrick J. Wong wrote:
> > + /*
> > + * Steal as many blocks as we can to try and satisfy the worst
> > + * case indlen for both new extents.
> > + */
> > + da_new = got_indlen + new_indlen;
> > + if (da_new > da_old) {
> > + stolen = XFS_FILBLKS_MIN(da_new - da_old,
> > + new.br_blockcount);
>
> Huh. We used to pass del->blockcount as one of the constraints on the
> stolen block count. Why pass new.br_blockcount instead?
.. we probably shouldn't. Let me take another closer look.
next prev parent reply other threads:[~2024-03-26 5:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 2:24 bring back RT delalloc support v4 Christoph Hellwig
2024-03-25 2:24 ` [PATCH 01/11] xfs: make XFS_TRANS_LOWMODE match the other XFS_TRANS_ definitions Christoph Hellwig
2024-03-25 2:24 ` [PATCH 02/11] xfs: move RT inode locking out of __xfs_bunmapi Christoph Hellwig
2024-03-25 2:24 ` [PATCH 03/11] xfs: block deltas in xfs_trans_unreserve_and_mod_sb must be positive Christoph Hellwig
2024-03-25 2:24 ` [PATCH 04/11] xfs: split xfs_mod_freecounter Christoph Hellwig
2024-03-25 23:41 ` Darrick J. Wong
2024-03-26 5:51 ` Christoph Hellwig
2024-03-25 2:24 ` [PATCH 05/11] xfs: reinstate RT support in xfs_bmapi_reserve_delalloc Christoph Hellwig
2024-03-25 2:24 ` [PATCH 06/11] xfs: cleanup fdblock/frextent accounting in xfs_bmap_del_extent_delay Christoph Hellwig
2024-03-25 2:24 ` [PATCH 07/11] xfs: support RT inodes in xfs_mod_delalloc Christoph Hellwig
2024-03-25 23:44 ` Darrick J. Wong
2024-03-25 2:24 ` [PATCH 08/11] xfs: look at m_frextents in xfs_iomap_prealloc_size for RT allocations Christoph Hellwig
2024-03-25 2:24 ` [PATCH 09/11] xfs: rework splitting of indirect block reservations Christoph Hellwig
2024-03-25 23:55 ` Darrick J. Wong
2024-03-26 5:51 ` Christoph Hellwig [this message]
2024-03-25 2:24 ` [PATCH 10/11] xfs: stop the steal (of data blocks for RT indirect blocks) Christoph Hellwig
2024-03-25 2:24 ` [PATCH 11/11] xfs: reinstate delalloc for RT inodes (if sb_rextsize == 1) Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240326055151.GC6808@lst.de \
--to=hch@lst.de \
--cc=chandan.babu@oracle.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.