From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 31C97CD11DD for ; Tue, 26 Mar 2024 11:20:31 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id E5E8D60820; Tue, 26 Mar 2024 11:20:30 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id AkbYSKfT5JyM; Tue, 26 Mar 2024 11:20:30 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 5656F60AAF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1711452030; bh=j7/DOi4mHQpFRpC2gN1HtFtXEvGwmHUVgRQuWzq2HYE=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=yy4iQI2VhuVUmEWDcR5K9kE4RPjgli2KRLEgeJULOP+aYP0s9pFtzV6PUlTQYH7Gi u6peaH0bOyjmPY8EMMRZds5HW33xl6T/gWeYTmZS37iT2JpT9UVVjrGi9AfTkvy0uq 9i5+h4pv3mEMrENCil5futtPL3HaRHTTdBtUNlWIDIOzAv0Q2r2aC53vXjQv3nd/Nm 8F2WxR8fptU7J6CGlJA12TuYOm3QMjlEeSFNeoCyFJP/xCVmzsHy72NAJAHfI3MSWs MamB4RVvUiRA7k1+WtANY8iQkMLFoZP2MIrrhJquIbWa1o+6hrWfIhl3iJCXHS7dPo wvnUWRRxCb6+w== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 5656F60AAF; Tue, 26 Mar 2024 11:20:30 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 8B1441BF45A for ; Tue, 26 Mar 2024 11:20:28 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 7585B4078F for ; Tue, 26 Mar 2024 11:20:28 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 0YiqjYjolBoL for ; Tue, 26 Mar 2024 11:20:27 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org 9E4F54028F DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 9E4F54028F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by smtp4.osuosl.org (Postfix) with ESMTPS id 9E4F54028F for ; Tue, 26 Mar 2024 11:20:27 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id DE74860A78; Tue, 26 Mar 2024 11:20:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3BB87C433F1; Tue, 26 Mar 2024 11:20:25 +0000 (UTC) Date: Tue, 26 Mar 2024 11:20:23 +0000 From: Simon Horman To: Michal Swiatkowski Message-ID: <20240326112023.GL403975@kernel.org> References: <20240325213433.829161-1-michal.swiatkowski@linux.intel.com> <20240325213433.829161-4-michal.swiatkowski@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240325213433.829161-4-michal.swiatkowski@linux.intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711452026; bh=rKe++Rz2WAQ6DvWQZx1Q6tqtL8Tl7Iu18OHMBTq2orQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dcJukP7+lgDuv2FBqGUKVAvYgPp00hcQ/opXeHXH4F1Xi8qMGRIeqqVEPITIa/rWd FGArHLyErjkGHshFFBg35uI2OQtbduTQWtM0j0hN4qoMYR/1CNWHMpkhw3D8U7yXY7 5eMGYzUipgQHshq4ubWP9XVmJ0A+J1dy+bR0sXnAPbHknZg9QvbytBSLm5ukJYW4SO azOHB0VtwoDJKxthemP91Esiz7uzUMB797+/5o7pn9sjXlYXiz7hjKiweqJTR06rkQ SXs3HPlzROJZCKKyDCJCTmLUU+LPVQosHnBzNmHkChkJ+DhBDrmg0o35SWhLnrmiRz FCWbR08UXsLtQ== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=none dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=dcJukP7+ Subject: Re: [Intel-wired-lan] [iwl-next v1 3/3] ice: hold devlink lock for whole init/cleanup X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jiri Pirko , netdev@vger.kernel.org, Wojciech Drewek , intel-wired-lan@lists.osuosl.org Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Mon, Mar 25, 2024 at 10:34:33PM +0100, Michal Swiatkowski wrote: > Simplify devlink lock code in driver by taking it for whole init/cleanup > path. Instead of calling devlink functions that taking lock call the > lockless versions. > > Suggested-by: Jiri Pirko > Reviewed-by: Jesse Brandeburg > Reviewed-by: Wojciech Drewek > Signed-off-by: Michal Swiatkowski Reviewed-by: Simon Horman From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0604954BEB for ; Tue, 26 Mar 2024 11:20:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711452027; cv=none; b=k+nf0USngr4NtPdRxbBMkee8Flc6C2Lxj4QQPA+c/kI7eKD97zLiz7UKgm60uO5Y+7RLMXohRLhtycn+2ZI97Isqwjp7sigwsg7nSvWCC87RavQ7MYZtcjcVai78TsVHOTKmwSxaGCx3BhfDbxXNlY9KXBkwfE8vxmQJp8OcaHE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711452027; c=relaxed/simple; bh=rKe++Rz2WAQ6DvWQZx1Q6tqtL8Tl7Iu18OHMBTq2orQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=r6pYBXPkbr5GTvCHye37gXHDy8WxmqJWPeaAyvg5NIhlARjBbHlVrHDAzJHqSZTP+WfVBM6Tp3pzWLPTxhLkiekxXzMUTGJpwD38jnfEfu9C95oJ1xRjWthFeYXNxNvqIBBIECTLqxx2J7J1Xgvr5e0D+W89pzb4n1nMOsAcRTE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dcJukP7+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dcJukP7+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3BB87C433F1; Tue, 26 Mar 2024 11:20:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711452026; bh=rKe++Rz2WAQ6DvWQZx1Q6tqtL8Tl7Iu18OHMBTq2orQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dcJukP7+lgDuv2FBqGUKVAvYgPp00hcQ/opXeHXH4F1Xi8qMGRIeqqVEPITIa/rWd FGArHLyErjkGHshFFBg35uI2OQtbduTQWtM0j0hN4qoMYR/1CNWHMpkhw3D8U7yXY7 5eMGYzUipgQHshq4ubWP9XVmJ0A+J1dy+bR0sXnAPbHknZg9QvbytBSLm5ukJYW4SO azOHB0VtwoDJKxthemP91Esiz7uzUMB797+/5o7pn9sjXlYXiz7hjKiweqJTR06rkQ SXs3HPlzROJZCKKyDCJCTmLUU+LPVQosHnBzNmHkChkJ+DhBDrmg0o35SWhLnrmiRz FCWbR08UXsLtQ== Date: Tue, 26 Mar 2024 11:20:23 +0000 From: Simon Horman To: Michal Swiatkowski Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, Jiri Pirko , Jesse Brandeburg , Wojciech Drewek Subject: Re: [iwl-next v1 3/3] ice: hold devlink lock for whole init/cleanup Message-ID: <20240326112023.GL403975@kernel.org> References: <20240325213433.829161-1-michal.swiatkowski@linux.intel.com> <20240325213433.829161-4-michal.swiatkowski@linux.intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240325213433.829161-4-michal.swiatkowski@linux.intel.com> On Mon, Mar 25, 2024 at 10:34:33PM +0100, Michal Swiatkowski wrote: > Simplify devlink lock code in driver by taking it for whole init/cleanup > path. Instead of calling devlink functions that taking lock call the > lockless versions. > > Suggested-by: Jiri Pirko > Reviewed-by: Jesse Brandeburg > Reviewed-by: Wojciech Drewek > Signed-off-by: Michal Swiatkowski Reviewed-by: Simon Horman