From: Simon Horman <horms@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, shuah@kernel.org, dw@davidwei.uk,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net] selftests: netdevsim: set test timeout to 10 minutes
Date: Tue, 26 Mar 2024 14:13:48 +0000 [thread overview]
Message-ID: <20240326141348.GV403975@kernel.org> (raw)
In-Reply-To: <20240325155612.2272174-1-kuba@kernel.org>
On Mon, Mar 25, 2024 at 08:56:11AM -0700, Jakub Kicinski wrote:
> The longest running netdevsim test, nexthop.sh, currently takes
> 5 min to finish. Around 260s to be exact, and 310s on a debug kernel.
> The default timeout in selftest is 45sec, so we need an explicit
> config. Give ourselves some headroom and use 10min.
>
> Commit under Fixes isn't really to "blame" but prior to that
> netdevsim tests weren't integrated with kselftest infra
> so blaming the tests themselves doesn't seem right, either.
>
> Fixes: 8ff25dac88f6 ("netdevsim: add Makefile for selftests")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-03-26 14:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 15:56 [PATCH net] selftests: netdevsim: set test timeout to 10 minutes Jakub Kicinski
2024-03-26 14:13 ` Simon Horman [this message]
2024-03-27 11:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240326141348.GV403975@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.