From: Simon Horman <horms@kernel.org>
To: Su Hui <suhui@nfschina.com>
Cc: sgoutham@marvell.com, gakula@marvell.com, sbhatta@marvell.com,
hkelam@marvell.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, nathan@kernel.org,
ndesaulniers@google.com, morbo@google.com,
justinstitt@google.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
kernel-janitors@vger.kernel.org,
Dan Carpenter <dan.carpenter@linaro.org>
Subject: Re: [PATCH net v2 2/2] octeontx2-pf: remove unused variables req_hdr and rsp_hdr
Date: Tue, 26 Mar 2024 14:27:00 +0000 [thread overview]
Message-ID: <20240326142700.GX403975@kernel.org> (raw)
In-Reply-To: <20240326061233.4133148-2-suhui@nfschina.com>
+ Dan Carpenter
On Tue, Mar 26, 2024 at 02:12:36PM +0800, Su Hui wrote:
> Clang static checker(scan-buid):
> drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c:503:2: warning:
> Value stored to 'rsp_hdr' is never read [deadcode.DeadStores]
>
> Remove these unused variables to save some space.
>
> Signed-off-by: Su Hui <suhui@nfschina.com>
Hi Su Hui,
as pointed out by Dan in his review of v1 of this patch, it is not a fix.
This means that it should be targeted at the net-next rather than the net
branch. As the granularity of patch handling on netdev is generally at the
patchset level I believe that this means that you need to separately,
in different email threads, repost:
1. Patch 1/2 of this series, targeted at net
[PATCH net v3] octeontx2-pf: check negative error code in otx2_open()
2. Patch 2/2 of this series, targeted at net-next
[PATCH net-next v3] octeontx2-pf: remove unused variables req_hdr
Also, please be sure to wait 24 hours since the posting of this patch-set
before reposting.
Some more information can be found here:
https://docs.kernel.org/process/maintainer-netdev.html
...
--
pw-bot: changes-requested
next prev parent reply other threads:[~2024-03-26 14:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 6:12 [PATCH net v2 1/2] octeontx2-pf: check negative error code in otx2_open() Su Hui
2024-03-26 6:12 ` [PATCH net v2 2/2] octeontx2-pf: remove unused variables req_hdr and rsp_hdr Su Hui
2024-03-26 14:27 ` Simon Horman [this message]
2024-03-26 14:19 ` [PATCH net v2 1/2] octeontx2-pf: check negative error code in otx2_open() Simon Horman
2024-03-26 15:51 ` Kalesh Anakkur Purayil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240326142700.GX403975@kernel.org \
--to=horms@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=justinstitt@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
--cc=suhui@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.