All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Surong Pang <surong.pang@unisoc.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	Orson.Zhai@unisoc.com, Zhiyong.liu@unisoc.com,
	Surong.Pang@gmail.com
Subject: Re: [PATCH] usb: gadget: rndis: add multi packages support for rndis
Date: Tue, 26 Mar 2024 10:34:35 +0100	[thread overview]
Message-ID: <2024032615-smog-pardon-4d5f@gregkh> (raw)
In-Reply-To: <20240306054949.324172-1-surong.pang@unisoc.com>

On Wed, Mar 06, 2024 at 01:49:49PM +0800, Surong Pang wrote:
> As ncm, aggergate multi skb packages and transfer them at one URB.
> In USB2.0, the network throughput can be improved from about 18MB/S
> to 35MB/S.

Why is rndis still being used?  It's an insecure and obsolete protocol
that should not be used at all anywhere.  I keep trying to delete it
entirely, but need to go and write an active exploit to prove to people
just how bad it really is before I can do so...

Adding more functionality to it is not a good idea, what is wrong with
the other, built-in, networking protocols instead?  Why are you using
this old one still when there are so many better options out there?

thanks,

greg k-h

  reply	other threads:[~2024-03-26  9:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-06  5:49 [PATCH] usb: gadget: rndis: add multi packages support for rndis Surong Pang
2024-03-26  9:34 ` Greg KH [this message]
2024-03-26  9:36 ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2024-03-26 10:47 庞苏荣 (Surong Pang)
2024-03-26 14:07 ` Greg KH
2024-03-26 10:52 庞苏荣 (Surong Pang)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024032615-smog-pardon-4d5f@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=Orson.Zhai@unisoc.com \
    --cc=Surong.Pang@gmail.com \
    --cc=Zhiyong.liu@unisoc.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=surong.pang@unisoc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.