Re: [Buildroot] [PATCH 1/3] package/python-fonttools: enable host-package

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Christian,

On Wed, 28 Feb 2024 15:50:09 +0100
Christian Hitz via buildroot <buildroot@buildroot.org> wrote:

> From: Christian Hitz <christian.hitz@bbv.ch>
> 
> The fonttools are used to generate static fonts from variable fonts
> at build time.
> 
> Signed-off-by: Christian Hitz <christian.hitz@bbv.ch>
> ---
>  package/python-fonttools/Config.in.host      | 6 ++++++
>  package/python-fonttools/python-fonttools.mk | 1 +
>  2 files changed, 7 insertions(+)
>  create mode 100644 package/python-fonttools/Config.in.host
> 
> diff --git a/package/python-fonttools/Config.in.host b/package/python-fonttools/Config.in.host
> new file mode 100644
> index 0000000000..641efb1cfb
> --- /dev/null
> +++ b/package/python-fonttools/Config.in.host
> @@ -0,0 +1,6 @@
> +config BR2_PACKAGE_HOST_PYTHON_FONTTOOLS
> +	bool "host-python-fonttools"
> +	help
> +	  Tools to manipulate font files.
> +
> +	  https://github.com/fonttools/fonttools

We don't really need this part, at least for PATCH 3/3. Just adding
$(eval $(host-python-package)) is sufficient. Adding a Config.in entry
is only needed if the host package needs to be made user-visible. In
your case, we don't need to make it user-visible: this host package is
merely a build-time dependency of generating static fonts from the
googlefontdirectory package.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot