From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Christian Hitz via buildroot <buildroot@buildroot.org>
Cc: Christian Hitz <christian@klarinett.li>,
Christian Hitz <christian.hitz@bbv.ch>,
Martin Bark <martin@barkynet.com>
Subject: Re: [Buildroot] [PATCH 2/2] package/zic: enable installation on target
Date: Tue, 26 Mar 2024 15:44:34 +0100 [thread overview]
Message-ID: <20240326154434.7734ca6f@windsurf> (raw)
In-Reply-To: <20240228145642.436509-2-christian@klarinett.li>
Hello Christian,
On Wed, 28 Feb 2024 15:56:41 +0100
Christian Hitz via buildroot <buildroot@buildroot.org> wrote:
> From: Christian Hitz <christian.hitz@bbv.ch>
>
> Signed-off-by: Christian Hitz <christian.hitz@bbv.ch>
Thanks, but for a patch like this, we definitely need a non-empty
commit log. Why do you need zic on the target, what is the use-case?
> diff --git a/package/zic/Config.in b/package/zic/Config.in
> new file mode 100644
> index 0000000000..11a8c99a66
> --- /dev/null
> +++ b/package/zic/Config.in
> @@ -0,0 +1,6 @@
> +config BR2_PACKAGE_ZIC
> + bool "zic"
> + help
No dependency on toolchain-specific features? Did you test this package
with ./utils/test-pkg ?
> diff --git a/package/zic/zic.mk b/package/zic/zic.mk
> index a915f6d256..12bb9e9943 100644
> --- a/package/zic/zic.mk
> +++ b/package/zic/zic.mk
> @@ -10,6 +10,19 @@ ZIC_SITE = https://www.iana.org/time-zones/repository/releases
> ZIC_STRIP_COMPONENTS = 0
> ZIC_LICENSE = Public domain
> ZIC_LICENSE_FILES = LICENSE
> +ZIC_INSTALL_STAGING = YES
> +
> +define ZIC_BUILD_CMDS
> + $(TARGET_MAKE_ENV) $(MAKE) CC="$(TARGET_CC)" -C $(@D) zic
Can we use $(TARGET_CONFIGURE_OPTS) instead of CC="$(TARGET_CC)" ?
> +define ZIC_INSTALL_STAGING_CMDS
> + $(INSTALL) -D -m 644 $(@D)/tzfile.h $(TARGET_DIR)/usr/include/tzfile.h
So just the header file is needed, no library is installed?
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-03-26 14:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 14:56 [Buildroot] [PATCH 1/2] package/zic: add hash for existing patch Christian Hitz via buildroot
2024-02-28 14:56 ` [Buildroot] [PATCH 2/2] package/zic: enable installation on target Christian Hitz via buildroot
2024-03-26 14:44 ` Thomas Petazzoni via buildroot [this message]
2024-03-26 16:03 ` christian--- via buildroot
2024-03-26 16:10 ` Thomas Petazzoni via buildroot
2024-03-26 16:37 ` [Buildroot] [PATCH v2] " Christian Hitz via buildroot
2024-03-26 14:43 ` [Buildroot] [PATCH 1/2] package/zic: add hash for existing patch Thomas Petazzoni via buildroot
2024-03-26 16:06 ` christian--- via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240326154434.7734ca6f@windsurf \
--to=buildroot@buildroot.org \
--cc=christian.hitz@bbv.ch \
--cc=christian@klarinett.li \
--cc=martin@barkynet.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.