From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C56CE1C2AF for ; Tue, 26 Mar 2024 17:13:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711473208; cv=none; b=OlLdGGH87ipYWGDR0u6GtOf48YF8azH2X3Aagxo5ZxFPRXALWmSwN3NjGqF6O+K9o+a89610h1c/a4VSDAiQPXb+x8WGxq16hU+USZjUf/1Bspeb6vsO/OZuxyWtMSYbX9JNKCpRLmdkyaOBgf7PGXkn7K1lTt7FUewhENQRyP0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711473208; c=relaxed/simple; bh=MnzMXAzZV1h7sUIdg5Aeq4kt19V4kaa+bzh/Anm4CGE=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=lQVM3FBPbhLfitugcH1VRsvXuvn14cOaOZ0AuKUwzY5OJZyzd78yMKmMFiK3UWR2SeyNJMvSaVkTLx74uTZ11p/6nD4dOzteqsSojVAUnfeHCOwin4Z+6PRWqFMapoQNP+zjPzG0VmeLiBWilaHQr9bi+9LjttwUgDSVwTdy+hc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4V3x8z72w7z6K9KK; Wed, 27 Mar 2024 01:08:51 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id EC4C6140594; Wed, 27 Mar 2024 01:13:17 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 26 Mar 2024 17:13:17 +0000 Date: Tue, 26 Mar 2024 17:13:16 +0000 From: Jonathan Cameron To: Laurent Pinchart CC: Jonathan Cameron , , , , "Trevor Zaharichuk" , Greg Lytle , "Lars-Peter Clausen" , Rob Herring , "Krzysztof Kozlowski" , Conor Dooley , Sean Nyekjaer , Subject: Re: [PATCH 1/5] dt-bindings: iio: dac: ti,dac5571: Add DAC081C081 support Message-ID: <20240326171316.000018f5@Huawei.com> In-Reply-To: <20240326165043.GB28895@pendragon.ideasonboard.com> References: <20240325203245.31660-1-laurent.pinchart@ideasonboard.com> <20240325203245.31660-2-laurent.pinchart@ideasonboard.com> <20240325204857.4f2fd468@jic23-huawei> <20240325205641.GD23988@pendragon.ideasonboard.com> <20240326152927.00006229@Huawei.com> <20240326165043.GB28895@pendragon.ideasonboard.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: lhrpeml100006.china.huawei.com (7.191.160.224) To lhrpeml500005.china.huawei.com (7.191.163.240) On Tue, 26 Mar 2024 18:50:43 +0200 Laurent Pinchart wrote: > On Tue, Mar 26, 2024 at 03:29:27PM +0000, Jonathan Cameron wrote: > > On Mon, 25 Mar 2024 22:56:41 +0200 Laurent Pinchart wrote: =20 > > > On Mon, Mar 25, 2024 at 08:48:57PM +0000, Jonathan Cameron wrote: =20 > > > > On Mon, 25 Mar 2024 22:32:41 +0200 Laurent Pinchart wrote: > > > > =20 > > > > > The DAC081C081 is a TI DAC whose software interface is compatible= with > > > > > the DAC5571. It is the 8-bit version of the DAC121C081, already > > > > > supported by the DAC5571 bindings. Extends the bindings to suppor= t this > > > > > chip. > > > > >=20 > > > > > Signed-off-by: Laurent Pinchart =20 > > > >=20 > > > > Hi Laurent, > > > >=20 > > > > Given it's a part number where no one is going to guess it is compa= tible > > > > with the DAC5571 and that we don't have a history of fallback compa= tibles > > > > I'm fine with this change, but just wanted to ask is a fallback com= patible > > > > useful to you to run with older kernels? > > > >=20 > > > > I should have noticed when Peter added the dac121c081. If we add a = fallback > > > > should do that one as well. =20 > > >=20 > > > I've indeed noticed that there should have been a fallback for > > > dac121c081, but didn't stop to ponder why that wasn't the case, and j= ust > > > went along with the flow :-) I agree a fallback could be useful, which > > > would then allow dropping patch 2/5 from this series (*). I can do so= if > > > you prefer. > > >=20 > > > * This is not entirely true. While the DAC1081C081 is largely compati= ble > > > with the DAC5573, they have different values for one of the power-down > > > resistors (2.5k=CE=A9 instead of 1k=CE=A9 if I recall correctly). To = be completely > > > accurate, the driver should report that. We could still use the fallb= ack > > > compatible, reporting the wrong power-down resistor value. =20 > >=20 > > Hmm - Would anyone really care about that value being wrong? =20 >=20 > I don't have enough expertise with IIO to be sure, but my guess is that > nobody would. >=20 > > I think perhaps that's just about significant enough that maybe a fallb= ack > > compatible doesn't make sense here. =20 >=20 > Then let's keep it simple and just merge this patch as-is ? :-) Makes sense. I'm on wrong computer at the moment but will pick it up at weekend if not before. Jonathan >=20 > > > > > --- > > > > > Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml | 1 + > > > > > 1 file changed, 1 insertion(+) > > > > >=20 > > > > > diff --git a/Documentation/devicetree/bindings/iio/dac/ti,dac5571= .yaml b/Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml > > > > > index 79da0323c327..e59db861e2eb 100644 > > > > > --- a/Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml > > > > > +++ b/Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml > > > > > @@ -21,6 +21,7 @@ properties: > > > > > - ti,dac5573 > > > > > - ti,dac6573 > > > > > - ti,dac7573 > > > > > + - ti,dac081c081 > > > > > - ti,dac121c081 > > > > > =20 > > > > > reg: =20 >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 15E59C6FD1F for ; Tue, 26 Mar 2024 17:13:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=g6ROnGKRAiTuF7pp4Iy59ASlyoCoa3Jq/eZF7FHtIS0=; b=xth7nE2uyhcTbP gR5n98SaZub/MW1kQVP1rnNpwrsWQ7jDC6v3ctTgU1KvUvXSTIMujbvQ+4yZirTP1d+2oigwBPeRb 2wPZKZbQrhKbgSHd1OgJrQ/9izJdWWU9Mw/quaQ4POH0gr38SXY6cjLl5C8ZcFwFYsBexSt7+0KDU tipk87SBe4QOfDp+zoLOWhcnPX0CD6FsFMNebNe8um1wE1hSWzD8OOb2MthaCSdFJNj0fGkWsXHan uJpnsNgW/wjzmdmyTFDXbxyZGD8b4pYNgYOTEppsKU70IdiyGw+adCn3QQ/Y1WVtPAbVQD/gFhOns KxO/DIZYYyDFxvAGTx9w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpAMf-00000005fvJ-1LbC; Tue, 26 Mar 2024 17:13:33 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpAMb-00000005fsO-2Nlk for linux-arm-kernel@lists.infradead.org; Tue, 26 Mar 2024 17:13:31 +0000 Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4V3x8z72w7z6K9KK; Wed, 27 Mar 2024 01:08:51 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id EC4C6140594; Wed, 27 Mar 2024 01:13:17 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 26 Mar 2024 17:13:17 +0000 Date: Tue, 26 Mar 2024 17:13:16 +0000 From: Jonathan Cameron To: Laurent Pinchart CC: Jonathan Cameron , , , , "Trevor Zaharichuk" , Greg Lytle , "Lars-Peter Clausen" , Rob Herring , "Krzysztof Kozlowski" , Conor Dooley , Sean Nyekjaer , Subject: Re: [PATCH 1/5] dt-bindings: iio: dac: ti,dac5571: Add DAC081C081 support Message-ID: <20240326171316.000018f5@Huawei.com> In-Reply-To: <20240326165043.GB28895@pendragon.ideasonboard.com> References: <20240325203245.31660-1-laurent.pinchart@ideasonboard.com> <20240325203245.31660-2-laurent.pinchart@ideasonboard.com> <20240325204857.4f2fd468@jic23-huawei> <20240325205641.GD23988@pendragon.ideasonboard.com> <20240326152927.00006229@Huawei.com> <20240326165043.GB28895@pendragon.ideasonboard.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml100006.china.huawei.com (7.191.160.224) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240326_101330_253958_185C99B1 X-CRM114-Status: GOOD ( 37.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCAyNiBNYXIgMjAyNCAxODo1MDo0MyArMDIwMApMYXVyZW50IFBpbmNoYXJ0IDxsYXVy ZW50LnBpbmNoYXJ0QGlkZWFzb25ib2FyZC5jb20+IHdyb3RlOgoKPiBPbiBUdWUsIE1hciAyNiwg MjAyNCBhdCAwMzoyOToyN1BNICswMDAwLCBKb25hdGhhbiBDYW1lcm9uIHdyb3RlOgo+ID4gT24g TW9uLCAyNSBNYXIgMjAyNCAyMjo1Njo0MSArMDIwMCBMYXVyZW50IFBpbmNoYXJ0IHdyb3RlOiAg Cj4gPiA+IE9uIE1vbiwgTWFyIDI1LCAyMDI0IGF0IDA4OjQ4OjU3UE0gKzAwMDAsIEpvbmF0aGFu IENhbWVyb24gd3JvdGU6ICAKPiA+ID4gPiBPbiBNb24sIDI1IE1hciAyMDI0IDIyOjMyOjQxICsw MjAwIExhdXJlbnQgUGluY2hhcnQgd3JvdGU6Cj4gPiA+ID4gICAgIAo+ID4gPiA+ID4gVGhlIERB QzA4MUMwODEgaXMgYSBUSSBEQUMgd2hvc2Ugc29mdHdhcmUgaW50ZXJmYWNlIGlzIGNvbXBhdGli bGUgd2l0aAo+ID4gPiA+ID4gdGhlIERBQzU1NzEuIEl0IGlzIHRoZSA4LWJpdCB2ZXJzaW9uIG9m IHRoZSBEQUMxMjFDMDgxLCBhbHJlYWR5Cj4gPiA+ID4gPiBzdXBwb3J0ZWQgYnkgdGhlIERBQzU1 NzEgYmluZGluZ3MuIEV4dGVuZHMgdGhlIGJpbmRpbmdzIHRvIHN1cHBvcnQgdGhpcwo+ID4gPiA+ ID4gY2hpcC4KPiA+ID4gPiA+IAo+ID4gPiA+ID4gU2lnbmVkLW9mZi1ieTogTGF1cmVudCBQaW5j aGFydCA8bGF1cmVudC5waW5jaGFydEBpZGVhc29uYm9hcmQuY29tPiAgICAKPiA+ID4gPiAKPiA+ ID4gPiBIaSBMYXVyZW50LAo+ID4gPiA+IAo+ID4gPiA+IEdpdmVuIGl0J3MgYSBwYXJ0IG51bWJl ciB3aGVyZSBubyBvbmUgaXMgZ29pbmcgdG8gZ3Vlc3MgaXQgaXMgY29tcGF0aWJsZQo+ID4gPiA+ IHdpdGggdGhlIERBQzU1NzEgYW5kIHRoYXQgd2UgZG9uJ3QgaGF2ZSBhIGhpc3Rvcnkgb2YgZmFs bGJhY2sgY29tcGF0aWJsZXMKPiA+ID4gPiBJJ20gZmluZSB3aXRoIHRoaXMgY2hhbmdlLCBidXQg anVzdCB3YW50ZWQgdG8gYXNrIGlzIGEgZmFsbGJhY2sgY29tcGF0aWJsZQo+ID4gPiA+IHVzZWZ1 bCB0byB5b3UgdG8gcnVuIHdpdGggb2xkZXIga2VybmVscz8KPiA+ID4gPiAKPiA+ID4gPiBJIHNo b3VsZCBoYXZlIG5vdGljZWQgd2hlbiBQZXRlciBhZGRlZCB0aGUgZGFjMTIxYzA4MS4gSWYgd2Ug YWRkIGEgZmFsbGJhY2sKPiA+ID4gPiBzaG91bGQgZG8gdGhhdCBvbmUgYXMgd2VsbC4gICAgCj4g PiA+IAo+ID4gPiBJJ3ZlIGluZGVlZCBub3RpY2VkIHRoYXQgdGhlcmUgc2hvdWxkIGhhdmUgYmVl biBhIGZhbGxiYWNrIGZvcgo+ID4gPiBkYWMxMjFjMDgxLCBidXQgZGlkbid0IHN0b3AgdG8gcG9u ZGVyIHdoeSB0aGF0IHdhc24ndCB0aGUgY2FzZSwgYW5kIGp1c3QKPiA+ID4gd2VudCBhbG9uZyB3 aXRoIHRoZSBmbG93IDotKSBJIGFncmVlIGEgZmFsbGJhY2sgY291bGQgYmUgdXNlZnVsLCB3aGlj aAo+ID4gPiB3b3VsZCB0aGVuIGFsbG93IGRyb3BwaW5nIHBhdGNoIDIvNSBmcm9tIHRoaXMgc2Vy aWVzICgqKS4gSSBjYW4gZG8gc28gaWYKPiA+ID4geW91IHByZWZlci4KPiA+ID4gCj4gPiA+ICog VGhpcyBpcyBub3QgZW50aXJlbHkgdHJ1ZS4gV2hpbGUgdGhlIERBQzEwODFDMDgxIGlzIGxhcmdl bHkgY29tcGF0aWJsZQo+ID4gPiB3aXRoIHRoZSBEQUM1NTczLCB0aGV5IGhhdmUgZGlmZmVyZW50 IHZhbHVlcyBmb3Igb25lIG9mIHRoZSBwb3dlci1kb3duCj4gPiA+IHJlc2lzdG9ycyAoMi41a86p IGluc3RlYWQgb2YgMWvOqSBpZiBJIHJlY2FsbCBjb3JyZWN0bHkpLiBUbyBiZSBjb21wbGV0ZWx5 Cj4gPiA+IGFjY3VyYXRlLCB0aGUgZHJpdmVyIHNob3VsZCByZXBvcnQgdGhhdC4gV2UgY291bGQg c3RpbGwgdXNlIHRoZSBmYWxsYmFjawo+ID4gPiBjb21wYXRpYmxlLCByZXBvcnRpbmcgdGhlIHdy b25nIHBvd2VyLWRvd24gcmVzaXN0b3IgdmFsdWUuICAKPiA+IAo+ID4gSG1tIC0gV291bGQgYW55 b25lIHJlYWxseSBjYXJlIGFib3V0IHRoYXQgdmFsdWUgYmVpbmcgd3Jvbmc/ICAKPiAKPiBJIGRv bid0IGhhdmUgZW5vdWdoIGV4cGVydGlzZSB3aXRoIElJTyB0byBiZSBzdXJlLCBidXQgbXkgZ3Vl c3MgaXMgdGhhdAo+IG5vYm9keSB3b3VsZC4KPiAKPiA+IEkgdGhpbmsgcGVyaGFwcyB0aGF0J3Mg anVzdCBhYm91dCBzaWduaWZpY2FudCBlbm91Z2ggdGhhdCBtYXliZSBhIGZhbGxiYWNrCj4gPiBj b21wYXRpYmxlIGRvZXNuJ3QgbWFrZSBzZW5zZSBoZXJlLiAgCj4gCj4gVGhlbiBsZXQncyBrZWVw IGl0IHNpbXBsZSBhbmQganVzdCBtZXJnZSB0aGlzIHBhdGNoIGFzLWlzID8gOi0pCk1ha2VzIHNl bnNlLiBJJ20gb24gd3JvbmcgY29tcHV0ZXIgYXQgdGhlIG1vbWVudCBidXQgd2lsbCBwaWNrIGl0 IHVwIGF0CndlZWtlbmQgaWYgbm90IGJlZm9yZS4KCkpvbmF0aGFuCgoKPiAKPiA+ID4gPiA+IC0t LQo+ID4gPiA+ID4gIERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9paW8vZGFjL3Rp LGRhYzU1NzEueWFtbCB8IDEgKwo+ID4gPiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlv bigrKQo+ID4gPiA+ID4gCj4gPiA+ID4gPiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZp Y2V0cmVlL2JpbmRpbmdzL2lpby9kYWMvdGksZGFjNTU3MS55YW1sIGIvRG9jdW1lbnRhdGlvbi9k ZXZpY2V0cmVlL2JpbmRpbmdzL2lpby9kYWMvdGksZGFjNTU3MS55YW1sCj4gPiA+ID4gPiBpbmRl eCA3OWRhMDMyM2MzMjcuLmU1OWRiODYxZTJlYiAxMDA2NDQKPiA+ID4gPiA+IC0tLSBhL0RvY3Vt ZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9paW8vZGFjL3RpLGRhYzU1NzEueWFtbAo+ID4g PiA+ID4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2lpby9kYWMvdGks ZGFjNTU3MS55YW1sCj4gPiA+ID4gPiBAQCAtMjEsNiArMjEsNyBAQCBwcm9wZXJ0aWVzOgo+ID4g PiA+ID4gICAgICAgIC0gdGksZGFjNTU3Mwo+ID4gPiA+ID4gICAgICAgIC0gdGksZGFjNjU3Mwo+ ID4gPiA+ID4gICAgICAgIC0gdGksZGFjNzU3Mwo+ID4gPiA+ID4gKyAgICAgIC0gdGksZGFjMDgx YzA4MQo+ID4gPiA+ID4gICAgICAgIC0gdGksZGFjMTIxYzA4MQo+ID4gPiA+ID4gIAo+ID4gPiA+ ID4gICAgcmVnOiAgICAKPiAKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVs QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==