From: Jakub Kicinski <kuba@kernel.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 0/3] using guard/__free in networking
Date: Tue, 26 Mar 2024 17:15:49 -0700 [thread overview]
Message-ID: <20240326171549.038591c8@kernel.org> (raw)
In-Reply-To: <0dc633a36a658b96f9ec98165e7db61a176c79e0.camel@sipsolutions.net>
On Tue, 26 Mar 2024 16:33:58 +0100 Johannes Berg wrote:
> > > I think you can't get scoped_guard() without guard(), so does that mean
> > > you'd accept the first patch in the series?
> >
> > How can we get one without the other.. do you reckon Joe P would let us
> > add a checkpatch check to warn people against pure guard() under net/ ?
>
> Maybe? But I think I do want to use guard() ;-)
IIUC Willem and Stan like the construct too, so I'm fine with patches
1 and 2. But let's not convert the exiting code just yet (leave out 3)?
next prev parent reply other threads:[~2024-03-27 0:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 22:31 [PATCH 0/3] using guard/__free in networking Johannes Berg
2024-03-25 22:31 ` [PATCH 1/3] rtnetlink: add guard for RTNL Johannes Berg
2024-03-25 22:31 ` [PATCH 2/3] netdevice: add DEFINE_FREE() for dev_put Johannes Berg
2024-03-25 22:31 ` [PATCH 3/3] net: core: use guard/__free in core dev code Johannes Berg
2024-03-26 2:09 ` [PATCH 0/3] using guard/__free in networking Jakub Kicinski
2024-03-26 8:42 ` Johannes Berg
2024-03-26 14:37 ` Jakub Kicinski
2024-03-26 15:23 ` Willem de Bruijn
2024-03-26 17:33 ` Stanislav Fomichev
2024-03-29 10:23 ` Simon Horman
2024-03-26 15:33 ` Johannes Berg
2024-03-27 0:15 ` Jakub Kicinski [this message]
2024-03-27 19:24 ` Johannes Berg
2024-03-27 20:07 ` Jakub Kicinski
2024-03-27 20:25 ` Jakub Sitnicki
2024-03-27 21:28 ` Johannes Berg
2024-03-27 21:43 ` Johannes Berg
2024-03-27 11:15 ` Przemek Kitszel
2024-03-26 15:33 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240326171549.038591c8@kernel.org \
--to=kuba@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.