From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: chandan.babu@oracle.com, linux-xfs@vger.kernel.org
Subject: Re: [PATCH v2] xfs: compile out v4 support if disabled
Date: Tue, 26 Mar 2024 10:24:33 -0700 [thread overview]
Message-ID: <20240326172433.GS6390@frogsfrogsfrogs> (raw)
In-Reply-To: <20240326055047.GA6808@lst.de>
On Tue, Mar 26, 2024 at 06:50:47AM +0100, Christoph Hellwig wrote:
> On Mon, Mar 25, 2024 at 05:02:37PM -0700, Darrick J. Wong wrote:
> > > +/*
> > > + * Some features are always on for v5 file systems, allow the compiler to
> > > + * eliminiate dead code when building without v4 support.
> > > + */
> > > +#define __XFS_HAS_V4_FEAT(name, NAME) \
> >
> > Shouldn't this be called __XFS_HAS_V5_FEAT?
>
> They are features for v4 and unconditional for v5. Given that Dave
> came up with the same names independently they can't be all bad,
> although I don't really care very strongly.
Ok, you've both persuaded me then.
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
prev parent reply other threads:[~2024-03-26 17:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 3:13 [PATCH v2] xfs: compile out v4 support if disabled Christoph Hellwig
2024-03-26 0:02 ` Darrick J. Wong
2024-03-26 5:50 ` Christoph Hellwig
2024-03-26 17:24 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240326172433.GS6390@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=chandan.babu@oracle.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.