From: Jakub Kicinski <kuba@kernel.org>
To: Ratheesh Kannoth <rkannoth@marvell.com>
Cc: Nikita Kiryushin <kiryushin@ancud.ru>,
Michael Chan <mchan@broadcom.com>,
Pavan Chebbi <pavan.chebbi@broadcom.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <lvc-project@linuxtesting.org>,
Michael Chan <michael.chan@broadcom.com>
Subject: Re: [PATCH net-next v2] tg3: Remove residual error handling in tg3_suspend
Date: Tue, 26 Mar 2024 20:24:42 -0700 [thread overview]
Message-ID: <20240326202442.6e80cf1a@kernel.org> (raw)
In-Reply-To: <20240327024430.GA1370891@maili.marvell.com>
On Wed, 27 Mar 2024 08:14:30 +0530 Ratheesh Kannoth wrote:
> > @@ -18090,7 +18090,6 @@ static int tg3_suspend(struct device *device)
> > {
> Please address Michael Chan's comment to make this function return type to "void"
> instead of "int"
It's used as a callback in SIMPLE_DEV_PM_OPS(), how would that work?
next prev parent reply other threads:[~2024-03-27 3:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 19:23 [PATCH] tg3: Remove residual error handling in tg3_suspend Nikita Kiryushin
2024-03-07 22:38 ` Michael Chan
2024-03-11 15:45 ` [PATCH v2] " Nikita Kiryushin
2024-03-11 17:22 ` Michael Chan
2024-03-26 18:35 ` [PATCH net-next " Nikita Kiryushin
2024-03-27 2:44 ` Ratheesh Kannoth
2024-03-27 3:24 ` Jakub Kicinski [this message]
2024-03-27 5:09 ` Michael Chan
2024-03-27 5:13 ` [EXTERNAL] " Ratheesh Kannoth
2024-03-29 1:10 ` Jakub Kicinski
2024-03-29 11:51 ` Nikita Kiryushin
2024-03-29 15:25 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240326202442.6e80cf1a@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kiryushin@ancud.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=mchan@broadcom.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=rjw@rjwysocki.net \
--cc=rkannoth@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.