From: Jakub Kicinski <kuba@kernel.org>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Donald Hunter <donald.hunter@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
Jacob Keller <jacob.e.keller@intel.com>,
Stanislav Fomichev <sdf@google.com>
Subject: Re: [PATCH net-next 3/4] net: team: use policy generated by YAML spec
Date: Tue, 26 Mar 2024 20:40:41 -0700 [thread overview]
Message-ID: <20240326204041.281cdd38@kernel.org> (raw)
In-Reply-To: <20240326033005.2072622-4-liuhangbin@gmail.com>
On Tue, 26 Mar 2024 11:30:03 +0800 Hangbin Liu wrote:
>
> -static int team_nl_cmd_port_list_get(struct sk_buff *skb,
> +int team_nl_port_list_get_doit(struct sk_buff *skb,
> struct genl_info *info)
nit: please adjust the indent of the continuation line
> +/* Global operation policy for team */
> +const struct nla_policy team_nl_policy[TEAM_ATTR_LIST_OPTION + 1] = {
You need to adjust max_attr in the family to be
ARRAY_SIZE(team_nl_policy), it's no longer TEAM_ATTR_MAX.
--
pw-bot: cr
next prev parent reply other threads:[~2024-03-27 3:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 3:30 [PATCH net-next 0/4] doc/netlink: add a YAML spec for team Hangbin Liu
2024-03-26 3:30 ` [PATCH net-next 1/4] Documentation: netlink: " Hangbin Liu
2024-03-26 3:30 ` [PATCH net-next 2/4] net: team: rename team to team_core for linking Hangbin Liu
2024-03-26 3:30 ` [PATCH net-next 3/4] net: team: use policy generated by YAML spec Hangbin Liu
2024-03-27 3:40 ` Jakub Kicinski [this message]
2024-03-26 3:30 ` [PATCH net-next 4/4] uapi: team: use header file generated from " Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240326204041.281cdd38@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=jacob.e.keller@intel.com \
--cc=jiri@resnulli.us \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.