All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: oe-kbuild-all@lists.linux.dev
Subject: Re: [RFC PATCH v2 1/4] tracing: add __print_sym() to replace __print_symbolic()
Date: Wed, 27 Mar 2024 13:34:32 +0800	[thread overview]
Message-ID: <202403271340.X3uVZhs3-lkp@intel.com> (raw)
In-Reply-To: <20240326202131.9d261d5bb667.I9bd2617499f0d170df58471bc51379742190f92d@changeid>

Hi Johannes,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on mcgrof/modules-next]
[also build test WARNING on arnd-asm-generic/master tip/timers/core net/main net-next/main linus/master horms-ipvs/master v6.9-rc1 next-20240326]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Johannes-Berg/tracing-add-__print_sym-to-replace-__print_symbolic/20240327-032437
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git modules-next
patch link:    https://lore.kernel.org/r/20240326202131.9d261d5bb667.I9bd2617499f0d170df58471bc51379742190f92d%40changeid
patch subject: [RFC PATCH v2 1/4] tracing: add __print_sym() to replace __print_symbolic()
config: sh-defconfig (https://download.01.org/0day-ci/archive/20240327/202403271340.X3uVZhs3-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240327/202403271340.X3uVZhs3-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202403271340.X3uVZhs3-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from include/trace/trace_events.h:27,
                    from include/trace/define_trace.h:102,
                    from include/trace/events/filemap.h:118,
                    from mm/filemap.c:54:
>> include/trace/stages/init.h:30: warning: "TRACE_DEFINE_SYM_FNS" redefined
      30 | #define TRACE_DEFINE_SYM_FNS(_symbol_id, _lookup, _show)                \
         | 
   In file included from include/trace/syscall.h:5,
                    from include/linux/syscalls.h:93,
                    from mm/filemap.c:25:
   include/linux/tracepoint.h:130: note: this is the location of the previous definition
     130 | #define TRACE_DEFINE_SYM_FNS(...)
         | 
>> include/trace/stages/init.h:54: warning: "TRACE_DEFINE_SYM_LIST" redefined
      54 | #define TRACE_DEFINE_SYM_LIST(_symbol_id, ...)                          \
         | 
   include/linux/tracepoint.h:131: note: this is the location of the previous definition
     131 | #define TRACE_DEFINE_SYM_LIST(...)
         | 
--
   In file included from include/trace/trace_events.h:27,
                    from include/trace/define_trace.h:102,
                    from include/trace/events/tlb.h:62,
                    from mm/rmap.c:82:
>> include/trace/stages/init.h:30: warning: "TRACE_DEFINE_SYM_FNS" redefined
      30 | #define TRACE_DEFINE_SYM_FNS(_symbol_id, _lookup, _show)                \
         | 
   In file included from include/trace/events/tlb.h:9:
   include/linux/tracepoint.h:130: note: this is the location of the previous definition
     130 | #define TRACE_DEFINE_SYM_FNS(...)
         | 
>> include/trace/stages/init.h:54: warning: "TRACE_DEFINE_SYM_LIST" redefined
      54 | #define TRACE_DEFINE_SYM_LIST(_symbol_id, ...)                          \
         | 
   include/linux/tracepoint.h:131: note: this is the location of the previous definition
     131 | #define TRACE_DEFINE_SYM_LIST(...)
         | 
   In file included from include/trace/trace_events.h:27,
                    from include/trace/define_trace.h:102,
                    from include/trace/events/migrate.h:146,
                    from mm/rmap.c:83:
>> include/trace/stages/init.h:30: warning: "TRACE_DEFINE_SYM_FNS" redefined
      30 | #define TRACE_DEFINE_SYM_FNS(_symbol_id, _lookup, _show)                \
         | 
   In file included from include/trace/trace_events.h:112:
   include/trace/stages/stage2_data_offsets.h:9: note: this is the location of the previous definition
       9 | #define TRACE_DEFINE_SYM_FNS(_symbol_id, _lookup, _show)
         | 
>> include/trace/stages/init.h:54: warning: "TRACE_DEFINE_SYM_LIST" redefined
      54 | #define TRACE_DEFINE_SYM_LIST(_symbol_id, ...)                          \
         | 
   include/trace/stages/stage2_data_offsets.h:12: note: this is the location of the previous definition
      12 | #define TRACE_DEFINE_SYM_LIST(_symbol_id, ...)
         | 


vim +/TRACE_DEFINE_SYM_FNS +30 include/trace/stages/init.h

    12	
    13	#undef TRACE_DEFINE_ENUM
    14	#define TRACE_DEFINE_ENUM(a)				\
    15		static struct trace_eval_map __used __initdata	\
    16		__##TRACE_SYSTEM##_##a =			\
    17		{						\
    18			.system = TRACE_SYSTEM_STRING,		\
    19			.eval_string = #a,			\
    20			.eval_value = a				\
    21		};						\
    22		static struct trace_eval_map __used		\
    23		__section("_ftrace_eval_map")			\
    24		*TRACE_SYSTEM##_##a = &__##TRACE_SYSTEM##_##a
    25	
    26	/*
    27	 * Define a symbol for __print_sym by giving lookup and
    28	 * show functions. See &struct trace_sym_def.
    29	 */
  > 30	#define TRACE_DEFINE_SYM_FNS(_symbol_id, _lookup, _show)		\
    31		_TRACE_DEFINE_SYM_FNS(TRACE_SYSTEM, _symbol_id, _lookup, _show)
    32	#define _TRACE_DEFINE_SYM_FNS(_system, _symbol_id, _lookup, _show)	\
    33		__TRACE_DEFINE_SYM_FNS(_system, _symbol_id, _lookup, _show)
    34	#define __TRACE_DEFINE_SYM_FNS(_system, _symbol_id, _lookup, _show)	\
    35		___TRACE_DEFINE_SYM_FNS(_system ## _ ## _symbol_id, _symbol_id,	\
    36					_lookup, _show)
    37	#define ___TRACE_DEFINE_SYM_FNS(_name, _symbol_id, _lookup, _show)	\
    38		static struct trace_sym_def					\
    39		__trace_sym_def_ ## _name = {					\
    40			.system = TRACE_SYSTEM_STRING,				\
    41			/* need the ) for later strcmp */			\
    42			.symbol_id = #_symbol_id ")",				\
    43			.lookup = _lookup,					\
    44			.show = _show,						\
    45		};								\
    46		static struct trace_sym_def 					\
    47		__section("_ftrace_sym_defs")					\
    48		*__trace_sym_def_p_ ## _name = &__trace_sym_def_ ## _name
    49	
    50	/*
    51	 * Define a symbol for __print_sym by giving lookup and
    52	 * show functions. See &struct trace_sym_def.
    53	 */
  > 54	#define TRACE_DEFINE_SYM_LIST(_symbol_id, ...)				\
    55		_TRACE_DEFINE_SYM_LIST(TRACE_SYSTEM, _symbol_id, __VA_ARGS__)
    56	#define _TRACE_DEFINE_SYM_LIST(_system, _symbol_id, ...)		\
    57		__TRACE_DEFINE_SYM_LIST(_system, _symbol_id, __VA_ARGS__)
    58	#define __TRACE_DEFINE_SYM_LIST(_system, _symbol_id, ...)		\
    59		___TRACE_DEFINE_SYM_LIST(_system ## _ ## _symbol_id, _symbol_id,\
    60					 __VA_ARGS__)
    61	#define ___TRACE_DEFINE_SYM_LIST(_name, _symbol_id, ...)		\
    62		static struct trace_sym_entry					\
    63		__trace_sym_list_ ## _name[] = { __VA_ARGS__ };			\
    64		static const char *						\
    65		__trace_sym_lookup_ ## _name(unsigned long long value)		\
    66		{								\
    67			return trace_sym_lookup(__trace_sym_list_ ## _name,	\
    68				ARRAY_SIZE(__trace_sym_list_ ## _name), value);	\
    69		}								\
    70		static void							\
    71		__trace_sym_show_ ## _name(struct seq_file *m)			\
    72		{								\
    73			trace_sym_show(m, __trace_sym_list_ ## _name,		\
    74				       ARRAY_SIZE(__trace_sym_list_ ## _name));	\
    75		}								\
    76		___TRACE_DEFINE_SYM_FNS(_name, _symbol_id,			\
    77					__trace_sym_lookup_ ## _name,		\
    78					__trace_sym_show_ ## _name)
    79	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  parent reply	other threads:[~2024-03-27  5:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-26 19:15 [RFC PATCH v2 0/4] tracing: improve symbolic printing Johannes Berg
2024-03-26 19:15 ` [RFC PATCH v2 1/4] tracing: add __print_sym() to replace __print_symbolic() Johannes Berg
2024-03-27  4:21   ` kernel test robot
2024-03-27  5:34   ` kernel test robot [this message]
2024-03-27 21:11   ` Simon Horman
2024-03-27 21:24     ` Johannes Berg
2024-03-26 19:15 ` [RFC PATCH v2 2/4] net: dropreason: use new __print_sym() in tracing Johannes Berg
2024-03-26 19:15 ` [RFC PATCH v2 3/4] net: drop_monitor: use drop_reason_lookup() Johannes Berg
2024-03-27  4:21   ` kernel test robot
2024-03-26 19:15 ` [RFC PATCH v2 4/4] tracing/timer: use __print_sym() Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202403271340.X3uVZhs3-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.